[{"id":1961099,"web_url":"http://patchwork.ozlabs.org/comment/1961099/","msgid":"<20180725175508.6769d2fb@bbrezillon>","list_archive_url":null,"date":"2018-07-25T15:55:08","subject":"Re: [PATCH v5 11/17] mtd: rawnand: jz4740: convert driver to\n\tnand_scan()","submitter":{"id":73370,"url":"http://patchwork.ozlabs.org/api/people/73370/","name":"Boris Brezillon","email":"boris.brezillon@bootlin.com"},"content":"On Wed, 25 Jul 2018 15:31:46 +0200\nMiquel Raynal wrote:\n\n> Two helpers have been added to the core to do all kind of controller\n> side configuration/initialization between the detection phase and the\n> final NAND scan. Implement these hooks so that we can convert the driver\n> to just use nand_scan() instead of the nand_scan_ident() +\n> nand_scan_tail() pair.\n> \n> Signed-off-by: Miquel Raynal \n\nReviewed-by: Boris Brezillon \n\n> ---\n> drivers/mtd/nand/raw/jz4740_nand.c | 32 ++++++++++++++++++++------------\n> 1 file changed, 20 insertions(+), 12 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c\n> index 09541608a45f..3816d56b0d01 100644\n> --- a/drivers/mtd/nand/raw/jz4740_nand.c\n> +++ b/drivers/mtd/nand/raw/jz4740_nand.c\n> @@ -309,7 +309,6 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n> \t\t\t size_t chipnr, uint8_t *nand_maf_id,\n> \t\t\t uint8_t *nand_dev_id)\n> {\n> -\tstruct jz_nand_platform_data *pdata = dev_get_platdata(&pdev->dev);\n> \tint ret;\n> \tchar res_name[6];\n> \tuint32_t ctrl;\n> @@ -332,20 +331,10 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n> \n> \tif (chipnr == 0) {\n> \t\t/* Detect first chip. */\n> -\t\tret = nand_scan_ident(mtd, 1, NULL);\n> +\t\tret = nand_scan(mtd, 1);\n> \t\tif (ret)\n> \t\t\tgoto notfound_id;\n> \n> -\t\tif (pdata && pdata->ident_callback)\n> -\t\t\tpdata->ident_callback(pdev, mtd, &pdata->partitions,\n> -\t\t\t\t\t &pdata->num_partitions);\n> -\n> -\t\tret = nand_scan_tail(mtd);\n> -\t\tif (ret) {\n> -\t\t\tdev_err(&pdev->dev, \"Failed to scan NAND\\n\");\n> -\t\t\tgoto notfound_id;\n> -\t\t}\n> -\n> \t\t/* Retrieve the IDs from the first chip. */\n> \t\tchip->select_chip(mtd, 0);\n> \n> @@ -380,6 +369,24 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n> \treturn ret;\n> }\n> \n> +static int jz_nand_attach_chip(struct nand_chip *chip)\n> +{\n> +\tstruct mtd_info *mtd = nand_to_mtd(chip);\n> +\tstruct device *dev = mtd->dev.parent;\n> +\tstruct jz_nand_platform_data *pdata = dev_get_platdata(dev);\n> +\tstruct platform_device *pdev = to_platform_device(dev);\n> +\n> +\tif (pdata && pdata->ident_callback)\n> +\t\tpdata->ident_callback(pdev, mtd, &pdata->partitions,\n> +\t\t\t\t &pdata->num_partitions);\n> +\n> +\treturn 0;\n> +}\n> +\n> +static const struct nand_controller_ops jz_nand_controller_ops = {\n> +\t.attach_chip = jz_nand_attach_chip,\n> +};\n> +\n> static int jz_nand_probe(struct platform_device *pdev)\n> {\n> \tint ret;\n> @@ -423,6 +430,7 @@ static int jz_nand_probe(struct platform_device *pdev)\n> \tchip->chip_delay = 50;\n> \tchip->cmd_ctrl = jz_nand_cmd_ctrl;\n> \tchip->select_chip = jz_nand_select_chip;\n> +\tchip->dummy_controller.ops = &jz_nand_controller_ops;\n> \n> \tif (nand->busy_gpio)\n> \t\tchip->dev_ready = jz_nand_dev_ready;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"SlnzIJ3a\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bKZf1NKnz9s29\n\tfor ;\n\tThu, 26 Jul 2018 01:55:54 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiM8f-0006UV-Vy; Wed, 25 Jul 2018 15:55:46 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiM8a-0006GP-EY\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 15:55:44 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid 0DF20207AB; Wed, 25 Jul 2018 17:55:29 +0200 (CEST)","from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr\n\t[90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id BF49620993;\n\tWed, 25 Jul 2018 17:55:07 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=kPy9LbYek66aYXQQP5tddBqzAAyO4NEcgPvTFRYUtR8=;\n\tb=SlnzIJ3a/MpglP\n\ta7l52ro2Fsrw9fFVNdkxbESGbWmb7G4KX42fNM6UnMrDDydjtUX/sQgMGh9yx1nwSafyks6plxWXO\n\tIfAadQUEokrr6oWOEajnCuTh9jk2QxBBTfd3FuU65wmc63sq7MpBymomh4v1fVrWlA0CdFjE1DB5D\n\t+IQrVFaSZrm5yJjD/SjQmS89KqnE4gXYC10ZQtWvCB9d1Rg8F68wIqU2tz3Dp+59lV0cNNtIEVlcX\n\tjtRxj2XZ7ugI0n01xIws1AoNUWYd3UYp4k2qVX/RSPxw57wvTsnsvWThXNDxwoJziNPUSyd5W0lLP\n\tJngvjj/OMbcvfl2dsSaw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 25 Jul 2018 17:55:08 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5 11/17] mtd: rawnand: jz4740: convert driver to\n\tnand_scan()","Message-ID":"<20180725175508.6769d2fb@bbrezillon>","In-Reply-To":"<20180725133152.30898-12-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>\n\t<20180725133152.30898-12-miquel.raynal@bootlin.com>","X-Mailer":"Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_085541_127985_78F1797D ","X-CRM114-Status":"GOOD ( 21.57 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tRichard Weinberger , Stefan Agner , \n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tJosh Wu ,\n\tBrian Norris , \n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]