[{"id":1961087,"web_url":"http://patchwork.ozlabs.org/comment/1961087/","msgid":"<20180725174839.20d1530a@bbrezillon>","list_archive_url":null,"date":"2018-07-25T15:48:39","subject":"Re: [PATCH v5 09/17] mtd: rawnand: jz4740: fix probe function error\n\tpath","submitter":{"id":73370,"url":"http://patchwork.ozlabs.org/api/people/73370/","name":"Boris Brezillon","email":"boris.brezillon@bootlin.com"},"content":"On Wed, 25 Jul 2018 15:31:44 +0200\nMiquel Raynal wrote:\n\n> An error after nand_scan_tail() should trigger a nand_cleanup(), not a\n> nand_release() as mtd_device_register() (or one of its variants) has not\n> been called and there is no need to deregister any MTD device yet.\n> \n> Signed-off-by: Miquel Raynal \n\nReviewed-by: Boris Brezillon \n\n> ---\n> drivers/mtd/nand/raw/jz4740_nand.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c\n> index a4052b03249c..3abf87420c10 100644\n> --- a/drivers/mtd/nand/raw/jz4740_nand.c\n> +++ b/drivers/mtd/nand/raw/jz4740_nand.c\n> @@ -472,15 +472,15 @@ static int jz_nand_probe(struct platform_device *pdev)\n> \n> \tif (ret) {\n> \t\tdev_err(&pdev->dev, \"Failed to add mtd device\\n\");\n> -\t\tgoto err_nand_release;\n> +\t\tgoto err_cleanup_nand;\n> \t}\n> \n> \tdev_info(&pdev->dev, \"Successfully registered JZ4740 NAND driver\\n\");\n> \n> \treturn 0;\n> \n> -err_nand_release:\n> -\tnand_release(mtd);\n> +err_cleanup_nand:\n> +\tnand_cleanup(chip);\n> err_unclaim_banks:\n> \twhile (chipnr--) {\n> \t\tunsigned char bank = nand->banks[chipnr];","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"IA9TbStt\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bKQt29f7z9s1x\n\tfor ;\n\tThu, 26 Jul 2018 01:49:10 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiM2A-0000Vd-Oz; Wed, 25 Jul 2018 15:49:02 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiM28-0000T6-Hr\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 15:49:01 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid 244E920765; Wed, 25 Jul 2018 17:48:49 +0200 (CEST)","from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr\n\t[90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id D037B2072C;\n\tWed, 25 Jul 2018 17:48:38 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=6ho9ODpbRdLUFVWQLFlhctMidYjtDDoUR5Cazxmg/iA=;\n\tb=IA9TbSttIdnqGj\n\tQxZJKcR8oZfbInukHjeS8DtvC+e8TASBT5YgC6iP8AdCK5r9TosgWmnvQ1TFqIzBOAewx/qvzmr9a\n\tKSEdipMzEVxW325/vnmHR/tPJQITW+1eaJSC+VSnklOv6AhxPiwpU9ZSK1k1RuqX5/3wv/+1GGx75\n\traIidr/+0evN2gayq1uEY+JV10FRfzCGtWlpWfEmrTnuyhmv7GHOIqluL45+4D04hXs9Aq7dqVJNZ\n\tOMHnyHWBwlUPmRTH8290hIK+9HNpmdgAzcG3C96MIL3dRGiTD6N2yFbESzjf7GDOhC0vsyUdqY2j2\n\tBphhzytM0EipaEzHommg==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 25 Jul 2018 17:48:39 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5 09/17] mtd: rawnand: jz4740: fix probe function error\n\tpath","Message-ID":"<20180725174839.20d1530a@bbrezillon>","In-Reply-To":"<20180725133152.30898-10-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>\n\t<20180725133152.30898-10-miquel.raynal@bootlin.com>","X-Mailer":"Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_084900_728062_E6485E81 ","X-CRM114-Status":"GOOD ( 19.25 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tRichard Weinberger , Stefan Agner , \n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tJosh Wu ,\n\tBrian Norris , \n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]