[{"id":1961067,"web_url":"http://patchwork.ozlabs.org/comment/1961067/","msgid":"<20180725173816.71da16b5@bbrezillon>","list_archive_url":null,"date":"2018-07-25T15:38:16","subject":"Re: [PATCH v5 03/17] mtd: rawnand: lpc32xx_mlc: convert driver to\n\tnand_scan()","submitter":{"id":73370,"url":"http://patchwork.ozlabs.org/api/people/73370/","name":"Boris Brezillon","email":"boris.brezillon@bootlin.com"},"content":"On Wed, 25 Jul 2018 15:31:38 +0200\nMiquel Raynal wrote:\n\n> Two helpers have been added to the core to do all kind of controller\n> side configuration/initialization between the detection phase and the\n> final NAND scan. Implement these hooks so that we can convert the driver\n> to just use nand_scan() instead of the nand_scan_ident() +\n> nand_scan_tail() pair.\n> \n> Signed-off-by: Miquel Raynal \n> ---\n> drivers/mtd/nand/raw/lpc32xx_mlc.c | 61 +++++++++++++++++++++-----------------\n> 1 file changed, 33 insertions(+), 28 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c\n> index 052d123a8304..e82abada130a 100644\n> --- a/drivers/mtd/nand/raw/lpc32xx_mlc.c\n> +++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c\n> @@ -184,6 +184,7 @@ static struct nand_bbt_descr lpc32xx_nand_bbt_mirror = {\n> };\n> \n> struct lpc32xx_nand_host {\n> +\tstruct platform_device\t*pdev;\n\nYou don't need pdev. With this field removed\n\nReviewed-by: Boris Brezillon \n\n> \tstruct nand_chip\tnand_chip;\n> \tstruct lpc32xx_mlc_platform_data *pdata;\n> \tstruct clk\t\t*clk;\n> @@ -653,6 +654,32 @@ static struct lpc32xx_nand_cfg_mlc *lpc32xx_parse_dt(struct device *dev)\n> \treturn ncfg;\n> }\n> \n> +static int lpc32xx_nand_attach_chip(struct nand_chip *chip)\n> +{\n> +\tstruct mtd_info *mtd = nand_to_mtd(chip);\n> +\tstruct lpc32xx_nand_host *host = nand_get_controller_data(chip);\n> +\tstruct device *dev = &host->pdev->dev;\n> +\n> +\thost->dma_buf = devm_kzalloc(dev, mtd->writesize, GFP_KERNEL);\n> +\tif (!host->dma_buf)\n> +\t\treturn -ENOMEM;\n> +\n> +\thost->dummy_buf = devm_kzalloc(dev, mtd->writesize, GFP_KERNEL);\n> +\tif (!host->dummy_buf)\n> +\t\treturn -ENOMEM;\n> +\n> +\tchip->ecc.mode = NAND_ECC_HW;\n> +\tchip->ecc.size = 512;\n> +\tmtd_set_ooblayout(mtd, &lpc32xx_ooblayout_ops);\n> +\thost->mlcsubpages = mtd->writesize / 512;\n> +\n> +\treturn 0;\n> +}\n> +\n> +static const struct nand_controller_ops lpc32xx_nand_controller_ops = {\n> +\t.attach_chip = lpc32xx_nand_attach_chip,\n> +};\n> +\n> /*\n> * Probe for NAND controller\n> */\n> @@ -669,6 +696,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)\n> \tif (!host)\n> \t\treturn -ENOMEM;\n> \n> +\thost->pdev = pdev;\n> +\n> \trc = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n> \thost->io_base = devm_ioremap_resource(&pdev->dev, rc);\n> \tif (IS_ERR(host->io_base))\n> @@ -748,31 +777,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)\n> \t\t}\n> \t}\n> \n> -\t/*\n> -\t * Scan to find existance of the device and\n> -\t * Get the type of NAND device SMALL block or LARGE block\n> -\t */\n> -\tres = nand_scan_ident(mtd, 1, NULL);\n> -\tif (res)\n> -\t\tgoto release_dma_chan;\n> -\n> -\thost->dma_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);\n> -\tif (!host->dma_buf) {\n> -\t\tres = -ENOMEM;\n> -\t\tgoto release_dma_chan;\n> -\t}\n> -\n> -\thost->dummy_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);\n> -\tif (!host->dummy_buf) {\n> -\t\tres = -ENOMEM;\n> -\t\tgoto release_dma_chan;\n> -\t}\n> -\n> -\tnand_chip->ecc.mode = NAND_ECC_HW;\n> -\tnand_chip->ecc.size = 512;\n> -\tmtd_set_ooblayout(mtd, &lpc32xx_ooblayout_ops);\n> -\thost->mlcsubpages = mtd->writesize / 512;\n> -\n> \t/* initially clear interrupt status */\n> \treadb(MLC_IRQ_SR(host->io_base));\n> \n> @@ -794,10 +798,11 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)\n> \t}\n> \n> \t/*\n> -\t * Fills out all the uninitialized function pointers with the defaults\n> -\t * And scans for a bad block table if appropriate.\n> +\t * Scan to find existence of the device and get the type of NAND device:\n> +\t * SMALL block or LARGE block.\n> \t */\n> -\tres = nand_scan_tail(mtd);\n> +\tnand_chip->dummy_controller.ops = &lpc32xx_nand_controller_ops;\n> +\tres = nand_scan(mtd, 1);\n> \tif (res)\n> \t\tgoto free_irq;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"kFOlMaNJ\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bKBx3dLLz9s1x\n\tfor ;\n\tThu, 26 Jul 2018 01:38:49 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLs9-0002XK-T4; Wed, 25 Jul 2018 15:38:41 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLs6-0002WJ-Ji\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 15:38:40 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid B1038207AD; Wed, 25 Jul 2018 17:38:26 +0200 (CEST)","from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr\n\t[90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 587CB20765;\n\tWed, 25 Jul 2018 17:38:16 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=rfuN5zhsVK92YTy5NtSHTtWXPbQx9CwMCQls2dRpZko=;\n\tb=kFOlMaNJ2Qs2LZ\n\tGlKiTvlb7tp1yxMWfD8Vl17eZyx+SC0UzFtfRqHLnJ5A8GXIUHvu4BT/4rSgXmqrEHxRHLnyoy9J6\n\txQqkS0mMdqAcAEXv3DOEvBYCiwHys5ppztTKacG4ToIJPf1CavYRUQCNmlMh+jjHnu5s07JsC8omA\n\tHxzhDfMobIfBK2EXR9pgvUjCMJAnvCWcruTimF5UFY8Y3O3wYRNZhQYsmzOoAlGGVauUu4eXXe4Xp\n\td2OZzfPEx95O6QIh8EEQhvB9h1ASaQtTDucgoA6ufHDPXbzdOJWF7sujFw4iPE2wASlXIODn0chLD\n\tZs6W2UR15RMcqBwPST/Q==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 25 Jul 2018 17:38:16 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5 03/17] mtd: rawnand: lpc32xx_mlc: convert driver to\n\tnand_scan()","Message-ID":"<20180725173816.71da16b5@bbrezillon>","In-Reply-To":"<20180725133152.30898-4-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>\n\t<20180725133152.30898-4-miquel.raynal@bootlin.com>","X-Mailer":"Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_083838_925482_D4681DE8 ","X-CRM114-Status":"GOOD ( 23.66 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tRichard Weinberger , Stefan Agner , \n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tJosh Wu ,\n\tBrian Norris , \n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]