[{"id":1799051,"web_url":"http://patchwork.ozlabs.org/comment/1799051/","msgid":"","list_archive_url":null,"date":"2017-11-04T09:07:34","subject":"Re: [net-next 06/12] net/mlx5e: Support DSCP trust state to\n\tEthernet's IP packet on SQ","submitter":{"id":64793,"url":"http://patchwork.ozlabs.org/api/people/64793/","name":"Or Gerlitz","email":"gerlitz.or@gmail.com"},"content":"On Sat, Nov 4, 2017 at 5:50 PM, Saeed Mahameed wrote:\n> From: Huy Nguyen \n>\n> If the port is in DSCP trust state, packets are placed in the right\n> priority queue based on the dscp value. This is done by selecting\n> the transmit queue based on the dscp of the skb.\n>\n> Until now select_queue honors priority only from the vlan header.\n> However that is not sufficient in cases where port trust state is DSCP\n> mode as packet might not even contain vlan header. Therefore if the port\n> is in dscp trust state and vport's min inline mode is not NONE,\n> copy the IP header to the eseg's inline header if the skb has it.\n> This is done by changing the transmit queue sq's min inline mode to L3.\n> Note that the min inline mode of sqs that belong to other features such\n> as xdpsq, icosq are not modified.\n>\n> Signed-off-by: Huy Nguyen \n> Reviewed-by: Parav Pandit \n> Signed-off-by: Saeed Mahameed \n\nReviewed-by: Or Gerlitz ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"onqdQBTR\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yTXyy72TTz9sBW\n\tfor ;\n\tSat, 4 Nov 2017 20:07:38 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756542AbdKDJHh (ORCPT );\n\tSat, 4 Nov 2017 05:07:37 -0400","from mail-oi0-f50.google.com ([209.85.218.50]:45932 \"EHLO\n\tmail-oi0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756478AbdKDJHf (ORCPT\n\t); Sat, 4 Nov 2017 05:07:35 -0400","by mail-oi0-f50.google.com with SMTP id f66so3803782oib.2\n\tfor ; Sat, 04 Nov 2017 02:07:35 -0700 (PDT)","by 10.202.81.5 with HTTP; Sat, 4 Nov 2017 02:07:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=s9TpYtDpD7MGYVlrr/xsmbGY2/yq4xO/Q7xi9ISD6vw=;\n\tb=onqdQBTR1qTBtWaR/qIrmu8uni21F1Jzq2N+G/aGsn2qJwqPU3kaUgdOglRif9V2Me\n\t+bKbyBfEvnLoPBEzEYtCYYHEdpkcKKulv94Tyt7l205a1RzkCdkpb9V6CQPn13IxZVnk\n\tP33Uo3ZDzA36u5DHGY5HQoCLQimDvqWsyb3CZzIeGwYezOJ9Xqnlr+QctdGlie7z0Pak\n\tZwl6gx1TdYGS0imjAmxnL8qY+1MTWRoKIU05HImNtxh+9QqwZXNYpZTtEVmMBJENwyQk\n\t1uyADLh2q81VqoY8P8sUd2fElAt6Idz3wTBbHiIcmKr17psbb8qyQn5JL8ZeZoVrKS9z\n\t/RRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=s9TpYtDpD7MGYVlrr/xsmbGY2/yq4xO/Q7xi9ISD6vw=;\n\tb=Ci/6kTujSVgzPIWst11d4uZkNs0MpvqoQxtuing662yP3ynD0VCjdwxi+knWDYLB9T\n\tBvvOiGTMRmk4IcFf3/bIGZx6YkpDUjFM4BCnD0/pwRfJ0C9xl9pgmmfTOYC1BuntWgLr\n\tSq3Iu7xyd+hXCYj0i5qTZ2bcEhEHLayOa+F1Q5j56qDEskt7zge7sD2p1cjO6xQZfHPA\n\tjcnT1F6F4A1vSORDcxTvpAfvnl6EKDuYB7xVN1YxCqVVrO3e/ghf4iFMAPwaWgJLN0yl\n\t6ahEvuZ/oQAL/DA7wDoBlZHxie/txH2R3qKfHN7JcaQJI3bwye+mlR7A6twRxI9N+eHW\n\tquNQ==","X-Gm-Message-State":"AMCzsaV2Ee5z9SdMnsZDsZtClf+bHAejPAFwHWZn2NENfe3bDaA9amGv\n\tUwYKpjxR4ZL8gE+nUOVmOpoak6IUAMcWaAheBDo=","X-Google-Smtp-Source":"ABhQp+TXkIe1YPu5QPKf4bp7Pabc/zs+FwwilmZYLmRDqfGiH222RaV8ZCiKqgrxz1gahNxWio8BkquqB9kxQzdmIic=","X-Received":"by 10.202.86.140 with SMTP id k134mr5565133oib.357.1509786455347;\n\tSat, 04 Nov 2017 02:07:35 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171104085030.25430-7-saeedm@mellanox.com>","References":"<20171104085030.25430-1-saeedm@mellanox.com>\n\t<20171104085030.25430-7-saeedm@mellanox.com>","From":"Or Gerlitz ","Date":"Sat, 4 Nov 2017 18:07:34 +0900","Message-ID":"","Subject":"Re: [net-next 06/12] net/mlx5e: Support DSCP trust state to\n\tEthernet's IP packet on SQ","To":"Saeed Mahameed ","Cc":"\"David S. Miller\" ,\n\tLinux Netdev List ,\n\tHuy Nguyen ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]