[{"id":1799021,"web_url":"http://patchwork.ozlabs.org/comment/1799021/","msgid":"<20171104011917.GJ9424@breakpoint.cc>","list_archive_url":null,"date":"2017-11-04T01:19:17","subject":"Re: [PATCH RFC,\n\tWIP 4/5] netfilter: nf_tables: flow offload expression","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/","name":"Florian Westphal","email":"fw@strlen.de"},"content":"Pablo Neira Ayuso <pablo@netfilter.org> wrote:\n> +static void nft_flow_offload_eval(const struct nft_expr *expr,\n> +\t\t\t\t  struct nft_regs *regs,\n> +\t\t\t\t  const struct nft_pktinfo *pkt)\n> +{\n[..]\n> +\tif (test_bit(IPS_HELPER_BIT, &ct->status))\n> +\t\tgoto out;\n> +\n> +\tif (ctinfo == IP_CT_NEW ||\n> +\t    ctinfo == IP_CT_RELATED)\n> +\t\tgoto out;\n\nWould it make sense to delay offload decision until l4 tracker has\nset ASSURED bit?","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yTLbG3BtCz9t16\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  4 Nov 2017 12:19:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756274AbdKDBTr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 3 Nov 2017 21:19:47 -0400","from Chamillionaire.breakpoint.cc ([146.0.238.67]:38380 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752663AbdKDBTq (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 3 Nov 2017 21:19:46 -0400","from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from <fw@strlen.de>)\n\tid 1eAn7F-0000Vc-2e; Sat, 04 Nov 2017 02:19:17 +0100"],"Date":"Sat, 4 Nov 2017 02:19:17 +0100","From":"Florian Westphal <fw@strlen.de>","To":"Pablo Neira Ayuso <pablo@netfilter.org>","Cc":"netfilter-devel@vger.kernel.org, netdev@vger.kernel.org","Subject":"Re: [PATCH RFC,\n\tWIP 4/5] netfilter: nf_tables: flow offload expression","Message-ID":"<20171104011917.GJ9424@breakpoint.cc>","References":"<20171103152636.9967-1-pablo@netfilter.org>\n\t<20171103152636.9967-5-pablo@netfilter.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171103152636.9967-5-pablo@netfilter.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]