[{"id":1799779,"web_url":"http://patchwork.ozlabs.org/comment/1799779/","msgid":"<20171106151830.GB21167@salvia>","list_archive_url":null,"date":"2017-11-06T15:18:30","subject":"Re: [PATCH nf-next,1/4] netfilter: conntrack: don't cache\n\tnlattr_tuple_size result in nla_size","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Sat, Nov 02, 2017 at 18:41:09PM +0100, Florian Westphal wrote:\n> We currently call ->nlattr_tuple_size() once at register time and\n> cache result in l4proto->nla_size.\n>\n> nla_size is the only member that is written to, avoiding this would\n> allow to make l4proto trackers const.\n>\n> We can use ->nlattr_tuple_size() at run time, and cache result in\n> the individual trackers instead.\n>\n> This is an intermediate step, next patch removes nlattr_size()\n> callback and computes size at compile time, then removes nla_size.\n\nFlorian, I can only see this one in this series via patchwork:\n\nhttp://patchwork.ozlabs.org/patch/833477/\n\nPlease, resend the three remaining patches so I can apply them.\n\nSorry for the inconvenience.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yVx6B70YPz9s7h\n\tfor ;\n\tTue, 7 Nov 2017 02:18:42 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752829AbdKFPSm (ORCPT );\n\tMon, 6 Nov 2017 10:18:42 -0500","from mail.us.es ([193.147.175.20]:41978 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752245AbdKFPSl (ORCPT );\n\tMon, 6 Nov 2017 10:18:41 -0500","from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id 3330D1B8406\n\tfor ;\n\tMon, 6 Nov 2017 16:18:40 +0100 (CET)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 24268DA86E\n\tfor ;\n\tMon, 6 Nov 2017 16:18:40 +0100 (CET)","by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid 19E2CDA86B; Mon, 6 Nov 2017 16:18:40 +0100 (CET)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 7BD8FDA7E9;\n\tMon, 6 Nov 2017 16:18:36 +0100 (CET)","from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tMon, 06 Nov 2017 16:18:36 +0100 (CET)","from us.es (unknown [27.1.3.195])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: 1984lsi)\n\tby entrada.int (Postfix) with ESMTPSA id 6056F403DF98;\n\tMon, 6 Nov 2017 16:18:35 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int","X-Spam-Level":"","X-Spam-Status":"No, score=-106.7 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tFAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS, SMTPAUTH_US2,\n\tUSER_IN_WHITELIST autolearn=disabled version=3.4.1","X-Virus-Status":"clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)","Date":"Mon, 6 Nov 2017 16:18:30 +0100","X-SMTPAUTHUS":"auth mail.us.es","From":"Pablo Neira Ayuso ","To":"Florian Westphal ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nf-next,1/4] netfilter: conntrack: don't cache\n\tnlattr_tuple_size result in nla_size","Message-ID":"<20171106151830.GB21167@salvia>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171102184112.32584-2-fw@strlen.de>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Virus-Scanned":"ClamAV using ClamSMTP","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]