[{"id":1798264,"web_url":"http://patchwork.ozlabs.org/comment/1798264/","msgid":"<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>","list_archive_url":null,"date":"2017-11-02T21:03:42","subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","submitter":{"id":8537,"url":"http://patchwork.ozlabs.org/api/people/8537/","name":"Felix Fietkau","email":"nbd@nbd.name"},"content":"On 2017-11-02 19:23, Philip Prindeville wrote:\n> From: Philip Prindeville <philipp@redfish-solutions.com>\n> \n> When uclient-fetch is called with multiple URL's, it derives the\n> first filename based on the URL. When it then handles the 2nd and\n> subsequent URLs, it assumes that it was called with a -O filename\n> argument as the output file, because it tries to overload the\n> variable output_file to mean 2 different things.\n> \n> The fix is to use a bool to remember whether we were called with\n> an explicit output filename, i.e. with the -O argument, and not\n> overload output_file for this purpose.\n> \n> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>\nThanks for debugging this. I've decided to fix this with a different\napproach instead. I've pushed a change that avoids the overloading issue\nentirely by renaming the global variable and overwriting a local\nvariable only.\n\n- Felix","headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"HEocsSW6\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nbd.name header.i=@nbd.name header.b=\"MWojrwwq\";\n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yScyw0w2Jz9s03\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 08:04:24 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eAMeq-0003gd-8E; Thu, 02 Nov 2017 21:04:12 +0000","from nbd.name ([2a01:4f8:131:30e2::2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eAMem-0003cN-8q\n\tfor lede-dev@lists.infradead.org; Thu, 02 Nov 2017 21:04:10 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=HtHwFyuZUYnP2hPNoNyue30j0O4HymDOShL3jiIme4o=;\n\tb=HEocsSW6u/EXSn\n\tF+AVQRkfVtlzKBpYhQhelDMk5X5gSvWh/JwhI9W/VTA0h++/ivNyzZkF9MCyMqP4IrkXBQT8MMItH\n\tWxenPWcbn38evH4ixRYoSBqRXmmMY60ei8Prj46O+1Oies++5MGKtNsXr8VzgqTh/ZfgRk4Gx0Pcn\n\tUIy7zSOXXI+/Ig6v3jSJHaEC83SfHGzZEAl2N3UdPYBcB1z0XfZ3BI8wMyWu0Ab8ftNhQ/vGjTr2g\n\tfOA57NPpAosO6VQNVO09R7Y+jgvWw6OsQoqFFXj3nb7FwsheJLIjvUwoPwHCFpzl+rEm6OFLuKYiX\n\t9gORYnI98AJ7S7LlQk0Q==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; \n\ts=20160729;\n\th=Content-Transfer-Encoding:Content-Type:In-Reply-To:\n\tMIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:\n\tList-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=3UDxGT7wBzpNwVlXL0KCq81+W+5CoI0D98/Ihn0vWm4=;\n\tb=MWojrwwqlMI781BDttL8aFCrEc\n\trGB33syxpz3G0RHzM3d583rdmffxsjdtLpZkvZdvBRLf1xJoICROYpYPcpg46P23ntzYK1Kx6ciXU\n\tel4ZCDPMbP1og9t5iNHGWZF9fpPLBzD6ywlqVlYK8F4WsLJIv3v+yU+SKIxxig3vL/n8=;"],"To":"Philip Prindeville <philipp@redfish-solutions.com>,\n\tlede-dev@lists.infradead.org","References":"<1509647003-21020-1-git-send-email-philipp@redfish-solutions.com>","From":"Felix Fietkau <nbd@nbd.name>","Message-ID":"<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>","Date":"Thu, 2 Nov 2017 22:03:42 +0100","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1509647003-21020-1-git-send-email-philipp@redfish-solutions.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171102_140408_671436_02C2332F ","X-CRM114-Status":"UNSURE (   9.83  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1798299,"web_url":"http://patchwork.ozlabs.org/comment/1798299/","msgid":"<837BB589-3611-4832-A949-8B174D75B9B5@redfish-solutions.com>","list_archive_url":null,"date":"2017-11-02T21:50:05","subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"> On Nov 2, 2017, at 3:03 PM, Felix Fietkau <nbd@nbd.name> wrote:\n> \n> On 2017-11-02 19:23, Philip Prindeville wrote:\n>> From: Philip Prindeville <philipp@redfish-solutions.com>\n>> \n>> When uclient-fetch is called with multiple URL's, it derives the\n>> first filename based on the URL. When it then handles the 2nd and\n>> subsequent URLs, it assumes that it was called with a -O filename\n>> argument as the output file, because it tries to overload the\n>> variable output_file to mean 2 different things.\n>> \n>> The fix is to use a bool to remember whether we were called with\n>> an explicit output filename, i.e. with the -O argument, and not\n>> overload output_file for this purpose.\n>> \n>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>\n> Thanks for debugging this. I've decided to fix this with a different\n> approach instead. I've pushed a change that avoids the overloading issue\n> entirely by renaming the global variable and overwriting a local\n> variable only.\n> \n> - Felix\n\n\nOkay, great.\n\nWhen will this show up in LEDE?\n\nThanks.","headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"OxsltcAv\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySf0C1zmlz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 08:50:35 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eANNg-0005J6-3f; Thu, 02 Nov 2017 21:50:32 +0000","from mail.redfish-solutions.com ([66.232.79.143])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eANNc-0004Zv-3y\n\tfor lede-dev@lists.infradead.org; Thu, 02 Nov 2017 21:50:29 +0000","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tvA2Lo62l016467\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Thu, 2 Nov 2017 15:50:06 -0600"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:References:Message-Id:Date:\n\tIn-Reply-To:From:Mime-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=F3P9po/7HecwSH32VZWx+zA1O+BEDwjsU99jlI3+fIg=;\n\tb=OxsltcAvwA8ihW\n\tBV8TB4h5XkORZcx1+Eo3fVBoExFedprrHCKICAD7KAWEPYxgf+TueSOoIavB0TT89j/RMTFGrPqme\n\tPRu2s45LpgCZKWqgNOd2tIr2VOYkLJgVVOPHylwgN9wYjw4/punz29KrUMGBGmu2OgdFntRMClV7z\n\tgC708NMGxVxv8wogOu4rImyfUngaHrHHF0wq+XuzeMXAAbbaYKoDvsAIGj/i+ZubmqNzCR86VC78R\n\td8qe5M3S9McKqgxTvi4kwTWEZC7oYyAfM/vfpoR2151NpJhv83R2pcY8M7CfuCDydMlUEVXXjdvRN\n\tIbqyDJDl3CcNxwMLedbw==;","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville <philipp_subx@redfish-solutions.com>","In-Reply-To":"<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>","Date":"Thu, 2 Nov 2017 15:50:05 -0600","Message-Id":"<837BB589-3611-4832-A949-8B174D75B9B5@redfish-solutions.com>","References":"<1509647003-21020-1-git-send-email-philipp@redfish-solutions.com>\n\t<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>","To":"Felix Fietkau <nbd@nbd.name>","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.82 on 192.168.1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171102_145028_299747_4834F2F1 ","X-CRM114-Status":"UNSURE (   9.74  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1798303,"web_url":"http://patchwork.ozlabs.org/comment/1798303/","msgid":"<b1a9bc12-303b-3bfe-7118-4505936bb6c2@nbd.name>","list_archive_url":null,"date":"2017-11-02T21:54:43","subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","submitter":{"id":8537,"url":"http://patchwork.ozlabs.org/api/people/8537/","name":"Felix Fietkau","email":"nbd@nbd.name"},"content":"On 2017-11-02 22:50, Philip Prindeville wrote:\n> \n>> On Nov 2, 2017, at 3:03 PM, Felix Fietkau <nbd@nbd.name> wrote:\n>> \n>> On 2017-11-02 19:23, Philip Prindeville wrote:\n>>> From: Philip Prindeville <philipp@redfish-solutions.com>\n>>> \n>>> When uclient-fetch is called with multiple URL's, it derives the\n>>> first filename based on the URL. When it then handles the 2nd and\n>>> subsequent URLs, it assumes that it was called with a -O filename\n>>> argument as the output file, because it tries to overload the\n>>> variable output_file to mean 2 different things.\n>>> \n>>> The fix is to use a bool to remember whether we were called with\n>>> an explicit output filename, i.e. with the -O argument, and not\n>>> overload output_file for this purpose.\n>>> \n>>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>\n>> Thanks for debugging this. I've decided to fix this with a different\n>> approach instead. I've pushed a change that avoids the overloading issue\n>> entirely by renaming the global variable and overwriting a local\n>> variable only.\n>> \n>> - Felix\n> \n> \n> Okay, great.\n> \n> When will this show up in LEDE?\nPushed just now.\n\n- Felix","headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Uw008+xp\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nbd.name header.i=@nbd.name header.b=\"Kyv4LvUQ\";\n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySf624xXSz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 08:55:38 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eANSU-000177-Bv; Thu, 02 Nov 2017 21:55:30 +0000","from nbd.name ([2a01:4f8:131:30e2::2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eANS6-0008SH-Sk\n\tfor lede-dev@lists.infradead.org; Thu, 02 Nov 2017 21:55:08 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=3wttFxrk3U86UUd96E5v/kE73yBEKzIhfaQhpbpW1cA=;\n\tb=Uw008+xpacCKZc\n\ttHtFCV9BV9Rc9d9PX7HQ/1xC5ip2LHhx17Do11HllHfRxtuZnW3KuWSfzmq1v/estLY5SAjyJAxMw\n\t8V0v8XjVkt7cJA1fCXdXR15ygEySC8wKgqaNFU/Ik2mjgSX8j+cbMQRS5iM85wrznGy3T+ymrzPe/\n\tOUkRKi3rKSI7bZFzu05UVDQC0FEB7FZ+TDyiaLrdDeG5OvKNeHYW/yqF4lpbn+Iz8G5CqdfszCO8T\n\tKmSzfdwFxAdgyLO0mrgNlECWAgEULNwqmbSXLL7exNWcyUvkI90YgM0w1ydtsqKt2NVxSOsUTK8Rn\n\tmqB80DH3zkBFJLPZLElw==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; \n\ts=20160729;\n\th=Content-Transfer-Encoding:Content-Type:In-Reply-To:\n\tMIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:\n\tList-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=ir1B0BxzwMr46Kc0+/NXW3uHajXO89TFk7RNvt5itlw=;\n\tb=Kyv4LvUQHVU/nYLuab5UuYmuY1\n\tndFd0r9zuQrvyyOZEm3umo//rMooHjZ8sWCdmUoyuG0LUaLjFqsd7/bQdCdn+rTl8oH1W5T4307KA\n\t1vVbIdag8/t16AzTmH65d+X0oZFFwh0T2PuzhIFZZ0QZF9P780VQ4HrrPYj7EY6wIGL0=;"],"To":"Philip Prindeville <philipp_subx@redfish-solutions.com>","References":"<1509647003-21020-1-git-send-email-philipp@redfish-solutions.com>\n\t<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>\n\t<837BB589-3611-4832-A949-8B174D75B9B5@redfish-solutions.com>","From":"Felix Fietkau <nbd@nbd.name>","Message-ID":"<b1a9bc12-303b-3bfe-7118-4505936bb6c2@nbd.name>","Date":"Thu, 2 Nov 2017 22:54:43 +0100","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<837BB589-3611-4832-A949-8B174D75B9B5@redfish-solutions.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171102_145507_186662_D9CA844E ","X-CRM114-Status":"UNSURE (   9.39  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1798380,"web_url":"http://patchwork.ozlabs.org/comment/1798380/","msgid":"<09A1E7F2-42A6-43BB-9770-86D043CB94FF@redfish-solutions.com>","list_archive_url":null,"date":"2017-11-03T03:30:13","subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"> On Nov 2, 2017, at 3:54 PM, Felix Fietkau <nbd@nbd.name> wrote:\n> \n> On 2017-11-02 22:50, Philip Prindeville wrote:\n>> \n>> Okay, great.\n>> \n>> When will this show up in LEDE?\n> Pushed just now.\n> \n> - Felix\n\n\nTested and confirmed!","headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"uxk0cFAy\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySnXy5Cqpz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 14:30:58 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eASgt-0003fh-Mu; Fri, 03 Nov 2017 03:30:43 +0000","from mail.redfish-solutions.com ([66.232.79.143])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eASgo-0003MO-VX\n\tfor lede-dev@lists.infradead.org; Fri, 03 Nov 2017 03:30:41 +0000","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tvA33UHsa017720\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Thu, 2 Nov 2017 21:30:17 -0600"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:References:Message-Id:Date:\n\tIn-Reply-To:From:Mime-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=NXsInmWeTz99/R7/3k42sX2AM75NPxgLKVfT6Vfqtv4=;\n\tb=uxk0cFAykpjteX\n\t17aeKg9JbO7UD3NxCH8V3CgLXcRa/qmV3QRf/2mMfQPmXyEWfzyyJJA15XObFYezFPE7czvb8nIll\n\thwYco0ZyYq1h56KW1XO/gK1jlVXRazXKXaBp7dfVujQ1Z/AVGnqhyRUqWckLCFDurpSIDYbmL0jHp\n\tfiUmwaVDYjEF9baOiZAPnBIZNeW+yfAVuxG+DyEs0NU0+mMQC18wd4RHV5dF+gnyfS8mgPjYuE3In\n\txiM78RETQP/Uz/SFZDSlNDafj4rCJsEDI/p7GGbt8sg8065k/I/by8/XJH/nswdznV+kLTMMyH89b\n\tNKjQoz0sp2Nk/Btfe4Uw==;","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville <philipp_subx@redfish-solutions.com>","In-Reply-To":"<b1a9bc12-303b-3bfe-7118-4505936bb6c2@nbd.name>","Date":"Thu, 2 Nov 2017 21:30:13 -0600","Message-Id":"<09A1E7F2-42A6-43BB-9770-86D043CB94FF@redfish-solutions.com>","References":"<1509647003-21020-1-git-send-email-philipp@redfish-solutions.com>\n\t<b492e9dc-0af2-388c-0e57-7ec86c2d8126@nbd.name>\n\t<837BB589-3611-4832-A949-8B174D75B9B5@redfish-solutions.com>\n\t<b1a9bc12-303b-3bfe-7118-4505936bb6c2@nbd.name>","To":"Felix Fietkau <nbd@nbd.name>","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.82 on 192.168.1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171102_203039_232411_5C1D3509 ","X-CRM114-Status":"UNSURE (   5.99  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH v1 1/1] uclient-fetch: correct filename w/\n\tmultple URLs","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]