[{"id":1810035,"web_url":"http://patchwork.ozlabs.org/comment/1810035/","msgid":"<20171125140210.447d626c@windsurf.lan>","list_archive_url":null,"date":"2017-11-25T13:02:10","subject":"Re: [Buildroot] [PATCH v4 1/1] gstreamer1-mm: new package","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Thu, 2 Nov 2017 11:20:15 -0400, Adam Duskett wrote:\n\n> diff --git a/package/gstreamer1/gstreamer1-mm/0001-remove-gstreamer-check-dependency.patch b/package/gstreamer1/gstreamer1-mm/0001-remove-gstreamer-check-dependency.patch\n> new file mode 100644\n> index 0000000000..6f7acd7fb0\n> --- /dev/null\n> +++ b/package/gstreamer1/gstreamer1-mm/0001-remove-gstreamer-check-dependency.patch\n> @@ -0,0 +1,29 @@\n> +From 34637fd7b5cb8cf817858f18d47dc156b52c04bc Mon Sep 17 00:00:00 2001\n> +From: Adam Duskett \n> +Date: Thu, 2 Nov 2017 10:39:00 -0400\n> +Subject: [PATCH] remove gstreamer-check dependency\n> +\n> +gstreamer-check is disabled by default in buildroot and isn't required to\n> +build gstreamermm.\n> +\n> +Signed-off-by: Adam Duskett \n> +---\n> + configure | 2 +-\n> + 1 file changed, 1 insertion(+), 1 deletion(-)\n> +\n> +diff --git a/configure b/configure\n> +index 45d92d4..903e00e 100755\n> +--- a/configure\n> ++++ b/configure\n\nWe really try to avoid patching the configure script directly, please\npatch configure.ac instead, and use _AUTORECONF = YES.\n\n> +@@ -16633,7 +16633,7 @@ fi\n> + # The format below is used so that the requirements appear nicely in the .pc\n> + # file.\n> + \n> +-GSTREAMERMM_MODULES='giomm-2.4 >= 2.47.6 gstreamer-1.0 >= 1.10.0 gstreamer-base-1.0 >= 1.10.0 gstreamer-check-1.0 >= 1.10.0 gstreamer-controller-1.0 >= 1.10.0 gstreamer-net-1.0 >= 1.10.0 gstreamer-allocators-1.0 >= 1.10.0 gstreamer-app-1.0 >= 1.10.0 gstreamer-audio-1.0 >= 1.10.0 gstreamer-fft-1.0 >= 1.10.0 gstreamer-pbutils-1.0 >= 1.10.0 gstreamer-plugins-base-1.0 >= 1.10.0 gstreamer-riff-1.0 >= 1.10.0 gstreamer-rtp-1.0 >= 1.10.0 gstreamer-rtsp-1.0 >= 1.10.0 gstreamer-sdp-1.0 >= 1.10.0 gstreamer-tag-1.0 >= 1.10.0 gstreamer-video-1.0 >= 1.10.0'\n> ++GSTREAMERMM_MODULES='giomm-2.4 >= 2.47.6 gstreamer-1.0 >= 1.10.0 gstreamer-base-1.0 >= 1.10.0 gstreamer-controller-1.0 >= 1.10.0 gstreamer-net-1.0 >= 1.10.0 gstreamer-allocators-1.0 >= 1.10.0 gstreamer-app-1.0 >= 1.10.0 gstreamer-audio-1.0 >= 1.10.0 gstreamer-fft-1.0 >= 1.10.0 gstreamer-pbutils-1.0 >= 1.10.0 gstreamer-plugins-base-1.0 >= 1.10.0 gstreamer-riff-1.0 >= 1.10.0 gstreamer-rtp-1.0 >= 1.10.0 gstreamer-rtsp-1.0 >= 1.10.0 gstreamer-sdp-1.0 >= 1.10.0 gstreamer-tag-1.0 >= 1.10.0 gstreamer-video-1.0 >= 1.10.0'\n\nHowever, this change is not upstreamable at all. Why is\ngstreamer-check-1.0 needed by gstreamer1-mm ?\n\nWe should make the dependency on gstreamer-check-1.0 optional, under\nthe appropriate condition, in the configure.ac script.\n\nCould you look into this ?\n\nThanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ykYnL40C3z9s83\n\tfor ;\n\tSun, 26 Nov 2017 00:29:26 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3A8282DFA8;\n\tSat, 25 Nov 2017 13:29:23 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0dypElPUwQ47; Sat, 25 Nov 2017 13:29:20 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id EBDC22DC3C;\n\tSat, 25 Nov 2017 13:29:19 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3B4321C4114\n\tfor ;\n\tSat, 25 Nov 2017 13:02:14 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3158588E90\n\tfor ;\n\tSat, 25 Nov 2017 13:02:14 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1wzEq8LKkGm1 for ;\n\tSat, 25 Nov 2017 13:02:11 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BFA8F88E7D\n\tfor ; Sat, 25 Nov 2017 13:02:11 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 6120B20747; Sat, 25 Nov 2017 14:02:10 +0100 (CET)","from windsurf.lan (LFbn-TOU-1-149-75.w86-201.abo.wanadoo.fr\n\t[86.201.231.75])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 1610120614;\n\tSat, 25 Nov 2017 14:02:10 +0100 (CET)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 25 Nov 2017 14:02:10 +0100","From":"Thomas Petazzoni ","To":"Adam Duskett ","Message-ID":"<20171125140210.447d626c@windsurf.lan>","In-Reply-To":"<20171102152015.30318-1-aduskett@gmail.com>","References":"<20171102152015.30318-1-aduskett@gmail.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Subject":"Re: [Buildroot] [PATCH v4 1/1] gstreamer1-mm: new package","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"buildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]