[{"id":1798434,"web_url":"http://patchwork.ozlabs.org/comment/1798434/","msgid":"<20171103.154955.386281473222499622.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-03T06:49:55","subject":"Re: [net-next 1/1] tipc: eliminate unnecessary probing","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jon Maloy \nDate: Thu, 2 Nov 2017 15:44:15 +0100\n\n> The neighbor monitor employs a threshold, default set to 32 peer nodes,\n> where it activates the \"Overlapping Neighbor Monitoring\" algorithm.\n> Below that threshold, monitoring is full-mesh, and no \"domain records\"\n> are passed between the nodes.\n> \n> Because of this, a node never received a peer's ack that it has received\n> the most recent update of the own domain. Hence, the field 'acked_gen'\n> in struct tipc_monitor_state remains permamently at zero, whereas the\n> own domain generation is incremented for each added or removed peer.\n> \n> This has the effect that the function tipc_mon_get_state() always sets\n> the field 'probing' in struct tipc_monitor_state true, again leading the\n> tipc_link_timeout() of the link in question to always send out a probe,\n> even when link->silent_intv_count is zero.\n> \n> This is functionally harmless, but leads to some unncessary probing,\n> which can easily be eliminated by setting the 'probing' field of the\n> said struct correctly in such cases.\n> \n> At the same time, we explictly invalidate the sent domain records when\n> the algorithm is not activated. This will eliminate any risk that an\n> invalid domain record might be inadverently accepted by the peer.\n> \n> Signed-off-by: Jon Maloy \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySsyf45gnz9sBd\n\tfor ;\n\tFri, 3 Nov 2017 17:50:02 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753226AbdKCGuA (ORCPT );\n\tFri, 3 Nov 2017 02:50:00 -0400","from shards.monkeyblade.net ([184.105.139.130]:36672 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750805AbdKCGt7 (ORCPT\n\t); Fri, 3 Nov 2017 02:49:59 -0400","from localhost (unknown [61.40.109.130])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 2F265103F5181;\n\tThu, 2 Nov 2017 23:49:57 -0700 (PDT)"],"Date":"Fri, 03 Nov 2017 15:49:55 +0900 (KST)","Message-Id":"<20171103.154955.386281473222499622.davem@davemloft.net>","To":"jon.maloy@ericsson.com","Cc":"netdev@vger.kernel.org, parthasarathy.bhuvaragan@ericsson.com,\n\tying.xue@windriver.com, tipc-discussion@lists.sourceforge.net","Subject":"Re: [net-next 1/1] tipc: eliminate unnecessary probing","From":"David Miller ","In-Reply-To":"<1509633855-24470-1-git-send-email-jon.maloy@ericsson.com>","References":"<1509633855-24470-1-git-send-email-jon.maloy@ericsson.com>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 02 Nov 2017 23:49:59 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]