[{"id":1798450,"web_url":"http://patchwork.ozlabs.org/comment/1798450/","msgid":"","list_archive_url":null,"date":"2017-11-03T07:46:06","subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Thu, Nov 2, 2017 at 3:29 PM, Arnd Bergmann wrote:\n\n> A cleanup left behind a temporary variable that is now unused:\n>\n> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c: In function 'armada_37xx_irq_startup':\n> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:693:20: error: unused variable 'chip' [-Werror=unused-variable]\n>\n> This removes the declarations as well.\n>\n> Fixes: 3ee9e605caea (\"pinctrl: armada-37xx: Stop using struct gpio_chip.irq_base\")\n> Signed-off-by: Arnd Bergmann \n\nIt is used on the head of development, so it's fixed in -next.\n\nIs it such a big issue for v4.14 that you think I should send it\nto Torvalds as a fix at this point or can I just leave it?\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cUU/YbNh\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySvCf0wvvz9sNw\n\tfor ;\n\tFri, 3 Nov 2017 18:46:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752538AbdKCHqI (ORCPT );\n\tFri, 3 Nov 2017 03:46:08 -0400","from mail-io0-f194.google.com ([209.85.223.194]:54241 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752134AbdKCHqH (ORCPT\n\t); Fri, 3 Nov 2017 03:46:07 -0400","by mail-io0-f194.google.com with SMTP id 189so4373383iow.10\n\tfor ;\n\tFri, 03 Nov 2017 00:46:07 -0700 (PDT)","by 10.79.14.140 with HTTP; Fri, 3 Nov 2017 00:46:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=O4JKKqRLVx3zo7OUmoVePC4zT5S+z4Ss/kP4WXx/WWk=;\n\tb=cUU/YbNhgWOQ9eDQhba94Q7Gw7YeWGkVLeyMqWpqKEG3tv8iRFFXRlh0HAIMtSj6FR\n\tKPnO4pyKZKpUV6YcYcY5lhRC0LX9I1pxfQ3l4pIJpxy4MGius+D0203ssyGotj5AyDzR\n\tzuCtOwBjE+0NxGcQpsM5rgrQDzA3ZkuD1qAuM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=O4JKKqRLVx3zo7OUmoVePC4zT5S+z4Ss/kP4WXx/WWk=;\n\tb=sd9nM1KhFPGGM6ciMJr2QMdhSjAYSecR+5qeXbrf1GmC6koaK3EaJ96RK7NiBRBe37\n\tQsNS75MMRlggoHZbyRIsGOI6/pCZTUCxKNFBjnShCFsnkR1RBQpL9QajPBIujMDbjgMe\n\t44aJzbg5rAr4PVQ7Rw9d+IEK8ePMBwjkj82dsyjzhOYu9Q9fzreIqh6l6bdnUr+Rpx4K\n\tcmG8MB1F7shJVmToBWNjtdnLtFYtGIj3+AePR8/Kyh7PGZDX6GjWNNxBSlSFh35+KwQr\n\tKyprPVx3sCb2Ynf9W8dXoWe3HGga5RVIzyXZ540iQSpT2KKjRrFZ9kb300pgD1S6MHpI\n\tFHlw==","X-Gm-Message-State":"AJaThX7G1IaF0WIZ5KNzOdBgVIVfWPTVyMYSK7LCKu73rqQ+1iDDi1sc\n\tqXASam0YUZdAK/MAuzaCAfT/vBYD9u64vKD+CkaoZQ==","X-Google-Smtp-Source":"ABhQp+R1q8deVnITyke2Hj/kQ4Jag9oqLtP0SPIZM828PTQH12yU4xbMu20npUUnBd0syJgy4kvQHLCmLhClmBKiIKI=","X-Received":"by 10.107.155.17 with SMTP id d17mr7746482ioe.220.1509695166935; \n\tFri, 03 Nov 2017 00:46:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171102142932.774199-1-arnd@arndb.de>","References":"<20171102142932.774199-1-arnd@arndb.de>","From":"Linus Walleij ","Date":"Fri, 3 Nov 2017 08:46:06 +0100","Message-ID":"","Subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","To":"Arnd Bergmann ","Cc":"Jason Cooper , Andrew Lunn ,\n\tGregory Clement ,\n\tSebastian Hesselbarth ,\n\tKen Ma , Thierry Reding ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1798472,"web_url":"http://patchwork.ozlabs.org/comment/1798472/","msgid":"","list_archive_url":null,"date":"2017-11-03T09:11:21","subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Fri, Nov 3, 2017 at 8:46 AM, Linus Walleij wrote:\n> On Thu, Nov 2, 2017 at 3:29 PM, Arnd Bergmann wrote:\n>\n>> A cleanup left behind a temporary variable that is now unused:\n>>\n>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c: In function 'armada_37xx_irq_startup':\n>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:693:20: error: unused variable 'chip' [-Werror=unused-variable]\n>>\n>> This removes the declarations as well.\n>>\n>> Fixes: 3ee9e605caea (\"pinctrl: armada-37xx: Stop using struct gpio_chip.irq_base\")\n>> Signed-off-by: Arnd Bergmann \n>\n> It is used on the head of development, so it's fixed in -next.\n>\n> Is it such a big issue for v4.14 that you think I should send it\n> to Torvalds as a fix at this point or can I just leave it?\n\nI'm confused. The build warning showed up in linux-next yesterday after\n3ee9e605caea got merged, which removes the user of that variable.\nIn v4.14 it is still used.\n\n Arnd\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ll/O89qE\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySx5n0L22z9sNc\n\tfor ;\n\tFri, 3 Nov 2017 20:11:25 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754612AbdKCJLX (ORCPT );\n\tFri, 3 Nov 2017 05:11:23 -0400","from mail-ot0-f193.google.com ([74.125.82.193]:51029 \"EHLO\n\tmail-ot0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754141AbdKCJLW (ORCPT\n\t); Fri, 3 Nov 2017 05:11:22 -0400","by mail-ot0-f193.google.com with SMTP id 15so1884337otj.7;\n\tFri, 03 Nov 2017 02:11:22 -0700 (PDT)","by 10.157.28.152 with HTTP; Fri, 3 Nov 2017 02:11:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=IRs4EwaI4lFAF4gTT5yysTPwDWwgpZhFhQ9EvmSpBm4=;\n\tb=Ll/O89qERt3h7KdLlq4EquKlQSxTEvEznSokcxiUnyQAVqKID7MvEDfybclh1hgOIN\n\tNQtyrn4caUWj/F4iLuaZCr/BoAMon5MdXmK8qWWJB/fnDR7u/67AMHN0vmGmmEMEt7Ep\n\tpcE0fwOTInn+zKEVjLvTKcvX6HiMQyXWVetoV04KMrqGuRvXRssYZuteBUwPglR0ZPYS\n\tekRR+45hg7CVGqoY5iG4VOlM9GeKLxc/9PFYmiz5fE05pKhH0GoCewKHCOUd8J1VRYXS\n\tjy78aKvy/vZvFTSbhGUqSnkLgzoak4HuRM58LSzGRHtRAUjG/tH7TXge4MjvK+0o3sDQ\n\t+wzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=IRs4EwaI4lFAF4gTT5yysTPwDWwgpZhFhQ9EvmSpBm4=;\n\tb=l/GTEihuKMyrWafcHDewnvCeKnQyLVwaR+bGFhYD4yKu8xrKgD23VpX3smY4CjUn6t\n\t4/4GKI4L+UfweKkVqhIoEsIv/G9mpB/6MpPrYrb2MscLNQTaa4pJCCaCgsGGyLTAe++v\n\tZlxC1sKDnlIorFXQ2zleKgZs8mRN+BQwaJX+g0EbPYEgBYCncVVdX39o2IXqv3V/hWDR\n\tv/cbUMTWUv69Kk73oDE7NP1FmtSxBYPLYHcZFHy2XNJwYr26xGNo8Jlp7RNPFZHFMUC3\n\thKvfZZy4UqR92NWJhVh95d0ieuxLKeHsTl3H2SH1GScvyYQEAuAxzUglJHMi7X0NPuLB\n\tnWqg==","X-Gm-Message-State":"AJaThX5eBxkt3SICa66i8OEsS+VxD619o8SM7MgE3ozOFlhIbUrrTg1O\n\tfQt641Slvv5X6B9BWCrOF2VoNCZx/V0LgftY8Ts=","X-Google-Smtp-Source":"ABhQp+SB3lUVgWxt7gpKKXZAjAeHhjc2GaXP34iw13qzWWQE10xzDYAZwuonhwI1aKQj1fF99vbyloeznOn6spCNfzM=","X-Received":"by 10.157.39.120 with SMTP id r111mr4118392ota.402.1509700281880;\n\tFri, 03 Nov 2017 02:11:21 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20171102142932.774199-1-arnd@arndb.de>\n\t","From":"Arnd Bergmann ","Date":"Fri, 3 Nov 2017 10:11:21 +0100","X-Google-Sender-Auth":"mwynlBFImFXcpfdMeAV17-IqRDc","Message-ID":"","Subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","To":"Linus Walleij ","Cc":"Jason Cooper , Andrew Lunn ,\n\tGregory Clement ,\n\tSebastian Hesselbarth ,\n\tKen Ma , Thierry Reding ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1798972,"web_url":"http://patchwork.ozlabs.org/comment/1798972/","msgid":"","list_archive_url":null,"date":"2017-11-03T22:21:44","subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Fri, Nov 3, 2017 at 10:11 AM, Arnd Bergmann wrote:\n> On Fri, Nov 3, 2017 at 8:46 AM, Linus Walleij wrote:\n>> On Thu, Nov 2, 2017 at 3:29 PM, Arnd Bergmann wrote:\n>>\n>>> A cleanup left behind a temporary variable that is now unused:\n>>>\n>>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c: In function 'armada_37xx_irq_startup':\n>>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:693:20: error: unused variable 'chip' [-Werror=unused-variable]\n>>>\n>>> This removes the declarations as well.\n>>>\n>>> Fixes: 3ee9e605caea (\"pinctrl: armada-37xx: Stop using struct gpio_chip.irq_base\")\n>>> Signed-off-by: Arnd Bergmann \n>>\n>> It is used on the head of development, so it's fixed in -next.\n>>\n>> Is it such a big issue for v4.14 that you think I should send it\n>> to Torvalds as a fix at this point or can I just leave it?\n>\n> I'm confused. The build warning showed up in linux-next yesterday after\n> 3ee9e605caea got merged, which removes the user of that variable.\n> In v4.14 it is still used.\n\nI just confused myself by trying to apply it to the pin control\ntree while the refactorings were in the GPIO tree.\n\nApplied it to the right tree now, thanks!\n\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"JtZCsO1S\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yTGdm2hV8z9s83\n\tfor ;\n\tSat, 4 Nov 2017 09:21:48 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752220AbdKCWVq (ORCPT );\n\tFri, 3 Nov 2017 18:21:46 -0400","from mail-io0-f196.google.com ([209.85.223.196]:47969 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751907AbdKCWVp (ORCPT\n\t); Fri, 3 Nov 2017 18:21:45 -0400","by mail-io0-f196.google.com with SMTP id h70so9405350ioi.4\n\tfor ;\n\tFri, 03 Nov 2017 15:21:45 -0700 (PDT)","by 10.79.14.140 with HTTP; Fri, 3 Nov 2017 15:21:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=UZ1cmF/gxZ4wlITkZFVhMHO31a+Rg07ARWUxVVGo3qg=;\n\tb=JtZCsO1ShS2fu/e/Mdw5WsGb/9/W2nEJmfK/LwZ4hXLm0oEPUXitTEQHLMLoOu4cdt\n\tJPW68YaMWVmHzya0iMFXWQgogqmdoD5/1708D+1OkCUtIuEc8fziYdFQ+Ysl33zelELN\n\tNk3J9kwpmhy+5KswonJDkdzaFQ0qdnmgfwZa4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=UZ1cmF/gxZ4wlITkZFVhMHO31a+Rg07ARWUxVVGo3qg=;\n\tb=Jnaj1zRDbhRBgwDaKR9mjno8PgAlJlld+y4m78hwHhb+6WkYZYt0/txdnkUjh1CBIx\n\tAStB2xhk+aksdQ8tN1hk8Bso778+fChXH4+WkwG7HTTiQ7traUcfh+AK7hXN7+WwRPr1\n\t7Z5wUSEYTOHSaiur4Bg+bBoy83YygkPx4m8xeUnFDASSbAKO/3m/6Na0WjVYoZVKBLOb\n\tg2ZULyuvJmmHu/tW4khuqjTbPVJTHeWIvS3JHIoSs1aQWL3FvIpIdyr3CCFF1CPSjuVJ\n\to5cWgvOndc5HlDBUFHUYf+cbKWbT+/5+SLG0PQ75yyHyAcu/nd6aoV2y+X8Ru3MN2+ap\n\t6HiQ==","X-Gm-Message-State":"AJaThX43dUcw4XFAM1t5XFlRepm+a0jUR29lxlkxZWQVf1k9ap6hPgED\n\tMyuIGOjLAb3bbdZ+GjNUwD+q9jK0D9TIMRRzXVZqWQ==","X-Google-Smtp-Source":"ABhQp+RngVr7qAtqSgbjTWcLnAjDzhl1F7O74VXjLVE5XvK/6vy0Jb+5D+eARuNzMrU1t+VJSbBTgNSmSU2QMvMT9iE=","X-Received":"by 10.36.29.208 with SMTP id 199mr660615itj.40.1509747705389;\n\tFri, 03 Nov 2017 15:21:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20171102142932.774199-1-arnd@arndb.de>\n\t\n\t","From":"Linus Walleij ","Date":"Fri, 3 Nov 2017 23:21:44 +0100","Message-ID":"","Subject":"Re: [PATCH] pinctrl: armada-37xx: remove unused variable","To":"Arnd Bergmann ","Cc":"Jason Cooper , Andrew Lunn ,\n\tGregory Clement ,\n\tSebastian Hesselbarth ,\n\tKen Ma , Thierry Reding ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]