[{"id":1798003,"web_url":"http://patchwork.ozlabs.org/comment/1798003/","msgid":"<20171102152531.GA16769@banjo.asicdesigners.com>","list_archive_url":null,"date":"2017-11-02T15:25:32","subject":"Re: [PATCH net-next] cxgb4: fix error return code in\n\tcxgb4_set_hash_filter()","submitter":{"id":9904,"url":"http://patchwork.ozlabs.org/api/people/9904/","name":"Kumar Sanghvi","email":"kumaras@chelsio.com"},"content":"On Thursday, November 11/02/17, 2017 at 11:15:07 +0000, Wei Yongjun wrote:\n> Fix to return a negative error code from thecxgb4_alloc_atid()\n> error handling case instead of 0.\n> \n> Fixes: 12b276fbf6e0 (\"cxgb4: add support to create hash filters\")\n> Signed-off-by: Wei Yongjun \n> ---\n> drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c\n> index abab67d..5980f30 100644\n> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c\n> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c\n> @@ -1110,8 +1110,10 @@ static int cxgb4_set_hash_filter(struct net_device *dev,\n> \t}\n> \n> \tatid = cxgb4_alloc_atid(t, f);\n> -\tif (atid < 0)\n> +\tif (atid < 0) {\n> +\t\tret = atid;\n> \t\tgoto free_smt;\n> +\t}\n> \n> \ticonf = adapter->params.tp.ingress_config;\n> \tif (iconf & VNIC_F) {\n>\n\nThank you for the fix.\n\nAcked-By: Kumar Sanghvi ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySTSF3DqZz9s74\n\tfor ;\n\tFri, 3 Nov 2017 02:25:49 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933816AbdKBPZr (ORCPT );\n\tThu, 2 Nov 2017 11:25:47 -0400","from stargate.chelsio.com ([12.32.117.8]:60570 \"EHLO\n\tstargate.chelsio.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933652AbdKBPZp (ORCPT\n\t); Thu, 2 Nov 2017 11:25:45 -0400","from localhost (munich.asicdesigners.com [10.192.163.218] (may be\n\tforged))\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id vA2FPXCp010060; \n\tThu, 2 Nov 2017 08:25:34 -0700"],"Date":"Thu, 2 Nov 2017 08:25:32 -0700","From":"Kumar Sanghvi ","To":"Wei Yongjun ","Cc":"Ganesh Goudar , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next] cxgb4: fix error return code in\n\tcxgb4_set_hash_filter()","Message-ID":"<20171102152531.GA16769@banjo.asicdesigners.com>","References":"<1509621307-152457-1-git-send-email-weiyongjun1@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1509621307-152457-1-git-send-email-weiyongjun1@huawei.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798403,"web_url":"http://patchwork.ozlabs.org/comment/1798403/","msgid":"<20171103.142424.1260190712649208337.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-03T05:24:24","subject":"Re: [PATCH net-next] cxgb4: fix error return code in\n\tcxgb4_set_hash_filter()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Wei Yongjun \nDate: Thu, 2 Nov 2017 11:15:07 +0000\n\n> Fix to return a negative error code from thecxgb4_alloc_atid()\n> error handling case instead of 0.\n> \n> Fixes: 12b276fbf6e0 (\"cxgb4: add support to create hash filters\")\n> Signed-off-by: Wei Yongjun \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySr3x6dHTz9sNV\n\tfor ;\n\tFri, 3 Nov 2017 16:24:29 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753950AbdKCFY1 (ORCPT );\n\tFri, 3 Nov 2017 01:24:27 -0400","from shards.monkeyblade.net ([184.105.139.130]:35248 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751057AbdKCFY1 (ORCPT\n\t); Fri, 3 Nov 2017 01:24:27 -0400","from localhost (unknown [61.40.109.130])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 01804103F3996;\n\tThu, 2 Nov 2017 22:24:25 -0700 (PDT)"],"Date":"Fri, 03 Nov 2017 14:24:24 +0900 (KST)","Message-Id":"<20171103.142424.1260190712649208337.davem@davemloft.net>","To":"weiyongjun1@huawei.com","Cc":"ganeshgr@chelsio.com, kumaras@chelsio.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next] cxgb4: fix error return code in\n\tcxgb4_set_hash_filter()","From":"David Miller ","In-Reply-To":"<1509621307-152457-1-git-send-email-weiyongjun1@huawei.com>","References":"<1509621307-152457-1-git-send-email-weiyongjun1@huawei.com>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 02 Nov 2017 22:24:26 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]