[{"id":1797999,"web_url":"http://patchwork.ozlabs.org/comment/1797999/","msgid":"<87mv44ln5v.fsf@qca.qualcomm.com>","list_archive_url":null,"date":"2017-11-02T15:23:42","subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","submitter":{"id":8605,"url":"http://patchwork.ozlabs.org/api/people/8605/","name":"Kalle Valo","email":"kvalo@qca.qualcomm.com"},"content":"Arnd Bergmann writes:\n\n> The combination of two patches has led to a build failure:\n>\n> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':\n> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]\n> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':\n> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]\n>\n> This moves the functions outside of the now incorrect #ifdef.\n>\n> Fixes: 96378bd2c6cd (\"ath10k: fix core PCI suspend when WoWLAN is supported but disabled\")\n> Fixes: 6af1de2e4ec4 (\"ath10k: mark PM functions as __maybe_unused\")\n> Signed-off-by: Arnd Bergmann \n\nBrian has already fixed this, please check that:\n\nhttps://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647\n\nBut apparently I forgot to merge ath-next to wireless-drivers-next, will\ndo that soon.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=qca.qualcomm.com header.i=@qca.qualcomm.com\n\theader.b=\"l96kSvyw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySTPz41Ldz9t2M\n\tfor ;\n\tFri, 3 Nov 2017 02:23:51 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933761AbdKBPXr (ORCPT );\n\tThu, 2 Nov 2017 11:23:47 -0400","from sabertooth01.qualcomm.com ([65.197.215.72]:46704 \"EHLO\n\tsabertooth01.qualcomm.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S933418AbdKBPXp (ORCPT\n\t); Thu, 2 Nov 2017 11:23:45 -0400","from unknown (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108])\n\tby sabertooth01.qualcomm.com with ESMTP; 02 Nov 2017 08:23:44 -0700","from nasanexm01b.na.qualcomm.com ([10.85.0.82])\n\tby Ironmsg04-R.qualcomm.com with ESMTP/TLS/AES256-SHA;\n\t02 Nov 2017 08:23:43 -0700","from eusanexr01a.eu.qualcomm.com (10.85.0.97) by\n\tNASANEXM01B.na.qualcomm.com (10.85.0.82) with Microsoft SMTP Server\n\t(TLS) id 15.0.1293.2; Thu, 2 Nov 2017 08:23:42 -0700","from eusanexr01a.eu.qualcomm.com ([10.85.0.97]) by\n\teusanexr01a.eu.qualcomm.com ([10.85.0.97]) with mapi id\n\t15.00.1293.002; Thu, 2 Nov 2017 08:23:43 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n\td=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt;\n\ts=qcdkim; t=1509636225; x=1541172225;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=Gcxe4mAVaRfV7lN9tb+vH7nDPNuhWr+xkZiF9ouHp2c=;\n\tb=l96kSvywnkNJg9TF/khgdrMG3DiGmHLd36k5sMp2eWTlnJu93soTflA1\n\tjEX2oj2GMuOKu8RQmHBbZASsRIjFS9aPidMkJy+1xOhqWqiDle4q+EgzB\n\tf4B6WtlzAtTQC4ylLGRZsB9a73A9B41X9kL4sKWwT//HFflUM04YkqaL/ o=;","X-IronPort-AV":["E=Sophos;i=\"5.44,334,1505804400\"; d=\"scan'208\";a=\"116387911\"","E=McAfee;i=\"5900,7806,8702\"; a=\"1525717657\""],"X-MGA-submission":"MDHK7kvN9UmRQwqP/85uUvQb5iPG+fnfd0pebrNgKxWfNp1SFuVM2ZK4Sa+ZYQSIseYfIJT55VTlnswMIriTKPedAu7lDn7lQhZuaoyhF2Ean/wGbOh34oSwFjh5bdJLgXAa8gk5PRfgsMvGV65DP7oD","From":"Kalle Valo ","To":"Arnd Bergmann ","CC":"Ryan Hsu ,\n\tGovind Singh ,\n\tSrinivas Kandagatla ,\n\tAshok Raj Nagarajan ,\n\tBen Greear ,\n\t\"Brian Norris\" ,\n\tColin Ian King ,\n\t\"ath10k@lists.infradead.org\" ,\n\t\"linux-wireless@vger.kernel.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","Thread-Topic":"[PATCH] ath10k: move pci suspend/resume functions","Thread-Index":"AQHTU8sIUwjYYm0/ZUGKqAY2G2HYKA==","Date":"Thu, 2 Nov 2017 15:23:42 +0000","Message-ID":"<87mv44ln5v.fsf@qca.qualcomm.com>","References":"<20171102110903.2886660-1-arnd@arndb.de>","In-Reply-To":"<20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's\n\tmessage of \"Thu, 2 Nov 2017 12:08:53 +0100\")","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-messagesentrepresentingtype":"1","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[199.106.107.6]","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798019,"web_url":"http://patchwork.ozlabs.org/comment/1798019/","msgid":"","list_archive_url":null,"date":"2017-11-02T15:40:57","subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Thu, Nov 2, 2017 at 4:23 PM, Kalle Valo wrote:\n> Arnd Bergmann writes:\n>\n>> The combination of two patches has led to a build failure:\n>>\n>> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':\n>> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]\n>> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':\n>> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]\n>>\n>> This moves the functions outside of the now incorrect #ifdef.\n>>\n>> Fixes: 96378bd2c6cd (\"ath10k: fix core PCI suspend when WoWLAN is supported but disabled\")\n>> Fixes: 6af1de2e4ec4 (\"ath10k: mark PM functions as __maybe_unused\")\n>> Signed-off-by: Arnd Bergmann \n>\n> Brian has already fixed this, please check that:\n>\n> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647\n>\n> But apparently I forgot to merge ath-next to wireless-drivers-next, will\n> do that soon.\n\nYes, Brian's version is better. I considered the same, but wasn't sure\nit was safe.\n\n Arnd","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZvMl08wD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySTp01kntz9sP1\n\tfor ;\n\tFri, 3 Nov 2017 02:41:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933974AbdKBPlA (ORCPT );\n\tThu, 2 Nov 2017 11:41:00 -0400","from mail-ot0-f195.google.com ([74.125.82.195]:45204 \"EHLO\n\tmail-ot0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933567AbdKBPk6 (ORCPT\n\t); Thu, 2 Nov 2017 11:40:58 -0400","by mail-ot0-f195.google.com with SMTP id q99so1735513ota.2;\n\tThu, 02 Nov 2017 08:40:58 -0700 (PDT)","by 10.157.28.152 with HTTP; Thu, 2 Nov 2017 08:40:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=pQtcm9wNUg+1pDqV1udMijgiRYfBcLKXthIPncUexlE=;\n\tb=ZvMl08wD85N5irZECEtcRCZ/duIKQE9lIkLGojAhLggPM6NpFspIhUBBMc2iadVfYE\n\tF2behqbxacZXlVnjM6L8mI10HkHlpeiKoB9Qu4E6IoZM0nzAxoKQKGoY7A0zNnpxdju/\n\t+Wgug3gKqH3+pGtE9rlaGWFNpXd4VChrfmvRyeIa3QOxPC1p2lzMzGcJm99H9J9JuJfE\n\t0D4WG84aGqNxx6xbUGVAEMCgARONoGmtQ2GBfI4nHa+MUxpMPRYskaN8EYgilU5dM8vT\n\tlx4Y9jrXjUMHZpakcf9KzX+EYcbtfIBbdFnM6F7wY4CVWemNVagfAIcPfNxtpkkPgSzR\n\t1Hpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=pQtcm9wNUg+1pDqV1udMijgiRYfBcLKXthIPncUexlE=;\n\tb=KqUqgl7diDUL2e5zb3KLqq3RhJu9GZyqmH74/XwIbX7wj824fbIk1nfJMCAOPCzlAC\n\tX980h27S8AneNkN2ZZOsOhCSoSO8bqo7f/SauJ4VpXaBZr32lcODIxcUnwO/tD3LTsOB\n\tBmi74ODFm8/t7RMD07YUkCiG+JcqvZx5Cu0F6baNDCB1atp9NtGg37L/+NrGIZKlI2yL\n\tf6nbPAhBj+kAQNT7kqilpVSDhUXLDdte4WaJApRcx39VlcAmY52ZJ7VM5rIW25qnNJ8U\n\tcfLDSq3ozJxjB6QJTeL8uPR50Xl1LZTjAmOcqVofqUxfxLWq4CawuIA0AsFChRZWolzU\n\tDW3g==","X-Gm-Message-State":"AJaThX6+03qDoR2d7Nu1FCKMH2+xrF8kopPH+Kg3Tbfr9Ho/vkA06p8z\n\tNqgeA+wGg98GCxvI71AWlqlUPka/+1r32IVyTz4=","X-Google-Smtp-Source":"ABhQp+ReG6IWhaE8cDOvvaVPWJYCdTFGv7PyoufjYEmzVfte2XhkcHkdm1R/KC0VjLumQOuRlPo3Qep+2310ie/RDqQ=","X-Received":"by 10.157.16.5 with SMTP id h5mr2673479ote.320.1509637258043;\n\tThu, 02 Nov 2017 08:40:58 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<87mv44ln5v.fsf@qca.qualcomm.com>","References":"<20171102110903.2886660-1-arnd@arndb.de>\n\t<87mv44ln5v.fsf@qca.qualcomm.com>","From":"Arnd Bergmann ","Date":"Thu, 2 Nov 2017 16:40:57 +0100","X-Google-Sender-Auth":"T8saDHtg1eBpx0NtS7xcTBPN5W8","Message-ID":"","Subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","To":"Kalle Valo ","Cc":"Ryan Hsu ,\n\tGovind Singh ,\n\tSrinivas Kandagatla ,\n\tAshok Raj Nagarajan ,\n\tBen Greear ,\n\tBrian Norris ,\n\tColin Ian King ,\n\t\"ath10k@lists.infradead.org\" ,\n\t\"linux-wireless@vger.kernel.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798096,"web_url":"http://patchwork.ozlabs.org/comment/1798096/","msgid":"<20171102171017.GA11081@google.com>","list_archive_url":null,"date":"2017-11-02T17:10:18","subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","submitter":{"id":67074,"url":"http://patchwork.ozlabs.org/api/people/67074/","name":"Brian Norris","email":"briannorris@chromium.org"},"content":"On Thu, Nov 02, 2017 at 04:40:57PM +0100, Arnd Bergmann wrote:\n> On Thu, Nov 2, 2017 at 4:23 PM, Kalle Valo wrote:\n> > Brian has already fixed this, please check that:\n> >\n> > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647\n> >\n> > But apparently I forgot to merge ath-next to wireless-drivers-next, will\n> > do that soon.\n> \n> Yes, Brian's version is better. I considered the same, but wasn't sure\n> it was safe.\n\nYes, it's safe. The code is still basically dead, since the mac80211 ops\nget dropped with !CONFIG_PM (so no one calls the\n*_hif_{suspend,resume}() functions), but at least we have fewer\n#ifdef's.\n\nBrian","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mfJNl2kt\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySWnS6g8hz9t30\n\tfor ;\n\tFri, 3 Nov 2017 04:10:52 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755191AbdKBRKZ (ORCPT );\n\tThu, 2 Nov 2017 13:10:25 -0400","from mail-io0-f194.google.com ([209.85.223.194]:53625 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752312AbdKBRKX (ORCPT\n\t); Thu, 2 Nov 2017 13:10:23 -0400","by mail-io0-f194.google.com with SMTP id 189so487945iow.10\n\tfor ; Thu, 02 Nov 2017 10:10:22 -0700 (PDT)","from google.com ([2620:0:1000:1600:8c9b:d142:8019:a6a3])\n\tby smtp.gmail.com with ESMTPSA id w6sm42983itc.43.2017.11.02.10.10.20\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 02 Nov 2017 10:10:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=RaNVazD729yXdD0MQ2Vakq77Cnm00Pc+PjP18DC6x+w=;\n\tb=mfJNl2ktO9xNuKadxv8Pa8rhRl5v/2hpN8+Wja/trxUzoo23aXK9B+VyRZBjmIcq/9\n\t81OT2TqEjHgai3wXHhM1ZkBYAttDrSzL0t9QJ3eWAwqIBMxyY9v8zO2jNyGOlyusf4ty\n\teJgM6SSurf1QjMXfBeU2Ow+eGl2KLFl8RZKuY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=RaNVazD729yXdD0MQ2Vakq77Cnm00Pc+PjP18DC6x+w=;\n\tb=WQXAJ7Vgaf9+oAnvKAVOaYTXshbk2u5V2CKuunKlEoXt0G6TAfd9ELrIpI/PQ6nbzp\n\tj/ORxRbkp5ezxF6RjbZdL97UMNncuAGMeDqqSV5SVJzURR3ZYiFXJgqIyCZoeK0Ixdm6\n\tIBS5OUpbZVGXuom5qqlg3ZpDJbsngsnx5ODBzsT4U5jhH+r1eunqg7fPt4t23neCzH6V\n\tyFZHhCUY5YSRWRqVgZHBq8EN9BlQiCmwx+S7P2AdpWgRKhblhl8qlzP0jX/Fc22J4gxV\n\ts/C5XoK0maSpqqj+hxy3Qw4PWl5XFQ4QG3J51l3NKFwxUBs/7ILncol2IAV62jcskrzr\n\tkIvg==","X-Gm-Message-State":"AMCzsaVwlto+N0rub6GKoPy+7xnKVBRLvypMfaQtXC1PCvbtpRdLFSCY\n\tFVE6cfAp1wD5ngcwhplXX6wZ/w==","X-Google-Smtp-Source":"ABhQp+T/smejpiTYreK6Kue8TjeZiG3oWBTVQTOGrrWQfIHehtiRWaTcSCDAvNQ0TG78MdT8YyGPuA==","X-Received":"by 10.36.33.23 with SMTP id e23mr3681300ita.109.1509642622521;\n\tThu, 02 Nov 2017 10:10:22 -0700 (PDT)","Date":"Thu, 2 Nov 2017 10:10:18 -0700","From":"Brian Norris ","To":"Arnd Bergmann ","Cc":"Kalle Valo , Ryan Hsu ,\n\tGovind Singh ,\n\tSrinivas Kandagatla ,\n\tAshok Raj Nagarajan ,\n\tBen Greear ,\n\tColin Ian King ,\n\t\"ath10k@lists.infradead.org\" ,\n\t\"linux-wireless@vger.kernel.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [PATCH] ath10k: move pci suspend/resume functions","Message-ID":"<20171102171017.GA11081@google.com>","References":"<20171102110903.2886660-1-arnd@arndb.de>\n\t<87mv44ln5v.fsf@qca.qualcomm.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]