[{"id":1798143,"web_url":"http://patchwork.ozlabs.org/comment/1798143/","msgid":"<20171102105530.1997dd91@cakuba.netronome.com>","list_archive_url":null,"date":"2017-11-02T17:55:30","subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","submitter":{"id":67484,"url":"http://patchwork.ozlabs.org/api/people/67484/","name":"Jakub Kicinski","email":"jakub.kicinski@netronome.com"},"content":"On Thu, 2 Nov 2017 12:05:51 +0100, Arnd Bergmann wrote:\n> I ran into this link error with the latest net-next plus linux-next\n> trees when networking is disabled:\n> \n> kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'\n> kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'\n> \n> It seems that the code was written to deal with varying contents of\n> the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops\n> and xdp_analyzer_ops are defined in the core networking code, so adding\n> a check for CONFIG_NET seems appropriate here, and I've verified this with\n> many randconfig builds\n> \n> Fixes: 4f9218aaf8a4 (\"bpf: move knowledge about post-translation offsets out of verifier\")\n> Signed-off-by: Arnd Bergmann \n\nThanks Arnd! I was hoping to nuke this code before build bots catch up\nto me, didn't work out :)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"hRlYFAxS\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySXnc3T46z9sPm\n\tfor ;\n\tFri, 3 Nov 2017 04:56:04 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933616AbdKBRzg (ORCPT );\n\tThu, 2 Nov 2017 13:55:36 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:43997 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933057AbdKBRze (ORCPT\n\t); Thu, 2 Nov 2017 13:55:34 -0400","by mail-qt0-f195.google.com with SMTP id j58so438947qtj.0\n\tfor ; Thu, 02 Nov 2017 10:55:34 -0700 (PDT)","from cakuba.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\tr16sm2537815qtc.4.2017.11.02.10.55.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 02 Nov 2017 10:55:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:organization:mime-version:content-transfer-encoding;\n\tbh=4mu6f3I7hdnNrIKH2wwJWJ3hWqgu1A/0yMk8FKTJK14=;\n\tb=hRlYFAxS+Qw1aT88+xS25afL8QrzRJpWMmqxJJvFro2dBd2wkWVgnqazaCMU+FodkN\n\tvc5wkcgm03rkwqs7iFPcmQ6cvKpHvCTMeHzcmcdcTAgSx+LoLy3+QhHP8EhSDurXOkN8\n\tglHjz2EQ90dFoL8MZvvOPjA3ySMMwK85HYoTXMSenS+TRfPZTtOnchpjVC1vMAH8Fnsr\n\tVEchnq5hoOe5thgirhe/k3/qgUelzJBbLr/OURzCGHknOjLsEJcZaufsed4xktdfk3Ll\n\tc6VP0/9agSJBr85ffCngGgqTFG8joAcGg5gjeyTevSZKMJarJiaKq57VdejLO8kKotXX\n\t4Blg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:organization:mime-version:content-transfer-encoding;\n\tbh=4mu6f3I7hdnNrIKH2wwJWJ3hWqgu1A/0yMk8FKTJK14=;\n\tb=ANXBwMZo9ue19eJ/vHNRpeEIniCdBZzraqk2/NOCnUXU1KGFPneFJ9+ZvhZBrR1i9f\n\t7M2rsyzFeB+fj4nmOTZO6W/j7P/lCI+wLPE2Ky7VhFqu4zLCXfJcQQ+b5qFeG5Rc93xk\n\tCXovUEid4lTAXkP+kwA6730ceNHelu8cvKuaPTOOBUFAiGVgV3dEbjzrZvLVkcOFXN2Z\n\tazN9ZWbaYmt31VJK3F2zJ05EZtVmlSZr4HRzbC4YQC5NotZBEjiFsk+KaJ6NPFI8q+kZ\n\t1T82ITfdvJMrlD+JdRsCf9NQxhpb0Rav3uDRxaA6HBIWFii6hydnTFIBfltNcvj88o6R\n\tjDWQ==","X-Gm-Message-State":"AMCzsaWu+T2/zOMoRD5qEF2afIUQhz+BGOIixaMMe93rIVDswZ9m6Ll8\n\tC8CKz0MSIX0btLYF7/KkwqtoFA==","X-Google-Smtp-Source":"ABhQp+QSlmOADlCrOXOKEsiFb3WIL0EVdpDfONXJul1mfsvCpmqPCV1nbPGtSGXLQKjbUPgeFFn0Dg==","X-Received":"by 10.200.8.148 with SMTP id v20mr6487933qth.33.1509645333899;\n\tThu, 02 Nov 2017 10:55:33 -0700 (PDT)","Date":"Thu, 2 Nov 2017 10:55:30 -0700","From":"Jakub Kicinski ","To":"Arnd Bergmann ","Cc":"Alexei Starovoitov ,\n\tDaniel Borkmann ,\n\t\"David S. Miller\" ,\n\tEdward Cree ,\n\tJohn Fastabend ,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","Message-ID":"<20171102105530.1997dd91@cakuba.netronome.com>","In-Reply-To":"<20171102110558.2746221-1-arnd@arndb.de>","References":"<20171102110558.2746221-1-arnd@arndb.de>","Organization":"Netronome Systems, Ltd.","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798188,"web_url":"http://patchwork.ozlabs.org/comment/1798188/","msgid":"<20171102184824.b6mucc5ebt3okrqy@ast-mbp>","list_archive_url":null,"date":"2017-11-02T18:48:25","subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Thu, Nov 02, 2017 at 10:55:30AM -0700, Jakub Kicinski wrote:\n> On Thu, 2 Nov 2017 12:05:51 +0100, Arnd Bergmann wrote:\n> > I ran into this link error with the latest net-next plus linux-next\n> > trees when networking is disabled:\n> > \n> > kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'\n> > kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'\n> > \n> > It seems that the code was written to deal with varying contents of\n> > the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops\n> > and xdp_analyzer_ops are defined in the core networking code, so adding\n> > a check for CONFIG_NET seems appropriate here, and I've verified this with\n> > many randconfig builds\n> > \n> > Fixes: 4f9218aaf8a4 (\"bpf: move knowledge about post-translation offsets out of verifier\")\n> > Signed-off-by: Arnd Bergmann \n> \n> Thanks Arnd! I was hoping to nuke this code before build bots catch up\n> to me, didn't work out :)\n\nyeah. Jakub's patches may not make it in time for net-next closing.\nso let's use this fix for now.\n\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T1E7UD9o\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySYyK1Gg1z9s81\n\tfor ;\n\tFri, 3 Nov 2017 05:48:41 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934160AbdKBSsa (ORCPT );\n\tThu, 2 Nov 2017 14:48:30 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:55718 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932571AbdKBSs3 (ORCPT\n\t); Thu, 2 Nov 2017 14:48:29 -0400","by mail-pg0-f65.google.com with SMTP id 15so366326pgc.12;\n\tThu, 02 Nov 2017 11:48:28 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:f1a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tb6sm6128251pgc.2.2017.11.02.11.48.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 11:48:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=pILitIEfoyen437fAJc6mz1hU6M9xbTv/c8Re1/MUSI=;\n\tb=T1E7UD9orCTbMIgW6jaIW9qzE7wNGAMsEo6ws6XAJXhUJjA151xD6gZYrnLfSy6Fc/\n\t5PbuhyDUH+EayvpkwNTkBgTFdCZNrZOZ0AdlCTnT1h8Qjl9i5llXOviY6RYQA7IW3G80\n\t0pQw3HjmW0eKOtBqcBw/HknDE+mUQlSAhpZ091jcWAeFfXs7lV574WRMiYVlMZI8cZRX\n\tpZO6KKlutiVSqHsnMDRIzlVygSUjzZyKQ67aX2861zXp9fgdDIM8NERBkMHcOpgR0pDH\n\ty5mdoZshy455r5pARdAH0DXUfi+TZXZLAl6u9T/LdLBBaImZS1I9VGtsjvBiQt2zFF5J\n\tBIGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=pILitIEfoyen437fAJc6mz1hU6M9xbTv/c8Re1/MUSI=;\n\tb=NTSFNxkaKRA193t8g6KVbwr28QWT3UadmxSSKW1Fihdm7vhY0/7VC52ZpM5U9xQ319\n\tqYxC9TsFbiIynOSOWaiBwD/83DwYvpUNnQ5qzOG+eJw8dhynfYHWkZPxwEnVk9yhOGCl\n\tuwx+pLmBfDOVS8kacRIdJnZkcU3QHlJ2iaGlcP8pbLHIEMh10+z+BlbTknafharTa/He\n\tAR3D50XGrzmi2BqONyEmQsdI4lqmvccHPXc6gY5bGXE/kFjflTrD+/wAEdbw8jtaH74d\n\tCZ8XQv9wFMp8ZCze9s8N/5Ej0qaq87vQAd49/Qv6oMgiM9kLDxWHIQBZvSpaBB55dlRX\n\tUrDg==","X-Gm-Message-State":"AMCzsaWm8/nnrGiYYvzHg+JqCcahjM5MvQ1LUWK96ARUQj/NogSiCfd1\n\tSHjmbRXBg5VHQc0IGyCKH6M=","X-Google-Smtp-Source":"ABhQp+Rrw3bfp993E6Adp9MVbm0Uxc/mpCHgGw4jy6bgQEIt1Sjbh1y3aIA5GZiQLF2I6Vr+L7iIhA==","X-Received":"by 10.101.88.14 with SMTP id g14mr4656046pgr.412.1509648508508; \n\tThu, 02 Nov 2017 11:48:28 -0700 (PDT)","Date":"Thu, 2 Nov 2017 11:48:25 -0700","From":"Alexei Starovoitov ","To":"Jakub Kicinski ","Cc":"Arnd Bergmann , Alexei Starovoitov ,\n\tDaniel Borkmann ,\n\t\"David S. Miller\" ,\n\tEdward Cree ,\n\tJohn Fastabend ,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","Message-ID":"<20171102184824.b6mucc5ebt3okrqy@ast-mbp>","References":"<20171102110558.2746221-1-arnd@arndb.de>\n\t<20171102105530.1997dd91@cakuba.netronome.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171102105530.1997dd91@cakuba.netronome.com>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798321,"web_url":"http://patchwork.ozlabs.org/comment/1798321/","msgid":"<59FB9D06.5010400@iogearbox.net>","list_archive_url":null,"date":"2017-11-02T22:32:38","subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 11/02/2017 12:05 PM, Arnd Bergmann wrote:\n> I ran into this link error with the latest net-next plus linux-next\n> trees when networking is disabled:\n>\n> kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'\n> kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'\n>\n> It seems that the code was written to deal with varying contents of\n> the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops\n> and xdp_analyzer_ops are defined in the core networking code, so adding\n> a check for CONFIG_NET seems appropriate here, and I've verified this with\n> many randconfig builds\n>\n> Fixes: 4f9218aaf8a4 (\"bpf: move knowledge about post-translation offsets out of verifier\")\n> Signed-off-by: Arnd Bergmann \n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySfx661NMz9sNx\n\tfor ;\n\tFri, 3 Nov 2017 09:32:58 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934599AbdKBWcq (ORCPT );\n\tThu, 2 Nov 2017 18:32:46 -0400","from www62.your-server.de ([213.133.104.62]:38325 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932201AbdKBWcp (ORCPT\n\t); Thu, 2 Nov 2017 18:32:45 -0400","from [194.230.159.142] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1eAO2S-0002Rm-4L; Thu, 02 Nov 2017 23:32:40 +0100"],"Message-ID":"<59FB9D06.5010400@iogearbox.net>","Date":"Thu, 02 Nov 2017 23:32:38 +0100","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Arnd Bergmann , Alexei Starovoitov ","CC":"\"David S. Miller\" ,\n\tEdward Cree ,\n\tJohn Fastabend ,\n\tJakub Kicinski ,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","References":"<20171102110558.2746221-1-arnd@arndb.de>","In-Reply-To":"<20171102110558.2746221-1-arnd@arndb.de>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/24010/Thu Nov 2 13:07:00 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798402,"web_url":"http://patchwork.ozlabs.org/comment/1798402/","msgid":"<20171103.142041.432905243636214188.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-03T05:20:41","subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Thu, 2 Nov 2017 12:05:51 +0100\n\n> I ran into this link error with the latest net-next plus linux-next\n> trees when networking is disabled:\n> \n> kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'\n> kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'\n> \n> It seems that the code was written to deal with varying contents of\n> the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops\n> and xdp_analyzer_ops are defined in the core networking code, so adding\n> a check for CONFIG_NET seems appropriate here, and I've verified this with\n> many randconfig builds\n> \n> Fixes: 4f9218aaf8a4 (\"bpf: move knowledge about post-translation offsets out of verifier\")\n> Signed-off-by: Arnd Bergmann \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySr0D1sLrz9s8J\n\tfor ;\n\tFri, 3 Nov 2017 16:21:16 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754103AbdKCFUq (ORCPT );\n\tFri, 3 Nov 2017 01:20:46 -0400","from shards.monkeyblade.net ([184.105.139.130]:35174 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751057AbdKCFUp (ORCPT\n\t); Fri, 3 Nov 2017 01:20:45 -0400","from localhost (unknown [61.40.109.130])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 69ABB103F3991;\n\tThu, 2 Nov 2017 22:20:43 -0700 (PDT)"],"Date":"Fri, 03 Nov 2017 14:20:41 +0900 (KST)","Message-Id":"<20171103.142041.432905243636214188.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"ast@kernel.org, daniel@iogearbox.net, ecree@solarflare.com,\n\tjohn.fastabend@gmail.com, jakub.kicinski@netronome.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET","From":"David Miller ","In-Reply-To":"<20171102110558.2746221-1-arnd@arndb.de>","References":"<20171102110558.2746221-1-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 02 Nov 2017 22:20:45 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]