[{"id":1801225,"web_url":"http://patchwork.ozlabs.org/comment/1801225/","msgid":"<87tvy5m7s1.fsf@vitty.brq.redhat.com>","list_archive_url":null,"date":"2017-11-08T09:36:30","subject":"Re: [PATCH net-next v2 2/2] hv_netvsc: hide warnings about\n\tuninitialized/missing rndis device","submitter":{"id":65701,"url":"http://patchwork.ozlabs.org/api/people/65701/","name":"Vitaly Kuznetsov","email":"vkuznets@redhat.com"},"content":"Stephen Hemminger writes:\n\n> On Nov 2, 2017 19:35, \"Vitaly Kuznetsov\" wrote:\n>\n> Hyper-V hosts are known to send RNDIS messages even after we halt the\n> device in rndis_filter_halt_device(). Remove user visible messages\n> as they are not really useful.\n>\n> Signed-off-by: Vitaly Kuznetsov \n> ---\n> drivers/net/hyperv/rndis_filter.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c\n> index 0648eebda829..8b1242b8d8ef 100644\n> --- a/drivers/net/hyperv/rndis_filter.c\n> +++ b/drivers/net/hyperv/rndis_filter.c\n> @@ -407,13 +407,13 @@ int rndis_filter_receive(struct net_device *ndev,\n>\n> /* Make sure the rndis device state is initialized */\n> if (unlikely(!rndis_dev)) {\n> - netif_err(net_device_ctx, rx_err, ndev,\n> + netif_dbg(net_device_ctx, rx_err, ndev,\n> \"got rndis message but no rndis device!\\n\");\n> return NVSP_STAT_FAIL;\n> }\n>\n> if (unlikely(rndis_dev->state == RNDIS_DEV_UNINITIALIZED)) {\n> - netif_err(net_device_ctx, rx_err, ndev,\n> + netif_dbg(net_device_ctx, rx_err, ndev,\n> \"got rndis message uninitialized\\n\");\n> return NVSP_STAT_FAIL;\n> }\n> --\n> 2.13.6\n>\n> _______________________________________________\n> devel mailing list\n> devel@linuxdriverproject.org\n> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel\n>\n> This should never happen since host removal should be setting device\n> down which disables NAPI. If this is not working correctly, that needs\n> to be fixed (rather than silencing the message).\n\nThis happens in between we halt RNDIS device in\nrndis_filter_halt_device() and NAPI shutdown from netvsc_device_remove()\nwhile the window is still open.\n\n>\n> Don't shoot the messenger\n\nThese messages are of no use for a random user: you change MTU on your\ndevice and see 'got rndis message uninitialized' - what are you supposed\nto do? I leave them at debugging level for us to actually debug.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=vkuznets@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yX1Qs5LLFz9s7c\n\tfor ;\n\tWed, 8 Nov 2017 20:36:53 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751489AbdKHJgg (ORCPT );\n\tWed, 8 Nov 2017 04:36:36 -0500","from mx1.redhat.com ([209.132.183.28]:40052 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751470AbdKHJge (ORCPT );\n\tWed, 8 Nov 2017 04:36:34 -0500","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CF94349029;\n\tWed, 8 Nov 2017 09:36:33 +0000 (UTC)","from vitty.brq.redhat.com.redhat.com (unknown [10.43.2.155])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5370960634;\n\tWed, 8 Nov 2017 09:36:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CF94349029","From":"Vitaly Kuznetsov ","To":"Stephen Hemminger ","Cc":"netdev ,\n\tStephen Hemminger ,\n\tEric Dumazet ,\n\tHaiyang Zhang ,\n\tlinux-kernel@vger.kernel.org, devel@linuxdriverproject.org","Subject":"Re: [PATCH net-next v2 2/2] hv_netvsc: hide warnings about\n\tuninitialized/missing rndis device","References":"<20171102103531.5514-1-vkuznets@redhat.com>\n\t<20171102103531.5514-3-vkuznets@redhat.com>\n\t\n\t\n\t","Date":"Wed, 08 Nov 2017 10:36:30 +0100","In-Reply-To":"\n\t(Stephen Hemminger's message of \"Wed, 8 Nov 2017 07:17:18 +0100\")","Message-ID":"<87tvy5m7s1.fsf@vitty.brq.redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 08 Nov 2017 09:36:34 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]