[{"id":1797807,"web_url":"http://patchwork.ozlabs.org/comment/1797807/","msgid":"","list_archive_url":null,"date":"2017-11-02T10:53:55","subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 11/02/2017 11:26 AM, Jiang Biao wrote:\n> Make some functions inline.\n\nWhy?\n\nDo you have evidence that the compiler isn't making reasonable default choices\nwith respect to inlining?\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ny6TQkF4\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySMRM1HG2z9t30\n\tfor ;\n\tThu, 2 Nov 2017 21:54:38 +1100 (AEDT)","from localhost ([::1]:59597 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eAD8s-0003Qh-BQ\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Nov 2017 06:54:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57593)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eAD8N-0003QI-Of\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 06:54:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eAD8K-0000XI-OK\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 06:54:03 -0400","from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:50345)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1eAD8K-0000Wo-HF\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 06:54:00 -0400","by mail-wm0-x22d.google.com with SMTP id s66so10052044wmf.5\n\tfor ; Thu, 02 Nov 2017 03:54:00 -0700 (PDT)","from cloudburst.twiddle.net (p57A4515F.dip0.t-ipconnect.de.\n\t[87.164.81.95]) by smtp.googlemail.com with ESMTPSA id\n\th56sm4258429ede.15.2017.11.02.03.53.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 03:53:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=jzirhAzmtbvVMopljWuM2GG8XjZT4r9zJigIY7vJDz0=;\n\tb=Ny6TQkF4+0o8hsm6MgvgRclA2pwSkGdkTyee2rcoPzijPXboiZTps0t0BabcF+kLaJ\n\tL/Ydc8mSXh0xkb659tB4zuGrMCJUEOw33T7pFKjCL3UgydIoE3ue8szsDurQyQAIulhq\n\ti2Le0VBp4t+svXnBxK5ph8aPR392VJZ2c8NcrkVQ58ZtJP+V2QPlMGntYXPBqXhtDbEW\n\tKGmBZ0TzlS1gn4AHvu649MW49WPbPwXBTFk9S+srVXVYtY/GWYNzVh6fdx8xLiXXkElu\n\tXdcFcJ+D7KC9SaKWleY4LETFDDEP245we46xHwafy0yR7ZZ7H0olJ5xy4XaC+GPfnWPt\n\twHsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=jzirhAzmtbvVMopljWuM2GG8XjZT4r9zJigIY7vJDz0=;\n\tb=nrwToMw8KZfZgAxDA4i3DSKgdgHFJ9mHI5T1hoAXT5hnP9Y3NeMmxhbQERBTRpoze/\n\tXmi3di5j6zLVVQV+v36805LagwafhIL7DZF9CagaIzRQQuu6tFj10ox9JHUFMUcVLwNp\n\tfnrL6PfeEqIgEt4j7MPYTBWBtgcdhnE8FUyag6X6Km/gbwDKue0XSqb9jARO0HdskbTb\n\tcpHxDj3wHwXV1hyWtaIRip42YU0UTeq5VGk4QI3vRPOTkSkUXeJx9estxkXJWIAgGYPl\n\tqLRZc9qf9Hz4g9SeMH81bzErb6TDPvmY5knSt/RPOsRl2ZOtDubLzK1uUAdm9a0YvEbB\n\t49ig==","X-Gm-Message-State":"AMCzsaXYo48M1O6+8VlbWTo+aSOG1BX5HHLW3+GMeXPmDadeUBa8N+IK\n\tWiTMjMXqX3wYyq6ovyiR13A=","X-Google-Smtp-Source":"ABhQp+TggqCc0Ncm/xJiRAhzw2hA7DaCVr7H1ENYFgryaETiuS2PSvFZ0WTdgzSwhNlxU26uvyzV+w==","X-Received":"by 10.80.166.3 with SMTP id d3mr3904623edc.96.1509620039047;\n\tThu, 02 Nov 2017 03:53:59 -0700 (PDT)","To":"Jiang Biao , aurelien@aurel32.net","References":"<1509618375-164238-1-git-send-email-jiang.biao2@zte.com.cn>","From":"Richard Henderson ","Message-ID":"","Date":"Thu, 2 Nov 2017 11:53:55 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1509618375-164238-1-git-send-email-jiang.biao2@zte.com.cn>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22d","Subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"zhong.weidong@zte.com.cn, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1797823,"web_url":"http://patchwork.ozlabs.org/comment/1797823/","msgid":"<201711021923504024201@zte.com.cn>","list_archive_url":null,"date":"2017-11-02T11:23:50","subject":"Re: [Qemu-devel] =?utf-8?q?=5BPATCH=5D_tcg/mips=3A_make_some_fun?=\n\t=?utf-8?q?ctions_inline=2E?=","submitter":{"id":47769,"url":"http://patchwork.ozlabs.org/api/people/47769/","name":"Jiang Biao","email":"jiang.biao2@zte.com.cn"},"content":"PiBPbiAxMS8wMi8yMDE3IDExOjI2IEFNLCBKaWFuZyBCaWFvIHdyb3RlOj4gPiBNYWtlIHNvbWUg\nZnVuY3Rpb25zIGlubGluZS4KPiAKPiBXaHk/Cj4gCj4gRG8geW91IGhhdmUgZXZpZGVuY2UgdGhh\ndCB0aGUgY29tcGlsZXIgaXNuJ3QgbWFraW5nIHJlYXNvbmFibGUgZGVmYXVsdCBjaG9pY2VzCj4g\nd2l0aCByZXNwZWN0IHRvIGlubGluaW5nPwpObywgOikgSnVzdCBmb3VuZCBzb21lIG9mIHRoZXNl\nIGZ1bmN0aW9ucyBhcmUgaW5saW5lIGFuZCBvdGhlcnMgYXJlIG5vdCB3aGVuIHJlYWRpbmcgCnRo\nZSBjb2RlLCB0aGUgc3R5bGUgbG9va3MgaW5jb25zaXN0ZW50LiAKQmVzaWRlcywgVGhlIGNvbXBp\nbGVyIG1heSBtYWtlIGRlZmF1bHQgaW5saW5lIGNob2ljZXMgZm9yIHNvbWUgZnVuY3Rpb25zLCBi\ndXQgbWF5IApub3QgZm9yIHNvbWUgY2FzZXMoc29tZSBsb25nZXIgb25lcykuIEFkZGluZyBpbmxp\nbmUgbWFudWFsbHkgY2FuIGd1YXJhbnRlZSBhbmQgCm5vdCBodXJ0LiA6KQpUaGFua3MuCgpyfg==","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySN6Y63H2z9t2l\n\tfor ;\n\tThu, 2 Nov 2017 22:25:08 +1100 (AEDT)","from localhost ([::1]:59697 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eADcQ-0002kS-1n\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Nov 2017 07:25:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40338)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eADbu-0002kM-Og\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:24:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eADbp-0001ZJ-Qc\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:24:34 -0400","from mxhk.zte.com.cn ([63.217.80.70]:53940)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1eADbp-0001YQ-Eu\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:24:29 -0400","from mse02.zte.com.cn (unknown [10.30.3.21])\n\tby Forcepoint Email with ESMTPS id A9328CCACC4BA98EB7C5;\n\tThu, 2 Nov 2017 19:23:55 +0800 (CST)","from kjyxapp04.zte.com.cn ([10.30.12.203])\n\tby mse02.zte.com.cn with SMTP id vA2BNlES090327;\n\tThu, 2 Nov 2017 19:23:47 +0800 (GMT-8)\n\t(envelope-from jiang.biao2@zte.com.cn)","from mapi (kjyxapp01[null]) by mapi (Zmail) with MAPI id mid14;\n\tThu, 2 Nov 2017 19:23:50 +0800 (CST)"],"Date":"Thu, 2 Nov 2017 19:23:50 +0800 (CST)","X-Zmail-TransId":"2b0359fb004620f-599db","X-Mailer":"Zmail v1.0","Message-ID":"<201711021923504024201@zte.com.cn>","In-Reply-To":"","References":"1509618375-164238-1-git-send-email-jiang.biao2@zte.com.cn,\n\tf4e7a6b9-7cdc-b986-2edb-c361622a23a7@twiddle.net","Mime-Version":"1.0","From":"","To":"","X-MAIL":"mse02.zte.com.cn vA2BNlES090327","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"63.217.80.70","Content-Type":"text/plain;\n\tcharset=\"UTF-8\"","Content-Transfer-Encoding":"base64 ","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] =?utf-8?q?=5BPATCH=5D_tcg/mips=3A_make_some_fun?=\n\t=?utf-8?q?ctions_inline=2E?=","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"zhong.weidong@zte.com.cn, qemu-devel@nongnu.org, aurelien@aurel32.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1797836,"web_url":"http://patchwork.ozlabs.org/comment/1797836/","msgid":"<1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net>","list_archive_url":null,"date":"2017-11-02T11:43:16","subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 11/02/2017 12:23 PM, jiang.biao2@zte.com.cn wrote:\n> No, :) Just found some of these functions are inline and others are not when reading \n> the code, the style looks inconsistent. \n\nMy preference would be to remove them all.\n\n> Besides, The compiler may make default inline choices for some functions, but may \n> not for some cases(some longer ones). Adding inline manually can guarantee and \n> not hurt. :)\n\nThe longer ones in particular should *not* be inline, so that we don't expand\nthe size of the code unnecessarily. Which *can* hurt.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qGp7tqKE\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySNXB1Xszz9t2V\n\tfor ;\n\tThu, 2 Nov 2017 22:43:53 +1100 (AEDT)","from localhost ([::1]:59758 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eADuS-0000rX-95\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Nov 2017 07:43:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48138)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eADu9-0000r9-6X\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:43:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eADu5-0003QL-8n\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:43:25 -0400","from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:51942)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1eADu5-0003Oq-2I\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 07:43:21 -0400","by mail-wm0-x236.google.com with SMTP id b9so10763759wmh.0\n\tfor ; Thu, 02 Nov 2017 04:43:20 -0700 (PDT)","from cloudburst.twiddle.net (p5DCBCAA6.dip0.t-ipconnect.de.\n\t[93.203.202.166]) by smtp.googlemail.com with ESMTPSA id\n\th51sm2776556eda.56.2017.11.02.04.43.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 04:43:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DxLOD3sBW6zIQYmFEewhn8hvlbvFdTzamDG1AjVOvQc=;\n\tb=qGp7tqKEASRzIxyn7Erz68wZE/Ih5uHue48F1UKJ7ROD8vZmQVp1zFKlPZVoNqzZzL\n\tqc4l8TPhRD5AeEwvvkT5y5cQOW8D9cADbFLNXHzG+fi698QcqhkqhKCCclrSwl1ADmKc\n\tmNMo/Ue7yHeymfesx0G9f1PgLTjz0QAMHhzJZ8SF1bJHcLCJKAK/KWTV1oxBihC3MWAo\n\tYuh+cdhAaPz3icPJrCoL5Qf2/qwhbLTYOEMv2iTCsksWjmXNDNbRuhZFLitPNqXuTAAJ\n\tuffgz/uC/Kdlp/LatQAsxElVD1+LD45Be+r6MgcW0+nUdTXJ09cNuxH5MucPQIXzMnVW\n\tUUpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DxLOD3sBW6zIQYmFEewhn8hvlbvFdTzamDG1AjVOvQc=;\n\tb=V8vZ+SuP0ojjMg39YC+aiCr7B7sc/QG9oLXhQF2t55wsQ4/Y77e4vJTfDhT8XP1lrA\n\tmkt8hfAhbYcFgmepOtR1T2ZFRSZtc2GDjNHmbQnm5O1jRYukTqWLlu35dKF7DSUYEv9j\n\t2oq3OdQmT7UbAJY82ZodmXMYGXucKdl3S3plKoemASzFxCvdXQmQPn19X5FfDgPJAfrL\n\tLFz0beCqBUd6GpEoN5ZXNzf5kdRBQLeK8NB0ZpvQWWb7G/Z/Kcg65xsHvKZWoCuSjq7i\n\tNqZSoZdUWM4yCbxlQnqsvcywaWCxMyghvQCLsPiJgDZUX0o0QgNbC+hxNhP5VFK1rFdC\n\t4lew==","X-Gm-Message-State":"AMCzsaVPszJ8qQsrtUo5Z4M8DECL6mggu686+5YByww2ht0ZliI0eatu\n\tCaqHQkzzQ4No2or49gfESrQ=","X-Google-Smtp-Source":"ABhQp+Rk+saA1DpQkLk6CSpekxNbCKIJpuE0bxTJdgpN/JnImW/xMmwuRnjPDKd6CRNmlz5OEI7+YQ==","X-Received":"by 10.80.136.49 with SMTP id b46mr4150886edb.238.1509622999808; \n\tThu, 02 Nov 2017 04:43:19 -0700 (PDT)","To":"jiang.biao2@zte.com.cn","References":"<201711021923504024201@zte.com.cn>","From":"Richard Henderson ","Message-ID":"<1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net>","Date":"Thu, 2 Nov 2017 12:43:16 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<201711021923504024201@zte.com.cn>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::236","Subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"zhong.weidong@zte.com.cn, qemu-devel@nongnu.org, aurelien@aurel32.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1797866,"web_url":"http://patchwork.ozlabs.org/comment/1797866/","msgid":"","list_archive_url":null,"date":"2017-11-02T12:16:26","subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","submitter":{"id":71119,"url":"http://patchwork.ozlabs.org/api/people/71119/","name":"Philippe Mathieu-Daudé via","email":"philippe@mathieu-daude.net"},"content":"On Thu, Nov 2, 2017 at 8:43 AM, Richard Henderson wrote:\n> On 11/02/2017 12:23 PM, jiang.biao2@zte.com.cn wrote:\n>> No, :) Just found some of these functions are inline and others are not when reading\n>> the code, the style looks inconsistent.\n>\n> My preference would be to remove them all.\n\nIf more people agree to this we should add an entry in HACKING coding\nguidelines (not sure about checkpatch).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a6QihrRf\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySPGG0L83z9sRW\n\tfor ;\n\tThu, 2 Nov 2017 23:16:52 +1100 (AEDT)","from localhost ([::1]:60122 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eAEQU-0003FF-Dt\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Nov 2017 08:16:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33537)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1eAEQ8-0003Ez-II\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:16:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1eAEQ7-0007sQ-Jz\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:16:28 -0400","from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]:45334)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eAEQ7-0007rj-FP\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:16:27 -0400","by mail-io0-x241.google.com with SMTP id i38so13466699iod.2\n\tfor ; Thu, 02 Nov 2017 05:16:27 -0700 (PDT)","by 10.2.151.211 with HTTP; Thu, 2 Nov 2017 05:16:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=uPGGreR37c3KHx2kR6f0xzPtoSaUX3Z7brGv4nAhnzI=;\n\tb=a6QihrRfCUlUPjEmqNFCwBFcW8cTdQa/qrZX2vrl67BCxp7sH8Y5ULY3ziWb6XlLoe\n\td7Cl/93l3RZ/CSYS6j25QbQ6NYs5KE8SUMIJpGXgvr86CIc6B69JhK4PqdQ3noQM8FBt\n\tEG3YG7zlGJtW5/E9XGx5DZgPN3ukWHxyz0+WvLceV8GU2S56OBpht433iewgsGLIf4po\n\tz5hY4VFmxcRfAffso9DHspMfwL036N2HjrudJkT9QBlNVf8CqsQ8sYEO1qvyIIDJkoQQ\n\taod45wSPY279+zVpUb5SA4kJ5BUKd09d9MEHFji6+FbsedYDEQ//nnYZ0czgb1MMo25l\n\tC1nQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=uPGGreR37c3KHx2kR6f0xzPtoSaUX3Z7brGv4nAhnzI=;\n\tb=QX8BbzRCIBs2IyainTQiTZhQlT9Pwr3sr0wIwWUcmH8rYbT1sDzyrQxDhtGfxfXqm7\n\tKaLlNiLLnI64o1nszomiA8ARJEEd4AnLfuZcCCPW1ZF1k/xrabFjY+YrmxZwHxCRw0e9\n\tTpCipEMazUpKF9D6T5f0IUYgAgx1K38U9ikpIoo2u8pxv6oJVRFJOaO68zJgY8gI9HEX\n\tD4M/6SncKdobh2ouN3zSkebDeIjxK54wIJB46aarhCMf0fZtGyS77hPNg2vBUyjWYsl6\n\t67kBmjXfgVb4qeWNAJmDZHAtJxdlLczQOfDqI3Nz9BIMJ5h4eClcT5DEO/M3onXXqgbP\n\tGohA==","X-Gm-Message-State":"AMCzsaX4uA7AGgGwXsd/vGL97Xk6EOQcNEj1K91MtFZOM5oKQvKEx6ya\n\t5OJ5qCkb4pfczn7flRH5W0FblKYJIGp5py1Fg8I=","X-Google-Smtp-Source":"ABhQp+SzgPKImV+TRmsQWjQ+LT7KuTV0mpwmOi+dDKdevckOIqo1qCJc/qQtPBpnGtDMPIeBZOnmA/CtApTpN9VdXKk=","X-Received":"by 10.107.173.160 with SMTP id m32mr4246656ioo.200.1509624986871;\n\tThu, 02 Nov 2017 05:16:26 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net>","References":"<201711021923504024201@zte.com.cn>\n\t<1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Date":"Thu, 2 Nov 2017 09:16:26 -0300","X-Google-Sender-Auth":"fLf65P39WEiryarshokQFPwoHI0","Message-ID":"","To":"Richard Henderson , Eric Blake ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::241","Subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jiang Biao , zhong.weidong@zte.com.cn,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1798346,"web_url":"http://patchwork.ozlabs.org/comment/1798346/","msgid":"<201711030837145949795@zte.com.cn>","list_archive_url":null,"date":"2017-11-03T00:37:14","subject":"Re: [Qemu-devel] =?utf-8?q?=5BPATCH=5D_tcg/mips=3A_make_some_fun?=\n\t=?utf-8?q?ctions_inline=2E?=","submitter":{"id":47769,"url":"http://patchwork.ozlabs.org/api/people/47769/","name":"Jiang Biao","email":"jiang.biao2@zte.com.cn"},"content":"PiBPbiAxMS8wMi8yMDE3IDEyOjIzIFBNLCBqaWFuZy5iaWFvMkB6dGUuY29tLmNuIHdyb3RlOgo+\nID4gTm8sIDopIEp1c3QgZm91bmQgc29tZSBvZiB0aGVzZSBmdW5jdGlvbnMgYXJlIGlubGluZSBh\nbmQgb3RoZXJzIGFyZSBub3Qgd2hlbiByZWFkaW5nCj4gPiB0aGUgY29kZSwgdGhlIHN0eWxlIGxv\nb2tzIGluY29uc2lzdGVudC4KPiA+Cj4gTXkgcHJlZmVyZW5jZSB3b3VsZCBiZSB0byByZW1vdmUg\ndGhlbSBhbGwuClNob3VsZCBJIGNvbW1pdCBhbm90aGVyIHBhdGNoIHRvIGRvIHRoYXQ/IDopIAoK\nPiA+IEJlc2lkZXMsIFRoZSBjb21waWxlciBtYXkgbWFrZSBkZWZhdWx0IGlubGluZSBjaG9pY2Vz\nIGZvciBzb21lIGZ1bmN0aW9ucywgYnV0IG1heQo+ID4gbm90IGZvciBzb21lIGNhc2VzKHNvbWUg\nbG9uZ2VyIG9uZXMpLiBBZGRpbmcgaW5saW5lIG1hbnVhbGx5IGNhbiBndWFyYW50ZWUgYW5kCj4g\nPiBub3QgaHVydC4gOikKPiBUaGUgbG9uZ2VyIG9uZXMgaW4gcGFydGljdWxhciBzaG91bGQgKm5v\ndCogYmUgaW5saW5lLCBzbyB0aGF0IHdlIGRvbid0IGV4cGFuZAo+IHRoZSBzaXplIG9mIHRoZSBj\nb2RlIHVubmVjZXNzYXJpbHkuICBXaGljaCAqY2FuKiBodXJ0LgpHb3QgdGhhdCwgdGhhbmtzIGZv\nciB0aGUgcmVwbHkuCgpSZWdhcmRzLA==","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySjjM03NMz9sPs\n\tfor ;\n\tFri, 3 Nov 2017 11:37:59 +1100 (AEDT)","from localhost ([::1]:34362 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eAPzh-00054W-3Y\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Nov 2017 20:37:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58550)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eAPzI-00054D-OK\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:37:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eAPzF-0003PA-Ln\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:37:32 -0400","from out1.zte.com.cn ([202.103.147.172]:39218 helo=mxct.zte.com.cn)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1eAPzF-0003Oc-Ad\n\tfor qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:37:29 -0400","from mse01.zte.com.cn (unknown [10.30.3.20])\n\tby Forcepoint Email with ESMTPS id 183FF8C0B59F1BAB0DE9;\n\tFri, 3 Nov 2017 08:37:25 +0800 (CST)","from kjyxapp03.zte.com.cn ([10.30.12.202])\n\tby mse01.zte.com.cn with SMTP id vA30bEdv076586;\n\tFri, 3 Nov 2017 08:37:14 +0800 (GMT-8)\n\t(envelope-from jiang.biao2@zte.com.cn)","from mapi (kjyxapp04[null]) by mapi (Zmail) with MAPI id mid14;\n\tFri, 3 Nov 2017 08:37:14 +0800 (CST)"],"Date":"Fri, 3 Nov 2017 08:37:14 +0800 (CST)","X-Zmail-TransId":"2b0659fbba3a724-7add0","X-Mailer":"Zmail v1.0","Message-ID":"<201711030837145949795@zte.com.cn>","In-Reply-To":"<1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net>","References":"201711021923504024201@zte.com.cn,\n\t1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net","Mime-Version":"1.0","From":"","To":"","X-MAIL":"mse01.zte.com.cn vA30bEdv076586","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"202.103.147.172","Content-Type":"text/plain;\n\tcharset=\"UTF-8\"","Content-Transfer-Encoding":"base64 ","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] =?utf-8?q?=5BPATCH=5D_tcg/mips=3A_make_some_fun?=\n\t=?utf-8?q?ctions_inline=2E?=","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"zhong.weidong@zte.com.cn, qemu-devel@nongnu.org, aurelien@aurel32.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1798462,"web_url":"http://patchwork.ozlabs.org/comment/1798462/","msgid":"<811e6387-83c3-0d30-89a0-22c6cc847178@twiddle.net>","list_archive_url":null,"date":"2017-11-03T08:42:01","subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 11/03/2017 01:37 AM, jiang.biao2@zte.com.cn wrote:\n>> On 11/02/2017 12:23 PM, jiang.biao2@zte.com.cn wrote:\n>>> No, :) Just found some of these functions are inline and others are not when reading\n>>> the code, the style looks inconsistent.\n>>>\n>> My preference would be to remove them all.\n> Should I commit another patch to do that? :) \n\nIf you find the inconsistency distracting, yes.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"b5m8sYhY\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySwW85VDKz9sBW\n\tfor ;\n\tFri, 3 Nov 2017 19:44:52 +1100 (AEDT)","from localhost ([::1]:35432 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eAXas-0004ak-Ty\n\tfor incoming@patchwork.ozlabs.org; Fri, 03 Nov 2017 04:44:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48750)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eAXYJ-000347-Pw\n\tfor qemu-devel@nongnu.org; Fri, 03 Nov 2017 04:42:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eAXYE-0003G8-TZ\n\tfor qemu-devel@nongnu.org; Fri, 03 Nov 2017 04:42:11 -0400","from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:51984)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1eAXYE-0003EY-Ms\n\tfor qemu-devel@nongnu.org; Fri, 03 Nov 2017 04:42:06 -0400","by mail-wm0-x241.google.com with SMTP id b9so3537377wmh.0\n\tfor ; Fri, 03 Nov 2017 01:42:06 -0700 (PDT)","from cloudburst.twiddle.net (p57A4515F.dip0.t-ipconnect.de.\n\t[87.164.81.95]) by smtp.googlemail.com with ESMTPSA id\n\tm8sm5028605edl.74.2017.11.03.01.42.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 03 Nov 2017 01:42:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=RSeA9Gp9cLhQm4RGaB5roKldKprV7cpFBNRaSdhgzf0=;\n\tb=b5m8sYhYgwsxgSJF9Sgi1fsqnR3zrxRsdGWMtpCaJf7cQcIEbXJFaZ2MjOEa9U31Ks\n\tivFrVaox+lRlSsiEEWzr31C60/qbEOVPz1YByM5zB/F+2jyAbYJ4CRhKwcPvAP6pXiQw\n\tbf1wje8IMPAvTkE72El24uPcen83l7qAuz4VbdeOwEVtP06G9ahwDQwK/FpAbt51ahvd\n\t4FxWvyS/aoMSc+fe/RNt/lTalVna48lVZO9OFyJtyQZ2juzqH1xOZTceUQ0aEeXhPS8C\n\tvNK7e36sVro1Wq/r1Gz1LZ/qaD8sE6uWcazaQLN2hBvD29uI+ziYFhH6UE2S6hNSfU+e\n\tq6mA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=RSeA9Gp9cLhQm4RGaB5roKldKprV7cpFBNRaSdhgzf0=;\n\tb=EkRK/BpNACKVCGI39JzvorLRT6oJkJYz0VILEUqGnQhgyFCOkIVBjG8huJGJ069uKa\n\tYWW0iMKpc3MJeNc5m8mKD5xCDZLPPSuJkt2OqzrXhh82SAFDS3g+7USBqkzvWBohuQQ9\n\tVkxPNQR4OgLIg2uKLsHmNU9y/+2Y3X0KYuBgSVn9NHwbzTsf1f1ZsjUBkQeguBpAABm8\n\toah+AajrJZTHIraeaAdeF+QoPCL2KQXoo5cu5dLLnK7nPgatW57o4fMOKxZjM6wks5RA\n\tCN+jAub9uBhw/sb6dZNCcHo9wbThBegEgt4dBmuUscsKNs7a0xKrhqCJB/48rGZpBy9s\n\tdU8g==","X-Gm-Message-State":"AMCzsaXlacuAoNBeX5LN+G1aIK/jJVMsERJ3KjLBitmy5G9zz4FcgiJB\n\tUaN3jYznoHui6o2pKOBCHBaGGSzZ","X-Google-Smtp-Source":"ABhQp+SFFoZ5IBbclnOloSbDgaIiATbi7jyzO956rtnq3EfrphunyPP7AsTlYI/0QbOVwpqXdRafTg==","X-Received":"by 10.80.192.27 with SMTP id r27mr7967209edb.138.1509698525568; \n\tFri, 03 Nov 2017 01:42:05 -0700 (PDT)","To":"jiang.biao2@zte.com.cn","References":"<201711030837145949795@zte.com.cn>","From":"Richard Henderson ","Message-ID":"<811e6387-83c3-0d30-89a0-22c6cc847178@twiddle.net>","Date":"Fri, 3 Nov 2017 09:42:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<201711030837145949795@zte.com.cn>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::241","Subject":"Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"zhong.weidong@zte.com.cn, qemu-devel@nongnu.org, aurelien@aurel32.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]