[{"id":1800539,"web_url":"http://patchwork.ozlabs.org/comment/1800539/","msgid":"<20171107150143.182ce22f.cohuck@redhat.com>","list_archive_url":null,"date":"2017-11-07T14:01:43","subject":"Re: [Qemu-devel] [PATCH v3 1/2] qdev_monitor: Simplify error\n\thandling in qdev_device_add()","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 2 Nov 2017 11:10:05 +0100\nThomas Huth wrote:\n\n> Instead of doing the clean-ups on errors multiple times, introduce\n> a jump label at the end of the function that can be used by all\n> error paths that need this cleanup.\n> \n> Suggested-by: Igor Mammedov \n> Signed-off-by: Thomas Huth \n> ---\n> qdev-monitor.c | 16 ++++++++--------\n> 1 file changed, 8 insertions(+), 8 deletions(-)\n\nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yWWMm5T6Nz9ryT\n\tfor ;\n\tWed, 8 Nov 2017 01:02:27 +1100 (AEDT)","from localhost ([::1]:53607 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eC4SO-0000KF-Ps\n\tfor incoming@patchwork.ozlabs.org; Tue, 07 Nov 2017 09:02:24 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:45208)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eC4Rx-0000Ic-Sa\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 09:02:03 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eC4Ru-0004Fs-0M\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 09:01:57 -0500","from mx1.redhat.com ([209.132.183.28]:45964)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eC4Rt-0004Fj-Qe\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 09:01:53 -0500","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B7D4E4E4C5\n\tfor ; Tue, 7 Nov 2017 14:01:52 +0000 (UTC)","from gondolin (ovpn-117-156.ams2.redhat.com [10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 12FF55D756;\n\tTue, 7 Nov 2017 14:01:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B7D4E4E4C5","Date":"Tue, 7 Nov 2017 15:01:43 +0100","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20171107150143.182ce22f.cohuck@redhat.com>","In-Reply-To":"<1509617407-21191-2-git-send-email-thuth@redhat.com>","References":"<1509617407-21191-1-git-send-email-thuth@redhat.com>\n\t<1509617407-21191-2-git-send-email-thuth@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 07 Nov 2017 14:01:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/2] qdev_monitor: Simplify error\n\thandling in qdev_device_add()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Habkost , david@redhat.com,\n\tMarkus Armbruster , qemu-devel@nongnu.org,\n\tPaolo Bonzini ,\n\tIgor Mammedov , \n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]