[{"id":1797902,"web_url":"http://patchwork.ozlabs.org/comment/1797902/","msgid":"<20171102125305.GI4772@lunn.ch>","list_archive_url":null,"date":"2017-11-02T12:53:05","subject":"Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Nov 02, 2017 at 10:36:48AM +0100, Egil Hjelmeland wrote:\n> Why:\n\nPlease drop the Why.\n\n> The lan9303 driver defines eth_stp_addr as a synonym to\n> eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.\n> \n> eth_reserved_addr_base is also used to define the start of Bridge Reserved\n> ethernet address range, which happen to be the STP address.\n> \n> br_dev_setup refer to eth_reserved_addr_base as a definition of STP\n> address.\n> \n> Clean up by:\n> - Move the eth_stp_addr definition to linux/etherdevice.h\n> - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.\n> \n> Signed-off-by: Egil Hjelmeland \n\nI was thinking along the same lines when reviewing your lan9303 patch.\n\nReviewed-by: Andrew Lunn \n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySQ4n2yGzz9t2l\n\tfor ;\n\tThu, 2 Nov 2017 23:53:45 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754143AbdKBMxV (ORCPT );\n\tThu, 2 Nov 2017 08:53:21 -0400","from vps0.lunn.ch ([185.16.172.187]:38991 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751898AbdKBMxU (ORCPT );\n\tThu, 2 Nov 2017 08:53:20 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1eAEzZ-00074f-UB; Thu, 02 Nov 2017 13:53:05 +0100"],"Date":"Thu, 2 Nov 2017 13:53:05 +0100","From":"Andrew Lunn ","To":"Egil Hjelmeland ","Cc":"vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\trafal@milecki.pl, stephen@networkplumber.org,\n\tbridge@lists.linux-foundation.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h","Message-ID":"<20171102125305.GI4772@lunn.ch>","References":"<20171102093648.4141-1-privat@egil-hjelmeland.no>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171102093648.4141-1-privat@egil-hjelmeland.no>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1798400,"web_url":"http://patchwork.ozlabs.org/comment/1798400/","msgid":"<20171103.141839.1785916247470411683.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-03T05:18:39","subject":"Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Egil Hjelmeland \nDate: Thu, 2 Nov 2017 10:36:48 +0100\n\n> The lan9303 driver defines eth_stp_addr as a synonym to\n> eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.\n> \n> eth_reserved_addr_base is also used to define the start of Bridge Reserved\n> ethernet address range, which happen to be the STP address.\n> \n> br_dev_setup refer to eth_reserved_addr_base as a definition of STP\n> address.\n> \n> Clean up by:\n> - Move the eth_stp_addr definition to linux/etherdevice.h\n> - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.\n> \n> Signed-off-by: Egil Hjelmeland \n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySqxf1fjRz9s8J\n\tfor ;\n\tFri, 3 Nov 2017 16:19:02 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754284AbdKCFSq (ORCPT );\n\tFri, 3 Nov 2017 01:18:46 -0400","from shards.monkeyblade.net ([184.105.139.130]:35130 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752354AbdKCFSp (ORCPT\n\t); Fri, 3 Nov 2017 01:18:45 -0400","from localhost (unknown [61.40.109.130])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 0724C103F398A;\n\tThu, 2 Nov 2017 22:18:40 -0700 (PDT)"],"Date":"Fri, 03 Nov 2017 14:18:39 +0900 (KST)","Message-Id":"<20171103.141839.1785916247470411683.davem@davemloft.net>","To":"privat@egil-hjelmeland.no","Cc":"andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tf.fainelli@gmail.com, rafal@milecki.pl, stephen@networkplumber.org,\n\tbridge@lists.linux-foundation.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h","From":"David Miller ","In-Reply-To":"<20171102093648.4141-1-privat@egil-hjelmeland.no>","References":"<20171102093648.4141-1-privat@egil-hjelmeland.no>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 02 Nov 2017 22:18:45 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]