[{"id":1797936,"web_url":"http://patchwork.ozlabs.org/comment/1797936/","msgid":"<87o9okvkcd.fsf@suse.com>","list_archive_url":null,"date":"2017-11-02T14:14:26","subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","submitter":{"id":72538,"url":"http://patchwork.ozlabs.org/api/people/72538/","name":"Aurélien Aptel","email":"aaptel@suse.com"},"content":"Ronnie Sahlberg <lsahlber@redhat.com> writes:\n> +\n> +\tnew_iov = kmalloc(sizeof(struct kvec) * (n_vec + 1), GFP_KERNEL);\n> +\tif (!new_iov)\n> +\t\treturn -ENOMEM;\n> +\n> +\t/* 1st iov is an RFC1002 Session Message length */\n> +\tmemcpy(new_iov + 1, iov, (sizeof(struct kvec) * n_vec));\n> +\n> +\tcount = 0;\n> +\tfor (i = 1; i < n_vec + 1; i++)\n> +\t\tcount += new_iov[i].iov_len;\n> +\n> +\trfc1002_marker = cpu_to_be32(count);\n> +\n> +\tnew_iov[0].iov_base = &rfc1002_marker;\n> +\tnew_iov[0].iov_len = 4;\n> +\n> +\tmemset(&rqst, 0, sizeof(struct smb_rqst));\n> +\trqst.rq_iov = new_iov;\n> +\trqst.rq_nvec = n_vec + 1;\n> +\n> +\trc = cifs_send_recv(xid, ses, &rqst, resp_buf_type, flags, resp_iov);\n> +\tkfree(new_iov);\n> +\treturn rc;\n> +}\n> +\n\nI know this is kind of unrelated but I've been thinking to myself we\nshould try to get rid of this dynamic allocation at some point.\n\nIIUC the iovec never has more than a couple of elements, so we could\nhave something like a fixed sized stack allocated iovec array +\nMAX_IOVEC_LENGTH macro.\n\nDoing a kmalloc() for every packet defeats the purpose of the memory\npool optimization we use for small/large buffers.","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySRt04jWbz9t2l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 01:14:32 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933440AbdKBOOb convert rfc822-to-8bit (ORCPT\n\t<rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 2 Nov 2017 10:14:31 -0400","from smtp.nue.novell.com ([195.135.221.5]:36431 \"EHLO\n\tsmtp.nue.novell.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933034AbdKBOOa (ORCPT\n\t<rfc822;groupwise-linux-cifs@vger.kernel.org:0:0>);\n\tThu, 2 Nov 2017 10:14:30 -0400","from localhost (charybdis-ext.suse.de [195.135.221.2])\n\tby smtp.nue.novell.com with ESMTP (TLS encrypted);\n\tThu, 02 Nov 2017 15:14:29 +0100"],"From":"=?utf-8?b?QXVyw6lsaWVu?= Aptel <aaptel@suse.com>","To":"Ronnie Sahlberg <lsahlber@redhat.com>,\n\tlinux-cifs <linux-cifs@vger.kernel.org>","Cc":"Steve French <smfrench@gmail.com>","Subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","In-Reply-To":"<20171102070312.18903-2-lsahlber@redhat.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<20171102070312.18903-2-lsahlber@redhat.com>","Date":"Thu, 02 Nov 2017 15:14:26 +0100","Message-ID":"<87o9okvkcd.fsf@suse.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8BIT","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1798422,"web_url":"http://patchwork.ozlabs.org/comment/1798422/","msgid":"<20171103062527.GA8075@infradead.org>","list_archive_url":null,"date":"2017-11-03T06:25:27","subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","submitter":{"id":178,"url":"http://patchwork.ozlabs.org/api/people/178/","name":"Christoph Hellwig","email":"hch@infradead.org"},"content":"On Thu, Nov 02, 2017 at 03:14:26PM +0100, Aurélien Aptel wrote:\n> I know this is kind of unrelated but I've been thinking to myself we\n> should try to get rid of this dynamic allocation at some point.\n> \n> IIUC the iovec never has more than a couple of elements, so we could\n> have something like a fixed sized stack allocated iovec array +\n> MAX_IOVEC_LENGTH macro.\n> \n> Doing a kmalloc() for every packet defeats the purpose of the memory\n> pool optimization we use for small/large buffers.\n\nYes.  You probably just want everyone to allocate an additional\nentry in the vector for the header if needed, and just leave the\nslot empty and start processing at offset for cases like SMB direct.\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"Id2Nie2O\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySsQM2MCMz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 17:25:31 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750826AbdKCGZa (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tFri, 3 Nov 2017 02:25:30 -0400","from bombadil.infradead.org ([65.50.211.133]:60834 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750821AbdKCGZ3 (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Fri, 3 Nov 2017 02:25:29 -0400","from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red\n\tHat Linux)) id 1eAVPz-0004Vr-LP; Fri, 03 Nov 2017 06:25:27 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=In-Reply-To:Content-Transfer-Encoding\n\t:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:\n\tSender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=1Ldtx5tctYmNd+tKq1m13sVqq+nHHvGzRNl4hMXigmQ=;\n\tb=Id2Nie2OwvAaImWlKpelZzLLDz\n\tWG1HiLD3clM9OOwY7v86WBuoZ6nRUIgXOP3KjhZHNPUT4QG1HGAfjqWln8awvV7zjV7n1AGBq6YlB\n\tXj3u9v8GY2norcIUdhzQJmLGekwUnL8llQqQlT4/SNdvhOloeXYOMuZGUfrQKGlJUwCkLeC4Tjqz8\n\tTWheYV7PFDre/nYmvSXonYP3OJQOHWmqEFPvEHmDjPWU/gmPyMg5C9zBWAVxMZC6YLm8zPH2fnWMP\n\tX0rcwK3xezTLIGqXne8KmIAxCvjIP0qK5pkVlEJbyquU+8eyjI0qGd1EiuONAH/TLWBCVCeDp1Twp\n\tU8SHspqQ==;","Date":"Thu, 2 Nov 2017 23:25:27 -0700","From":"Christoph Hellwig <hch@infradead.org>","To":"=?iso-8859-1?q?Aur=E9lien?= Aptel <aaptel@suse.com>","Cc":"Ronnie Sahlberg <lsahlber@redhat.com>,\n\tlinux-cifs <linux-cifs@vger.kernel.org>,\n\tSteve French <smfrench@gmail.com>","Subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","Message-ID":"<20171103062527.GA8075@infradead.org>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<20171102070312.18903-2-lsahlber@redhat.com>\n\t<87o9okvkcd.fsf@suse.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<87o9okvkcd.fsf@suse.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-SRS-Rewrite":"SMTP reverse-path rewritten from <hch@infradead.org> by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1798424,"web_url":"http://patchwork.ozlabs.org/comment/1798424/","msgid":"<20171103062715.GB8075@infradead.org>","list_archive_url":null,"date":"2017-11-03T06:27:15","subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","submitter":{"id":178,"url":"http://patchwork.ozlabs.org/api/people/178/","name":"Christoph Hellwig","email":"hch@infradead.org"},"content":"On Thu, Nov 02, 2017 at 06:02:54PM +1100, Ronnie Sahlberg wrote:\n> This function is similar to SendReceive2 except it does not expect\n> a 4 byte rfc1002 length header in the first io vector.\n\nCan you give it a proper name?  cifs_ prefix, lower case with _\nas the word delimiter.\n\nAlso please explain the strategy for phasing out the old API(s) so\nthat we won't have three around forever.\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"GbQFmsLx\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySsSP4bslz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 17:27:17 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751284AbdKCG1Q (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tFri, 3 Nov 2017 02:27:16 -0400","from bombadil.infradead.org ([65.50.211.133]:37844 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750971AbdKCG1Q (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Fri, 3 Nov 2017 02:27:16 -0400","from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red\n\tHat Linux)) id 1eAVRj-0006Fm-UH; Fri, 03 Nov 2017 06:27:15 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version\n\t:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=2tNa43JgC+2shz9OYGxC86lvdW42oLQnB7ryi7B4RxE=;\n\tb=GbQFmsLxUZ4lD9O5XAn0nv05L\n\tq1xsN/3G/QFcnPdxIPc9AsSvmru2dBlCoDCgxa+S9d9XVMdx0LH+NrHxac2kXFxWF2cEPln+HCUWp\n\tLy83+kCvjsc7V3jCQ8R+bvbVLy+TFdoOqh5oQDLRAlVXNx/I+PcGZanJB7fhZHoVJNsMgtDvMGTwd\n\tw3aN7DVhtrMzUamoFteyEL6jnRZsTXPAqL99iSThBEnF60FfFXtSJ3d0jIyOgSATZEgxswMn22FOx\n\tQzkTqbGKoGkQUe8c8Dwk4rq0x/kjJAjl+qyUx45lRfH3HZUk0r0g+BAISJf9frpfJ5vwOuwhfQd7z\n\tShDXt2ijw==;","Date":"Thu, 2 Nov 2017 23:27:15 -0700","From":"Christoph Hellwig <hch@infradead.org>","To":"Ronnie Sahlberg <lsahlber@redhat.com>","Cc":"linux-cifs <linux-cifs@vger.kernel.org>,\n\tSteve French <smfrench@gmail.com>","Subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","Message-ID":"<20171103062715.GB8075@infradead.org>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<20171102070312.18903-2-lsahlber@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171102070312.18903-2-lsahlber@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-SRS-Rewrite":"SMTP reverse-path rewritten from <hch@infradead.org> by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1798425,"web_url":"http://patchwork.ozlabs.org/comment/1798425/","msgid":"<CAN05THS8m9Z=KwiGarKh4qJT-X_ZnYU_AqVe26NNtF3Ad9j5nQ@mail.gmail.com>","list_archive_url":null,"date":"2017-11-03T06:37:59","subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","submitter":{"id":6089,"url":"http://patchwork.ozlabs.org/api/people/6089/","name":"ronnie sahlberg","email":"ronniesahlberg@gmail.com"},"content":"On Fri, Nov 3, 2017 at 4:27 PM, Christoph Hellwig <hch@infradead.org> wrote:\n> On Thu, Nov 02, 2017 at 06:02:54PM +1100, Ronnie Sahlberg wrote:\n>> This function is similar to SendReceive2 except it does not expect\n>> a 4 byte rfc1002 length header in the first io vector.\n>\n> Can you give it a proper name?  cifs_ prefix, lower case with _\n> as the word delimiter.\n\nSince this will now be the _only_ send/receive function SMB2 uses\n(except for the two async calls)\nI can rename it s/SendReceive3/SMB2SendReceive/  ?\n\n>\n> Also please explain the strategy for phasing out the old API(s) so\n> that we won't have three around forever.\n\nThat is harder and I don't plan to do so.\nSendReceive2 and SendReceiveNoRsp is after this series no longer used by\nsmb2, but they are still used by SMB1.\nSMB1 uses a LOT of different send/receive functions.\n\n\nI don't want to touch SMB1. I mostly want it to just go away :-)\n\n\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mB4+NsDi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySshq3r8jz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  3 Nov 2017 17:38:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750826AbdKCGiC (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tFri, 3 Nov 2017 02:38:02 -0400","from mail-qk0-f170.google.com ([209.85.220.170]:54167 \"EHLO\n\tmail-qk0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750772AbdKCGiB (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Fri, 3 Nov 2017 02:38:01 -0400","by mail-qk0-f170.google.com with SMTP id y23so2065585qkb.10\n\tfor <linux-cifs@vger.kernel.org>;\n\tThu, 02 Nov 2017 23:38:01 -0700 (PDT)","by 10.12.176.19 with HTTP; Thu, 2 Nov 2017 23:37:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=DTdDq3I1jLedcm/IbDIh8q3dRXYJ+FgOXkhoV5ULMrM=;\n\tb=mB4+NsDinSGPQcxyA52Nl6uQzTp9yl9Ny0sYQhjJWUUQcJQNs/899eBHZlGlmjlyiH\n\tuBPtNdNEi3Hr7I049YoG2MBkgpg/FeuU/pmxW484oQxJOYCXKzewk1RdkaEVlMejS6lE\n\t435MPkNlw0+qpDvEa4LGhM5CyYAOKbguUwPRPa3lS6Z+y2tq9g3lLoutKFc5qnA7SvzV\n\tq0zIon5VfPDP4abrzOJfynSoYRKcIXPl+aqXuWUJ8BPzocDz2GazaFSaQ8kB14D7A9cr\n\tK6v7K6XKnd40JNTuOhZCDYWTk5BbvLRvnRWkeRPV99a/BHQvRiv4Z3He90yp2sdSqK6q\n\t+IfA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=DTdDq3I1jLedcm/IbDIh8q3dRXYJ+FgOXkhoV5ULMrM=;\n\tb=rw+9RVDwlYRQySM1Kcv4ldmzqLq1hgiiaFMFy8jlunBKE6FmyqFMC3txznwpWS6pq5\n\tP5xx5Gy5CJdj59jUP7TN9/sT8LmgNzScxdxBAhbpvqs0D9yOffkWtONogPnB67KBrsl0\n\t/xb238sq/fxyint8yyvXKh4EqCxBvu10sc9Tblud1O4/uV/TXxL/VJbBo9nUh7LXLviM\n\tJMoIyqDWNVB1h+KdTO0fcJeaPCi43xktfjJE5eXXX6kplxQ7ECPp6lg6NHAo5qsghRsh\n\tlXrGDIXwX4MArjr1ZFBtc2K8XkvprBFVcOujFoY5JVoyKIzeqdTMxlzrPouAhBjoArNV\n\tZ96w==","X-Gm-Message-State":"AMCzsaWtaLd40Nn4qCiwAe7Qh8VJ3R5nD5RjAX22hQ7P/3vY/OmunENP\n\t1wYbovKpkNzyA96vuGCTYVPu/FcRNmgNayW02bE=","X-Google-Smtp-Source":"ABhQp+SS4TIRrtKMg5V1TCnwvVDb5U/Pn3xNFlMSF+ONWVYJPiCJqSvDzgCtWXbgSon2hh2RvgVxcluHO4Ecl1pwh88=","X-Received":"by 10.55.149.70 with SMTP id x67mr8286292qkd.62.1509691079938;\n\tThu, 02 Nov 2017 23:37:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171103062715.GB8075@infradead.org>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<20171102070312.18903-2-lsahlber@redhat.com>\n\t<20171103062715.GB8075@infradead.org>","From":"ronnie sahlberg <ronniesahlberg@gmail.com>","Date":"Fri, 3 Nov 2017 16:37:59 +1000","Message-ID":"<CAN05THS8m9Z=KwiGarKh4qJT-X_ZnYU_AqVe26NNtF3Ad9j5nQ@mail.gmail.com>","Subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","To":"Christoph Hellwig <hch@infradead.org>","Cc":"Ronnie Sahlberg <lsahlber@redhat.com>,\n\tlinux-cifs <linux-cifs@vger.kernel.org>,\n\tSteve French <smfrench@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1798612,"web_url":"http://patchwork.ozlabs.org/comment/1798612/","msgid":"<20171103133626.GA4280@infradead.org>","list_archive_url":null,"date":"2017-11-03T13:36:26","subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","submitter":{"id":178,"url":"http://patchwork.ozlabs.org/api/people/178/","name":"Christoph Hellwig","email":"hch@infradead.org"},"content":"On Fri, Nov 03, 2017 at 04:37:59PM +1000, ronnie sahlberg wrote:\n> Since this will now be the _only_ send/receive function SMB2 uses\n> (except for the two async calls)\n> I can rename it s/SendReceive3/SMB2SendReceive/  ?\n\nsmb2_send_recv, please.\n\n> > Also please explain the strategy for phasing out the old API(s) so\n> > that we won't have three around forever.\n> \n> That is harder and I don't plan to do so.\n> SendReceive2 and SendReceiveNoRsp is after this series no longer used by\n> smb2, but they are still used by SMB1.\n> SMB1 uses a LOT of different send/receive functions.\n> \n> \n> I don't want to touch SMB1. I mostly want it to just go away :-)\n\nOh well.  I guess it's just going to slowly bitrot then..\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"HMOZpbTG\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yT2zd2qK5z9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  4 Nov 2017 00:36:29 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756207AbdKCNg2 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tFri, 3 Nov 2017 09:36:28 -0400","from bombadil.infradead.org ([65.50.211.133]:50433 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751676AbdKCNg1 (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Fri, 3 Nov 2017 09:36:27 -0400","from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red\n\tHat Linux)) id 1eAc94-0003EL-RY; Fri, 03 Nov 2017 13:36:26 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version\n\t:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=0UYF3ctDD+gB819GusVEW9rVsEOMlViYxsgpvRkq4S4=;\n\tb=HMOZpbTGnEYO0+8DGNpJn2v+I\n\ttlBVpBN+Q+oCZnx0n+iRiInksqP7RRrFZwDKM+Z6oUBHDOqtz1/KhrC3T/PpjAFE2MUWzi8UEdUsw\n\t+fNGtLJ1xQn90CSgrrxbksV/RmIjlQM7pRpvCazyJiLx0Pe8y/a5vQBctVVKZxAH1O/noaIRwUk3v\n\t4HucevVyOsC5mZCIdrHj8Zjoz4z8TX7tnCzr4ZWgO6Q4KfiUUnA2yZmcGNgyo0mTfDUOtcjnloT7R\n\t912hssvGqwY7EsXDNDbUYX1YkmTk2FuEq1ITh0TA5i8JEfp6QbYwoqmHOaxs7onwPHkRdYjtGhnpo\n\tjse56ZciA==;","Date":"Fri, 3 Nov 2017 06:36:26 -0700","From":"Christoph Hellwig <hch@infradead.org>","To":"ronnie sahlberg <ronniesahlberg@gmail.com>","Cc":"Christoph Hellwig <hch@infradead.org>,\n\tRonnie Sahlberg <lsahlber@redhat.com>,\n\tlinux-cifs <linux-cifs@vger.kernel.org>,\n\tSteve French <smfrench@gmail.com>","Subject":"Re: [PATCH 01/19] cifs: Add SendReceive3","Message-ID":"<20171103133626.GA4280@infradead.org>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<20171102070312.18903-2-lsahlber@redhat.com>\n\t<20171103062715.GB8075@infradead.org>\n\t<CAN05THS8m9Z=KwiGarKh4qJT-X_ZnYU_AqVe26NNtF3Ad9j5nQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<CAN05THS8m9Z=KwiGarKh4qJT-X_ZnYU_AqVe26NNtF3Ad9j5nQ@mail.gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-SRS-Rewrite":"SMTP reverse-path rewritten from <hch@infradead.org> by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}}]