[{"id":1798176,"web_url":"http://patchwork.ozlabs.org/comment/1798176/","msgid":"<20171102183042.GJ27530@ovn.org>","list_archive_url":null,"date":"2017-11-02T18:30:42","subject":"Re: [ovs-dev] [PATCH] packets: Fix C++ compilation issues when\n\tinclude packets.h","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Wed, Nov 01, 2017 at 02:40:27PM -0700, Yi-Hung Wei wrote:\n> This patch fixes three C++ compilation errors when it includes\n> \"lib/packets.h\".\n> \n> 1) Fix in \"include/openvswitch/util.h\" is to avoid duplicated\n> named_member__ in struct pkt_metadata.\n> \n> 2) Fix in \"lib/packets.h\" is because designated initializers are not\n> implemented in GNU C++ [1].\n> \n> 3) Fix in \"lib/util.h\" is because __builtin_types_compatible_p and\n> __builtin_choose_expr are only supported in GCC. I use one solution\n> for C++ that is type-safe and works at compile time from [2].\n> \n> [1]: https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html\n> [2]: https://goo.gl/xNe48A\n> \n> Signed-off-by: Yi-Hung Wei \n\nThanks! I applied this to master.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySYYm2kYBz9sPm\n\tfor ;\n\tFri, 3 Nov 2017 05:30:52 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id D2AC1CEA;\n\tThu, 2 Nov 2017 18:30:50 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 736A4CE8\n\tfor ; Thu, 2 Nov 2017 18:30:49 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id DC67B20D\n\tfor ; Thu, 2 Nov 2017 18:30:48 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 67CE941C089;\n\tThu, 2 Nov 2017 19:30:46 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Thu, 2 Nov 2017 11:30:42 -0700","From":"Ben Pfaff ","To":"Yi-Hung Wei ","Message-ID":"<20171102183042.GJ27530@ovn.org>","References":"<1509572427-19204-1-git-send-email-yihung.wei@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1509572427-19204-1-git-send-email-yihung.wei@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] packets: Fix C++ compilation issues when\n\tinclude packets.h","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]