[{"id":1797282,"web_url":"http://patchwork.ozlabs.org/comment/1797282/","msgid":"<bcee429e-2f51-b75e-62cb-798e023d0ceb@gmail.com>","list_archive_url":null,"date":"2017-11-01T13:54:46","subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","submitter":{"id":20028,"url":"http://patchwork.ozlabs.org/api/people/20028/","name":"John Fastabend","email":"john.fastabend@gmail.com"},"content":"On 11/01/2017 04:44 AM, Jesper Dangaard Brouer wrote:\n> Discovered that the compiler laid-out asm code in suboptimal way\n> when studying perf report during benchmarking of cpumap. Help\n> the compiler by the marking unlikely code paths.\n> \n> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n> ---\n>  kernel/bpf/cpumap.c |    4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c\n> index 86e29cbf7827..ce5b669003b2 100644\n> --- a/kernel/bpf/cpumap.c\n> +++ b/kernel/bpf/cpumap.c\n> @@ -208,7 +208,7 @@ static struct xdp_pkt *convert_to_xdp_pkt(struct xdp_buff *xdp)\n>  \theadroom = xdp->data - xdp->data_hard_start;\n>  \tmetasize = xdp->data - xdp->data_meta;\n>  \tmetasize = metasize > 0 ? metasize : 0;\n> -\tif ((headroom - metasize) < sizeof(*xdp_pkt))\n> +\tif (unlikely((headroom - metasize) < sizeof(*xdp_pkt)))\n>  \t\treturn NULL;\n>  \n>  \t/* Store info in top of packet */\n> @@ -656,7 +656,7 @@ int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu, struct xdp_buff *xdp,\n>  \tstruct xdp_pkt *xdp_pkt;\n>  \n>  \txdp_pkt = convert_to_xdp_pkt(xdp);\n> -\tif (!xdp_pkt)\n> +\tif (unlikely(!xdp_pkt))\n>  \t\treturn -EOVERFLOW;\n>  \n>  \t/* Info needed when constructing SKB on remote CPU */\n> \n\nSeems OK to me, just curious is this noticeable at pps benchmarks?\n\nAcked-by: John Fastabend <john.fastabend@gmail.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dfheRz4X\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRqV034cdz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  2 Nov 2017 00:55:04 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752154AbdKANzA (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 1 Nov 2017 09:55:00 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:51954 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751511AbdKANy7 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 1 Nov 2017 09:54:59 -0400","by mail-pf0-f194.google.com with SMTP id n14so2021069pfh.8\n\tfor <netdev@vger.kernel.org>; Wed, 01 Nov 2017 06:54:59 -0700 (PDT)","from [192.168.86.24] ([72.168.145.34])\n\tby smtp.gmail.com with ESMTPSA id\n\t84sm1437583pfy.179.2017.11.01.06.54.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 01 Nov 2017 06:54:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=R4cXLYKahQgBzJy4tw2pLjRQGRf9Bde8HwsxE+zO3uI=;\n\tb=dfheRz4XS0jTPhLa98Oke9T2tVSDz3A0naO1CqfYOizjurU8oB5vJcRSqvFZuwy1TY\n\twxpPbFl0yv5uFgnHzzliuIDqOOcJNZBsCQ8eVBTo1+/JKMPhgeBy6vAGsfFe7I079VvK\n\tnQ1te8W4qOVFxmmKI2PAtVi2q3imCW5IPJDR3H+0C9yd2RY+iGe6+kFaRqks1WHwSOHo\n\tjteZvwPEEzoTKAXhMBrc3vr50xJZjH90a5+kGxPuDX8f1T5Lh+I1WhzkuKKOeK345gLe\n\tSQtKVrS4hllycyhuK7qE6OEi9UilOKo+MzPLe8Qxrmm2LWrQ87vhergMzTFquDoqlKwX\n\tooWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=R4cXLYKahQgBzJy4tw2pLjRQGRf9Bde8HwsxE+zO3uI=;\n\tb=kiGLcvmQJ6ZOsfqNzzkWkN2XQOSt5d7tlpzBg7KXhuoyP8JKo1Sy0KMwN6wYyzICo9\n\t6Jqfs16TcuAyCYHrUuixUhdUE85iQRuSkaJ8hh8SfIt9hjWG+hEicZe+6ezhF029KJvb\n\tws92j5nQPzWtNA4I+NQK98T1yt6PppLuwc2DdX+xDIneDDz9LiSJ+4X+4D4fxllBb0xN\n\t4ZFbNPkKcsvm+sVYaJAZUuPDXTEtupInJ1cEvhFrprApnugB3NTteASMWp9nzKihYUmI\n\tWd2LBM+wtLOikDOH1JgrLDI9RsK/rhqnWCtYVhwjpVYS2XSFJLZ+w6yNPthrF2K6UoRP\n\tc++w==","X-Gm-Message-State":"AMCzsaXIrbMbIx7X68SAF+noxoSNPiKaXNudWXB6OFtR2cHF3VcO6y0q\n\tFU2JLvDzlSul+lE50nX/H4hhpYDN","X-Google-Smtp-Source":"ABhQp+TZvVXEuatQTWpy/FilwlHO/IQ3mzHD3AM9YHibsA2SwgveDZ/Ica/WAyxf19iFeR9Ojg3jIQ==","X-Received":"by 10.98.242.13 with SMTP id m13mr7023575pfh.306.1509544498906; \n\tWed, 01 Nov 2017 06:54:58 -0700 (PDT)","Subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","To":"Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org","References":"<150953668583.30172.5069550217700139382.stgit@firesoul>","From":"John Fastabend <john.fastabend@gmail.com>","Message-ID":"<bcee429e-2f51-b75e-62cb-798e023d0ceb@gmail.com>","Date":"Wed, 1 Nov 2017 06:54:46 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<150953668583.30172.5069550217700139382.stgit@firesoul>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1797289,"web_url":"http://patchwork.ozlabs.org/comment/1797289/","msgid":"<20171101151859.189ae769@redhat.com>","list_archive_url":null,"date":"2017-11-01T14:18:59","subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","submitter":{"id":13625,"url":"http://patchwork.ozlabs.org/api/people/13625/","name":"Jesper Dangaard Brouer","email":"brouer@redhat.com"},"content":"On Wed, 1 Nov 2017 06:54:46 -0700\nJohn Fastabend <john.fastabend@gmail.com> wrote:\n\n> On 11/01/2017 04:44 AM, Jesper Dangaard Brouer wrote:\n> > Discovered that the compiler laid-out asm code in suboptimal way\n> > when studying perf report during benchmarking of cpumap. Help\n> > the compiler by the marking unlikely code paths.\n> > \n> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n> > ---\n> >  kernel/bpf/cpumap.c |    4 ++--\n> >  1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c\n> > index 86e29cbf7827..ce5b669003b2 100644\n> > --- a/kernel/bpf/cpumap.c\n> > +++ b/kernel/bpf/cpumap.c\n> > @@ -208,7 +208,7 @@ static struct xdp_pkt *convert_to_xdp_pkt(struct xdp_buff *xdp)\n> >  \theadroom = xdp->data - xdp->data_hard_start;\n> >  \tmetasize = xdp->data - xdp->data_meta;\n> >  \tmetasize = metasize > 0 ? metasize : 0;\n> > -\tif ((headroom - metasize) < sizeof(*xdp_pkt))\n> > +\tif (unlikely((headroom - metasize) < sizeof(*xdp_pkt)))\n> >  \t\treturn NULL;\n> >  \n> >  \t/* Store info in top of packet */\n> > @@ -656,7 +656,7 @@ int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu, struct xdp_buff *xdp,\n> >  \tstruct xdp_pkt *xdp_pkt;\n> >  \n> >  \txdp_pkt = convert_to_xdp_pkt(xdp);\n> > -\tif (!xdp_pkt)\n> > +\tif (unlikely(!xdp_pkt))\n> >  \t\treturn -EOVERFLOW;\n> >  \n> >  \t/* Info needed when constructing SKB on remote CPU */\n> >   \n> \n> Seems OK to me, just curious is this noticeable at pps benchmarks?\n\nI calculate this into an approx 2 nanosec improvement based on PPS\nbenchmarks.  Given my systems accuracy is around 2 nanosec (after much\ntuning) then I cannot claim my measurements to be statistically\nsignificant ;-)\n\n> Acked-by: John Fastabend <john.fastabend@gmail.com>\n\nThanks","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRr1p0T6lz9sRq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  2 Nov 2017 01:19:10 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754719AbdKAOTH (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 1 Nov 2017 10:19:07 -0400","from mx1.redhat.com ([209.132.183.28]:38472 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754705AbdKAOTF (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tWed, 1 Nov 2017 10:19:05 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 29E3134C4;\n\tWed,  1 Nov 2017 14:19:05 +0000 (UTC)","from localhost (ovpn-200-16.brq.redhat.com [10.40.200.16])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8F14D5C8A8;\n\tWed,  1 Nov 2017 14:19:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 29E3134C4","Date":"Wed, 1 Nov 2017 15:18:59 +0100","From":"Jesper Dangaard Brouer <brouer@redhat.com>","To":"John Fastabend <john.fastabend@gmail.com>","Cc":"netdev@vger.kernel.org, brouer@redhat.com","Subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","Message-ID":"<20171101151859.189ae769@redhat.com>","In-Reply-To":"<bcee429e-2f51-b75e-62cb-798e023d0ceb@gmail.com>","References":"<150953668583.30172.5069550217700139382.stgit@firesoul>\n\t<bcee429e-2f51-b75e-62cb-798e023d0ceb@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 01 Nov 2017 14:19:05 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1797344,"web_url":"http://patchwork.ozlabs.org/comment/1797344/","msgid":"<20171101161210.55ekkcrkrsgltvx6@ast-mbp>","list_archive_url":null,"date":"2017-11-01T16:12:11","subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Wed, Nov 01, 2017 at 12:44:45PM +0100, Jesper Dangaard Brouer wrote:\n> Discovered that the compiler laid-out asm code in suboptimal way\n> when studying perf report during benchmarking of cpumap. Help\n> the compiler by the marking unlikely code paths.\n> \n> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n\nAcked-by: Alexei Starovoitov <ast@kernel.org>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QHJye+6G\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRtXH3Lc1z9sNx\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  2 Nov 2017 03:12:15 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932392AbdKAQMN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 1 Nov 2017 12:12:13 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:56650 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754593AbdKAQMM (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 1 Nov 2017 12:12:12 -0400","by mail-pg0-f68.google.com with SMTP id m18so2476979pgd.13\n\tfor <netdev@vger.kernel.org>; Wed, 01 Nov 2017 09:12:11 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:39bd])\n\tby smtp.gmail.com with ESMTPSA id\n\tp14sm1797244pgr.51.2017.11.01.09.12.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 01 Nov 2017 09:12:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=u0RaZ0NV5cSURHi5Xn/osnM7GetCyY2NsDJzgGdIIak=;\n\tb=QHJye+6GD3YmhXCMpwAZn3Hn1Ak8D4fGrlx7lsTbmKX3KRqzhPu/0EmAfTvvwKBbmR\n\thJBFBUeyL5tA8MCJhxsLYlPiIN1/w4EUEzb2LCo+J5sBmkhal/K1Hw+5N4at/Pmohh6d\n\tNeCB6ziJQbmUtbQQ6xgMN2yCAPGYb0EdbHyltdx6O9hn01r+4Tpy8hUQa8sXNMW4eXrs\n\tQUfPq1qFVf5SgEn6T0DR9u7yWMjKY+1hUDzx35X70gp/v4+Z4HJ3WD5BIjTby7YlrtNn\n\teRLPv+Cny7+5fkX2Py5VsUJ+hViHe89xpfw6AYZUXN2igo/z2vtoBFuYkxtSNXbG2Y6l\n\tWz3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=u0RaZ0NV5cSURHi5Xn/osnM7GetCyY2NsDJzgGdIIak=;\n\tb=s5kfOqzqlvuxlf8x/nUBwoLcKY1bVy37ajLYm7yOgHCOFRftmfYQVM6+6mpUUjpYYF\n\tJcMAJrPk3VBNqNKvc+3+A3JJkezxSdexAuWfOu7tw3oG6i9IWYgSiehw4tYp8GaIaKxT\n\tNzJ+Qcy/ahSemJ50jKOQuqASAdRdqOQotJpBiw94mGx1WJ6BY8B7/swxjgszqseeTnah\n\tyK5Cn5V7IS+A9LLypIPmNr2lugYFMaKueHENoFbNoweiay8e54M8Xj3t6/CT4L0JR/Jx\n\tOgTj+SMpW5IGAPYA/mRml0xP4G+TE5roivPIMwkfFeaMo+PaChbnvTGI5ff1OAP+mVj/\n\tfURQ==","X-Gm-Message-State":"AMCzsaXa6/ZQmolyPOfz17vghDsNZX1BRvNij3vebAGiRWUzwlf6jS/+\n\tPY4hbL9aHdlFjJuhHSQu5jYYIThi","X-Google-Smtp-Source":"ABhQp+SiCrMHQdHzZMwStBXr6Mv+YJVaSim7evxneO4w/8N97oG+bpA+N5RjOQ3d3ILqvUlhutHJCg==","X-Received":"by 10.159.230.13 with SMTP id u13mr111239plq.226.1509552731541; \n\tWed, 01 Nov 2017 09:12:11 -0700 (PDT)","Date":"Wed, 1 Nov 2017 09:12:11 -0700","From":"Alexei Starovoitov <alexei.starovoitov@gmail.com>","To":"Jesper Dangaard Brouer <brouer@redhat.com>","Cc":"netdev@vger.kernel.org","Subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","Message-ID":"<20171101161210.55ekkcrkrsgltvx6@ast-mbp>","References":"<150953668583.30172.5069550217700139382.stgit@firesoul>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<150953668583.30172.5069550217700139382.stgit@firesoul>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1797670,"web_url":"http://patchwork.ozlabs.org/comment/1797670/","msgid":"<20171102.161435.1119634915876878060.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-02T07:14:35","subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jesper Dangaard Brouer <brouer@redhat.com>\nDate: Wed, 01 Nov 2017 12:44:45 +0100\n\n> Discovered that the compiler laid-out asm code in suboptimal way\n> when studying perf report during benchmarking of cpumap. Help\n> the compiler by the marking unlikely code paths.\n> \n> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n\nApplied, thanks Jesper.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySGYY3h41z9t2V\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  2 Nov 2017 18:14:41 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754992AbdKBHOj (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 2 Nov 2017 03:14:39 -0400","from shards.monkeyblade.net ([184.105.139.130]:44182 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751567AbdKBHOi (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 2 Nov 2017 03:14:38 -0400","from localhost (unknown [106.252.28.196])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id C26DC1363BC69;\n\tThu,  2 Nov 2017 00:14:37 -0700 (PDT)"],"Date":"Thu, 02 Nov 2017 16:14:35 +0900 (KST)","Message-Id":"<20171102.161435.1119634915876878060.davem@davemloft.net>","To":"brouer@redhat.com","Cc":"netdev@vger.kernel.org","Subject":"Re: [net-next PATCH] bpf: cpumap micro-optimization in\n\tcpu_map_enqueue","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<150953668583.30172.5069550217700139382.stgit@firesoul>","References":"<150953668583.30172.5069550217700139382.stgit@firesoul>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 02 Nov 2017 00:14:38 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]