[{"id":1795891,"web_url":"http://patchwork.ozlabs.org/comment/1795891/","msgid":"<87d8006a-f345-452c-033d-1769982395bc@virtuozzo.com>","list_archive_url":null,"date":"2017-10-30T12:34:54","subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"content":"27.10.2017 13:45, Eric Blake wrote:\n> Commenting these two lines is enough to avoid the change to 083.out\n> in 12/12. That is evidence that we may want these two lines to be\n> trace points rather than error messages; or maybe we really do like\n> the extra verbosity in the case of an unexpected communication break.\n>\n> This patch does not meet coding guidelines, and I'm not proud enough\n> of it to give S-o-b, but I'm posting it for conversation.\n>\n> ---\n> block/nbd-client.c | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/block/nbd-client.c b/block/nbd-client.c\n> index b44d4d4a01..e063b3fbc0 100644\n> --- a/block/nbd-client.c\n> +++ b/block/nbd-client.c\n> @@ -654,7 +654,8 @@ static int nbd_co_request(BlockDriverState *bs, NBDRequest *request,\n>\n> ret = nbd_co_receive_return_code(client, request->handle, &local_err);\n> if (local_err) {\n> - error_report_err(local_err);\n> + assert(ret < 0);\n> +// error_report_err(local_err);\n> }\n> return ret;\n> }\n> @@ -682,7 +683,7 @@ int nbd_client_co_preadv(BlockDriverState *bs, uint64_t offset,\n> ret = nbd_co_receive_cmdread_reply(client, request.handle, offset, qiov,\n> &local_err);\n> if (ret < 0) {\n> - error_report_err(local_err);\n> + //error_report_err(local_err);\n> }\n> return ret;\n> }\n\ncommenting is not ok, you should call error_free instead.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"ZmCG55d0\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsementsov@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQYqZ452lz9sQl\n\tfor ;\n\tMon, 30 Oct 2017 23:35:52 +1100 (AEDT)","from localhost ([::1]:40481 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e99IE-0007l7-2R\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 08:35:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42465)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e99Hh-0007g7-Ut\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 08:35:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e99He-0000Ql-SU\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 08:35:17 -0400","from mail-ve1eur01on0097.outbound.protection.outlook.com\n\t([104.47.1.97]:45246\n\thelo=EUR01-VE1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e99HS-0000I0-46; Mon, 30 Oct 2017 08:35:02 -0400","from [172.16.24.243] (195.214.232.6) by\n\tDB6PR0801MB2054.eurprd08.prod.outlook.com (2603:10a6:4:77::7) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4;\n\tMon, 30 Oct 2017 12:34:56 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=GD9CwDw7Li4wr3K2noTxaWZSE80WgNA2wAWGpmjpM88=;\n\tb=ZmCG55d08BowT3afbSaQsmN5yRvgpOcX4QYF7zjQZtuXcD5w0B3Yz9vPO49J+MuMe6YmfPdnEuNDaHBbhW+xyAJ3mfconMVpQAsGLq7sFxfRW/pvvVSXgMGpinar9dMDOccq1jN1euCExW8kuwysUMHp2OEelqE8ll1jYW7xPT0=","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104546.8582-1-eblake@redhat.com>","From":"Vladimir Sementsov-Ogievskiy ","Message-ID":"<87d8006a-f345-452c-033d-1769982395bc@virtuozzo.com>","Date":"Mon, 30 Oct 2017 15:34:54 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171027104546.8582-1-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"DB6PR0202CA0002.eurprd02.prod.outlook.com\n\t(2603:10a6:4:29::12) To DB6PR0801MB2054.eurprd08.prod.outlook.com\n\t(2603:10a6:4:77::7)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"02759fbb-e801-45b0-3e18-08d51f92a182","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603238);\n\tSRVR:DB6PR0801MB2054; ","X-Microsoft-Exchange-Diagnostics":["1; DB6PR0801MB2054;\n\t3:r++VgyJ6aXAbcI6JKMb14V4vnU1rugCopf5eGh0aeb21q5unLAupEt0MgaTfdX7dxR8ZEJyA2OfYT4quzUMRX5GthcFpIp4UuarAoeV5EOCLAu/werrde4+MAzxbFUtvQ0YbDa5HYcYGICCRIvYHqn4VWCgtT5mT2XYApzw+8iUJUryBeD3Q6Hf3GkWEJmWTYDeGzDhqoCAnxZjhRlzyugU11qIJQfi6JmTS7fKrRi7ZsuhtWtCUU+capA0f2xM5;\n\t25:iVtEbWGPXmK705SfGRhrB1eDP87MmEHc6CsQoeruj3hPGOI+tT1Cy4c/3Htjc0dMXqprC2fj0V2EtcjHM6fZKoI2xi4PqYLCeUCuUiea5W5wBabONy07I9y8G/Jgagtv3IBSVW/c71s7ISWzw+hUbmn0RAGTcDhR4qtBxJJfFVyy6sryJgSYIATE3G/J9mLtwfQx7U60msTA4y6yk0DmSVvddaH5QeZLF6a1WvWOp/U220LWiQr+10LwHJEpuypmPUhLmLEXRpjsbJytxvluE0N0NTOAn8St8r2L/bCeuhfLjJ5whwSpH2FS00UdpfQ5idi82fzddHkx64vWd/UY+o7fcrvTyup0XefsICMuuNY=;\n\t31:yAu53kHaA1M2bHhgnzDjgk7+psP/cy466Cb2MUAw/bHjbnw0R/cHGsNy4wvZBcivUNOKphwNJnnHvdXmEJgDDTK3ShjoExG+DEPMpwUilgDyVB45S/SjarhjDD+BB1+QyY440TdDHyfbIVEN4djs47zZOrWEvD5AIWzT00WP01/dPWytuQR5hOsf0OttJE7kUQLOub62NpjWA9YTrPBFN+vPJJXhkIBh0qrm64u5/UQ=","1; DB6PR0801MB2054;\n\t20:Qh1ZyYKjz9ZfxUhXV++CmEf0jekI+P6crKjfr8cjbsfO7NfgQNmhTRm+1p/U9Ghu0sjp2z9pGgPitwR9UwST+NXUte5d4vfZ5CRCJCoh59tpplDA2ZSoB6zQJv4ukMH8FQzdDVK4fcjnOcqcGDobQr9wbyuoeYL3Q5wqwLg7Vgrs4ODnOgqIbgtH27OXiCZukBalbudP72KKwh3NTQYrf93njE30UYnerHxjN99/D7uHImUj4PaWsC57cB1hKFnZo1W6yvn4ufC/EcOSTGiToYEgIiA2IRE8193ts4dyDQVNx8y2qqt18KD2tysaoLMHUJBkBvnw6o5fmXpLLztOWKkALovOtgyWcynXU42HoPBQv+JSclitqfj4K0bunzT7mF3mg3HTwbeesiZwQ17KfCacylZyxttk0ePm0/85Z+8=;\n\t4:RmNSXKKU3YqUfq7KtZlLlj7cZyAaU6PvYnnjmKxGWosba4Om4n9Zd6ma3XdBsC8aV5wqqLF0zOgxggcRhn8vTWyghgsjpOfHoy387FX7b8E6jUM0//Xddr1TcSfPPqw+eG0YBmoyP+Ce4oNutCIhNq186/Lchz6I0JzUcyBoC4Mhjx3RUHC2n6WKMj5XeRPZFS3hXK8KC7u52L1AgJbGK3z09eMuJACzXA79KdFXaBBIgDrxmqxwz40mriFaqYzx","=?utf-8?q?1=3BDB6PR0801MB2054=3B23=3AsA?=\n\t=?utf-8?q?V4Sg5+W07jL9oDesc01iJbb5qVIRisNQ4PdwWjoeAyhiqT43Cz+bBP6C?=\n\t=?utf-8?q?RLLwWPZb5tYRypVexBTZ6h+wlB7n4SXvtXp6qEq/U444tTBKdFavpuPg?=\n\t=?utf-8?q?P8YyufkUjnFvwklkMmiyxUP5xDfaInraFoHlfiIk9oPLzg9Z/TVwYU98?=\n\t=?utf-8?q?tFN53rb2fZNBrOhsUMLj0QGB57C5A8sRzMZpuii7LLcim3K2E/RFqHjc?=\n\t=?utf-8?q?4lXK05CighNWJ6uOxlRZZuLMfhCkI9jsiCuCkZAmkUW8ORov5qDNCsSA?=\n\t=?utf-8?q?2V20cVoTcoyA2s1qtps7jpqA7pDOczZ6CqkBGgSHS6h0WA9eVZM/a3EC?=\n\t=?utf-8?q?7pBqzYfm+2K+GpznQdh3sVQYrlrowlTH+9cjYXPI16wJeezUsItn45ym?=\n\t=?utf-8?q?L/qOyjP9vMo8ij7ukRLuWE+hWfflRJZOjfOSUxmhiMwVUu4UUg3pKepd?=\n\t=?utf-8?q?ITFNvdaZyBmLZrNMSvfaXPir8b5ra32hnMz1TG5wmF10qfNIQ+WeW5gO?=\n\t=?utf-8?q?vbVd5c79wT+Y47v0YlwjbZcCFE8VNi7CtBnVsmJJ0v/ifovGElwLMSUP?=\n\t=?utf-8?q?8PH3HORbug0S/iWNUh1TP2Dv/iZLm4rAZKvHGigbWEdfN1/nS39ZG/2Q?=\n\t=?utf-8?q?bq7kikic2yt+Ut7YP14PiQ2kz8UK30eTOzzy9gJfdH9LLhkjG2cEBIvw?=\n\t=?utf-8?q?e+bMRcu5boAOJaS2hE3/jx9ddq7DcQC+guS/NJTVmF3Hb/VQkSWqmh+K?=\n\t=?utf-8?q?ZTP3dLoWz6+OrQPcfh5lN9jUjhYOq0oGgRpjDifvYidl0trMOr9NUixh?=\n\t=?utf-8?q?jl8i+kcNkg50hULisJxL3VliBQfY2b7C/JspH/PhcVglhe92kR3/1qXK?=\n\t=?utf-8?q?wr8uYHcSt2oo+P+MUBu+cE+8kRcwTXxx7K5sbeGJpai+awU+chBy6tWC?=\n\t=?utf-8?q?uaE8ZkTgbTSEhgrJ7+jl1PsfwIpLUzhGNI3Q3Tt3EGjKnncWVYiMfs3b?=\n\t=?utf-8?q?MLmVG6Lal1RSNY9aU9qxFWoHFT8tZjNA36fHLP1ErtkvjY6Qn8GXWHzs?=\n\t=?utf-8?q?ebA7UlNCg+nkhF+5LJlY09ND/FH5lugMibe93BP4fdfYTBbknQG6znyk?=\n\t=?utf-8?q?TJWc5YrMLoulDglui9YHCeoH/rf2Lc8IsuniP8AkwIvQYzZpTmkaP9b7?=\n\t=?utf-8?q?NDM7ndQsAKcBSi23u9TaAWuWs2VVWw4d4UDdwT2mBWoLk63zzW8/KpEB?=\n\t=?utf-8?q?U2Gsu70HuUG4Mu8QwihiN39VXHItvtropxbvvLSLfM2msVQ6e/11+d2c?=\n\t=?utf-8?q?KNXPUIBxREcgRp2bmeAuPrNKV2cXukGXxXCnKatHa9oDFizssXFMVIqL?=\n\t=?utf-8?q?Dsb0k9TPBJ0YTrr8pKhWjh2DgkW+u77uc=3D?=","1; DB6PR0801MB2054;\n\t6:vw4+anj+DfDUSD+AWGrMe/mG91vkceuCxQWs3XqFf3Kxl18atBYpgk7r8JRgfv2YUmUKyjRXFauXoYvhnbWtNfP5iFlR2ic2SjdgR0oOFvwfoxCHCpy4AxqVGATMbLn9T022juOztsdmVwZGAeyYHItBPGF8bnCRvONGOtMZfV3HfecI3a8OQAp89qevI1KGuSsBZRTFiG4rKJCE/s4lDRt8Q8C9XDUtVweyIjY+8dnF+MbtU/6Sr/YTQ7duoSX/kvy6cyml2Jg366jJC8pk3s0e0z0ku4YV4m/YYI4C+8tPXTJPEt0l+goSPgo+2MeipRddQxlv/Fo7ARRBfGEz3g==;\n\t5:UnYMVRL079KeWAArezFSColeRfWUjyMbxccCp9NLDzo5hnk+fSM62rVePyD79MQ2wP/L0x3oIR2xgmQJKoow+VibqYCbySb6LjpFsBLlUbMeTgnd1Duxab5CgScMuAKynxzLjPjjIU3AtEzwAzqToA==;\n\t24:wvOZJz9rXJHfLaw7c7fxM+fqS44MQQkPdkoz8rEitRKTdE0ZR3PdoWowv0PUaH3rW8GOaJEwTF7MaevYK3Sbd7idaEO85YNEOba1wy8rZlw=;\n\t7:w7JyufYwM8YrahVtsanfZoKZwrCGXCC+mTfcDnMZmYEPHlsybx/zBTMWV3mRAJm8uLYtUC3SBZrd5Mv+1JFcvxZx4ZifGjH6jbpq64iPl1KKqrk6MMbY1nOFCA7xtSQ1NK4zDW0buxzzDoGxDNNdVd2vyBBI5vGejKSD8aLbfXzpAjpN2Qu1XyTBktq9P71r1m0okk+gEH/9PUKMjlwRbgLvYW0RR5PhgUBFp9rdAH8=","1; DB6PR0801MB2054;\n\t20:5berGz7acXYUi3zWNavDuM7MxJBpu/SbwnK+cnp5q8gl0S59HwSWwtq5SUD8EvRNrSugY3TF2EihrHMrqNIfwmqFiOwLD++xeiSR6Gnbj149Y6dK+qTL7WrNPt9Mev8rC7FYY4sphH4q2bzE3U98hd6s7VaiimWvMZhPiLacqYs="],"X-MS-TrafficTypeDiagnostic":"DB6PR0801MB2054:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231020)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0801MB2054; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0801MB2054; ","X-Forefront-PRVS":"0476D4AB88","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(6049001)(376002)(346002)(39830400002)(24454002)(189002)(199003)(83506002)(81156014)(65826007)(5660300001)(305945005)(478600001)(16526018)(7736002)(31686004)(105586002)(86362001)(68736007)(230700001)(36756003)(65806001)(65956001)(66066001)(50466002)(16576012)(316002)(53936002)(229853002)(31696002)(106356001)(2906002)(6486002)(47776003)(77096006)(64126003)(2950100002)(97736004)(58126008)(54906003)(54356999)(23676002)(6246003)(76176999)(8676002)(4326008)(50986999)(6116002)(3846002)(33646002)(189998001)(25786009)(101416001)(8936002)(81166006)(217873001);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:DB6PR0801MB2054;\n\tH:[172.16.24.243]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Oct 2017 12:34:56.8302\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"02759fbb-e801-45b0-3e18-08d51f92a182","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0801MB2054","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.1.97","Subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1795912,"web_url":"http://patchwork.ozlabs.org/comment/1795912/","msgid":"","list_archive_url":null,"date":"2017-10-30T13:00:40","subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 10/30/2017 01:34 PM, Vladimir Sementsov-Ogievskiy wrote:\n> 27.10.2017 13:45, Eric Blake wrote:\n>> Commenting these two lines is enough to avoid the change to 083.out\n>> in 12/12.  That is evidence that we may want these two lines to be\n>> trace points rather than error messages; or maybe we really do like\n>> the extra verbosity in the case of an unexpected communication break.\n>>\n>> This patch does not meet coding guidelines, and I'm not proud enough\n>> of it to give S-o-b, but I'm posting it for conversation.\n>>\n\n>>       if (ret < 0) {\n>> -        error_report_err(local_err);\n>> +        //error_report_err(local_err);\n>>       }\n>>       return ret;\n>>   }\n> \n> commenting is not ok, you should call error_free instead.\n\nIndeed, and that's why I marked this RFC and used the wrong style\ncomment, to make it obvious that if we aren't going to print an error\nmessage, there are better ways to go about doing that which don't leak\nmemory. The question is whether the output is useful, or whether it\nshould be only via a trace (as it is, we aren't yet tracing anything in\nblock/nbd-client.c), or whether it is always just extra noise (in which\ncase passing the errp parameter around isn't helpful).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQZPK1kNVz9sRm\n\tfor ;\n\tTue, 31 Oct 2017 00:01:38 +1100 (AEDT)","from localhost ([::1]:40589 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e99h8-0004bT-Jx\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 09:01:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48092)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e99gi-0004X6-VK\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 09:01:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e99gd-0006KI-TA\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 09:01:07 -0400","from mx1.redhat.com ([209.132.183.28]:53476)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e99gT-0006B4-GQ; Mon, 30 Oct 2017 09:00:53 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A129313A62;\n\tMon, 30 Oct 2017 13:00:51 +0000 (UTC)","from [10.10.123.35] (ovpn-123-35.rdu2.redhat.com [10.10.123.35])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8F4CDE9F34;\n\tMon, 30 Oct 2017 13:00:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A129313A62","To":"Vladimir Sementsov-Ogievskiy ,\n\tqemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104546.8582-1-eblake@redhat.com>\n\t<87d8006a-f345-452c-033d-1769982395bc@virtuozzo.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 30 Oct 2017 14:00:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<87d8006a-f345-452c-033d-1769982395bc@virtuozzo.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"iWOnLAfBrBP8WXAs3svFN5QNxk16Aj9pi\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 30 Oct 2017 13:00:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1796139,"web_url":"http://patchwork.ozlabs.org/comment/1796139/","msgid":"","list_archive_url":null,"date":"2017-10-30T18:01:51","subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"content":"27.10.2017 13:45, Eric Blake wrote:\n> Commenting these two lines is enough to avoid the change to 083.out\n> in 12/12. That is evidence that we may want these two lines to be\n> trace points rather than error messages; or maybe we really do like\n> the extra verbosity in the case of an unexpected communication break.\n>\n> This patch does not meet coding guidelines, and I'm not proud enough\n> of it to give S-o-b, but I'm posting it for conversation.\n\nI think more verbosity on fail is not bad, it's rare case. In previous patch\nthe corresponding change looks big, but in real case it would be just one\nmore line in log.\n\nHowever, if you unsure about it, people who want more verbosity may always\nenable this particular trace, so tracing is ok too and more flexible.\n\n>\n> ---\n> block/nbd-client.c | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/block/nbd-client.c b/block/nbd-client.c\n> index b44d4d4a01..e063b3fbc0 100644\n> --- a/block/nbd-client.c\n> +++ b/block/nbd-client.c\n> @@ -654,7 +654,8 @@ static int nbd_co_request(BlockDriverState *bs, NBDRequest *request,\n>\n> ret = nbd_co_receive_return_code(client, request->handle, &local_err);\n> if (local_err) {\n> - error_report_err(local_err);\n> + assert(ret < 0);\n> +// error_report_err(local_err);\n> }\n> return ret;\n> }\n> @@ -682,7 +683,7 @@ int nbd_client_co_preadv(BlockDriverState *bs, uint64_t offset,\n> ret = nbd_co_receive_cmdread_reply(client, request.handle, offset, qiov,\n> &local_err);\n> if (ret < 0) {\n> - error_report_err(local_err);\n> + //error_report_err(local_err);\n> }\n> return ret;\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"Ubry4k7U\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsementsov@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQj4f4sfYz9t2r\n\tfor ;\n\tTue, 31 Oct 2017 05:02:41 +1100 (AEDT)","from localhost ([::1]:41960 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e9EOU-0005vJ-Ol\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 14:02:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37520)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e9EO1-0005sM-RE\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 14:02:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e9EO1-0007rM-1z\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 14:02:09 -0400","from mail-db5eur01on0120.outbound.protection.outlook.com\n\t([104.47.2.120]:4768\n\thelo=EUR01-DB5-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e9ENq-0007i3-Ic; Mon, 30 Oct 2017 14:01:59 -0400","from [172.16.24.243] (195.214.232.6) by\n\tDB6PR0801MB2056.eurprd08.prod.outlook.com (2603:10a6:4:77::9) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4;\n\tMon, 30 Oct 2017 18:01:54 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=UGUOmu2hF1e5ctmULwQYy/r/UWNKLFZnUqdyRUrG8Go=;\n\tb=Ubry4k7UlD4T75GpNR8WqzSNKNnvG3I9vX5I8f7rxEU50eFdbJcfkfddY9rlHx47DftVnGXJmobz2Zq5eZH3zipG0NxMeAhr9g5T2Y9Z/32Khu6bWooAgHmsP0WSHzdl/UJK/4n7IwZW7gcAY6DU+0oMLhXZMdQRz3Sj3R9daUI=","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104546.8582-1-eblake@redhat.com>","From":"Vladimir Sementsov-Ogievskiy ","Message-ID":"","Date":"Mon, 30 Oct 2017 21:01:51 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171027104546.8582-1-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"VI1P18901CA0005.EURP189.PROD.OUTLOOK.COM\n\t(2603:10a6:801::15) To DB6PR0801MB2056.eurprd08.prod.outlook.com\n\t(2603:10a6:4:77::9)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"ad65d947-8f58-4bae-8c1d-08d51fc04e3e","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603199);\n\tSRVR:DB6PR0801MB2056; ","X-Microsoft-Exchange-Diagnostics":["1; DB6PR0801MB2056;\n\t3:SIFWnD9jcIh5QhV4As348drujnHac7ebGRMxA8TwItjQwjF0HcgshoTMSfoXFX81KiuUlk2aeICoeBhNhgoLJGUNi3H1KAe2VHBG7FEfl20P5M/Os+xkpj8FGto9hV+c3+DBtRiwC866cs4lFh78oVYIeFHbGDOkKRrfOM5XPwSguVrEfJ+TXkGfmkicsNExPMUVqJQhNBlV0gb85HF4N6nLZxmHJUK9TtTCjM4HdCA2fypMUIAfWW7RJIOAFK0O;\n\t25:a+0zs0Lny9qIwgylJmH/XANTvu5PwtL38m2Ok5RhUw0vgjf56Td0rRQPKfEs82m2V65pt97skQrc4R4hZjLFyy9bfH/sF3maQomHGiGHClrq+O/rVoNVMtHzqCS5z/lieKTaFXO4lWx9iLaoxzCpbuMQdhGddyn6u6G7Ud8RXUen5xXujNR8OPRPCh0ypIt2953VRRtf+i4enJxeUOwZZ6PMaszC0mKOL2ClTlA0kTf7hZs0QDf7jwfM7c0ad0J9Cp5Tv/8066/FZR337Hq74Kx4O34nCrMjjnYAcJcr4uttHr8rt1f5RUPHBArwxJqjscfcVevBZBgW5EHB+WdwfQ==;\n\t31:3cUxFyYOO4cE0DaFjhcnwV5jn9ymFtSagb+b60bhoy4e8loXA8MeyR6f1+66W7+JLuRkR4SWfpzMtBBhaPGnBoj4m9m5XJSweNccTkfuzM5VR0HCmyM33PNcFrMjnIRU2FPbkivxyivgDXGP95H1/2Nx1iuCHuFP3lPKTruoEksrXWm5J/UK/RFBrvmNflXbwmHyYfGm8hALf+DJ5euDaCGLFBH5YzwAp8R29gRJ6/c=","1; DB6PR0801MB2056;\n\t20:n5wvL3vOQHoUYcNMajmfH69KrM4Kb1pTa6u91Q17mVjFhe6EgQEWKVgXcuwnL1y9JKiKHeP9HnZD5uvNbJxaa7vkHZbyGZ1+BYSwFGJRZhYuot11gz1vzHX276LpcdaGPX0Z0fa9K8jPHL38SbfHsUEj2uvvyfMQLadYFHGWj1l+ni27FR/5kSZn3bj/9WJ4SMaSCO17DVXiGTBX3ycmuRotNm+pSTjbmd+JRqSt97dyGUQFCHJE/iu09QaKqMSfzGRdzGWHozBMlnPs78l/QWYxh7HfwKto5BbgWOplL70EDRhLDA8qJw0s22j04vN2PToFPCbV7LorTFgKWChCBLQixxL2n2draZybJBV+vFpzkVK9jjWHFKo2MSZbXGyTE7C1tg2JabTrXN6Dn+8FI1P+4NYS2r3W0V6dBWc0HoE=;\n\t4:We8V2DFKshMR3hfkkWOfpe6e88j1bl9ojANc0VopJkZoYFazTvQvb9fafZVp/cpkJDy3TrfhDr6p4eA77+iqcmGUKSxscXT68HhNKUxdv0/Fdms078n71x1gGfBzLVvg5mqeJIun8IXinvEFo0cF84Y2oPnF7NjAKH53PcvJeSUWSBzghB1mkzEhcsaLqG/mtle00oUmR6cYUf9VNsz2v/PzOooNeIlEb7s/3In5UiE5nqPwvoVlCe9XCl3kZ+uu","=?utf-8?q?1=3BDB6PR0801MB2056=3B23=3Abm?=\n\t=?utf-8?q?UAiSk5EZtl7GHbwkSprc6HIsO/W8ow3ZF0Ja/iCH439I8+Qz5e1dYobp?=\n\t=?utf-8?q?7aTL0Y1AMBT6tYbOwrykzHHks8JTp9G1hhrfWwIn0awmAt2eTfvk2yro?=\n\t=?utf-8?q?aACAcXTXh+IpJmE3Shcs2vsRNAgLYtuWX2mtdN3lhdj0w5YN9MJpb42C?=\n\t=?utf-8?q?RS65InS1mPIuL+fNUFennnz5Mxp4JMFKOhQJEAGINFKkH8kJxhld5pCU?=\n\t=?utf-8?q?aq0jmfDe6cCSypV5b22rOqKlEpun0P5nj8t+wccocpCIMgA4KFVqeEsX?=\n\t=?utf-8?q?8mVPpGb/+Ao6+JyHWZSZxzWIxhMBX6LmEkMYD6UfseNNXxeCmuKVJRwf?=\n\t=?utf-8?q?OA8UxX3hyHI4Xd2571eEAWh9+VoTOOIdMp/ywFfPWLPPwZuIJIUPs7fG?=\n\t=?utf-8?q?TS9XO0q1etZTqRqkFZHoEeJbwd/KgUcXLmrGrAAFixYULELd4LHXiobc?=\n\t=?utf-8?q?jhgFvYDuFKv5wUgV+AoqGt+GfNb5wfSRRSJUtV9eYAkYMrnVqx1nJaj7?=\n\t=?utf-8?q?LE9LUKSIpx1YvJ5SnE26cbXF3SyZiiUbLncumW6G/6WN5N1d/IO0zaJl?=\n\t=?utf-8?q?9DKiRK4pNQpwBb3IA2/CfsMZnVrUAqHY8xhQYWj/YprFvkUOtnh1G12U?=\n\t=?utf-8?q?2mZTbKBX7aeLMGMip9v1YHTyVwQZEqvSilAMw2wqktOrZHzvPrP/hICy?=\n\t=?utf-8?q?6WX6qE7WLBiO3SMc8xYnnX1GpqQYDQlDMOV7UCpZJaHi2jtGLrB8QcNs?=\n\t=?utf-8?q?lg4rA/UN954gpiju4/LLDSI2YCOuHKLJSjOWyx129fe3N0i0+tcKt1RP?=\n\t=?utf-8?q?dxrz2fIbrZo/gNGn0Rghc7Lwh/d9ebgrgDOIoNxn6z3WKk7kSrpYpmE8?=\n\t=?utf-8?q?1Y9vBc3dcbfIF1kABw/JcaOIRjIUPUhZ83zSvZMDbmaSAGzD70TN8AzA?=\n\t=?utf-8?q?kkkTrrUP0lUEJwtROVmDzKQr9/mTCOjLvrXQrlevzGCMRi4rBI8ujDGR?=\n\t=?utf-8?q?dL9AmSQp0hed7NbD5GAdm9WuLFGrriRQv0xAL4ieCFLziGp8J6I5oqs8?=\n\t=?utf-8?q?gXCmuqLYFlIurnnlL27zOWnA4aaeq5NCRGTBJtbIWX2gkTRhDdqCMfDH?=\n\t=?utf-8?q?X/tSes1liSPRAQRoBw/CHBjIoJVnpnU35+0N9CejvSG2QAzchwvdbCS3?=\n\t=?utf-8?q?i8teUp6Sj+JKMIrgjk1dXB3EH4ziF801rIM0u1kDBLwhJFEwzF5b6rIo?=\n\t=?utf-8?q?ufD4MpZpUaxfnTeG9x+LTR5v2rOWPTUN48WZEemdUkHT8DYrP5hbXRil?=\n\t=?utf-8?q?Gp+gmx9TvkMMPZ+vQZVTJS8OTq79+HaoaOJERK5JfIsmB9qBXif3KjHW?=\n\t=?utf-8?q?gyJ983IPnoHnyqYg4RROrrqoZbr7Sd9N2h32Ceh+lYAyzrFtN2H1kT?=","1; DB6PR0801MB2056;\n\t6:AIHOATy4HzsUSfYniDW3c2pgfEYKun499ZHCXm6KktcpV4EJkMo0/mYQjH4Uc6oiYVqYTmFVMqs3DhBWeH9VtvgPYgQ7bxZgREVIaBjtOpu5SRFEtEVimj/af8Ch1t3cOoaLlbYjVWxcWOF2739wJ8DU+Y6Y1uTWMhfDxWqgZii46j6R1ncK8NEkQVjn52k+Nt0dNzMxTiPBbHgwSGQ/qmBxhlLLHuzR6Zp9iWNcmXuDLYpMi1bj3bPPSGQtDlJouojBRyHMhwpmpfAMKi/crj5OpFHMlU+Le4xzVjspHW/xmGGA1Pvua/T8t8xgeqZzTcXdyLc7fZiVdXiyTBwmqg==;\n\t5:L1UmxTJAHGdEbDBumOD3DiSJya/kfqG9uTb+Y0yyFZpIfHEnbft5MQOwu/hatRIPMZFi0BQfGoZHdvyLVr4s5HSIOGfnWXiChPM4g6hnB42/HN350WLonS8EGxEZ1cqHgz3d67a6btGUQKDNTylz3g==;\n\t24:yd6vlLUc3ur1EPgNQHxngs0XGTuO6BDFxSZYMfoV8FUCQJju9QsZ3a7fiSq+Z/L+rZA0PfCQMCzKC0MB9Fb1dS786p9On0TS03hvovRtT2Y=;\n\t7:6DGfUO85Lro04lBz9gHG72nN56ckeLi+Tw+aKHek+543Sb9BRGB5212csZytb87ILjFUssGavUZjZImSo6ZiLXRLz8xpaz+xARB9nxyVRjWfMa23JckHeAYkzgQuRzoCZSct6gNKVum8ItCjmM0OxSuwUPXOZiC2rZwYu7n7ZfEHDP4saeqcimcdfTf3I0zPXRKCb97URkKWCjms5Ldelppqu+xsWp3UtwHPEH/fKd8=","1; DB6PR0801MB2056;\n\t20:mfM5QVflevsp/nhCfNHcnuUan/jA2s5dWLWJbF89Sf+szR3ddAf9TwqrHltYmMhZSPseN39FuBPIufLVJycFr4+ke+nStYDnRNkngIIZMDrtV82S64UmSlomv7yt7VHHNPJZQZU/BLtuaPtqcDVNEUw6JYnAJLJdzfWEFbAMNjE="],"X-MS-TrafficTypeDiagnostic":"DB6PR0801MB2056:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231020)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0801MB2056; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0801MB2056; ","X-Forefront-PRVS":"0476D4AB88","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(6049001)(39830400002)(346002)(376002)(199003)(189002)(24454002)(229853002)(4326008)(478600001)(25786009)(2950100002)(6116002)(3846002)(230700001)(6666003)(5660300001)(53936002)(6246003)(101416001)(36756003)(65956001)(86362001)(66066001)(23676003)(54906003)(50986999)(54356999)(76176999)(6486002)(77096006)(31696002)(81166006)(8936002)(65806001)(81156014)(47776003)(50466002)(64126003)(16576012)(106356001)(105586002)(31686004)(58126008)(33646002)(97736004)(68736007)(8676002)(65826007)(305945005)(16526018)(2906002)(83506002)(316002)(189998001)(7736002)(217873001);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:DB6PR0801MB2056;\n\tH:[172.16.24.243]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Oct 2017 18:01:54.1728\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"ad65d947-8f58-4bae-8c1d-08d51fc04e3e","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0801MB2056","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.2.120","Subject":"Re: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]