[{"id":1796132,"web_url":"http://patchwork.ozlabs.org/comment/1796132/","msgid":"<60d6e8df-8544-90ad-b4f1-12a6a350fe48@virtuozzo.com>","list_archive_url":null,"date":"2017-10-30T17:55:00","subject":"Re: [Qemu-devel] [PATCH v6 12/12] nbd: Minimal structured read for\n\tclient","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"content":"27.10.2017 13:40, Eric Blake wrote:\n> From: Vladimir Sementsov-Ogievskiy \n>\n> Minimal implementation: for structured error only error_report error\n> message.\n>\n> Note that test 83 is now more verbose, because the implementation\n> prints more warnings about unexpected communication errors; perhaps\n> future patches should tone things down by using trace messages\n> instead of traces, but the common case of successful communication\n> is no noisier than before.\n>\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> Signed-off-by: Eric Blake \n\nok for me, thank you!\n\n>\n> ---\n> v6: tweak overflow check [Vladimir], fix reads to use absolute offset\n> from server by tracking original offset, fix talking to old-style server,\n> tweak iotest 83 output to account for new verbosity\n> v5: fix payload_advance[32,64], return correct negative error on\n> structured error, rearrange size checks to not be vulnerable to\n> overflow, simplify payload to use g_new instead of qemu_memalign,\n> don't set errp when returning 0, validate that error message\n> length is sane\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"hjlmpsb8\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsementsov@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQhwf1nRbz9t2l\n\tfor ;\n\tTue, 31 Oct 2017 04:55:42 +1100 (AEDT)","from localhost ([::1]:41938 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e9EHj-0003JG-3w\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 13:55:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36008)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e9EHK-0003HS-DT\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 13:55:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e9EHJ-0002Iz-J3\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 13:55:14 -0400","from mail-he1eur01on0116.outbound.protection.outlook.com\n\t([104.47.0.116]:23299\n\thelo=EUR01-HE1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e9EHD-0002EV-1L; Mon, 30 Oct 2017 13:55:07 -0400","from [172.16.24.243] (195.214.232.6) by\n\tVI1PR0801MB2061.eurprd08.prod.outlook.com (2603:10a6:800:8b::18) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6;\n\tMon, 30 Oct 2017 17:55:02 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=sA5XGcv0a+GghufwrolsMD6R94w6EuJjaqfZd+Pg39s=;\n\tb=hjlmpsb8/TkZsJ0n1gppiY1hFP0GLQYSMsC6jPiKxu7u69OKlmSZ1N9Dn+BLcmi56fSmHTPu8mDkqj2v1jIkuF2jUa0RmDH5St0/791uVnsNXmxzfr8HMGb+NIitP3lWtLEtuojjmiG5NU98pxkDt6NJooOKOmkj5ojmqJbWd8w=","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104037.8319-13-eblake@redhat.com>","From":"Vladimir Sementsov-Ogievskiy ","Message-ID":"<60d6e8df-8544-90ad-b4f1-12a6a350fe48@virtuozzo.com>","Date":"Mon, 30 Oct 2017 20:55:00 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171027104037.8319-13-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM\n\t(2603:10a6:4:55::23) To VI1PR0801MB2061.eurprd08.prod.outlook.com\n\t(2603:10a6:800:8b::18)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"372a4e6a-4ed0-461d-b42f-08d51fbf5910","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603199);\n\tSRVR:VI1PR0801MB2061; ","X-Microsoft-Exchange-Diagnostics":["1; VI1PR0801MB2061;\n\t3:RXZsrRLmmjZ/aO6DWPAT2AwzIkm6SNmXJNUXH3YE+8VcUAokwALbrKcbK+PHuhvw9ns5drxbqe560wYcezkKf+XaIOLEv+82aizvH7tr9UV/9U1Ckj37Cq+ylkCEvUy3+Ny0K4/hbQFCYxat4hGfkOs5rDpdGBEFAZiffKpmGdnVDSfGOszXudEdj4TfTzbOniWiRcrSpCy1UnewsZEju1m9EkNn7knA5NaoxLnakVSVhfg9TpWDBl3q49VJ7TBF;\n\t25:D1LuqWFoCRfxV4GLtL1oPYaZ1Cz8mFON25wJNAuJRSs+Swc1adHA3qTvavEfzNl8O0TFRtISv6dW5qMJza9x8J3Z22gzuklaTGvBpWXBrLFFUPExaJohYD74z6aLgJcEwfM7RysZDACgyRPYZgYhR3weps48nMPjtL8UKh8mcKfz2KTYuCVXOB4YXsnFSu2qGVFQlFebd2EUD7Y5Qg8SZjdL9019ZJEpaMSJK1AoV7THFhOk1L1dVtx8e43uayOgs+bYpmsDsVJcU5tCIggYlSqEAX195IKKMQ/WaG2CrP4r9mAyVlkcyZqLs8MuzDcmMM4AqYUibNiifTevyn1VfQ==;\n\t31:hie3HH3VaxdV0lkudz3ZLUhZndvg5axXG/jpZ+VTkCGMW+nyzqM9oRABIhWw35ps4lLgglSllLxbL16HT7yS4or0nH+GmiQcNseG42FC+u6A3kml2UeOqXMm97DsaUqzBQG481R4JiEOnGkuHNeQBB2NNPYII8N4iUM7JTouw4W+lvXOXQC2jEx325mLYkvLtwZ3uPpG8VSzz7PEHYvg1Pfn1TCIyu1UinaB4u2yVFs=","1; VI1PR0801MB2061;\n\t20:DnQI6iYoTjor3HHGZqeHVzSqIX9vf4r+e3K9xnJJjFABwVJkcsLVX7qn3p5aEKmPhJFIM2VjrPRNH+vmbIFuDgqa1iO9a4rvhX+xsc4DSC2Gwv6vjcOlx3TNaqOIBeHl8rzTRwGhY7sty0cHAmIA/ohg9NYmeigTkz4BiF5dVD3peGiaK30FBGYMtl4qNXuhkHi8b6WFYwmaqGludysAJJ+BhzFFfzREM7tKRv+lQ0HKoO6Zuy/6CFUKmpjqjFBeK/cY4+pQ2xf/35P3ZBMQwYhtDt6D74Ls2Qu+Wef272UXcOrVN7lqShAHLYZAKYpQZXe1lUyVUEiJbo5x4+tSZUsR+eYDQ19OdgX8wvYsIt5MCxOajhYnX0OJ7ktcl8Ilhiq09xX0zAnby7AsjtuxHD82jArmFAmon4EvtEoSGKE=;\n\t4:90cYAxXGCtSJE+P9sVL/eQI83iIYX1IgweHi1SaxolHpJh2KtoaeiP45F7vvpMhipy4rUT9oRMdRZG84xLAg2Dtwa+Vprp49j27e2KhMcE9ITtzyvx7zEQ5hM9siE5EQ2zR/FPfktXABhvwf6sNL6745orzSEEfYNZ6IT3ZlZWNgnh2sc2gIMSqZKxlfqKs9n3f12nAUnGXnv12sNHxwQmqydIJIht7EQ0XtQSe149tRrpHn1e0Vud/qO2og3F1T8NmZo8t4ECmLDZOU3jOsRIPlOV4h3LdpLtrRUAvOtWunOVHTTM3KqirulO2wu1a8","=?utf-8?q?1=3BVI1PR0801MB2061=3B23=3Aru?=\n\t=?utf-8?q?nIJzvOeEUjYhSbAsdSaAnY9aUXr4PLbMsXELdpJIa+5sj4xJvkMFKyD8?=\n\t=?utf-8?q?iigmY4+7c/iSf3t0SeLveEnldb+8BXC/aSY9OWwaD1Gnz7Ga6hySWakc?=\n\t=?utf-8?q?dp/CaYewKaZV4uJqphK8Hxnn15n80aimT1BUh2A2O12IiLnWBLR/Gtap?=\n\t=?utf-8?q?m8RjbYIem8++QsuA5VpmZAk7Ohf78qAlz6GUe2izo7Fr01UZamh89HNW?=\n\t=?utf-8?q?vnVmH6wnbLqylitStMaJy81Mb7bVbdvs2M4N5qcfFN27rqNUPrLS55HW?=\n\t=?utf-8?q?eOz07mDsO9LmzWUlXToZaLU9TaLj+Z4XVdHreB852gUW4IQ8YlGBGzlh?=\n\t=?utf-8?q?0trJJF9KcVjR1bWOgoYI8FtX1L55xNgmvYxOUuu6Wk4P0/XIK4lLY8n2?=\n\t=?utf-8?q?qut1UDgyCSioNTkdbfYPSU6aNJsA5pnqKYCOVUmPVkdPAWtVjmXEJYFH?=\n\t=?utf-8?q?TBWfbFJMDGmewfNzYaBpnfWcARv7ltj1tnFG9GaOQZIwAFaO3P9LYDkX?=\n\t=?utf-8?q?26jjtFC6RWYv8s/4wyIIVq5DuUQ7yWJ62eSH50wNgUovLVualsV6gxG1?=\n\t=?utf-8?q?snmZILHVdaGwttfU4dUo1daCbY8KondXXp6SrYh+6AGQfYSIChoxwGii?=\n\t=?utf-8?q?9Uv32FRhxGdW1nWEUaeQNJuXoIZPXq4Tyqzq1msh4j5WUZBnhYlyng1/?=\n\t=?utf-8?q?x8Fir76hcUKcJDXOVFTZBLeY012H2taDvYMBLZY+EyrCVhSurIGZWz8X?=\n\t=?utf-8?q?8N/pajmkSdrOmvt4Vuln2pq86//xqbIs86rdpF/NnXhrsQ5isbRGG0q6?=\n\t=?utf-8?q?sxR3Ib9fYcsvnYSXLE64nKzLDAuiAA3iTS2p7ycOtiCIebAx8WNqTWgr?=\n\t=?utf-8?q?/29Mzj5ZSmfLzwdcz9y/MNPGklfUsv2JB3O0k7dahGBABmtN6+BMue0/?=\n\t=?utf-8?q?alOzNSsqv3uAlvCE4Qsuags2F2E8HMK7BNMw/lsFBV5MdZptlFvHBEbn?=\n\t=?utf-8?q?msoPs9ZvaOliuHLyUEwqEMnOL1qTKZiJxArgYDsdl+rrEbRhNtrVpr1Z?=\n\t=?utf-8?q?nh06m9Q0FlL7Q5Pgyi6B2bPcBEEdnmWPQv+o80sN3Wyv6kMtSSnfRdg1?=\n\t=?utf-8?q?oWPCYIh+to2VIYVtU8su36MSTohFhXO42/IdIB20yQF0GP7sftmcfHjq?=\n\t=?utf-8?q?gw/c69mZo0KZOnvjoUFjiFp+thnyOmLeYPzGcF4/6X1W+O2lUErVls1f?=\n\t=?utf-8?q?vTVpRrKJOCsudCUnEUTUgfcMcmIT81uQhqGINUrgWAVrUIxzodxQGA50?=\n\t=?utf-8?q?CQirtpAGxG0Uxp7+oaxVPrGBxF+7jlQWn5pk/o2/nwyeIk1vtIUtjHjT?=\n\t=?utf-8?q?WlyprX9woj+A=3D=3D?=","1; VI1PR0801MB2061;\n\t6:LoqZLfQQV+vIxP5rNteXph/JsR2NN7waKkohvrEKtXBGPL1TPv4WYAcu+EHra49pidVYb/Gk+gS5R9CgmiFbCpDVezS7mBoK4y5e8+FyEAmy4CCsRdI+yhlEbiYPp8hKRJDCNB+gs567aEgyNF8FtPg1TGyRxDx6JwA9atdxAj7/HGDckilPq8rag3g1w6JrU5gAl+qQv3rSJI2upo1c87szy3hl07/BYY2zt1zUiC6sILyENw70leesWnBf6LjABeZyhQaT5HtZmYE7tUBhOtBE9iHuHu3YlUb1o0CGgQ8Tl+LaIcAYknAMmwY29Byi2K4cjNJvlLhh1rEL/2Kf8Ov1mdNF7yZXbBr6Lr9IPuw=;\n\t5:BXz5V28t94VKMccEuN3Pwa2zlmK35GBOZXRqtlSBOsyWN0XcjdKVpyNW1Ommo5jO6WYdkckm9nCBbX7rV3S+tJ136IW/cdG3A8tvxeukx8w5GPd0UiyzgZyFz9vx6lOV3kDNX3vfUUa9OOoqArAPneX9qLkGm2x2GRbDyxatYj0=;\n\t24:kClg8XwRyavMuEwcdS8QeHmcK4V9sOHVPoMnAV/JPBm/jhiRxitdgk1e3CReB8L88/dVvnKxUor0sOz8Uc03bRfpAJHJUKF537LjY8WZvTY=;\n\t7:egVd2EBdobagOrLVAfWhAckV6sM/zC4s5lrsGDeXdCbpEOhXcbrMX1XTZ78/+TvRJXuasLDzCTpq1dIFDkRobhKvGOKIMSTm10jlHJtXzUeuPrcQocecivqv8CCp+u2eiw2TT+s6weR+A4KIoSMymFFUBMoBcrifw+Fj1RWOhQu4mQ3D1uNuSg7CnuziIEpuZvEkcbgFHLzvNetiy9pKR5wu+2GkDZz57HWCUa9t0FNJ2gjLh7tuV7IVzMErvzX0","1; VI1PR0801MB2061;\n\t20:OlgdzUCCzdYEZwesr8zqkaDAXD/2maih0RVH5FuCsLM31AVPS9oln2nwKTL3c6zf36D3q4MCldSvZm1E5ty5JMIFcwu6tmeSpjDtH6QwSMwGjsP/VQCTUOMK2Pner8lAKV4QjUWbbXjDtrDKp6ZimMk23YzYAAsDNcgluDKMbc8="],"X-MS-TrafficTypeDiagnostic":"VI1PR0801MB2061:","X-Exchange-Antispam-Report-Test":"UriScan:(158342451672863);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0801MB2061; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0801MB2061; ","X-Forefront-PRVS":"0476D4AB88","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(6049001)(346002)(376002)(39830400002)(199003)(24454002)(189002)(106356001)(68736007)(50986999)(16526018)(47776003)(3846002)(81156014)(8676002)(8936002)(58126008)(189998001)(101416001)(54906003)(6116002)(76176999)(83506002)(6486002)(5660300001)(54356999)(36756003)(478600001)(105586002)(65806001)(65956001)(229853002)(77096006)(7736002)(33646002)(66066001)(31686004)(50466002)(25786009)(53936002)(86362001)(81166006)(6246003)(64126003)(65826007)(2950100002)(16576012)(97736004)(2906002)(316002)(31696002)(305945005)(4326008)(230700001)(23676003);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0801MB2061;\n\tH:[172.16.24.243]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Oct 2017 17:55:02.7524\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"372a4e6a-4ed0-461d-b42f-08d51fbf5910","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0801MB2061","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.0.116","Subject":"Re: [Qemu-devel] [PATCH v6 12/12] nbd: Minimal structured read for\n\tclient","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]