[{"id":1796393,"web_url":"http://patchwork.ozlabs.org/comment/1796393/","msgid":"<87vaiw2d8o.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-10-31T03:43:51","subject":"Re: [Skiboot] [PATCH] FSP/CONSOLE: Disable notification on\n\tunresponsive consoles","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Vasant Hegde writes:\n> Commit fd6b71fc fixed the situation where ipmi console was open (hvc0) but got\n> data on different console (hvc1).\n>\n> During FSP R/R OPAL closes all consoles. After R/R complete FSP requests to\n> open hvc1 and sends data on this. If hvc1 registration failed or not opened in\n> host kernel then it will not read data and results in RCU stalls.\n>\n> Note that this is workaround for older kernel where we don't have separate irq\n> for each console. Latest kernel works fine without this patch.\n>\n> CC: stable\n> CC: Sam Mendoza-Jonas \n> Signed-off-by: Vasant Hegde \n> ---\n> hw/fsp/fsp-console.c | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n\nMerged to master as of c9cc5ef5772ebfbfff978f1c25763d733e45752c\nand 5.4.x as of d4172005b25f4247d07c2d81deeddd3a323d8b41\n\nHopefully the last in the reset/reload cases around console fun.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQxzY0TDgz9t1G\n\tfor ;\n\tTue, 31 Oct 2017 14:44:09 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yQxzX6Z0QzDqyC\n\tfor ;\n\tTue, 31 Oct 2017 14:44:08 +1100 (AEDT)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yQxzP0dtzzDqwZ\n\tfor ; Tue, 31 Oct 2017 14:44:00 +1100 (AEDT)","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv9V3dU9Y019720\n\tfor ; Mon, 30 Oct 2017 23:43:58 -0400","from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2dxdsxuf9j-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 30 Oct 2017 23:43:58 -0400","from localhost\n\tby e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 30 Oct 2017 23:43:57 -0400","from b01cxnp22036.gho.pok.ibm.com (9.57.198.26)\n\tby e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 30 Oct 2017 23:43:55 -0400","from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com\n\t[9.57.199.106])\n\tby b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v9V3hsYl48955402; Tue, 31 Oct 2017 03:43:54 GMT","from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 461882803E;\n\tMon, 30 Oct 2017 23:43:47 -0400 (EDT)","from birb.localdomain (unknown [9.102.41.178])\n\tby b01ledav001.gho.pok.ibm.com (Postfix) with SMTP id 3F3DA2803A;\n\tMon, 30 Oct 2017 23:43:46 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid AFFF94EC5FD; Tue, 31 Oct 2017 14:43:51 +1100 (AEDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"Vasant Hegde , skiboot@lists.ozlabs.org","In-Reply-To":"<20171027105045.939-1-hegdevasant@linux.vnet.ibm.com>","References":"<20171027105045.939-1-hegdevasant@linux.vnet.ibm.com>","Date":"Tue, 31 Oct 2017 14:43:51 +1100","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17103103-0008-0000-0000-00000298F9A6","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007984; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000239; SDB=6.00938923; UDB=6.00473322;\n\tIPR=6.00719184; \n\tBA=6.00005663; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017801;\n\tXFM=3.00000015; UTC=2017-10-31 03:43:55","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17103103-0009-0000-0000-0000372B0FA5","Message-Id":"<87vaiw2d8o.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-31_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1710310048","Subject":"Re: [Skiboot] [PATCH] FSP/CONSOLE: Disable notification on\n\tunresponsive consoles","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sam@mendozajonas.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1799466,"web_url":"http://patchwork.ozlabs.org/comment/1799466/","msgid":"","list_archive_url":null,"date":"2017-11-06T06:41:10","subject":"Re: [Skiboot] [PATCH] FSP/CONSOLE: Disable notification on\n\tunresponsive consoles","submitter":{"id":22361,"url":"http://patchwork.ozlabs.org/api/people/22361/","name":"Vasant Hegde","email":"hegdevasant@linux.vnet.ibm.com"},"content":"On 10/31/2017 09:13 AM, Stewart Smith wrote:\n> Vasant Hegde writes:\n>> Commit fd6b71fc fixed the situation where ipmi console was open (hvc0) but got\n>> data on different console (hvc1).\n>>\n>> During FSP R/R OPAL closes all consoles. After R/R complete FSP requests to\n>> open hvc1 and sends data on this. If hvc1 registration failed or not opened in\n>> host kernel then it will not read data and results in RCU stalls.\n>>\n>> Note that this is workaround for older kernel where we don't have separate irq\n>> for each console. Latest kernel works fine without this patch.\n>>\n>> CC: stable\n>> CC: Sam Mendoza-Jonas \n>> Signed-off-by: Vasant Hegde \n>> ---\n>> hw/fsp/fsp-console.c | 8 +++++---\n>> 1 file changed, 5 insertions(+), 3 deletions(-)\n>\n> Merged to master as of c9cc5ef5772ebfbfff978f1c25763d733e45752c\n> and 5.4.x as of d4172005b25f4247d07c2d81deeddd3a323d8b41\n>\n> Hopefully the last in the reset/reload cases around console fun.\n>\n\nHope so :-)\n\n-Vasant","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yVjdL4tZbz9s4q\n\tfor ;\n\tMon, 6 Nov 2017 17:41:26 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yVjdL40DBzDrJq\n\tfor ;\n\tMon, 6 Nov 2017 17:41:26 +1100 (AEDT)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yVjdD29ZRzDr8P\n\tfor ; Mon, 6 Nov 2017 17:41:20 +1100 (AEDT)","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tvA66cqA7036638\n\tfor ; Mon, 6 Nov 2017 01:41:17 -0500","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2e2fva5sk7-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 06 Nov 2017 01:41:17 -0500","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tMon, 6 Nov 2017 06:41:15 -0000","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 6 Nov 2017 06:41:13 -0000","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id vA66fCOK35193002; Mon, 6 Nov 2017 06:41:12 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id ABFA2A4057;\n\tMon, 6 Nov 2017 06:36:14 +0000 (GMT)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C90ECA404D;\n\tMon, 6 Nov 2017 06:36:13 +0000 (GMT)","from [9.109.222.221] (unknown [9.109.222.221])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 6 Nov 2017 06:36:13 +0000 (GMT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=hegdevasant@linux.vnet.ibm.com; receiver=)","To":"Stewart Smith , skiboot@lists.ozlabs.org","References":"<20171027105045.939-1-hegdevasant@linux.vnet.ibm.com>\n\t<87vaiw2d8o.fsf@linux.vnet.ibm.com>","From":"Vasant Hegde ","Date":"Mon, 6 Nov 2017 12:11:10 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<87vaiw2d8o.fsf@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17110606-0012-0000-0000-00000589DE4D","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17110606-0013-0000-0000-000019047A41","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-11-06_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1711060093","Subject":"Re: [Skiboot] [PATCH] FSP/CONSOLE: Disable notification on\n\tunresponsive consoles","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sam@mendozajonas.com","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]