[{"id":1796121,"web_url":"http://patchwork.ozlabs.org/comment/1796121/","msgid":"<9445173a-2fe4-1a7a-be2d-3c557575b079@virtuozzo.com>","list_archive_url":null,"date":"2017-10-30T17:32:28","subject":"Re: [Qemu-devel] [PATCH v6 09/12] nbd/client: refactor\n\tnbd_receive_starttls","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"content":"27.10.2017 13:40, Eric Blake wrote:\n> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>\n>\n> Split out nbd_request_simple_option to be reused for structured reply\n> option.\n>\n> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>\n> Signed-off-by: Eric Blake <eblake@redhat.com>\n\n\nok for me.\n\n>\n> ---\n> v6: error message tweak [Vladimir]\n> v5: only check length for ACK responses\n> v4: reduce redundant traces, typo fix in commit message\n> ---","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"dZ2w9EnB\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsementsov@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQhRn0D3jz9rvt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 31 Oct 2017 04:34:13 +1100 (AEDT)","from localhost ([::1]:41863 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e9Dwx-00080H-61\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 13:34:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59577)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <vsementsov@virtuozzo.com>) id 1e9DvT-0007SS-HJ\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 13:32:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <vsementsov@virtuozzo.com>) id 1e9DvS-00076J-OP\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 13:32:39 -0400","from mail-eopbgr50136.outbound.protection.outlook.com\n\t([40.107.5.136]:13968\n\thelo=EUR03-VE1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <vsementsov@virtuozzo.com>)\n\tid 1e9DvO-00070P-2G; Mon, 30 Oct 2017 13:32:34 -0400","from [172.16.24.243] (195.214.232.6) by\n\tHE1PR0801MB2059.eurprd08.prod.outlook.com (2603:10a6:3:51::7) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6;\n\tMon, 30 Oct 2017 17:32:30 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=V0m3ZH9DNRAmtdNrkQ7uEcpcj6m5jDmfcJLfhIDkVFc=;\n\tb=dZ2w9EnBHe10I+2VmTrPp0bwEEFP0nhyd5KRwZdTvqK0WeHj/BNN9IZmfzs90bovwu3qNOD9lM8eEPXzBzX4eEY5TfAcvt32ZshGeVsszAGgXvGk+Ve+bGW//pwn4zoEjR/tJA2em5s5avRDiDCK9GByEe1Xpzwi7+5rHuXvv4c=","To":"Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104037.8319-10-eblake@redhat.com>","From":"Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>","Message-ID":"<9445173a-2fe4-1a7a-be2d-3c557575b079@virtuozzo.com>","Date":"Mon, 30 Oct 2017 20:32:28 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171027104037.8319-10-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"VI1P189CA0011.EURP189.PROD.OUTLOOK.COM\n\t(2603:10a6:802:2a::24) To HE1PR0801MB2059.eurprd08.prod.outlook.com\n\t(2603:10a6:3:51::7)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"7f7db566-da94-4f74-e431-08d51fbc3334","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603199);\n\tSRVR:HE1PR0801MB2059; ","X-Microsoft-Exchange-Diagnostics":["1; HE1PR0801MB2059;\n\t3:GogNN+SDtMGnhyByyhA6FqGC7XAY+ak5iORrCLnDZp/LM70j3SfjJ+yxV8CWtUTUebUC9ZHM6sHKBMKphcXtInIesvK1Q60TKHg8qRe8gnZD23UNYREZphyrXrofZEH5fWFOOzAlOkvsSnarDY0S7+FbOXLQFAN+I7YiZS6b7YDKHAmVDPOaqkHryuSx5MOnEmsQf6gWjDKnEm1tP5xod2OtfTAsfFjbUZbbtXuagZSpQXJ8rkttq55VQ3T0EA8E;\n\t25:Z+S128ghQ5aqsPyX1Tqed1nbg5v6kfeAWNhMoz/2Rx9fH85Xl1SE5vxUBntsbEAKvGDZw+x7Y//OgA88dxdXqbbtyzFmTGsvUTvWIeHS38WG621ufwsH+vkCMPsJbZKXoVbEOWo0A1908nkXHbdEBFZuMmZnJHTS3e8DfLZ1Su113ExkG71zBp+kbqA+/FwuHXUl5ohqVhRs1TdJTJOMThpAPP3KUYScx94Tw87IbPxkd/TOnsrHdfma0skKcjemLUh+51itQBRo68dgEhDQWpsBK79e4XOC+KgLxpY+DfSdLj6I3A1EIHeAJWWx0ezLfoM5yQnqrjB9nL16j82xPA==;\n\t31:yRhse5DHbf14TlS5I+8utAZYe3KQKdn1jeHdP6GCIJwbkztWjKNWr9u3yT4WdPpkDc5Wkl8kpABDYs1OggqS/FiMFsfIp4ytyEKamsl6F2HPd3d+PlHogkjul6E6kd7cMvBt67U5XybEZkRyhNus8sUIEsUiC5FxUs/Q+Z8IIZ6mb84c5OgBN0dP5T46XbOQOTGiwxUXS85DPjb/psMZNqHgV7OU+1J3PRqYB9GlWiA=","1; HE1PR0801MB2059;\n\t20:s7Fg+uyRkIOnTKKvBHctM2wh2N/a8swooYDbYblANEZyJNl0TTU5mFewloNXabheyR6DiJaFjgn1MKk0dKL/Q45gx3O639x6KfiDqYH8tYVQRTRPbURbuPLy7kqnxbxPO3jk9WRjZAG+YCBb8w2KYDX502MUNRfTwWUX9R2VsHMUaI+HQSG2VT2ULu4NkhJj0pOjrSomBj8nU0Dr0NLs4sl5S4ZfGhXAmO4ih2qM9W+57qcUl7qjoORS/Zi3Gd4cOAhHbdReS8u9DiDsb9abVXxFUmWeu/sEPfHo3aetSWeuHM1cmFFKVm0PaHaZeutTVZ97xZSf4Tt4gHsmB6tK79lEgIiGSx1+BF/3tOYQDVQfCrmC3uWg/pA13cVpmUzLU/F5PtIM2o8G9/cWcpdqS6rx1hd4UsggyeG+chLMCBI=;\n\t4:0tXog/iSUbqeMLQFhHnhMEk+caZenrEd2JkdNOl9wfgkg0Hpzq384/T4k/QAPTt+B11dMlhf2BAhY6SYIS1m7lnBlPaAecCj04NKd7Zodkz5i/rx1I4jiJV7srkjs+cbo39ghdETJ0eqicYvnkckl51LuJ1lKmACS7EO+Vf8DwpT7dWb3b99LwhcSb04QvG29Ty/+J83Ol5Wjh2FmmqFpHGrNmHHW0dCnNZueWyUpxrFLk6QobbiBHJdNh0zGXsPz/VCdfSp5wVKAJrnBZrLow==","=?utf-8?q?1=3BHE1PR0801MB2059=3B23=3ADl?=\n\t=?utf-8?q?5kLzkM3K2EO9duyfudYl6kVQRooGS6cZ+3IONMj4hDwg+7ySxaapuxSt?=\n\t=?utf-8?q?ygf03BHUs9tMuOpvhBXFU3TQ6EUCgsHy+5xtuaEo8FBtt0TEDzeSRlJF?=\n\t=?utf-8?q?Oz7aG9eHp/KzE2bWjDn2xZ9b4YGhdeTU7tqR95NpnVlKMOzYWo3d+Xwr?=\n\t=?utf-8?q?hUBrNIMURmi4Vt+9wzhoablcTb7IswIsg0KTKRMU5X761dgMXX91Cr2Y?=\n\t=?utf-8?q?+OAta7eZJxDp58qapDuQp+iYXKFizfSjS/uto8B0L6zGOtlY1L11bp/s?=\n\t=?utf-8?q?5oegc3qIbGAmfVGEsrobSNYTQq52CSoMB3v5LAdKWFFf1bj6mMYUUHjP?=\n\t=?utf-8?q?P5F30Ut5q/V+wE1y70wv/WYrSa4P4kKvjsxiStEpv5GiNv0uFZyaYW7z?=\n\t=?utf-8?q?1ZreyNjJX0AGBoyQFye7XuPQxr0/1F0If04F9l2G22ojhvMg63V8M9km?=\n\t=?utf-8?q?hAE0QksXTsTopWQEUXtC1zmxH6xY3pj+rwOu0xDUTMxhB3b2x2kJGp0f?=\n\t=?utf-8?q?/DYLAINDNJYvK2Ck39OOOiu84rnBiUHHv7I71DkISvAhanDFXRX5Paup?=\n\t=?utf-8?q?NqPQU78bao8K+tfX5r4rCjehJevWdChXqt70TgN36O2xS/oapoDQolKK?=\n\t=?utf-8?q?hyhje1HKHVTrwr5S5lZqnEhFk+uEDC6fXOx4H1GkrWh7lLyy6qiBa6nN?=\n\t=?utf-8?q?A86+48eL4FE/5Pu++DAXcIR2bgofEHNRwpOC0M5jupia4vAM59CMLDLA?=\n\t=?utf-8?q?uiBT7k9c0VELNm84ysf8ipA33wBkKkJvaxCMSL++BYwu7rmaO5827q+B?=\n\t=?utf-8?q?7XTnr/8AHyO2s+PC3U+eRXqzHilI3czW8IOdQ6MAm2OygwrJxMk+kpsb?=\n\t=?utf-8?q?jglEnjkXVv5LK9/WY/c3qR+d585LVSWCH3QswZYry1PEYn0DUGn6HF4I?=\n\t=?utf-8?q?vhUq8UmNmpQRZrxmll6Ya1lpXjOVW7s0PNMIAkcrN/CHVgM6bGLpxDFJ?=\n\t=?utf-8?q?QVSKK/9ZzDB9qiR7p5rSu7RqXg783nSTtrAFefNt30uxaAecfxCAsT6n?=\n\t=?utf-8?q?h3V9uMgi/6i93rzJAL8zovJ4sjt9ApA71j4q6Eu1wkw7jEOxGxbVFS+p?=\n\t=?utf-8?q?Hb4cl5uWCbOuyFjakVC5guESN2JBUjMRbKjRxacPFjtOsmVCrKgfFunf?=\n\t=?utf-8?q?2QzExUBafggmJoIuM/mp51585C+zBDda5CqS99cRQ0RpDRQpDxKlWl0C?=\n\t=?utf-8?q?KRQdgzxAl0wB7QVTglle8rdEHdpvCNeOmfhc0jXQa1FbWDFU7crwIufA?=\n\t=?utf-8?q?Wa3owBbL95ZrFcMKz7M0phT7IHZKZmyx1ethxCcmsIuFye?=","1; HE1PR0801MB2059;\n\t6:bW+X4NA+Friv1B3Rujz9hpQe3malZju1jDSo7WpZS9AMct5CX2jMqtZJFh+QoHU1smjHXdeN8Zjz9yLijAMyg1STyOP0TbBi4XUP2WpgGk0drUOKD4FopuHOnLzooOylC0NS0b3DWib0UOCYb4Bxf1CcdBBThiWk731rFiBBzEFn5nLwGo0TNyfjXbnWQ3coMafilOzvs/YI09ciUVYrsMA+ndRbXR3HJxq1YqwAz+HTjqd25ODHb0vXk4MIfXS+fjEE6IFe4IcxI70OYtNL1K1ovK/Yh/FfeQ8+BFYK6eD5W84zQ/96yFTKWwRvvsa9flAE5J5qEC1e++869xLdGmFe9GFm/POUJaK+udLk7o0=;\n\t5:4gUAg2j37iTWLpJUfYelRA6SYTNt+MMHVp0yXtHIEbR1lSaKoYPTW46F6gKyi8nqjZtoZUgomyyn+ircTzxUuufdzd1pCkxRr5lElmcIy6dYttaJ+pPqoSu4ez1VPKglp5TCkX3UwcSAka8OICbf4I7IpQCGlw2e14LJeG86Zzk=;\n\t24:cRvejltICsDZUuOEORfJ9E/vsey2C92asp0a5kPNVePxLoKdTAmMSRF7KoqZn+tlbpCWXv+/t7066rkUcEpHz+bT+ODx9GoBqUIJOfuj+kw=;\n\t7:O68b5MllR5eYlDIIaD0bMbaYmMCcT4wZjc85sMUTzV27myIXPYGw2i1qRdANgbAXbi1GbyZl98UdF1IxcLMdRv+HeLGD3OA5dPJPh1UjHNAn11HXFAtTdKwt15FhjoaUkieZ+4dh1LDGYLE9m+BnquOjA8SsJ4eCLL3/cWxSXBEierTZnZh6XKCfZyMOQGtSz2rolCN3Vo1LYBBu23OzW4AUUHwLvMjxiWl10dDl7hG8TI2EmZ1hxLKyy74yi9L/","1; HE1PR0801MB2059;\n\t20:hFM4tMjz0gLNkotWx1KQPXRqC1jBS1bESrOObvBW7ygiUbCLIfxataXZ2KZRJELXn2aCaE1hW3RFEjrvytlk6Ff2zGZBrTO9Fl9a6OJNujlfVNsfEYG9IfqKSzAyiQjH0uMyNydZqMC1ruDVTkrGIfrczB0WJ0KhSHXkQ35C5l4="],"X-MS-TrafficTypeDiagnostic":"HE1PR0801MB2059:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<HE1PR0801MB20599EC17000A0542EFB2FB8C1590@HE1PR0801MB2059.eurprd08.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR0801MB2059; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR0801MB2059; ","X-Forefront-PRVS":"0476D4AB88","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(6049001)(376002)(346002)(39830400002)(199003)(189002)(24454002)(8676002)(53936002)(65806001)(36756003)(97736004)(6246003)(50986999)(2906002)(229853002)(81156014)(81166006)(68736007)(7736002)(8936002)(64126003)(6116002)(16526018)(305945005)(6486002)(3846002)(16576012)(33646002)(478600001)(50466002)(31686004)(25786009)(4326008)(101416001)(54356999)(47776003)(105586002)(76176999)(65826007)(66066001)(2950100002)(77096006)(31696002)(230700001)(5660300001)(83506002)(65956001)(189998001)(106356001)(316002)(58126008)(86362001)(23676003);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0801MB2059;\n\tH:[172.16.24.243]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Oct 2017 17:32:30.9960\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"7f7db566-da94-4f74-e431-08d51fbc3334","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR0801MB2059","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"40.107.5.136","Subject":"Re: [Qemu-devel] [PATCH v6 09/12] nbd/client: refactor\n\tnbd_receive_starttls","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"pbonzini@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]