[{"id":1796091,"web_url":"http://patchwork.ozlabs.org/comment/1796091/","msgid":"<7cbeda36-a17d-4a7c-35fd-b56d2b380f79@virtuozzo.com>","list_archive_url":null,"date":"2017-10-30T16:43:15","subject":"Re: [Qemu-devel] [PATCH v6 05/12] nbd/server: Simplify\n\tnbd_negotiate_options loop","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"content":"27.10.2017 13:40, Eric Blake wrote:\n> Instead of making each caller check whether a transmission error\n> occurred, we can sink a common error check to the end of the loop.\n>\n> Signed-off-by: Eric Blake \n\nReviewed-by: Vladimir Sementsov-Ogievskiy ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"ICDOKNaa\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsementsov@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQgL26ZTMz9s7G\n\tfor ;\n\tTue, 31 Oct 2017 03:44:10 +1100 (AEDT)","from localhost ([::1]:41670 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e9DAX-0006f7-0q\n\tfor incoming@patchwork.ozlabs.org; Mon, 30 Oct 2017 12:44:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47566)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e9D9r-0006YO-BT\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 12:43:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e9D9q-000625-Ke\n\tfor qemu-devel@nongnu.org; Mon, 30 Oct 2017 12:43:27 -0400","from mail-eopbgr20090.outbound.protection.outlook.com\n\t([40.107.2.90]:54784\n\thelo=EUR02-VE1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e9D9k-0005wE-TH; Mon, 30 Oct 2017 12:43:21 -0400","from [172.16.24.243] (195.214.232.6) by\n\tVI1PR0801MB2063.eurprd08.prod.outlook.com (2603:10a6:800:8b::20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6;\n\tMon, 30 Oct 2017 16:43:17 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=5AQxjLsUv8XvmlXru5jekrieTcGO8twY5rVX9+0jyBQ=;\n\tb=ICDOKNaa+2QwUq/UylU9aK3EQAnKi0ZCp/5V3fCxbjoqoUK8r8ZoohFIWlbdV+zVbcEFLTtO58WxvslkeWoaJz/wjH8nCeWJACHa0nZSf5NGiLquL5b4UyD7zxaWXxHQAdES5jczuvk9SNHdjqD6Y334kv+uV83jEmLpRdAFH5E=","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20171027104037.8319-1-eblake@redhat.com>\n\t<20171027104037.8319-6-eblake@redhat.com>","From":"Vladimir Sementsov-Ogievskiy ","Message-ID":"<7cbeda36-a17d-4a7c-35fd-b56d2b380f79@virtuozzo.com>","Date":"Mon, 30 Oct 2017 19:43:15 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171027104037.8319-6-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"AM5PR0701CA0002.eurprd07.prod.outlook.com\n\t(2603:10a6:203:51::12) To VI1PR0801MB2063.eurprd08.prod.outlook.com\n\t(2603:10a6:800:8b::20)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"e3cadf09-ead7-485d-ec7b-08d51fb552b8","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603199);\n\tSRVR:VI1PR0801MB2063; ","X-Microsoft-Exchange-Diagnostics":["1; VI1PR0801MB2063;\n\t3:Vbkr+82SQfVXBGdWuBi3/GszVp5tD6o+6+W0iPK6CcHg5i5TlV7NmoPzwIcaNf+7aHvL87UqZNsvH1MBJ+D5ZDBtV0d4GlezAW8/uhNPCSOLWtmnPXAhE2MzAQe8Z6By5+oMKhmGEYaTOoliezVFjKvRPeiUbxeRykHZcaJkDTNNduDZn9e2xyBgYrBFq5oOnQZyjH+ObBb4Xk0G9WyyPNFkNE6D7aT8N9NY79wNwB6R51uvCD9wKp5S9y1fhUr1;\n\t25:O+r3Gj35yLZiY/9SRMRVfWg9mdqSGE0jr8fKwba+n8JbSz403q6VT9D+dob+UXpBbyOibBtLdNnHxl3Z6DKk+B7foZblSCCED3R30KrFQAN3S896yeyUQjlSBo7O956Y3Q+EP2gdpthtenJo4sUI1hZb/rXCMyUSMhyYYkzQpXSJmIOedSCZO7L+IUIhME8lWKwiXHE4LQy4Ekfcn/VebH4VbkHOE5t0LNimUt+dx+bDrZzgRbaM2HOuksjYwGWfqNH3wJzmBTbrRkE+mNiZoylMsuzTDYg0EbVT7KIkSd48bsE7SbcEhkWs7NsGVY92ykLQcWhQzrHgjj3LKGKKdg==;\n\t31:N036eU3HSjQ1nUH2tLrAUzHdlepBpfPppU7pNvHm3g6R2nJsqonxYkA25kinS1AjsT4CyYpyc+96Es4EaFa+S/pw7xXzdtAmM/UI1U198hoy4KSncGgwoU4FJ0J4hBgMnHsCkuKHXL5W75Wvo43U3nNrQ2eLVkHbwSAw0BtYj/4396habCFzUOkpyIDgmoX5xa04O7hSHTTzWM/wMV9n21v3hGJ9yCHtlOUEwXeLnCo=","1; VI1PR0801MB2063;\n\t20:xowyAWYQGgqwwjsuI0G0zzYTOatH5ABzi8VKTbjmdYUWvtSzJ3Wpdyf0mwYtmdKaXYBxv37X1RiC+ndCgiswM9uE2/o6XRNszt27vK3I93rA/7HsFsRsH15ntXvb8HEA5k7sA+ic6sK2YhDbKpjqq06LEH1dJUd/Vcbf+75ZuelLHkgpCZuIcgX1FBWTnRcpp8jAKwp0h1eTogrzVt1I7rVocYwNOV4vdC0EtQzQhgJ8D4l3kpI8nAIdwI6xrcgg4kj5UM9rwt/twPGtgJLxlsOj59f3B+D5dKDr7RZ75K7z5Omn5boDTc1WVnXY+2Cd8rrZr/GVLAUER6ARmX0puKVdAryBpk0QIzBcyqEVi01xgvtl/yeNohbLdyGNZ79UnoIi/I2WSDQnWSLJZdN+NnvQoIQtvxdvtCMln5VdTfI=;\n\t4:hzwJ+HW1Yl8b4luYVfE/WBR0oaaS6B/uGhnVArZQvtj1iQjb5sgUBNU1zax8BdftPyucZLcrNY+8eCw5vWUjyrzlqiHRUfnPtS0JZrGAEzyw8FIWjhyNMIcU//zW43mc+PCndhe45tSGHNNlwy3jsjGrr3DuKXsXMBE7owqjcoaN2wA2vBE7gi4JlFB7HUtSQcPezsC6ZCQFagEsXob4va+hXDqt8ebQlZ32FSogOa1ZmCOCg5AelHNCcXL2ey282znZCJ6xoJ36TtHu0VfJvESHIsUWIlt+gRGFtv8h+y/h9omxE7Es6/sO7J5qC6Ww","=?utf-8?q?1=3BVI1PR0801MB2063=3B23=3Adz?=\n\t=?utf-8?q?UI08fKq5k5RErqqr1PQiKBKwCfUhb3gWfNGv3Fqlr6t2s0fb40C24bmi?=\n\t=?utf-8?q?bWZ0ffD5ed2/x0iMW5PexK84Ae5NiVaK63LZ5UDQW8SQdRFfQjQ4Pctp?=\n\t=?utf-8?q?2CGcl9uwi7viU93zPInskO/S1lMm3139jF7VikU6RwLydKT3MVR9KIwC?=\n\t=?utf-8?q?/jFH19xU68PlZunpD52YFcx3XjWn8zozp+6Z6SssEcv0lWOdjOVSSAOZ?=\n\t=?utf-8?q?7suABkR1O7+FQ8IJ63JGdxqGw473hYD9HOCweYxHlBfRmT9sQdLqW1bR?=\n\t=?utf-8?q?x1cFdg2sLJO+xWGqrjk98a3zxioP13lEX9l20migaIxwqX8YNhA0pb+P?=\n\t=?utf-8?q?zlMXH9BgoYSFQ3drL2eurE80OC8G0rlo+BQDgYKg0Si5qgEDJQ3YX6cF?=\n\t=?utf-8?q?+l2uWbjbamSL9v7E10Mj5KZretd6idbyOk/4kuG4N11/CZ2gZTS9ztmE?=\n\t=?utf-8?q?bR2oQmisQwy2w+F4CS49Zz5b94zHitDqyKYe9wN++rLRDNLeoD1yjDBf?=\n\t=?utf-8?q?gC18eum6GeWqvo1Mxulrre8OYuIVFQpwm01gs8YA56EAkmJE60zfaF+N?=\n\t=?utf-8?q?PW5KfwuOPCI/X88OrXG6r8B1BCCd+hJI2Sp4FUDAVt3BcsAwZMirc6Fd?=\n\t=?utf-8?q?oci9iyi5MzOGMj+ronqWA3fB1jfuZQIuV1y22BFbuAc5Pyp9Ng3/s9Ke?=\n\t=?utf-8?q?FyMA3w7OhhMhVIzHVO/E8d0p87rU7zRfAwmFaBTnx5taR6x9qj4PYLuD?=\n\t=?utf-8?q?YoUskTS79rAr5lnSqdNhF9PMVFUUFrOImZY+xNtHsbGO18hxo9Lb/TV0?=\n\t=?utf-8?q?U8Bt67TrvRKhnm9ZkJlnXDkdgU3N2QVyTrciZmImL6Z/iRfxx0Q+tXgK?=\n\t=?utf-8?q?jj7YWQjUMvhNYZiswU6DgDoT5UZ9pLoSsFF7Ib+hj31YMCztjmhWP4MK?=\n\t=?utf-8?q?r43gcdJ4YzCKGUJ/v84VSludDS4ZkRw5VLCAdrvGuGyg4vbHY8gagTLD?=\n\t=?utf-8?q?LD0f6TthmxFQrkRBaw2ZQ7CKPS23TktspG1X4E57bGOcJ9v/iJNh52Ol?=\n\t=?utf-8?q?fNG58BvEl7rlCoJcvIOs7yIFJlJvwYw8OFaPHuULjgv8GZ4E9Lp/c2OA?=\n\t=?utf-8?q?TrSTJlbP6/NoDcrhDu1fBl8v3H1NN99qf2iWraoigiryvqiZ07pIkeOM?=\n\t=?utf-8?q?iT12iPxRXxiNbPv3i3Aqwx6TxTPJAZR4xLyfzkbzdrlz8gn1GBqbXK+5?=\n\t=?utf-8?q?OdIIUGYsLrYwJXup0R2GGQ41m9eHR4xcs0hvU882ipSbxB/8vy+Kwh83?=\n\t=?utf-8?q?csamlB9BIGvJoUDcEB5UdVCSAWOcxspXCsOcb51gRvTiWu?=","1; VI1PR0801MB2063;\n\t6:zKj/3gziDlw+8WWdGUHTTjjN2g1GJlZM4qFqB+xCMJcH5wZN+mPUwqKIjcjaIRrlMbNj6qJ6kE8Me6i1eQntdw5/m8Ra/CyBdBfkcMUZWSA7qjP5w829c1472iYMBlZiZTPrwyga5YB/hQ25ok8A7meQ8Aob4PCNkEnsnC3v7ZllZds1UPzMy5QTMCB9ySUSviCRCJEny1wOvqHBh7a3nacISb9h56yss9CCkRxKt2F1Q/gr7x9z9ofNjt05Ne66m9PN3t7Hx0yDhqsJBZKeh/gHObgbtZj7ocLLBcs2L6Q4Zhe3g5oeEcuSCCdyvJaKM5xxM1ZlQtmd/jyoGqp3unDWLoiI0BAmtvY0O+dzA3k=;\n\t5:TaaaGrgRUr5Dvk88ng0cNpNXii+ZW1hPGV3c6H7/4XVXMfWMpaiUGo0P34LSi1+npxJT576m7UT5sGlc/hI7Ucdfqh3jCQ675Bqi/b274kgXkFbZ5hpDRIGdMhqgYzcsXYqEJsEN/VcV2nexr65zW91dr79gsu7OOdxZYp6g8mc=;\n\t24:YsrgvASL6vFoOcJ7WG2BgscG4XiVIdqWFWtkfgh8cO/A6mGxu3RE5dJiu9z5b9blb+0EpBJITqqgFXkSiUv0sK7XZrAgOi054E26it4hukU=;\n\t7:EeEw1cvp9F+HbQinSQMeje6IQ8AVvplni42G8/KU9kVkUn4JQvHniFpeIWZmpoFKdI2NbYbyleF3u6ZlQ7mLSJkZ9/4SxCav54Awp8MdSMw1f00jJy/jwPHIWhd3gqNt2kXuVEPnM05Ur19PpmkaCgpJ7ifbsOdSDwaHaIslOZy+Ob5dnH5MBsZetVohoYAu8gZNJYE9PkMoP/h6yxds69+pwKIjUEfRq2xXu8WQ3K9r7Y7NAYAaNbj07/pRLB7J","1; VI1PR0801MB2063;\n\t20:4jyb8/Yuvruh2TryVLkCkk7LGvGup22itiV+un+FrSkJbV7uydfGhKL1XagFdlqIeXW/bRlxDGPGtuJOKlK04FssLAP4oZZyz0XOc1w3bDBS/t/7HfeSo96MMa1wAQLiwLa3Fmy0w+Hsv+hnot7s3872z00TkZJgW8vKoQFw8so="],"X-MS-TrafficTypeDiagnostic":"VI1PR0801MB2063:","X-Exchange-Antispam-Report-Test":"UriScan:(158342451672863);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0801MB2063; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0801MB2063; ","X-Forefront-PRVS":"0476D4AB88","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(6049001)(376002)(346002)(39830400002)(189002)(24454002)(199003)(66066001)(65806001)(8936002)(4326008)(7736002)(36756003)(54356999)(316002)(97736004)(76176999)(50986999)(478600001)(6116002)(230700001)(16526018)(6486002)(58126008)(23676003)(31686004)(25786009)(6246003)(229853002)(3846002)(77096006)(83506002)(31696002)(81156014)(65826007)(5660300001)(305945005)(2950100002)(53936002)(8676002)(81166006)(101416001)(33646002)(16576012)(86362001)(50466002)(68736007)(105586002)(2906002)(106356001)(189998001)(65956001)(47776003)(64126003);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0801MB2063;\n\tH:[172.16.24.243]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Oct 2017 16:43:17.4716\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"e3cadf09-ead7-485d-ec7b-08d51fb552b8","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0801MB2063","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"40.107.2.90","Subject":"Re: [Qemu-devel] [PATCH v6 05/12] nbd/server: Simplify\n\tnbd_negotiate_options loop","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]