[{"id":1794732,"web_url":"http://patchwork.ozlabs.org/comment/1794732/","msgid":"<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>","list_archive_url":null,"date":"2017-10-27T09:32:42","subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","submitter":{"id":71804,"url":"http://patchwork.ozlabs.org/api/people/71804/","name":"Yunsheng Lin","email":"linyunsheng@huawei.com"},"content":"Hi, Dan\n\nOn 2017/10/27 14:40, Dan Carpenter wrote:\n> There are several places where we accidentally return success when\n> kcalloc() fails.\n> \n> Fixes: fcb39f6c10b2 (\"qed: Add mpa buffer descriptors for storing and processing mpa fpdus\")\n> Signed-off-by: Dan Carpenter \n> \n> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> index 409041eab189..6366f2ef82b7 100644\n> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> @@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> \tstruct qed_ll2_cbs cbs;\n> \tu32 mpa_buff_size;\n> \tu16 n_ooo_bufs;\n> -\tint rc = 0;\n> +\tint rc;\n> \tint i;\n> \n> \tiwarp_info = &p_hwfn->p_rdma_info->iwarp;\n> @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> \tif (rc)\n> \t\tgoto err;\n> \n> +\trc = -ENOMEM;\n> \tiwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n> \t\t\t\t\t sizeof(*iwarp_info->partial_fpdus),\n> \t\t\t\t\t GFP_KERNEL);\n\nDoes the memory allocated here need to be freed when error happens below?\n\n\n> @@ -2724,7 +2725,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> \tfor (i = 0; i < data.input.rx_num_desc; i++)\n> \t\tlist_add_tail(&iwarp_info->mpa_bufs[i].list_entry,\n> \t\t\t &iwarp_info->mpa_buf_list);\n> -\treturn rc;\n> +\treturn 0;\n> err:\n> \tqed_iwarp_ll2_stop(p_hwfn, p_ptt);\n> \n> \n> .\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNdwf0pl0z9t2h\n\tfor ;\n\tFri, 27 Oct 2017 20:33:38 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752218AbdJ0Jd1 (ORCPT );\n\tFri, 27 Oct 2017 05:33:27 -0400","from szxga05-in.huawei.com ([45.249.212.191]:9520 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752351AbdJ0JdX (ORCPT\n\t); Fri, 27 Oct 2017 05:33:23 -0400","from 172.30.72.60 (EHLO DGGEMS401-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DJZ82578; Fri, 27 Oct 2017 17:33:10 +0800 (CST)","from [127.0.0.1] (10.74.191.121) by DGGEMS401-HUB.china.huawei.com\n\t(10.3.19.201) with Microsoft SMTP Server id 14.3.361.1;\n\tFri, 27 Oct 2017 17:32:43 +0800"],"Subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","To":"Dan Carpenter ,\n\tAriel Elior ","CC":", ,\n\t, ","References":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","From":"Yunsheng Lin ","Message-ID":"<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>","Date":"Fri, 27 Oct 2017 17:32:42 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.74.191.121]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020204.59F2FD56.00A9, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"27f9b5470a448e43e3b2556607b662f1","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794797,"web_url":"http://patchwork.ozlabs.org/comment/1794797/","msgid":"<20171027115252.hhqc2u6zrn5b4uet@mwanda>","list_archive_url":null,"date":"2017-10-27T11:52:52","subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"content":"On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote:\n> Hi, Dan\n> \n> On 2017/10/27 14:40, Dan Carpenter wrote:\n> > There are several places where we accidentally return success when\n> > kcalloc() fails.\n> > \n> > Fixes: fcb39f6c10b2 (\"qed: Add mpa buffer descriptors for storing and processing mpa fpdus\")\n> > Signed-off-by: Dan Carpenter \n> > \n> > diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> > index 409041eab189..6366f2ef82b7 100644\n> > --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> > +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> > @@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> > \tstruct qed_ll2_cbs cbs;\n> > \tu32 mpa_buff_size;\n> > \tu16 n_ooo_bufs;\n> > -\tint rc = 0;\n> > +\tint rc;\n> > \tint i;\n> > \n> > \tiwarp_info = &p_hwfn->p_rdma_info->iwarp;\n> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> > \tif (rc)\n> > \t\tgoto err;\n> > \n> > +\trc = -ENOMEM;\n> > \tiwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n> > \t\t\t\t\t sizeof(*iwarp_info->partial_fpdus),\n> > \t\t\t\t\t GFP_KERNEL);\n> \n> Does the memory allocated here need to be freed when error happens below?\n> \n\nHm... I think you're right that it leaks. Also I'm confused by the\nqed_iwarp_ll2_alloc_buffers() allocation. The comment in there says\nthat /* buffers will be deallocated by qed_ll2 */ but qed_ll2 is not\na function name or something which is useful to grep.\n\nregards,\ndan carpenter","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNj1r5Cwnz9t2W\n\tfor ;\n\tFri, 27 Oct 2017 22:53:20 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752547AbdJ0LxJ (ORCPT );\n\tFri, 27 Oct 2017 07:53:09 -0400","from aserp1040.oracle.com ([141.146.126.69]:39897 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752190AbdJ0LxH (ORCPT\n\t); Fri, 27 Oct 2017 07:53:07 -0400","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v9RBr0eH001314\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 27 Oct 2017 11:53:00 GMT","from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v9RBqx5K016943\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 27 Oct 2017 11:53:00 GMT","from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv9RBqxwG026921; Fri, 27 Oct 2017 11:52:59 GMT","from mwanda (/129.205.6.86)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Fri, 27 Oct 2017 04:52:58 -0700"],"Date":"Fri, 27 Oct 2017 14:52:52 +0300","From":"Dan Carpenter ","To":"Yunsheng Lin ","Cc":"Ariel Elior , everest-linux-l2@cavium.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org","Subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","Message-ID":"<20171027115252.hhqc2u6zrn5b4uet@mwanda>","References":"<20171027064020.aq52ue4kfp5htrb5@mwanda>\n\t<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795198,"web_url":"http://patchwork.ozlabs.org/comment/1795198/","msgid":"","list_archive_url":null,"date":"2017-10-28T05:50:25","subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","submitter":{"id":71804,"url":"http://patchwork.ozlabs.org/api/people/71804/","name":"Yunsheng Lin","email":"linyunsheng@huawei.com"},"content":"Hi, Dan\n\nOn 2017/10/27 19:52, Dan Carpenter wrote:\n> On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote:\n>> Hi, Dan\n>>\n>> On 2017/10/27 14:40, Dan Carpenter wrote:\n>>> There are several places where we accidentally return success when\n>>> kcalloc() fails.\n>>>\n>>> Fixes: fcb39f6c10b2 (\"qed: Add mpa buffer descriptors for storing and processing mpa fpdus\")\n>>> Signed-off-by: Dan Carpenter \n>>>\n>>> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n>>> index 409041eab189..6366f2ef82b7 100644\n>>> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n>>> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n>>> @@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n>>> \tstruct qed_ll2_cbs cbs;\n>>> \tu32 mpa_buff_size;\n>>> \tu16 n_ooo_bufs;\n>>> -\tint rc = 0;\n>>> +\tint rc;\n>>> \tint i;\n>>> \n>>> \tiwarp_info = &p_hwfn->p_rdma_info->iwarp;\n>>> @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n>>> \tif (rc)\n>>> \t\tgoto err;\n>>> \n>>> +\trc = -ENOMEM;\n>>> \tiwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n>>> \t\t\t\t\t sizeof(*iwarp_info->partial_fpdus),\n>>> \t\t\t\t\t GFP_KERNEL);\n>>\n>> Does the memory allocated here need to be freed when error happens below?\n>>\n> \n> Hm... I think you're right that it leaks. Also I'm confused by the\n> qed_iwarp_ll2_alloc_buffers() allocation. The comment in there says\n> that /* buffers will be deallocated by qed_ll2 */ but qed_ll2 is not\n> a function name or something which is useful to grep.\n\nYes, I am confused by it too.\n\nEven in qed_iwarp_ll2_alloc_buffers, if kzcalloc failed, it do not clean\nup the memory allocated by pre kzcalloc.\n\n> \n> regards,\n> dan carpenter\n> \n> \n> .\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yP8z34DRKz9t2S\n\tfor ;\n\tSat, 28 Oct 2017 16:52:31 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751390AbdJ1FwV (ORCPT );\n\tSat, 28 Oct 2017 01:52:21 -0400","from szxga04-in.huawei.com ([45.249.212.190]:9464 \"EHLO\n\tszxga04-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750962AbdJ1FwT (ORCPT\n\t); Sat, 28 Oct 2017 01:52:19 -0400","from 172.30.72.58 (EHLO DGGEMS403-HUB.china.huawei.com)\n\t([172.30.72.58])\n\tby dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DJX79401; Sat, 28 Oct 2017 13:52:04 +0800 (CST)","from [127.0.0.1] (10.74.191.121) by DGGEMS403-HUB.china.huawei.com\n\t(10.3.19.203) with Microsoft SMTP Server id 14.3.361.1;\n\tSat, 28 Oct 2017 13:50:25 +0800"],"Subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","To":"Dan Carpenter ","CC":"Ariel Elior ,\n\t, ,\n\t, ","References":"<20171027064020.aq52ue4kfp5htrb5@mwanda>\n\t<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>\n\t<20171027115252.hhqc2u6zrn5b4uet@mwanda>","From":"Yunsheng Lin ","Message-ID":"","Date":"Sat, 28 Oct 2017 13:50:25 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20171027115252.hhqc2u6zrn5b4uet@mwanda>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.74.191.121]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020203.59F41B05.007E, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"3a41fa2fd15a165605ee6e90292287c9","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795394,"web_url":"http://patchwork.ozlabs.org/comment/1795394/","msgid":"","list_archive_url":null,"date":"2017-10-29T07:45:23","subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","submitter":{"id":69904,"url":"http://patchwork.ozlabs.org/api/people/69904/","name":"Michal Kalderon","email":"Michal.Kalderon@cavium.com"},"content":"From: Dan Carpenter \nSent: Friday, October 27, 2017 2:52 PM\n\n>On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote:\n>> > iwarp_info = &p_hwfn->p_rdma_info->iwarp;\n>> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n>> > if (rc)\n>> > goto err;\n>> >\n>> > + rc = -ENOMEM;\n>> > iwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n>> > sizeof(*iwarp_info->partial_fpdus),\n>> > GFP_KERNEL);\n>>\n>> Does the memory allocated here need to be freed when error happens below?\n>>\n>\n>Hm... I think you're right that it leaks. Also I'm confused by the\n>qed_iwarp_ll2_alloc_buffers() allocation. The comment in there says\n>that /* buffers will be deallocated by qed_ll2 */ but qed_ll2 is not\n>a function name or something which is useful to grep.\n\nThanks Dan, partial_fpdus is released during qed_iwarp_resc_free, called from qed_rdma_resc_free\ncalled on qed_rdma_stop and on failure during qed_rdma_start.\nRegarding ll2 buffers. For each successfully allocated buffer we call\nqed_iwarp_ll2_post_rx->qed_ll2_post_rx_buffer.\nThese buffers will get released and freed when we call qed_ll2_terminate_connection\ncalled from qed_iwarp_ll2_stop ( which is called during qed_iwarp_ll2_start on error ).\nthanks,\nMichal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"BbsOytHW\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Michal.Kalderon@cavium.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPqRB148kz9rxl\n\tfor ;\n\tSun, 29 Oct 2017 18:45:42 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751540AbdJ2Hp3 (ORCPT );\n\tSun, 29 Oct 2017 03:45:29 -0400","from mail-bn3nam01on0042.outbound.protection.outlook.com\n\t([104.47.33.42]:19904\n\t\"EHLO NAM01-BN3-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750928AbdJ2Hp0 (ORCPT );\n\tSun, 29 Oct 2017 03:45:26 -0400","from CY1PR0701MB2012.namprd07.prod.outlook.com (10.163.142.11) by\n\tCY1PR0701MB1338.namprd07.prod.outlook.com (10.160.150.141) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6;\n\tSun, 29 Oct 2017 07:45:24 +0000","from CY1PR0701MB2012.namprd07.prod.outlook.com ([10.163.142.11]) by\n\tCY1PR0701MB2012.namprd07.prod.outlook.com ([10.163.142.11]) with mapi\n\tid 15.20.0178.011; Sun, 29 Oct 2017 07:45:23 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=AwDJNQ+dV4vu23gqwZnGGVeme/eLm6h3/Rm5st50X/o=;\n\tb=BbsOytHWgPnMgwra3UyEuMB2fQsOC5d+sRXMp/BQsMv85YbCHcGGeMwrY2+wlL4vYlf0aLYFxROhQqq3URUABHx/1PaMq2BqQUiV2WPlZjl4n3zvKdkrmDau3edzjB+X2JJz85hCMqdPZgrp/rMq8q486pI8QUWBiK+fos5chqU=","From":"\"Kalderon, Michal\" ","To":"Dan Carpenter ,\n\tYunsheng Lin ","CC":"\"Elior, Ariel\" ,\n\tDept-Eng Everest Linux L2 ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" ","Subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","Thread-Topic":"[PATCH net-next] qed: Set error code for allocation failures","Thread-Index":"AQHTTu587uCXVOC9tkul0P7kKFBRbqL3bzYAgAAnKQCAAt3Usg==","Date":"Sun, 29 Oct 2017 07:45:23 +0000","Message-ID":"","References":"<20171027064020.aq52ue4kfp5htrb5@mwanda>\n\t<9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>,\n\t<20171027115252.hhqc2u6zrn5b4uet@mwanda>","In-Reply-To":"<20171027115252.hhqc2u6zrn5b4uet@mwanda>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[109.67.96.88]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; CY1PR0701MB1338;\n\t6:eAKiL4VI0RdmrN+wQcByHLy2pX56GhekKOOSmei3pLXhwPGModWOudRjp9IjM8jJmgOqXspXDmg+ULLcBOuig9wUCp7hkUgaWCf0xl54wqMCvoBpO5S8gV5ckelssP/+A1cYgeoGXhS06IhcHQw4EeA/qzvBtmFYtaEMS2b5S4PmkU6rDKFcqy3jkC2YyylbwPZzM/4WAu56h5yX+3RHkrkkDPm512Mz4E9AJ1V8AxJELh3p9MmMDMSrw00U5eGoOiGduhYFD9zLO6YAQmKO56RVtAQNpV7/DYqbihs75ICIzu0HSQdXSzsgOiqhp5JYUtHAiKxZNkDrCds9WexQmeLaBpQTKThk+8KJBWLBBY4=;\n\t5:qPwTbLVtogVJsE3Ht+2Big2NrLwD5JKLyQlqRrZ+fCr2qKFxjG59zp6D+I5z62EfT/Tc2++WIR8g9NQm3GwjNtR4nCpxWhSlGv5J1UUdg9MKGEGom58eXjtSJa+EAuA50Hj07X/Syi9J89s/EC5ODwVR4um5h4/ma2viCfaUQQc=;\n\t24:crwpBw8jq5sDdPEW//rB+XhJHGJ/PptfAVKgfkjBlBS8phJkUrjT/NaFqS/G04qqL/NrvEnvldI24jV6VZxK3GnAuD25kkDsK6S65+rpNqY=;\n\t7:sf+cryXL7Kck5E53v+PXsUErM2nNq3T8iRZtELNtEC8vMH8xjcYtVuLv6Se7kHogwdkufCXaYSYHHKBVOlHUYYI9YscOmPVwOI+xymJhuNd4Cgm/GufkIX+quP9mkwCPr4gxbs8XD8iirpKKNeQfdCUCrR3yppZPfkx4xHHqLDvnNVYPU/ldyMCQRfpBpTzvyt1beXvNQJHIV1QMz4YOqSYBfuosB0C+oy2wrjSBLn46NjUkI7fu7i2QhyNKM2ev","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-ms-office365-filtering-correlation-id":"e2e9681f-2168-45d7-5444-08d51ea10375","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603238);\n\tSRVR:CY1PR0701MB1338; ","x-ms-traffictypediagnostic":"CY1PR0701MB1338:","x-exchange-antispam-report-test":"UriScan:(146099531331640);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231020)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY1PR0701MB1338; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY1PR0701MB1338; ","x-forefront-prvs":"0475418F50","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(24454002)(189002)(199003)(97736004)(101416001)(105586002)(76176999)(50986999)(106356001)(4326008)(25786009)(33656002)(6246003)(8676002)(7736002)(229853002)(6116002)(3846002)(102836003)(7696004)(2950100002)(305945005)(54356999)(3660700001)(3280700002)(110136005)(2906002)(5660300001)(54906003)(74316002)(68736007)(8936002)(81166006)(6436002)(189998001)(6506006)(77096006)(66066001)(99286003)(81156014)(478600001)(53936002)(14454004)(316002)(72206003)(9686003)(86362001)(2900100001)(55016002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1338;\n\tH:CY1PR0701MB2012.namprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"BbsOytHW\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Michal.Kalderon@cavium.com; "],"spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"e2e9681f-2168-45d7-5444-08d51ea10375","X-MS-Exchange-CrossTenant-originalarrivaltime":"29 Oct 2017 07:45:23.7663\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY1PR0701MB1338","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795396,"web_url":"http://patchwork.ozlabs.org/comment/1795396/","msgid":"","list_archive_url":null,"date":"2017-10-29T07:50:06","subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","submitter":{"id":69904,"url":"http://patchwork.ozlabs.org/api/people/69904/","name":"Michal Kalderon","email":"Michal.Kalderon@cavium.com"},"content":"From: Dan Carpenter \nSent: Friday, October 27, 2017 9:40 AM\n\n> There are several places where we accidentally return success when\n> kcalloc() fails.\n> \n> Fixes: fcb39f6c10b2 (\"qed: Add mpa buffer descriptors for storing and processing mpa fpdus\")\n> Signed-off-by: Dan Carpenter \n>\n> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> index 409041eab189..6366f2ef82b7 100644\n> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n> @@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> struct qed_ll2_cbs cbs;\n> u32 mpa_buff_size;\n> u16 n_ooo_bufs;\n> - int rc = 0;\n> + int rc;\n> int i;\n> \n> iwarp_info = &p_hwfn->p_rdma_info->iwarp;\n> @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> if (rc)\n> goto err;\n> \n> + rc = -ENOMEM;\n> iwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n> sizeof(*iwarp_info->partial_fpdus),\n> GFP_KERNEL);\n> @@ -2724,7 +2725,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n> for (i = 0; i < data.input.rx_num_desc; i++)\n> list_add_tail(&iwarp_info->mpa_bufs[i].list_entry,\n> &iwarp_info->mpa_buf_list);\n> - return rc;\n> + return 0;\n> err:\n> qed_iwarp_ll2_stop(p_hwfn, p_ptt);\n\nThanks Dan,\nAcked-by: Michal Kalderon ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"dWpu03nW\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Michal.Kalderon@cavium.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPqXc5VJjz9sxR\n\tfor ;\n\tSun, 29 Oct 2017 18:50:24 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751799AbdJ2HuN (ORCPT );\n\tSun, 29 Oct 2017 03:50:13 -0400","from mail-bn3nam01on0051.outbound.protection.outlook.com\n\t([104.47.33.51]:54739\n\t\"EHLO NAM01-BN3-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750928AbdJ2HuI (ORCPT );\n\tSun, 29 Oct 2017 03:50:08 -0400","from CY1PR0701MB2012.namprd07.prod.outlook.com (10.163.142.11) by\n\tCY1PR0701MB1338.namprd07.prod.outlook.com (10.160.150.141) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6;\n\tSun, 29 Oct 2017 07:50:06 +0000","from CY1PR0701MB2012.namprd07.prod.outlook.com ([10.163.142.11]) by\n\tCY1PR0701MB2012.namprd07.prod.outlook.com ([10.163.142.11]) with mapi\n\tid 15.20.0178.011; Sun, 29 Oct 2017 07:50:06 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=BZ5oQjStpMzjd/30a5gBO82Ry8K/BgwWXnNCOYTMBlI=;\n\tb=dWpu03nWckU19vKnW80sYpUmWKnmpAoC/Cs9LFOh91QQyVp+twCnjqRSfL1ESM6I9UvRsmCbDkv8E0YLRiYjcRJut+9zSqsbQhdUh02zfVHBvNJOc47ZgKqavjQ6KNvlhDtNGCDUJcL7+caZIw3KIUN7oA9H/3p76nQgM2I4yEw=","From":"\"Kalderon, Michal\" ","To":"Dan Carpenter ,\n\t\"Elior, Ariel\" ","CC":"Dept-Eng Everest Linux L2 ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" ","Subject":"Re: [PATCH net-next] qed: Set error code for allocation failures","Thread-Topic":"[PATCH net-next] qed: Set error code for allocation failures","Thread-Index":"AQHTTu587uCXVOC9tkul0P7kKFBRbqL6df6y","Date":"Sun, 29 Oct 2017 07:50:06 +0000","Message-ID":"","References":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","In-Reply-To":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[109.67.96.88]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; CY1PR0701MB1338;\n\t6:6E+qShMQD5rlLMqeLcEGGFHIZswSkec7P/EqAjSY/pdFhi0K17ggPNGahfCjBLljPJGx4szn1/fSt+aklug5fQHt64BV+ZOtPpanwb9ZcyfbzL9fKg3HIBR9a32wfO+3WLrm5pw1QtMnzFdBbxW7otTFhH+0zf6jSlu64oyIwKY10lj7wfZU1Y6DF/FhGtT7aGesyVypNAqIMNb/2xH5jOzOxGT9VH0osSQvlnj9Gw4wwVMcC96itJIrrxzkuAQATGIsMdeKudEI1t8mrxUAHKzK3WNA/3l7WMAQjdrh1oA6PbxCDzlbwmGwBfQXpfwFIoC5JYmk3fgHcq+9a6+iyjgJnuJqkZFnvZF0DJ7wJTc=;\n\t5:Zr/sm/feyB16EU4YDT1d6mCVOvBCm9fZn3gGWRlySJZfVgUpn9TxZsMdCwE4Tb6Grzh4XfXjWmChhsR/paL0jAhBg86W6dsTewtuSlk+N/oEduYmGGQFyuk7OzP80D3+2qjgzqdjlqRAR52CMe4a73kKvvJGg8Jt6XRW+ip9fSw=;\n\t24:IkLh+Dx1Wi/8tsY9UDoZUUORH52HD0OATKCdOStOKWL1BdqOmlT6WReypLf0Z1X71NixuDlLW7WUJ60jjM4rvFpHfXh+3r1fn18QqO+dzLs=;\n\t7:Ej7qsUBJEI2lyRT4MevvhEA9tYceToIlJ5usQy9RuZX4FTL3cjKpnb4pVTVhtbyGBp6SJbhIvL5ho0+BvjoOv5KVUiVEuyJfp6GQ78Y06g4CbyHMKj2OXbFHN2ddkJsxyNSaf3l0yQsihuoU0hxKl5rupfbfP8su7rsN92rfIS75S48jOCZVFU7Tl9Rb+FrWqIO4g6Z0SHYbranFOizhuQMfZhPf4+snRkPS9It3A69o+HrIf+wuAzh+nFqkZXIF","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-ms-office365-filtering-correlation-id":"0cbe86cc-222f-4245-c2bb-08d51ea1abc8","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(4534020)(4602075)(2017052603238);\n\tSRVR:CY1PR0701MB1338; ","x-ms-traffictypediagnostic":"CY1PR0701MB1338:","x-exchange-antispam-report-test":"UriScan:(146099531331640);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231020)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY1PR0701MB1338; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY1PR0701MB1338; ","x-forefront-prvs":"0475418F50","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(189002)(199003)(97736004)(101416001)(105586002)(6636002)(76176999)(50986999)(106356001)(4326008)(25786009)(33656002)(6246003)(8676002)(7736002)(229853002)(6116002)(3846002)(102836003)(7696004)(2950100002)(305945005)(54356999)(3660700001)(3280700002)(110136005)(2906002)(5660300001)(54906003)(74316002)(68736007)(8936002)(81166006)(6436002)(189998001)(6506006)(77096006)(66066001)(99286003)(81156014)(478600001)(53936002)(14454004)(316002)(72206003)(9686003)(86362001)(2900100001)(55016002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1338;\n\tH:CY1PR0701MB2012.namprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"dWpu03nW\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Michal.Kalderon@cavium.com; "],"spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"0cbe86cc-222f-4245-c2bb-08d51ea1abc8","X-MS-Exchange-CrossTenant-originalarrivaltime":"29 Oct 2017 07:50:06.2328\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY1PR0701MB1338","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]