[{"id":1794911,"web_url":"http://patchwork.ozlabs.org/comment/1794911/","msgid":"<20171027143844.uxhl3vbzacvv3z4j@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-27T14:38:44","subject":"Re: [PATCH v2 1/3] dt-bindings: mailbox: Introduce Hi3660 controller\n\tbinding","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Oct 27, 2017 at 02:15:02PM +0800, Kaihua Zhong wrote:\n> From: Leo Yan \n> \n> Introduce a binding for the Hi3660 mailbox controller, the mailbox is\n> used within application processor (AP), communication processor (CP),\n> HIFI and MCU, etc.\n> \n> Cc: John Stultz \n> Cc: Guodong Xu \n> Cc: Haojian Zhuang \n> Cc: Niranjan Yadla \n> Cc: Raj Pawate \n> Signed-off-by: Leo Yan \n> ---\n> .../bindings/mailbox/hisilicon,hi3660-mailbox.txt | 52 ++++++++++++++++++++++\n> 1 file changed, 52 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> \n> diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> new file mode 100644\n> index 0000000..8a8d7e1\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> @@ -0,0 +1,52 @@\n> +Hisilicon Hi3660 Mailbox Driver\n\nBindings are for h/w, not drivers.\n\n> +\n> +Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages\n> +are passed between processors, including application & communication\n> +processors, MCU, HIFI, etc. Each channel is unidirectional and accessed\n> +by using MMIO registers; it supports maximum to 8 words message.\n> +\n> +Controller\n> +----------\n> +\n> +Required properties:\n> +- compatible:\t\t: Shall be \"hisilicon,hi3660-mbox\"\n> +- reg:\t\t\t: Offset and length of the device's register set\n> +- #mbox-cells:\t\t: Must be 3\n> +\t\t\t <&phandle channel dst_irq ack_irq>\n> +\t\t\t phandle\t: Label name of controller\n> +\t\t\t channel\t: Channel number\n> +\t\t\t dst_irq\t: Remote interrupt vector\n> +\t\t\t ack_irq\t: Local interrupt vector\n> +\n> +- interrupts:\t\t: Contains the two IRQ lines for mailbox.\n> +\n> +Example:\n> +\n> +mailbox: mailbox@e896b000 {\n> +\tcompatible = \"hisilicon,hi3660-mbox\";\n> +\treg = <0x0 0xe896b000 0x0 0x1000>;\n> +\tinterrupts = <0x0 0xc0 0x4>,\n> +\t\t <0x0 0xc1 0x4>;\n> +\t#mbox-cells = <3>;\n> +};\n> +\n> +Client\n> +------\n> +\n> +Required properties:\n> +- compatible\t\t: See the client docs\n> +- mboxes\t\t: Standard property to specify a Mailbox (See ./mailbox.txt)\n> +\t\t\t Cells must match 'mbox-cells' (See Controller docs above)\n> +\n> +Optional properties\n> +- mbox-names\t\t: Name given to channels seen in the 'mboxes' property.\n> +\n> +Example:\n> +\n> +stub_clock: stub_clock {\n\nclock@e896b500\n\n> +\tcompatible = \"hisilicon,hi3660-stub-clk\";\n> +\treg = <0x0 0xe896b500 0x0 0x0100>;\n> +\t#clock-cells = <1>;\n> +\tmbox-names = \"mbox-tx\";\n\nDon't need -names when there is only one. Plus \"mbox-\" part is \nredundant.\n\n> +\tmboxes = <&mailbox 13 3 0>;\n> +};\n> -- \n> 1.9.1\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNmj51Q4Zz9s1h\n\tfor ;\n\tSat, 28 Oct 2017 01:39:05 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751973AbdJ0Oiu (ORCPT\n\t);\n\tFri, 27 Oct 2017 10:38:50 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:57315 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751644AbdJ0Ois (ORCPT\n\t); Fri, 27 Oct 2017 10:38:48 -0400","by mail-oi0-f68.google.com with SMTP id v9so11142719oif.13;\n\tFri, 27 Oct 2017 07:38:47 -0700 (PDT)","from localhost (mobile-166-176-121-60.mycingular.net.\n\t[166.176.121.60]) by smtp.gmail.com with ESMTPSA id\n\tv21sm3722576ote.49.2017.10.27.07.38.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 27 Oct 2017 07:38:45 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=XqwDsNNoiWo6lj3cHBjd0Hdp8/2NkMrJJyzKtOdROzE=;\n\tb=lRFk5JPByg/rpm9nlbGJg46afBqmD9P+E/Lznc4XRDNeDsWhpK5brx1GPYfNq0QAeQ\n\tVFcxXOe7LmBXk3uHFC5c3FFK9bcppvQNL9pLueKBcfjIPfRGEfRGThrGKSmSpBNYpvTS\n\tJamrJ88V7MT1x24qVd6tWQL3KK25TjsHXSQD+Hso0MSFxNSwjvh6hx+Gd2apI4VWKbyN\n\tXf91zvWmhAngecm6QzyeTr3uD/KXfhU2V10ID8KjfIu+bVonqPIVlW5QYgbENkfgMdTR\n\tit1jXBlPWt7oeZBSLbtfJ4YMXKF64biRYmBvuWGs/lNQiAYA6BG8AV8ejoExfBKXQ9Oy\n\ttGQg==","X-Gm-Message-State":"AMCzsaUuT1nVI698eg9fdK91Ld50nq3UOxngRYFrMf/OxisfOX8sHKjC\n\tPXc6+rmH0K3wDBzlAuD3sw==","X-Google-Smtp-Source":"ABhQp+Q8lGobUY82WLrw4wloJi9PJN/iEtvlHdaaMMt9ImB2JCDtnHrfw35EMcp4JszAFqIoU/He0A==","X-Received":"by 10.202.204.197 with SMTP id c188mr337985oig.143.1509115126359;\n\tFri, 27 Oct 2017 07:38:46 -0700 (PDT)","Date":"Fri, 27 Oct 2017 09:38:44 -0500","From":"Rob Herring ","To":"Kaihua Zhong ","Cc":"mark.rutland@arm.com, xuwei5@hisilicon.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com,\n\tjassisinghbrar@gmail.com, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tguodong.xu@linaro.org, haojian.zhuang@linaro.org,\n\tsuzhuangluan@hisilicon.com, xuezhiliang@hisilicon.com,\n\tkevin.wangtao@hisilicon.com","Subject":"Re: [PATCH v2 1/3] dt-bindings: mailbox: Introduce Hi3660 controller\n\tbinding","Message-ID":"<20171027143844.uxhl3vbzacvv3z4j@rob-hp-laptop>","References":"<1509084904-2505-1-git-send-email-zhongkaihua@huawei.com>\n\t<1509084904-2505-2-git-send-email-zhongkaihua@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1509084904-2505-2-git-send-email-zhongkaihua@huawei.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794958,"web_url":"http://patchwork.ozlabs.org/comment/1794958/","msgid":"<20171027150251.GE29281@leoy-linaro>","list_archive_url":null,"date":"2017-10-27T15:02:51","subject":"Re: [PATCH v2 1/3] dt-bindings: mailbox: Introduce Hi3660 controller\n\tbinding","submitter":{"id":66057,"url":"http://patchwork.ozlabs.org/api/people/66057/","name":"Leo Yan","email":"leo.yan@linaro.org"},"content":"On Fri, Oct 27, 2017 at 09:38:44AM -0500, Rob Herring wrote:\n> On Fri, Oct 27, 2017 at 02:15:02PM +0800, Kaihua Zhong wrote:\n> > From: Leo Yan \n> > \n> > Introduce a binding for the Hi3660 mailbox controller, the mailbox is\n> > used within application processor (AP), communication processor (CP),\n> > HIFI and MCU, etc.\n> > \n> > Cc: John Stultz \n> > Cc: Guodong Xu \n> > Cc: Haojian Zhuang \n> > Cc: Niranjan Yadla \n> > Cc: Raj Pawate \n> > Signed-off-by: Leo Yan \n> > ---\n> > .../bindings/mailbox/hisilicon,hi3660-mailbox.txt | 52 ++++++++++++++++++++++\n> > 1 file changed, 52 insertions(+)\n> > create mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> > new file mode 100644\n> > index 0000000..8a8d7e1\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt\n> > @@ -0,0 +1,52 @@\n> > +Hisilicon Hi3660 Mailbox Driver\n> \n> Bindings are for h/w, not drivers.\n\nThanks for reviewing, Rob.\n\nWill fix for this and below comments.\n\n> > +\n> > +Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages\n> > +are passed between processors, including application & communication\n> > +processors, MCU, HIFI, etc. Each channel is unidirectional and accessed\n> > +by using MMIO registers; it supports maximum to 8 words message.\n> > +\n> > +Controller\n> > +----------\n> > +\n> > +Required properties:\n> > +- compatible:\t\t: Shall be \"hisilicon,hi3660-mbox\"\n> > +- reg:\t\t\t: Offset and length of the device's register set\n> > +- #mbox-cells:\t\t: Must be 3\n> > +\t\t\t <&phandle channel dst_irq ack_irq>\n> > +\t\t\t phandle\t: Label name of controller\n> > +\t\t\t channel\t: Channel number\n> > +\t\t\t dst_irq\t: Remote interrupt vector\n> > +\t\t\t ack_irq\t: Local interrupt vector\n> > +\n> > +- interrupts:\t\t: Contains the two IRQ lines for mailbox.\n> > +\n> > +Example:\n> > +\n> > +mailbox: mailbox@e896b000 {\n> > +\tcompatible = \"hisilicon,hi3660-mbox\";\n> > +\treg = <0x0 0xe896b000 0x0 0x1000>;\n> > +\tinterrupts = <0x0 0xc0 0x4>,\n> > +\t\t <0x0 0xc1 0x4>;\n> > +\t#mbox-cells = <3>;\n> > +};\n> > +\n> > +Client\n> > +------\n> > +\n> > +Required properties:\n> > +- compatible\t\t: See the client docs\n> > +- mboxes\t\t: Standard property to specify a Mailbox (See ./mailbox.txt)\n> > +\t\t\t Cells must match 'mbox-cells' (See Controller docs above)\n> > +\n> > +Optional properties\n> > +- mbox-names\t\t: Name given to channels seen in the 'mboxes' property.\n> > +\n> > +Example:\n> > +\n> > +stub_clock: stub_clock {\n> \n> clock@e896b500\n> \n> > +\tcompatible = \"hisilicon,hi3660-stub-clk\";\n> > +\treg = <0x0 0xe896b500 0x0 0x0100>;\n> > +\t#clock-cells = <1>;\n> > +\tmbox-names = \"mbox-tx\";\n> \n> Don't need -names when there is only one. Plus \"mbox-\" part is \n> redundant.\n> \n> > +\tmboxes = <&mailbox 13 3 0>;\n> > +};\n> > -- \n> > 1.9.1\n> > \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eolyyPsl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNnF72D7Tz9t3q\n\tfor ;\n\tSat, 28 Oct 2017 02:03:23 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751872AbdJ0PDF (ORCPT\n\t);\n\tFri, 27 Oct 2017 11:03:05 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:46260 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751304AbdJ0PDD (ORCPT\n\t); Fri, 27 Oct 2017 11:03:03 -0400","by mail-wm0-f68.google.com with SMTP id m72so4133880wmc.1\n\tfor ;\n\tFri, 27 Oct 2017 08:03:03 -0700 (PDT)","from leoy-linaro (li1530-42.members.linode.com. [139.162.245.42])\n\tby smtp.gmail.com with ESMTPSA id\n\tl15sm5560433wrb.45.2017.10.27.08.02.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 27 Oct 2017 08:03:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=w0HNWa86GvEnmcgIIK5o9qj0HAD9S2MgOg2ZyeNREAw=;\n\tb=eolyyPslSRjsscN9RSU/l7sllOnipaX8WKWjpmA5j6R+yu02t+kodNu350AKOCd1xz\n\tnALLrPzc6qSxczxQwXaPoTBLOjUBsXGoF5PxMriOH/D/N+Fmmx9rinDcer+UfqZhBY7x\n\tIkKf4nyjbQG8E/atyyGxzUPF7RbkgXm0RvZ2s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=w0HNWa86GvEnmcgIIK5o9qj0HAD9S2MgOg2ZyeNREAw=;\n\tb=YgZD4efK6FPRy4WAKLHSg4HPsD8WTp6JQDryvEgQXMwX+BCCey+pd/MzAavnshmtXp\n\tls4CLiVzTaEjXJWdV9MC/Dq3st0cf+IHNOdn/KRDfgqMPaA0d9wZuKz759NfCFKDnk1/\n\tN1Pw3YMpQpzFyP+LjR4xAivJ8/kaE6g1mF1t5cujn0Pa0exMaN2r3NAlHp4bEb8nzs4C\n\tFzPRcKjuaEy5+vPn/xqFqvA/KsXliiZq38gFHRKrjcn/rmC/+q+xBt6VoGBaugOVtEHr\n\tNoKEbo+hnd2gZHh4mtvAlE8f0ZNz7D1jNvlYVlPDkjQCmT0kQ8Qh3ankwe7KQJMaNFJY\n\tEhzA==","X-Gm-Message-State":"AMCzsaXhYLpZK1I7QLuTH3ZnrwGWT7TewvsbPxEWmznMxIe7Ur+axdKO\n\tzx3Bm4TH/VHaTRx7Haeik3VYmw==","X-Google-Smtp-Source":"ABhQp+TUTFb9h4QjLkJpAEMiiEFRqZl3zOjzOPpDIEOsFISfUQgXe3T+hM5Nlm99DprNUIgUNY+BMQ==","X-Received":"by 10.28.190.12 with SMTP id o12mr748272wmf.4.1509116582569;\n\tFri, 27 Oct 2017 08:03:02 -0700 (PDT)","Date":"Fri, 27 Oct 2017 23:02:51 +0800","From":"Leo Yan ","To":"Rob Herring ","Cc":"Kaihua Zhong , mark.rutland@arm.com,\n\txuwei5@hisilicon.com, catalin.marinas@arm.com, will.deacon@arm.com,\n\tjassisinghbrar@gmail.com, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tguodong.xu@linaro.org, haojian.zhuang@linaro.org,\n\tsuzhuangluan@hisilicon.com, xuezhiliang@hisilicon.com,\n\tkevin.wangtao@hisilicon.com","Subject":"Re: [PATCH v2 1/3] dt-bindings: mailbox: Introduce Hi3660 controller\n\tbinding","Message-ID":"<20171027150251.GE29281@leoy-linaro>","References":"<1509084904-2505-1-git-send-email-zhongkaihua@huawei.com>\n\t<1509084904-2505-2-git-send-email-zhongkaihua@huawei.com>\n\t<20171027143844.uxhl3vbzacvv3z4j@rob-hp-laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171027143844.uxhl3vbzacvv3z4j@rob-hp-laptop>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]