[{"id":1795240,"web_url":"http://patchwork.ozlabs.org/comment/1795240/","msgid":"<20171028.190615.1780763141354795593.davem@redhat.com>","list_archive_url":null,"date":"2017-10-28T10:06:15","subject":"Re: [PATCH V2 net] tuntap: properly align skb->head before\n\tbuilding skb","submitter":{"id":1181,"url":"http://patchwork.ozlabs.org/api/people/1181/","name":"David Miller","email":"davem@redhat.com"},"content":"From: Jason Wang \nDate: Fri, 27 Oct 2017 11:05:44 +0800\n\n> An unaligned alloc_frag->offset caused by previous allocation will\n> result an unaligned skb->head. This will lead unaligned\n> skb_shared_info and then unaligned dataref which requires to be\n> aligned for accessing on some architecture. Fix this by aligning\n> alloc_frag->offset before the frag refilling.\n> \n> Fixes: 0bbd7dad34f8 (\"tun: make tun_build_skb() thread safe\")\n> Cc: Eric Dumazet \n> Cc: Willem de Bruijn \n> Cc: Wei Wei \n> Cc: Dmitry Vyukov \n> Cc: Mark Rutland \n> Reported-by: Wei Wei \n> Signed-off-by: Jason Wang \n\nApplied and queued up for -stable, thanks Jason.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=davem@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPGcL4x6zz9s81\n\tfor ;\n\tSat, 28 Oct 2017 21:06:42 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751399AbdJ1KGa (ORCPT );\n\tSat, 28 Oct 2017 06:06:30 -0400","from mx1.redhat.com ([209.132.183.28]:38824 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751121AbdJ1KG3 (ORCPT );\n\tSat, 28 Oct 2017 06:06:29 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BE6073A266;\n\tSat, 28 Oct 2017 10:06:28 +0000 (UTC)","from localhost (ovpn-112-4.rdu2.redhat.com [10.10.112.4])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 828C9ABD8F;\n\tSat, 28 Oct 2017 10:06:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BE6073A266","Date":"Sat, 28 Oct 2017 19:06:15 +0900 (KST)","Message-Id":"<20171028.190615.1780763141354795593.davem@redhat.com>","To":"jasowang@redhat.com","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tdotweiba@gmail.com, edumazet@google.com,\n\twillemdebruijn.kernel@gmail.com, dvyukov@google.com, mark.rutland@arm.com","Subject":"Re: [PATCH V2 net] tuntap: properly align skb->head before\n\tbuilding skb","From":"David Miller ","In-Reply-To":"<1509073544-4474-1-git-send-email-jasowang@redhat.com>","References":"<1509073544-4474-1-git-send-email-jasowang@redhat.com>","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tSat, 28 Oct 2017 10:06:28 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795348,"web_url":"http://patchwork.ozlabs.org/comment/1795348/","msgid":"<06D9B61F-5C89-47C4-A060-B63FE5A8F922@gmail.com>","list_archive_url":null,"date":"2017-10-28T22:20:54","subject":"Re: [PATCH V2 net] tuntap: properly align skb->head before building\n\tskb","submitter":{"id":72684,"url":"http://patchwork.ozlabs.org/api/people/72684/","name":"Wei Wei","email":"dotweiba@gmail.com"},"content":"With this patch, the crash can’t be reproduced with the syz-repro and crash log0/log1.\n\nThe auto-generated reproducers are here: \nhttps://github.com/dotweiba/skb_clone_atomic_inc_bug\n\nThanks,\nWei\n> On 28 Oct 2017, at 6:06 AM, David Miller wrote:\n> \n> From: Jason Wang \n> Date: Fri, 27 Oct 2017 11:05:44 +0800\n> \n>> An unaligned alloc_frag->offset caused by previous allocation will\n>> result an unaligned skb->head. This will lead unaligned\n>> skb_shared_info and then unaligned dataref which requires to be\n>> aligned for accessing on some architecture. Fix this by aligning\n>> alloc_frag->offset before the frag refilling.\n>> \n>> Fixes: 0bbd7dad34f8 (\"tun: make tun_build_skb() thread safe\")\n>> Cc: Eric Dumazet \n>> Cc: Willem de Bruijn \n>> Cc: Wei Wei \n>> Cc: Dmitry Vyukov \n>> Cc: Mark Rutland \n>> Reported-by: Wei Wei \n>> Signed-off-by: Jason Wang \n> \n> Applied and queued up for -stable, thanks Jason.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"D/4VWe6g\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPZw13pPrz9t39\n\tfor ;\n\tSun, 29 Oct 2017 09:21:21 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751445AbdJ1WVC (ORCPT );\n\tSat, 28 Oct 2017 18:21:02 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:53897 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751273AbdJ1WVB (ORCPT\n\t); Sat, 28 Oct 2017 18:21:01 -0400","by mail-pg0-f65.google.com with SMTP id s2so8061358pge.10;\n\tSat, 28 Oct 2017 15:21:00 -0700 (PDT)","from vpn-client-455.itap.purdue.edu\n\t(vpn-client-455.itap.purdue.edu. [128.210.193.211])\n\tby smtp.gmail.com with ESMTPSA id\n\tn72sm20891580pfg.109.2017.10.28.15.20.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 28 Oct 2017 15:20:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=rMXWfzML3B9w7lLek+JKrjexbJ19VlHGsqIRLh4oqLY=;\n\tb=D/4VWe6ghSYF6B78e/U7m45PMaQ8vMcWGoE+aueJ2fv3jdS+5dOmzQGoHtcrZm5MjC\n\tVjErX6bBBt2uK6GtbESU8vH6i7F0F6yzqOoPyJ8fLcEq2DffHeD+Q0c0exGN2qL6/ECE\n\tW1yMTzjdLOsdWQh+rq0FEGngOuqAHvFHFnSGVdms3S/GqvLZw0YSO/uslwnEGqtlTuJ9\n\tmgennn2p96zHjmTX/eofEQh27VxHtEpb9XtUSKwPqnsY9LyLtq6kCOJ6FiirJJ9A6JEb\n\tKPhaIgL8oD96c1J53suGPSAwmSgC7dMm0hstoPz3gQNa35NyhMwTklvy9brundUFIBt/\n\tU2zQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=rMXWfzML3B9w7lLek+JKrjexbJ19VlHGsqIRLh4oqLY=;\n\tb=NBnLp+tjX4/1SEYv7CPBkcS0RkcRJK4H67/I+0jpxNsSC4QJf5uQQXxsshXSTqGfth\n\t/viIAJjwwVU7uTi98B+fhzgSpp4uWvlSqZzZ5No+le6o+gG/NekFvRZ12WuJGDmAamX8\n\tIIFmk4v610vfpKk7SgCfUMJP3pksMVfBPGevUrdqNcSlV93PENkJx5RKwoHBcHTFdcIc\n\tYYG9VZNtzNH4tnf06w7lA3YSzgRlxaQ3yunl/E9PTvPjwGTt2Gn7ddg/tAX/JkWkSw0y\n\tGkiK6mwfIcO3uotozW/EUqCRWaSy9okoMz1jVdxqEHMw64Slui/kmTv9lkfDJ+h/KQwW\n\th5Hg==","X-Gm-Message-State":"AMCzsaUr4oQsihK5PatXJXhASHm9u2O8eTMZ8UQojbN4Vz7V9RGnsGsH\n\t7n/B8w5QuSSM40710GtjCR0=","X-Google-Smtp-Source":"ABhQp+SpnqhqdjicrD32ADYo+aPNfcMTCuaoYo55nMQ5sc2B/KW0XY5/z86+iP8+qsiYfI1uma7Skg==","X-Received":"by 10.98.217.2 with SMTP id s2mr4426230pfg.298.1509229260539;\n\tSat, 28 Oct 2017 15:21:00 -0700 (PDT)","Content-Type":"text/plain; charset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH V2 net] tuntap: properly align skb->head before building\n\tskb","From":"Wei Wei ","In-Reply-To":"<20171028.190615.1780763141354795593.davem@redhat.com>","Date":"Sat, 28 Oct 2017 18:20:54 -0400","Cc":"jasowang@redhat.com, netdev ,\n\tLKML , Eric Dumazet ,\n\tWillem de Bruijn ,\n\tDmitry Vyukov , Mark Rutland ","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<06D9B61F-5C89-47C4-A060-B63FE5A8F922@gmail.com>","References":"<1509073544-4474-1-git-send-email-jasowang@redhat.com>\n\t<20171028.190615.1780763141354795593.davem@redhat.com>","To":"David Miller ","X-Mailer":"Apple Mail (2.3273)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]