[{"id":1794166,"web_url":"http://patchwork.ozlabs.org/comment/1794166/","msgid":"<622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp>","list_archive_url":null,"date":"2017-10-26T10:16:27","subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","submitter":{"id":22461,"url":"http://patchwork.ozlabs.org/api/people/22461/","name":"Toshiaki Makita","email":"makita.toshiaki@lab.ntt.co.jp"},"content":"On 2017/10/26 7:52, Nikolay Aleksandrov wrote:\n...\n> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n> \n> \tASSERT_RTNL();\n> \n> +\t*changed = false;\n> \tvg = br_vlan_group(br);\n> \tvlan = br_vlan_find(vg, vid);\n> \tif (vlan) {\n> @@ -576,9 +592,12 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n> \t\t\trefcount_inc(&vlan->refcnt);\n> \t\t\tvlan->flags |= BRIDGE_VLAN_INFO_BRENTRY;\n> \t\t\tvg->num_vlans++;\n> +\t\t\t*changed = true;\n> \t\t}\n> -\t\t__vlan_add_flags(vlan, flags);\n> -\t\treturn 0;\n> +\t\tif (__vlan_add_flags(vlan, flags))\n> +\t\t\t*changed = true;\n> +\n> +\t\treturn ret;\n\n\"ret\" isn't always initialized here, is it?\n\n\nToshiaki Makita","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yN2yB2ppCz9t2r\n\tfor ;\n\tThu, 26 Oct 2017 21:17:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751520AbdJZKRv (ORCPT );\n\tThu, 26 Oct 2017 06:17:51 -0400","from tama50.ecl.ntt.co.jp ([129.60.39.147]:37951 \"EHLO\n\ttama50.ecl.ntt.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751460AbdJZKRu (ORCPT\n\t); Thu, 26 Oct 2017 06:17:50 -0400","from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153])\n\tby tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v9QAHbFp020788; \n\tThu, 26 Oct 2017 19:17:37 +0900","from vc1.ecl.ntt.co.jp (localhost [127.0.0.1])\n\tby vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 1D5CD60282;\n\tThu, 26 Oct 2017 19:17:37 +0900 (JST)","from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp\n\t[129.60.87.134])\n\tby vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 0E6AA5F590;\n\tThu, 26 Oct 2017 19:17:37 +0900 (JST)","from [IPv6:::1] (unknown [129.60.241.120])\n\tby jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 076B24003EC;\n\tThu, 26 Oct 2017 19:17:37 +0900 (JST)"],"Subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","References":"\n\t<1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com>\n\t<1508971954-3567-3-git-send-email-nikolay@cumulusnetworks.com>","From":"Toshiaki Makita ","Message-ID":"<622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp>","Date":"Thu, 26 Oct 2017 19:16:27 +0900","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1508971954-3567-3-git-send-email-nikolay@cumulusnetworks.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","To":"Nikolay Aleksandrov , netdev@vger.kernel.org","Cc":"roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,\n\tmrv@mojatatu.com, dsa@cumulusnetworks.com, davem@davemloft.net","X-TM-AS-MML":"disable","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794180,"web_url":"http://patchwork.ozlabs.org/comment/1794180/","msgid":"<3ad411f5-72fe-db6c-aa13-385dd1c10f36@cumulusnetworks.com>","list_archive_url":null,"date":"2017-10-26T11:02:20","subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 26/10/17 13:16, Toshiaki Makita wrote:\n> On 2017/10/26 7:52, Nikolay Aleksandrov wrote:\n> ...\n>> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n>> \n>> \tASSERT_RTNL();\n>> \n>> +\t*changed = false;\n>> \tvg = br_vlan_group(br);\n>> \tvlan = br_vlan_find(vg, vid);\n>> \tif (vlan) {\n>> @@ -576,9 +592,12 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n>> \t\t\trefcount_inc(&vlan->refcnt);\n>> \t\t\tvlan->flags |= BRIDGE_VLAN_INFO_BRENTRY;\n>> \t\t\tvg->num_vlans++;\n>> +\t\t\t*changed = true;\n>> \t\t}\n>> -\t\t__vlan_add_flags(vlan, flags);\n>> -\t\treturn 0;\n>> +\t\tif (__vlan_add_flags(vlan, flags))\n>> +\t\t\t*changed = true;\n>> +\n>> +\t\treturn ret;\n> \n> \"ret\" isn't always initialized here, is it?\n> \n> \n> Toshiaki Makita\n\nOh, good catch! Right you are, weird that there was no warning even with W=1 as\nI always check that before sending a set.\n\nThanks,\n Nik","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"hsKrgDW0\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yN3xb3Cmhz9t2W\n\tfor ;\n\tThu, 26 Oct 2017 22:02:27 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932337AbdJZLCZ (ORCPT );\n\tThu, 26 Oct 2017 07:02:25 -0400","from mail-wm0-f51.google.com ([74.125.82.51]:44682 \"EHLO\n\tmail-wm0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932141AbdJZLCX (ORCPT\n\t); Thu, 26 Oct 2017 07:02:23 -0400","by mail-wm0-f51.google.com with SMTP id 196so18941243wma.1\n\tfor ; Thu, 26 Oct 2017 04:02:23 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tx7sm3231050edi.6.2017.10.26.04.02.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 26 Oct 2017 04:02:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=n0vl9a1LWBQVz0WE+ZO9plXdZYaMrzSke8xwZPi4bVg=;\n\tb=hsKrgDW0V10uaNAYpH+2jBVzZMBQElHHFJmZFR3icbtFW3aytmphQOQO26/oTbvFb7\n\thA/hpmPJikuN1Gb3jn3gVUsQl1AqviK4IatYMUeNLXsg4CGjQiGNJfznQWCXiNBoZxto\n\tLrC0v6CR0MAFiBN+3FpQDzR3Cx9DwCDbekMnU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=n0vl9a1LWBQVz0WE+ZO9plXdZYaMrzSke8xwZPi4bVg=;\n\tb=Kqjcr4Nb47fDkxgAOWdzPuCKgYGKglBCBe+fJJ1ytP/Ew+0pOSHJsaWB83/xCOXlY3\n\thPDmbTgovPlYu1cqptuxdSIW21kARgb0j/OOJKZ/tZaLEM+9xLysBcXQI0iFjXG0Fd2U\n\tdyWtc8EUSWiDVAW2i0ljvdGfoEfzw+telNyrnVCW3+OuBeHBEP8tqhcV3ZQCQ3tEwK/g\n\tB91NG2+8poKIzH0p8zt3mDnTO5T95hRFoPUWpzw/ueMxoHl+lmMCTjwHBEFjIpJ7xc7f\n\t/2LLtYRykoAjgQo0Rlyf1i8+yDX2BF3jmIwRymq/5MuNUNE3GOMKHpTJPOUBq9kfKyWX\n\tzakQ==","X-Gm-Message-State":"AMCzsaWNb0uqB2FXIBixGXfCHw3KO0zLQTROywkdOKsfNi8YTPloGjfT\n\tzZQLLohStoY3aPG+4GEDvc0ubQ==","X-Google-Smtp-Source":"ABhQp+RIa6dAeakWFUWpJrBUhM2Odr1OkzrOVex7smGOryCcB8tLl02iMxztbp5yY2GU+89e04Dw8A==","X-Received":"by 10.80.182.165 with SMTP id d34mr26233324ede.131.1509015742453;\n\tThu, 26 Oct 2017 04:02:22 -0700 (PDT)","Subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","To":"Toshiaki Makita , netdev@vger.kernel.org","Cc":"roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,\n\tmrv@mojatatu.com, dsa@cumulusnetworks.com, davem@davemloft.net","References":"\n\t<1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com>\n\t<1508971954-3567-3-git-send-email-nikolay@cumulusnetworks.com>\n\t<622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp>","From":"Nikolay Aleksandrov ","Message-ID":"<3ad411f5-72fe-db6c-aa13-385dd1c10f36@cumulusnetworks.com>","Date":"Thu, 26 Oct 2017 14:02:20 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794183,"web_url":"http://patchwork.ozlabs.org/comment/1794183/","msgid":"<0f1e8fb5-b9a8-b363-c080-65c23f76b25e@cumulusnetworks.com>","list_archive_url":null,"date":"2017-10-26T11:08:02","subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 26/10/17 14:02, Nikolay Aleksandrov wrote:\n> On 26/10/17 13:16, Toshiaki Makita wrote:\n>> On 2017/10/26 7:52, Nikolay Aleksandrov wrote:\n>> ...\n>>> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n>>> \n>>> \tASSERT_RTNL();\n>>> \n>>> +\t*changed = false;\n>>> \tvg = br_vlan_group(br);\n>>> \tvlan = br_vlan_find(vg, vid);\n>>> \tif (vlan) {\n>>> @@ -576,9 +592,12 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)\n>>> \t\t\trefcount_inc(&vlan->refcnt);\n>>> \t\t\tvlan->flags |= BRIDGE_VLAN_INFO_BRENTRY;\n>>> \t\t\tvg->num_vlans++;\n>>> +\t\t\t*changed = true;\n>>> \t\t}\n>>> -\t\t__vlan_add_flags(vlan, flags);\n>>> -\t\treturn 0;\n>>> +\t\tif (__vlan_add_flags(vlan, flags))\n>>> +\t\t\t*changed = true;\n>>> +\n>>> +\t\treturn ret;\n>>\n>> \"ret\" isn't always initialized here, is it?\n>>\n>>\n>> Toshiaki Makita\n> \n> Oh, good catch! Right you are, weird that there was no warning even with W=1 as\n> I always check that before sending a set.\n> \n> Thanks,\n> Nik\n> \n\nUnfortunately that was a leftover from v0 of this set where I always initialized ret.\nWill fix and send v5, thanks again.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"P3VdiwBD\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yN44D5Psqz9t2W\n\tfor ;\n\tThu, 26 Oct 2017 22:08:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932322AbdJZLIJ (ORCPT );\n\tThu, 26 Oct 2017 07:08:09 -0400","from mail-lf0-f66.google.com ([209.85.215.66]:48130 \"EHLO\n\tmail-lf0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932286AbdJZLIH (ORCPT\n\t); Thu, 26 Oct 2017 07:08:07 -0400","by mail-lf0-f66.google.com with SMTP id a69so3283677lfe.5\n\tfor ; Thu, 26 Oct 2017 04:08:06 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tm3sm1106582lfe.37.2017.10.26.04.08.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 26 Oct 2017 04:08:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:from:to:cc:references:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ozCVlj+EGkPpAY1tihUf+9wDD7FbL5BN8IcSEqHCAj8=;\n\tb=P3VdiwBDvZVDboke+ShIMiJ508vKoMe/mHqCKjnuW2bJz37hc5n9OYYz67rjeUoRBL\n\t/1B90FYtShyNeVTVHvuS257eZm4eMS69k9al8oBqQb6daRQfQftm0YZzZP3OG+lYXyO1\n\tQvcjSelI9DDcM+jG6HGibC35jzzdxv/v6p93U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ozCVlj+EGkPpAY1tihUf+9wDD7FbL5BN8IcSEqHCAj8=;\n\tb=ViNo4+v+xymNO8WSsqyeYQmYp1fuek7zHArHtyn1MH75QhMm6pPFFEAYEaLZ+e7tFK\n\t/TUYWzQOsswXaKtWn5pzSqKhU3fHwST4xh9LEBs3s9JPikoFTHlFqy9hp7T1uS64bip5\n\ttVPR+LRSUCIVM4GI0hGEaCI7aXKm1NJT/KNSvD8TzfbFdICBPWELCfuT3XEC4MajUvW7\n\tV5ZHUZb9Apwg/YDCuvQ3a//FebFBwMJyPrQzCKojmbbvTHY5ZFa69HVoMnismZdQDq3T\n\tf8wHv3oZBX6jZBehJn8ubf4GhsFafSPqPShUatZgc7zFfSMLab7xS+GkhvzMfqAIjlos\n\tqkCg==","X-Gm-Message-State":"AMCzsaXUN35DkLmcQS6/GxAO/M6sIxOqOGnSStUhWDA5/n54P/KYlVJ0\n\tDEngep/tGyysLdmuLTgfEb93Kw==","X-Google-Smtp-Source":"ABhQp+RDkVUHg49RoSpKJ5M53sRm3TlYD4bosRFg6OflgME2xbF1GAz2FvSuDume+lIxmlFgQCS6FA==","X-Received":"by 10.25.115.196 with SMTP id h65mr7821151lfk.203.1509016085589; \n\tThu, 26 Oct 2017 04:08:05 -0700 (PDT)","Subject":"Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if\n\tanything changed on vlan add","From":"Nikolay Aleksandrov ","To":"Toshiaki Makita , netdev@vger.kernel.org","Cc":"roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,\n\tmrv@mojatatu.com, dsa@cumulusnetworks.com, davem@davemloft.net","References":"\n\t<1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com>\n\t<1508971954-3567-3-git-send-email-nikolay@cumulusnetworks.com>\n\t<622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp>\n\t<3ad411f5-72fe-db6c-aa13-385dd1c10f36@cumulusnetworks.com>","Message-ID":"<0f1e8fb5-b9a8-b363-c080-65c23f76b25e@cumulusnetworks.com>","Date":"Thu, 26 Oct 2017 14:08:02 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<3ad411f5-72fe-db6c-aa13-385dd1c10f36@cumulusnetworks.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]