[{"id":1793841,"web_url":"http://patchwork.ozlabs.org/comment/1793841/","msgid":"<20171025092248.28ee41d9@cakuba.netronome.com>","list_archive_url":null,"date":"2017-10-25T16:22:48","subject":"Re: [PATCH] drivers/net: netronome: Convert timers to use\n\ttimer_setup()","submitter":{"id":67484,"url":"http://patchwork.ozlabs.org/api/people/67484/","name":"Jakub Kicinski","email":"jakub.kicinski@netronome.com"},"content":"On Wed, 25 Oct 2017 03:51:38 -0700, Kees Cook wrote:\n> In preparation for unconditionally passing the struct timer_list pointer to\n> all timer callbacks, switch to using the new timer_setup() and from_timer()\n> to pass the timer pointer explicitly.\n> \n> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>\n> Cc: \"David S. Miller\" <davem@davemloft.net>\n> Cc: Jiri Pirko <jiri@mellanox.com>\n> Cc: Jamal Hadi Salim <jhs@mojatatu.com>\n> Cc: Simon Horman <simon.horman@netronome.com>\n> Cc: oss-drivers@netronome.com\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook <keescook@chromium.org>\n\nAcked-by: Jakub Kicinski <jakub.kicinski@netronome.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"mYHoa0Em\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMb5w1yVnz9t3k\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 26 Oct 2017 03:23:00 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751970AbdJYQW5 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 25 Oct 2017 12:22:57 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:46163 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751898AbdJYQW4 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 25 Oct 2017 12:22:56 -0400","by mail-wm0-f68.google.com with SMTP id m72so2982952wmc.1\n\tfor <netdev@vger.kernel.org>; Wed, 25 Oct 2017 09:22:55 -0700 (PDT)","from cakuba.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\td3sm1756698edd.41.2017.10.25.09.22.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 25 Oct 2017 09:22:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:organization:mime-version:content-transfer-encoding;\n\tbh=c9ud4ptdsemocE/DJG5cxpQ6R/eQjKBSJwNaIDKOjxw=;\n\tb=mYHoa0EmFPApMl8ZvM0LquiN6goYZBn0IsUpt9ADzGBWJ5zY4AtFghELnsmosXFNgO\n\tmDGAgEVWqC6CUo39WazrGNEEX/7wAcFTOzguN3Ocw++AW5aHfDWOEN++Daaf/WV0I2cI\n\taCcjwxxkZkMLvzDhSrlHvNaaqi5PaSwEzycBmc7BYBqKlYTST6VXsgxaKKBd0PRM3Z5F\n\tLZJhMAH4RMJEz83yOUiWbfWjxTigen/u9xCj0JHzPHPPZa2MYzv4BDsYX53THAWulUCa\n\tz/gnKUsVRzUOqzSFg65cp40cPDoLir4RLrT1mICAqAv1g+QkfATbDE+PqF95tAc9tNY8\n\tmoUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:organization:mime-version:content-transfer-encoding;\n\tbh=c9ud4ptdsemocE/DJG5cxpQ6R/eQjKBSJwNaIDKOjxw=;\n\tb=S9LtAdUgaUznWt0p9pnn9iM8nLgTZhOnFt2gL45cTbI3PMY4n64Zyl9YqXIy5bkp8r\n\t6uJ/bvkxtpMqFLorOwIssH5UV8eFqD7wypfvAh84p+jCkiRfdGC7pguFn9kb3Hq1G2h8\n\trtMvRtak1AHTYb523l8mwNzHHuRLfqIUpnTk4bVu4DAdXFo/jqgZA85XGBIYS9RQzF49\n\t0Dd7Mu1TZLGzeRA1JZ5rBkbirjviIO7rEu2by16C7IYPx8sPtcUQSHq5ujrN2XrhcxkE\n\tldWlXGVObT4SqFSjZSJoS8OtkTF3vEthjI1OKV9OtZ7BoD2wACpsNLaOg2Z+bTPSAz8v\n\tcPeg==","X-Gm-Message-State":"AMCzsaXAlHPyiSaIdPN4qAn8rpcDHoHMQSQcWzgK+RCrc5ZR/WGOfNU0\n\tyaSV8FrzAs1+bB4iC9kFUXXNww==","X-Google-Smtp-Source":"ABhQp+R8d7/2cYn1GRTLLDxgTHuVTolnobq454IQ+6t3MCs3dVMjrrpkqw08mxHCpZJx/vToNakFrA==","X-Received":"by 10.80.141.18 with SMTP id s18mr6293004eds.241.1508948575186; \n\tWed, 25 Oct 2017 09:22:55 -0700 (PDT)","Date":"Wed, 25 Oct 2017 09:22:48 -0700","From":"Jakub Kicinski <jakub.kicinski@netronome.com>","To":"Kees Cook <keescook@chromium.org>","Cc":"\"David S. Miller\" <davem@davemloft.net>, Jiri Pirko <jiri@mellanox.com>,\n\tJamal Hadi Salim <jhs@mojatatu.com>,\n\tSimon Horman <simon.horman@netronome.com>,\n\toss-drivers@netronome.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] drivers/net: netronome: Convert timers to use\n\ttimer_setup()","Message-ID":"<20171025092248.28ee41d9@cakuba.netronome.com>","In-Reply-To":"<20171025105138.GA146561@beast>","References":"<20171025105138.GA146561@beast>","Organization":"Netronome Systems, Ltd.","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794590,"web_url":"http://patchwork.ozlabs.org/comment/1794590/","msgid":"<20171027.120956.1944875051120489377.davem@davemloft.net>","list_archive_url":null,"date":"2017-10-27T03:09:56","subject":"Re: [PATCH] drivers/net: netronome: Convert timers to use\n\ttimer_setup()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Kees Cook <keescook@chromium.org>\nDate: Wed, 25 Oct 2017 03:51:38 -0700\n\n> In preparation for unconditionally passing the struct timer_list pointer to\n> all timer callbacks, switch to using the new timer_setup() and from_timer()\n> to pass the timer pointer explicitly.\n> \n> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>\n> Cc: \"David S. Miller\" <davem@davemloft.net>\n> Cc: Jiri Pirko <jiri@mellanox.com>\n> Cc: Jamal Hadi Salim <jhs@mojatatu.com>\n> Cc: Simon Horman <simon.horman@netronome.com>\n> Cc: oss-drivers@netronome.com\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook <keescook@chromium.org>\n\nApplied.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNTSq5L2fz9t2x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 14:12:27 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752153AbdJ0DKE (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 26 Oct 2017 23:10:04 -0400","from shards.monkeyblade.net ([184.105.139.130]:43698 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751685AbdJ0DKA (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 26 Oct 2017 23:10:00 -0400","from localhost (unknown [211.196.191.92])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id EB0911340112D;\n\tThu, 26 Oct 2017 20:09:57 -0700 (PDT)"],"Date":"Fri, 27 Oct 2017 12:09:56 +0900 (KST)","Message-Id":"<20171027.120956.1944875051120489377.davem@davemloft.net>","To":"keescook@chromium.org","Cc":"jakub.kicinski@netronome.com, jiri@mellanox.com, jhs@mojatatu.com,\n\tsimon.horman@netronome.com, oss-drivers@netronome.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] drivers/net: netronome: Convert timers to use\n\ttimer_setup()","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<20171025105138.GA146561@beast>","References":"<20171025105138.GA146561@beast>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 26 Oct 2017 20:09:59 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]