[{"id":1794574,"web_url":"http://patchwork.ozlabs.org/comment/1794574/","msgid":"<20171027.120141.2030619458420639672.davem@davemloft.net>","list_archive_url":null,"date":"2017-10-27T03:01:41","subject":"Re: [PATCH] thunderbolt: Drop sequence number check from\n\ttb_xdomain_match()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mika Westerberg \nDate: Wed, 25 Oct 2017 12:27:34 +0300\n\n> Commit 9a03c3d398c1 (\"thunderbolt: Fix a couple right shifting to zero\n> bugs\") revealed an issue that was previously hidden because we never\n> actually compared received XDomain message sequence numbers properly.\n> The idea with these sequence numbers is that the responding host uses\n> the same sequence number that was in the request packet which we can\n> then check at the requesting host.\n> \n> However, testing against macOS it looks like it does not follow this but\n> instead uses some other logic. Windows driver on the other hand handles\n> it the same way than Linux.\n> \n> In order to be able to talk to macOS again, fix this so that we drop the\n> whole sequence number check. This effectively works exactly the same\n> than it worked before the aforementioned commit. This also follows the\n> logic the original P2P networking code used.\n> \n> Signed-off-by: Mika Westerberg \n> ---\n> This applies on top of net-next.git/master.\n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNTDY1QW9z9t2x\n\tfor ;\n\tFri, 27 Oct 2017 14:01:49 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932375AbdJ0DBr (ORCPT );\n\tThu, 26 Oct 2017 23:01:47 -0400","from shards.monkeyblade.net ([184.105.139.130]:43590 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932443AbdJ0DBp (ORCPT\n\t); Thu, 26 Oct 2017 23:01:45 -0400","from localhost (unknown [211.196.191.92])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 47BB513401107;\n\tThu, 26 Oct 2017 20:01:43 -0700 (PDT)"],"Date":"Fri, 27 Oct 2017 12:01:41 +0900 (KST)","Message-Id":"<20171027.120141.2030619458420639672.davem@davemloft.net>","To":"mika.westerberg@linux.intel.com","Cc":"andreas.noever@gmail.com, michael.jamet@intel.com,\n\tyehezkel.bernat@intel.com, dan.carpenter@oracle.com,\n\tamir.jer.levy@intel.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] thunderbolt: Drop sequence number check from\n\ttb_xdomain_match()","From":"David Miller ","In-Reply-To":"<20171025092734.51299-1-mika.westerberg@linux.intel.com>","References":"<20171025092734.51299-1-mika.westerberg@linux.intel.com>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 26 Oct 2017 20:01:45 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]