[{"id":1794147,"web_url":"http://patchwork.ozlabs.org/comment/1794147/","msgid":"<20171026095411.GJ20299@lunn.ch>","list_archive_url":null,"date":"2017-10-26T09:54:11","subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Tue, Oct 24, 2017 at 07:57:08PM +0200, Corentin Labbe wrote:\n> Since dwmac-sun8i could use either an integrated PHY or an external PHY\n> (which could be at same MDIO address), we need to represent this selection\n> by a MDIO switch.\n> \n> Signed-off-by: Corentin Labbe \n\nReviewed-by: Andrew Lunn \n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yN2R13RY8z9rxj\n\tfor ;\n\tThu, 26 Oct 2017 20:54:21 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752099AbdJZJyT (ORCPT );\n\tThu, 26 Oct 2017 05:54:19 -0400","from vps0.lunn.ch ([185.16.172.187]:58477 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751263AbdJZJyR (ORCPT );\n\tThu, 26 Oct 2017 05:54:17 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1e7erb-0006ef-4e; Thu, 26 Oct 2017 11:54:11 +0200"],"Date":"Thu, 26 Oct 2017 11:54:11 +0200","From":"Andrew Lunn ","To":"Corentin Labbe ","Cc":"robh+dt@kernel.org, mark.rutland@arm.com,\n\tmaxime.ripard@free-electrons.com, wens@csie.org,\n\tlinux@armlinux.org.uk, catalin.marinas@arm.com,\n\twill.deacon@arm.com, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","Message-ID":"<20171026095411.GJ20299@lunn.ch>","References":"<20171024175714.15840-1-clabbe.montjoie@gmail.com>\n\t<20171024175714.15840-5-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171024175714.15840-5-clabbe.montjoie@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794150,"web_url":"http://patchwork.ozlabs.org/comment/1794150/","msgid":"","list_archive_url":null,"date":"2017-10-26T09:56:30","subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","submitter":{"id":72653,"url":"http://patchwork.ozlabs.org/api/people/72653/","name":"Don Baton","email":"batnnubv@gmail.com"},"content":"2017-10-26 12:54 GMT+03:00, Andrew Lunn :\n> On Tue, Oct 24, 2017 at 07:57:08PM +0200, Corentin Labbe wrote:\n>> Since dwmac-sun8i could use either an integrated PHY or an external PHY\n>> (which could be at same MDIO address), we need to represent this\n>> selection\n>> by a MDIO switch.\n>>\n>> Signed-off-by: Corentin Labbe \n>\n> Reviewed-by: Andrew Lunn \n>\n> Andrew\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"C1WjoQuR\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yN2Tp4bB2z9rxj\n\tfor ;\n\tThu, 26 Oct 2017 20:56:46 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932198AbdJZJ4e (ORCPT );\n\tThu, 26 Oct 2017 05:56:34 -0400","from mail-wm0-f41.google.com ([74.125.82.41]:50137 \"EHLO\n\tmail-wm0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751162AbdJZJ4c (ORCPT\n\t); Thu, 26 Oct 2017 05:56:32 -0400","by mail-wm0-f41.google.com with SMTP id b189so6729556wmd.4;\n\tThu, 26 Oct 2017 02:56:31 -0700 (PDT)","by 10.80.171.70 with HTTP; Thu, 26 Oct 2017 02:56:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=59TVKKaBOWNLgZmhSdOyJq2kX1TTwtmELEmp97oRMc4=;\n\tb=C1WjoQuRUqCbRVZrgLwmTyLcFmoRkfTPBc7RB7QvAG4k4KP/UvsdK4/+pmR5GPCSbh\n\teTzS0avQztTLpaGm8j8PJVoqmONh8I3E5ABD9gPqESMK8TCP6R3EGe4U4HQZTQDyEL+W\n\tPNrsiv9vTJ6g4vFr5rhtk6W7jhBOPpq5oW+uAhq8jAvpzZlHe+tg3xkkKZZQT4ql/Ipc\n\tvzhOLnoLzYNSnAE0L5xMFaXSj/7bvEbtbn75G8SlpIjFsxFr+3UrbkAnt5zlOe2eLTxU\n\tqlnHYbt+fWcTCVGtb9EqYd617BZKKCkia+BxWX1xVJXaKiCqHtK3k1OpHsDbTn/mK+0L\n\tlwLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=59TVKKaBOWNLgZmhSdOyJq2kX1TTwtmELEmp97oRMc4=;\n\tb=tT92RbrR9cYq0V/AtVa9wTyHJkdlrrvx0obdayPh4Cfh5KiflVjGxiadiW6flo01Ed\n\tDVzKdL2e1J/ItIkN3//DpY7snNDW9Oi7T2n9i8ZNk1jlTvPy83nwWhH0t+5MLxeMJn3Q\n\tcneemqndwTqdtdvF3X2OSBahUjtq+wf9X2qBu2MnunMoXEjY6bfHvP5zA0QzDrIvQ2n3\n\ti3pCaoJG6b4PnMjVC9TAl/0tsrQb6hwBVhmdjmz1P6HBF7eS8INAejUNIeUlm0P7JGjH\n\twsH4uZMGnk2S8FkdnGCj0fw/G3wcV37oOzjHhjUGMlZJM2/bDYo2QW4AI6IWDk8MD4Kz\n\tnjcA==","X-Gm-Message-State":"AMCzsaXFJH7lNyvpf9V0D20F56KFZgiLsYlCinqYYfwplzEWRaXfRy3p\n\tb/FT4Xi4AP7lyJ2JigKR4FlI1045ef0eUU9aB3g=","X-Google-Smtp-Source":"ABhQp+TPFO9Hg9vzpMPCexZY6YsddbfEkbDCIafVYhLzc0nFQeh5bHVxdqoCWfBuq8I9bQgbBQFjYT1KaW487W/h280=","X-Received":"by 10.80.179.246 with SMTP id t51mr26768667edd.176.1509011791002;\n\tThu, 26 Oct 2017 02:56:31 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171026095411.GJ20299@lunn.ch>","References":"<20171024175714.15840-1-clabbe.montjoie@gmail.com>\n\t<20171024175714.15840-5-clabbe.montjoie@gmail.com>\n\t<20171026095411.GJ20299@lunn.ch>","From":"Don Baton ","Date":"Thu, 26 Oct 2017 12:56:30 +0300","Message-ID":"","Subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","To":"Andrew Lunn ","Cc":"Corentin Labbe , robh+dt@kernel.org,\n\tmark.rutland@arm.com, maxime.ripard@free-electrons.com,\n\twens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com,\n\twill.deacon@arm.com, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1794972,"web_url":"http://patchwork.ozlabs.org/comment/1794972/","msgid":"<20171027151220.m3vbtqd22bbupvpe@flea>","list_archive_url":null,"date":"2017-10-27T15:12:20","subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi,\n\nThe prefix should be ARM, uppercase.\n\nOn Tue, Oct 24, 2017 at 07:57:08PM +0200, Corentin Labbe wrote:\n> Since dwmac-sun8i could use either an integrated PHY or an external PHY\n> (which could be at same MDIO address), we need to represent this selection\n> by a MDIO switch.\n> \n> Signed-off-by: Corentin Labbe \n> ---\n> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 32 +++++++++++++++++++++++++++-----\n> 1 file changed, 27 insertions(+), 5 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> index d762098fc589..0e97df490aba 100644\n> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> @@ -422,14 +422,36 @@\n> \t\t\t#size-cells = <0>;\n> \t\t\tstatus = \"disabled\";\n> \n> -\t\t\tmdio: mdio {\n> +\t\t\tmdio0: mdio {\n> \t\t\t\t#address-cells = <1>;\n> \t\t\t\t#size-cells = <0>;\n> -\t\t\t\tint_mii_phy: ethernet-phy@1 {\n> -\t\t\t\t\tcompatible = \"ethernet-phy-ieee802.3-c22\";\n> +\t\t\t\tcompatible = \"snps,dwmac-mdio\";\n> +\t\t\t};\n> +\n> +\t\t\tmdio-mux {\n> +\t\t\t\tcompatible = \"allwinner,sun8i-h3-mdio-mux\";\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <0>;\n> +\t\t\t\tmdio-parent-bus = <&mdio0>;\n\nAnd you should have a line here.\n\nThanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNnRn1vdHz9t3s\n\tfor ;\n\tSat, 28 Oct 2017 02:12:37 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932417AbdJ0PMZ (ORCPT );\n\tFri, 27 Oct 2017 11:12:25 -0400","from mail.free-electrons.com ([62.4.15.54]:53810 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932143AbdJ0PMX (ORCPT\n\t); Fri, 27 Oct 2017 11:12:23 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 0E33720389; Fri, 27 Oct 2017 17:12:21 +0200 (CEST)","from localhost (unknown [185.94.189.189])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 9B1EB2037C;\n\tFri, 27 Oct 2017 17:12:20 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 27 Oct 2017 17:12:20 +0200","From":"Maxime Ripard ","To":"Corentin Labbe ","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,\n\tlinux@armlinux.org.uk, catalin.marinas@arm.com,\n\twill.deacon@arm.com, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, andrew@lunn.ch, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio\n\tswitch used by sun8i-h3-emac","Message-ID":"<20171027151220.m3vbtqd22bbupvpe@flea>","References":"<20171024175714.15840-1-clabbe.montjoie@gmail.com>\n\t<20171024175714.15840-5-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"vll6ktdf4tacmmcr\"","Content-Disposition":"inline","In-Reply-To":"<20171024175714.15840-5-clabbe.montjoie@gmail.com>","User-Agent":"NeoMutt/20171013","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]