[{"id":1794571,"web_url":"http://patchwork.ozlabs.org/comment/1794571/","msgid":"<20171027.115354.2129010929524093978.davem@davemloft.net>","list_archive_url":null,"date":"2017-10-27T02:53:54","subject":"Re: [PATCH net-next] net: updating dst lastusage is an unlikely\n\tevent.","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Paolo Abeni \nDate: Tue, 24 Oct 2017 12:41:01 +0200\n\n> Since commit 0da4af00b2ed (\"ipv6: only update __use and lastusetime\n> once per jiffy at most\"), updating the dst lastuse field is an\n> unlikely action: it happens at most once per jiffy, out of\n> potentially millions of calls per second.\n> \n> Mark explicitly the code as such, and let the compiler generate\n> better code.\n> \n> Note: gcc 7.2 and several older versions do actually generate\n> different - better - code when the unlikely() hint is in place,\n> avoid jump in the fast path and keeping better code locality.\n> \n> Signed-off-by: Paolo Abeni \n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNT3d1Dm7z9s8J\n\tfor ;\n\tFri, 27 Oct 2017 13:54:05 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932428AbdJ0CyC (ORCPT );\n\tThu, 26 Oct 2017 22:54:02 -0400","from shards.monkeyblade.net ([184.105.139.130]:43490 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932334AbdJ0CyA (ORCPT\n\t); Thu, 26 Oct 2017 22:54:00 -0400","from localhost (unknown [211.196.191.92])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id DEC4E133FDE8F;\n\tThu, 26 Oct 2017 19:53:58 -0700 (PDT)"],"Date":"Fri, 27 Oct 2017 11:53:54 +0900 (KST)","Message-Id":"<20171027.115354.2129010929524093978.davem@davemloft.net>","To":"pabeni@redhat.com","Cc":"netdev@vger.kernel.org, weiwan@google.com, kafai@fb.com,\n\thannes@stressinduktion.org","Subject":"Re: [PATCH net-next] net: updating dst lastusage is an unlikely\n\tevent.","From":"David Miller ","In-Reply-To":"","References":"","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 26 Oct 2017 19:54:00 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]