[{"id":1794594,"web_url":"http://patchwork.ozlabs.org/comment/1794594/","msgid":"<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-27T03:13:36","subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:\n> Signed-off-by: Lukasz Majewski <lukma@denx.de>\n> ---\n>  .../bindings/display/panel/tianma,tm070rvhg71.txt  |  7 ++++++\n>  drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++++++++\n>  2 files changed, 34 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> \n> diff --git a/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> new file mode 100644\n> index 0000000..b84217f\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> @@ -0,0 +1,7 @@\n> +Tianma Micro-electronics TM070RVHG71 7.0\" WXGA TFT LCD panel\n> +\n> +Required properties:\n> +- compatible: should be \"tianma,tm070rvhg71\n> +\n> +This binding is compatible with the simple-panel binding, which is specified\n> +in simple-panel.txt in this directory.\n\nNo supplies? Still need to list power-supply here if so, so it is clear \nthat this display has a single supply (or you need to list multiple ones \nif not).\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNTVF03k1z9t30\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 14:13:41 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751940AbdJ0DNj (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 26 Oct 2017 23:13:39 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:44284 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751747AbdJ0DNi (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 26 Oct 2017 23:13:38 -0400","by mail-oi0-f65.google.com with SMTP id v132so8986062oie.1;\n\tThu, 26 Oct 2017 20:13:38 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\t13sm3346650otc.3.2017.10.26.20.13.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 20:13:37 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=LBVQU1SuOmtKQ/+FlNgom9HW4Gx4QaDEfF/bDonoSaA=;\n\tb=tTiYtrk4RT4BYEAPp01tTSXOBaSRw4SySa01Fg1PDi2o1IZL26yeI1dFEte27OYpGt\n\tCwhXBGJYGhm5CddN1gsCZyZdetIy/EN6qGQ61PcWp8mkpnLcLeYdY3Um4XIMiv7bijaG\n\ta+KKtRAxaKhIZRpL6q8B4xXCy7GhsdGgnb4ZEWpiBEj7Fi2rKLEODmF/NcqcA4+HWRfz\n\tjX9wp4e78FWmNg5drzBQLjwUWSgQJL6zVf/Uhyb/WY11uSh8O3IzcNZ6Xz4jK4d2xUYJ\n\tpt1HO9MkejFXzD5RazrUe4ybrekXWYt7maWPN0a11xRtWMmu4UM+jJdMoGl8ApWLEeFk\n\tEVRA==","X-Gm-Message-State":"AMCzsaUdw/2+OqWDW9qORnwrOdeqoXakuzJwnbIIld3X7TMfOyy8ZcHP\n\tyL1vk0S8LlvHpManHpjjHQ==","X-Google-Smtp-Source":"ABhQp+TBOhVCh6H/nM4C55h+quxOPFCVO9udvTsIfBpIQJdsY562a/cgx/tyHt0sg8XyoY+Hyad/NA==","X-Received":"by 10.202.245.88 with SMTP id t85mr3811733oih.194.1509074017847; \n\tThu, 26 Oct 2017 20:13:37 -0700 (PDT)","Date":"Thu, 26 Oct 2017 22:13:36 -0500","From":"Rob Herring <robh@kernel.org>","To":"Lukasz Majewski <lukma@denx.de>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tDavid Airlie <airlied@linux.ie>, \n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","Message-ID":"<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>","References":"<1508537403-878-1-git-send-email-lukma@denx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1508537403-878-1-git-send-email-lukma@denx.de>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794698,"web_url":"http://patchwork.ozlabs.org/comment/1794698/","msgid":"<20171027101800.5dbfb161@jawa>","list_archive_url":null,"date":"2017-10-27T08:18:00","subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Rob,\n\n> On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:\n> > Signed-off-by: Lukasz Majewski <lukma@denx.de>\n> > ---\n> >  .../bindings/display/panel/tianma,tm070rvhg71.txt  |  7 ++++++\n> >  drivers/gpu/drm/panel/panel-simple.c               | 27\n> > ++++++++++++++++++++++ 2 files changed, 34 insertions(+)\n> >  create mode 100644\n> > Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > \n> > diff --git\n> > a/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > new file mode 100644 index 0000000..b84217f --- /dev/null\n> > +++\n> > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > @@ -0,0 +1,7 @@ +Tianma Micro-electronics TM070RVHG71 7.0\" WXGA TFT\n> > LCD panel +\n> > +Required properties:\n> > +- compatible: should be \"tianma,tm070rvhg71\n> > +\n> > +This binding is compatible with the simple-panel binding, which is\n> > specified +in simple-panel.txt in this directory.\n> \n> No supplies? Still need to list power-supply here if so, so it is\n> clear that this display has a single supply (or you need to list\n> multiple ones if not).\n\nI took the same approach as several other simple panels having\ndescription in Documentation/devicetree/bindings/display/panel/*\ndirectory (e.g. innolux,g121i1-l01.txt) .\n\nIn the description it is stated that this binding is compatible with\none documented in the simple-panel.txt, which defines following\nproperties:\n\nRequired properties:\n- power-supply: regulator to provide the supply voltage\n\nOptional properties:\n- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing\n- enable-gpios: GPIO pin to enable or disable the panel\n- backlight: phandle of the backlight device attached to the panel\n\n\nDo I need to do something more?\n\n> \n> Rob\n\n\nBest regards,\n\nLukasz Majewski\n\n--\n\nDENX Software Engineering GmbH,      Managing Director: Wolfgang Denk\nHRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\nPhone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNcFZ03VCz9t30\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 19:18:10 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751050AbdJ0ISH (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tFri, 27 Oct 2017 04:18:07 -0400","from mail-out.m-online.net ([212.18.0.10]:39128 \"EHLO\n\tmail-out.m-online.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750790AbdJ0ISE (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Fri, 27 Oct 2017 04:18:04 -0400","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3yNcFQ2PSHz1rgsW;\n\tFri, 27 Oct 2017 10:18:02 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3yNcFQ12g6z1tSmS;\n\tFri, 27 Oct 2017 10:18:02 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id oFezAMhD890w; Fri, 27 Oct 2017 10:18:01 +0200 (CEST)","from jawa (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tFri, 27 Oct 2017 10:18:01 +0200 (CEST)"],"X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"PERw8Blw8bCWJ3M2WU1SKighdBcW73rwYdMUMBEL0k4=","Date":"Fri, 27 Oct 2017 10:18:00 +0200","From":"Lukasz Majewski <lukma@denx.de>","To":"Rob Herring <robh@kernel.org>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tDavid Airlie <airlied@linux.ie>, \n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","Message-ID":"<20171027101800.5dbfb161@jawa>","In-Reply-To":"<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>","References":"<1508537403-878-1-git-send-email-lukma@denx.de>\n\t<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>","Organization":"denx.de","X-Mailer":"Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1799403,"web_url":"http://patchwork.ozlabs.org/comment/1799403/","msgid":"<20171105231955.46d20be1@jawa>","list_archive_url":null,"date":"2017-11-05T22:19:55","subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Rob,\n\n> Hi Rob,\n> \n> > On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:  \n> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>\n> > > ---\n> > >  .../bindings/display/panel/tianma,tm070rvhg71.txt  |  7 ++++++\n> > >  drivers/gpu/drm/panel/panel-simple.c               | 27\n> > > ++++++++++++++++++++++ 2 files changed, 34 insertions(+)\n> > >  create mode 100644\n> > > Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > > \n> > > diff --git\n> > > a/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > > new file mode 100644 index 0000000..b84217f --- /dev/null\n> > > +++\n> > > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n> > > @@ -0,0 +1,7 @@ +Tianma Micro-electronics TM070RVHG71 7.0\" WXGA\n> > > TFT LCD panel +\n> > > +Required properties:\n> > > +- compatible: should be \"tianma,tm070rvhg71\n> > > +\n> > > +This binding is compatible with the simple-panel binding, which\n> > > is specified +in simple-panel.txt in this directory.  \n> > \n> > No supplies? Still need to list power-supply here if so, so it is\n> > clear that this display has a single supply (or you need to list\n> > multiple ones if not).  \n> \n> I took the same approach as several other simple panels having\n> description in Documentation/devicetree/bindings/display/panel/*\n> directory (e.g. innolux,g121i1-l01.txt) .\n> \n> In the description it is stated that this binding is compatible with\n> one documented in the simple-panel.txt, which defines following\n> properties:\n> \n> Required properties:\n> - power-supply: regulator to provide the supply voltage\n> \n> Optional properties:\n> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing\n> - enable-gpios: GPIO pin to enable or disable the panel\n> - backlight: phandle of the backlight device attached to the panel\n> \n> \n> Do I need to do something more?\n\nGentle ping...\n\n> \n> > \n> > Rob  \n> \n> \n> Best regards,\n> \n> Lukasz Majewski\n> \n> --\n> \n> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk\n> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\n> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de\n\n\nBest regards,\n\nLukasz Majewski\n\n--\n\nDENX Software Engineering GmbH,      Managing Director: Wolfgang Denk\nHRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\nPhone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yVVWD5mzNz9s81\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon,  6 Nov 2017 09:20:24 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751136AbdKEWUC (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSun, 5 Nov 2017 17:20:02 -0500","from mail-out.m-online.net ([212.18.0.9]:35744 \"EHLO\n\tmail-out.m-online.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750857AbdKEWUA (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Sun, 5 Nov 2017 17:20:00 -0500","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3yVVVk06MMz1qsTF;\n\tSun,  5 Nov 2017 23:19:57 +0100 (CET)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3yVVVj65dMz1r6DD;\n\tSun,  5 Nov 2017 23:19:57 +0100 (CET)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 6-A3Z8qB60dl; Sun,  5 Nov 2017 23:19:56 +0100 (CET)","from jawa (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tSun,  5 Nov 2017 23:19:56 +0100 (CET)"],"X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"Lfn2tNreS9CFQxib2y4OoVoimn9d3tw4D4xMc2sGOdc=","Date":"Sun, 5 Nov 2017 23:19:55 +0100","From":"Lukasz Majewski <lukma@denx.de>","To":"Rob Herring <robh@kernel.org>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tDavid Airlie <airlied@linux.ie>, \n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","Message-ID":"<20171105231955.46d20be1@jawa>","In-Reply-To":"<20171027101800.5dbfb161@jawa>","References":"<1508537403-878-1-git-send-email-lukma@denx.de>\n\t<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>\n\t<20171027101800.5dbfb161@jawa>","Organization":"denx.de","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tboundary=\"Sig_/oxaH4Ti7GXT2X5Jbxyhl+RO\";\n\tprotocol=\"application/pgp-signature\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1799733,"web_url":"http://patchwork.ozlabs.org/comment/1799733/","msgid":"<CAL_JsqJz67k_fTMkx5dHb5qFwXif9y+Cv=+PTq7OLH7woNoU=g@mail.gmail.com>","list_archive_url":null,"date":"2017-11-06T14:30:31","subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Oct 27, 2017 at 3:18 AM, Lukasz Majewski <lukma@denx.de> wrote:\n> Hi Rob,\n>\n>> On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:\n>> > Signed-off-by: Lukasz Majewski <lukma@denx.de>\n>> > ---\n>> >  .../bindings/display/panel/tianma,tm070rvhg71.txt  |  7 ++++++\n>> >  drivers/gpu/drm/panel/panel-simple.c               | 27\n>> > ++++++++++++++++++++++ 2 files changed, 34 insertions(+)\n>> >  create mode 100644\n>> > Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n>> >\n>> > diff --git\n>> > a/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n>> > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n>> > new file mode 100644 index 0000000..b84217f --- /dev/null\n>> > +++\n>> > b/Documentation/devicetree/bindings/display/panel/tianma,tm070rvhg71.txt\n>> > @@ -0,0 +1,7 @@ +Tianma Micro-electronics TM070RVHG71 7.0\" WXGA TFT\n>> > LCD panel +\n>> > +Required properties:\n>> > +- compatible: should be \"tianma,tm070rvhg71\n>> > +\n>> > +This binding is compatible with the simple-panel binding, which is\n>> > specified +in simple-panel.txt in this directory.\n>>\n>> No supplies? Still need to list power-supply here if so, so it is\n>> clear that this display has a single supply (or you need to list\n>> multiple ones if not).\n>\n> I took the same approach as several other simple panels having\n> description in Documentation/devicetree/bindings/display/panel/*\n> directory (e.g. innolux,g121i1-l01.txt) .\n>\n> In the description it is stated that this binding is compatible with\n> one documented in the simple-panel.txt, which defines following\n> properties:\n>\n> Required properties:\n> - power-supply: regulator to provide the supply voltage\n>\n> Optional properties:\n> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing\n> - enable-gpios: GPIO pin to enable or disable the panel\n> - backlight: phandle of the backlight device attached to the panel\n>\n>\n> Do I need to do something more?\n\nYes. How do I know this panel has a single power supply vs. it has\nmultiple supplies and you haven't thought about supplies yet or they\naren't s/w controlled on some boards. The latter is frequently the\ncase when I go read the datasheets.\n\nAnd yes there are examples that don't do this, but we're stricter now.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yVw340F3cz9s82\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tTue,  7 Nov 2017 01:30:55 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752714AbdKFOay (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 6 Nov 2017 09:30:54 -0500","from mail.kernel.org ([198.145.29.99]:33006 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752276AbdKFOax (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tMon, 6 Nov 2017 09:30:53 -0500","from mail-qt0-f180.google.com (mail-qt0-f180.google.com\n\t[209.85.216.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 9C97B2193C;\n\tMon,  6 Nov 2017 14:30:52 +0000 (UTC)","by mail-qt0-f180.google.com with SMTP id v41so11075281qtv.12;\n\tMon, 06 Nov 2017 06:30:52 -0800 (PST)","by 10.12.130.134 with HTTP; Mon, 6 Nov 2017 06:30:31 -0800 (PST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 9C97B2193C","X-Gm-Message-State":"AMCzsaXTz3chsuMx04qphaNdaB3nb/pOU6JywmYvy6mZvQ0nxaw36VYx\n\tVOII/X6fLsK1tacdkmrioRjOxdh59L7Mc+x4UQ==","X-Google-Smtp-Source":"ABhQp+R2CLL20P5TdOb5CjoUcaxlNDA9VlHl5oDhsoTZkiT3bTcqFbvESoZeED8hHTNz3ftVMdEyRKKdeq710lzkDPE=","X-Received":"by 10.200.15.204 with SMTP id f12mr23974639qtk.161.1509978651791;\n\tMon, 06 Nov 2017 06:30:51 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<20171027101800.5dbfb161@jawa>","References":"<1508537403-878-1-git-send-email-lukma@denx.de>\n\t<20171027031336.psu7hn27w2xajyux@rob-hp-laptop>\n\t<20171027101800.5dbfb161@jawa>","From":"Rob Herring <robh@kernel.org>","Date":"Mon, 6 Nov 2017 08:30:31 -0600","X-Gmail-Original-Message-ID":"<CAL_JsqJz67k_fTMkx5dHb5qFwXif9y+Cv=+PTq7OLH7woNoU=g@mail.gmail.com>","Message-ID":"<CAL_JsqJz67k_fTMkx5dHb5qFwXif9y+Cv=+PTq7OLH7woNoU=g@mail.gmail.com>","Subject":"Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support\n\t(800x480)","To":"Lukasz Majewski <lukma@denx.de>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tDavid Airlie <airlied@linux.ie>, \n\tdri-devel <dri-devel@lists.freedesktop.org>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]