[{"id":1790794,"web_url":"http://patchwork.ozlabs.org/comment/1790794/","msgid":"<20171019171615.hq2ukawo35arvyj3@tarshish>","list_archive_url":null,"date":"2017-10-19T17:16:15","subject":"Re: [Buildroot] [PATCH v3 1/1] gstreamer1-mm: new package","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Adam,\n\nOn Wed, Oct 18, 2017 at 09:17:02AM -0400, Adam Duskett wrote:\n\n[...]\n\n> diff --git a/package/gstreamer1/gstreamer1-mm/Config.in b/package/gstreamer1/gstreamer1-mm/Config.in\n> new file mode 100644\n> index 0000000000..33052c943e\n> --- /dev/null\n> +++ b/package/gstreamer1/gstreamer1-mm/Config.in\n> @@ -0,0 +1,28 @@\n> +config BR2_PACKAGE_GSTREAMER1_MM\n> +\tbool \"gstreamer1-mm\"\n> +\tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # glibmm\n> +\tdepends on BR2_INSTALL_LIBSTDCPP # glibmm\n\nC++ seems to be a direct dependency of gstreamer1-mm. So this comment is \nmisleading.\n\n> +\tdepends on BR2_USE_WCHAR # libglib2\n\nlibglib2 is an indirect dependency of gstreamer1-mm via glibmm, right? In this \ncase we usually write:\n\n depends on BR2_USE_WCHAR # glibmm -> libglib2\n\n> +\tdepends on BR2_TOOLCHAIN_HAS_THREADS # libglib2\n> +\tdepends on BR2_USE_MMU # libglib2\n\nSame here.\n\n> +\tselect BR2_PACKAGE_GST1_PLUGINS_BASE\n> +\tselect BR2_PACKAGE_GLIBMM\n> +\thelp\n> +\t gstreamermm provides C++ bindings for the GStreamer streaming\n> +\t multimedia library (http://gstreamer.freedesktop.org). With\n> +\t gstreamermm it is possible to\tdevelop applications that work\n> +\t with multimedia in C++.\n> +\n> +\t gstreamermm is developed over glibmm, libsigc++ and libxml++\n> +\t and the functionalities they provide. This means that, among\n> +\t other things, referencing and unreferencing of GObjects is\n> +\t handled automatically via glibmm's automatic pointer class,\n> +\t Glib::RefPtr, and libsigc++'s slots are used for callbacks and\n> +\t signals.\n> +\n> +\t https://gstreamer.freedesktop.org/bindings/cplusplus.html\n\nbaruch","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yHwZX5GtMz9tXc\n\tfor ;\n\tFri, 20 Oct 2017 04:16:36 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 259352D9A6;\n\tThu, 19 Oct 2017 17:16:32 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lG+mvG0bDBHK; Thu, 19 Oct 2017 17:16:30 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 51C4A2316D;\n\tThu, 19 Oct 2017 17:16:30 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DCA7D1C0060\n\tfor ;\n\tThu, 19 Oct 2017 17:16:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D7EBA88A38\n\tfor ;\n\tThu, 19 Oct 2017 17:16:28 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dfXUC24jY1Fx for ;\n\tThu, 19 Oct 2017 17:16:26 +0000 (UTC)","from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 60D408770B\n\tfor ; Thu, 19 Oct 2017 17:16:26 +0000 (UTC)","from tarshish (unknown [10.0.8.6])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id AE6C54400D6;\n\tThu, 19 Oct 2017 20:16:18 +0300 (IDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Thu, 19 Oct 2017 20:16:15 +0300","From":"Baruch Siach ","To":"Adam Duskett ","Message-ID":"<20171019171615.hq2ukawo35arvyj3@tarshish>","References":"<20171018131702.1710-1-Adamduskett@outlook.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20171018131702.1710-1-Adamduskett@outlook.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Cc":"Adam Duskett , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3 1/1] gstreamer1-mm: new package","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]