[{"id":1787054,"web_url":"http://patchwork.ozlabs.org/comment/1787054/","msgid":"<1508089409.31614.74.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-10-15T17:43:29","subject":"Re: [RFC PATCH v2 5/5] wave: Added TCP Wave","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Sat, 2017-10-14 at 13:47 +0200, Natale Patriciello wrote:\n> TCP Wave (TCPW) replaces the window-based transmission paradigm of the\n> standard TCP with a burst-based transmission, the ACK-clock scheduling\n> with a self-managed timer and the RTT-based congestion control loop\n> with an Ack-based Capacity and Congestion Estimation (ACCE) module. In\n> non-technical words, it sends data down the stack when its internal\n> timer expires, and the timing of the received ACKs contribute to\n> updating this timer regularly.\n> \n\n\n> It is the first TCP congestion control that uses the timing constraint\n> developed in the Linux kernel.\n\nYou seem to have missed BBR.\n\n\n\nThis is against what we have worked in the last years, preventing bursts\nin the first place.\n\nIf this series is to address WIFI peculiarities with TSQ (this is a well\nknown problem, still waiting for a fix), I would rather not add all this\ncode in TCP and find better alternatives.\n\nSince you do not provide information and testing results, there is no\nchance we accept such patches.\n\nYour work seems to be a variation of TSQ, and a very complex one.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Xvy18eV7\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yFTXf2THFz9t38\n\tfor ;\n\tMon, 16 Oct 2017 04:51:29 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751140AbdJORnd (ORCPT );\n\tSun, 15 Oct 2017 13:43:33 -0400","from mail-pg0-f46.google.com ([74.125.83.46]:49113 \"EHLO\n\tmail-pg0-f46.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750907AbdJORnb (ORCPT\n\t); Sun, 15 Oct 2017 13:43:31 -0400","by mail-pg0-f46.google.com with SMTP id v78so5002453pgb.5\n\tfor ; Sun, 15 Oct 2017 10:43:31 -0700 (PDT)","from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\tl23sm11640697pfg.83.2017.10.15.10.43.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 15 Oct 2017 10:43:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=7eWbWFLwbnJq60Nb3MLO/m7Hg9+lnm0dFEcFyNhSu0U=;\n\tb=Xvy18eV7SM8+a1vaRPm/v0YSjGIjnwFGEFgBq6hDujCqhjf1viB6uE7Yx+bUJLp7xc\n\thwDlPnEOR0Ftis5Alk9ME1qSdQDh4IQmygmuVDgtYz7j+roAitcXOiiDvWZY5vtoKcZT\n\tBBK4lgrcu+8qakY+9kNPGV5R7GAHVhWQSsm1dbw59PQfnq14Gx1CdDOetHFuj4Awv7cZ\n\t45/F6SfwNuh6sdQ7emdnoXKdjkkiJ0ThyVcQVGKHmmazDdYFt00jQ7p6h8DpWti4nk+/\n\tl3VuF/r4cb2u9SdT7ks1NChwM1ainNPt7x0eN+MkOUJcNWtdbuB0xrjymMIxCRaaUjo+\n\tNSWg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=7eWbWFLwbnJq60Nb3MLO/m7Hg9+lnm0dFEcFyNhSu0U=;\n\tb=Rd86XInLghY7cuAe89PTzcp0EWnoUevE3Ff1J90FXJr0glp0a3qE3KyZbq3SXXk4KH\n\tRlRGbJKzNo3ojkAV0bWKjD1JX//Wnwq+Dwai/XHnYc+DqvDZcZqGm+RwzEwaZ+iFTe1M\n\tRJFg2gpyGjt5xtrmYoijxrxUNgL2CxpTz4NrCc4YGKtu31K3cz5vwi8xpECNVTQhPDXA\n\tHXqwXrvqLmFE/i2IafR7FGMoovgmh3oA5TCuuGRdgL2XquZ0TIkyYhkf6yTFOYw/aABt\n\t9Q7CCpZ7hB5qwLyCG22YJzC7il4r1BagYUucxJagPSwhGijA+QPWUYptWonLjHMp75kp\n\tdsxg==","X-Gm-Message-State":"AMCzsaWPONRk+D1TTrNGIBg8fXSesfHed6ZHt632mSxaSfPq/e7nxhQR\n\tkpENtcHRo/jbsbkFmPNma0E=","X-Google-Smtp-Source":"AOwi7QCMFW/UIOPJYKzbPw1I7rT/TBCA5CSRM0u2exf/3kB7zYfq+oQ0xWV09NosmdCE9rW+ag0W1w==","X-Received":"by 10.84.128.1 with SMTP id 1mr6683921pla.238.1508089411133;\n\tSun, 15 Oct 2017 10:43:31 -0700 (PDT)","Message-ID":"<1508089409.31614.74.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [RFC PATCH v2 5/5] wave: Added TCP Wave","From":"Eric Dumazet ","To":"Natale Patriciello ","Cc":"\"David S . Miller\" ,\n\tnetdev , Ahmed Said ,\n\tFrancesco Zampognaro ,\n\tCesare Roseti ","Date":"Sun, 15 Oct 2017 10:43:29 -0700","In-Reply-To":"<20171014114714.3694-6-natale.patriciello@gmail.com>","References":"<20171014114714.3694-1-natale.patriciello@gmail.com>\n\t<20171014114714.3694-6-natale.patriciello@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]