[{"id":1785879,"web_url":"http://patchwork.ozlabs.org/comment/1785879/","msgid":"","list_archive_url":null,"date":"2017-10-12T21:55:35","subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","submitter":{"id":6978,"url":"http://patchwork.ozlabs.org/api/people/6978/","name":"Fabio Estevam","email":"festevam@gmail.com"},"content":"On Wed, Oct 11, 2017 at 12:56 PM, Eric Nelson wrote:\n> Note that alarms are not currently implemented.\n>\n> 64 bytes of nvmem is supported and exposed in\n> sysfs (# is the instance number, starting with 0):\n>\n> /sys/bus/nvmem/devices/pcf85363-#/nvmem\n>\n> Signed-off-by: Eric Nelson \n\nReviewed-by: Fabio Estevam ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LJBn8xlj\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yCl5k0kn3z9sNw\n\tfor ;\n\tFri, 13 Oct 2017 08:55:38 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756601AbdJLVzh (ORCPT );\n\tThu, 12 Oct 2017 17:55:37 -0400","from mail-oi0-f45.google.com ([209.85.218.45]:49522 \"EHLO\n\tmail-oi0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756600AbdJLVzg (ORCPT\n\t); Thu, 12 Oct 2017 17:55:36 -0400","by mail-oi0-f45.google.com with SMTP id w197so10674179oif.6;\n\tThu, 12 Oct 2017 14:55:36 -0700 (PDT)","by 10.157.44.195 with HTTP; Thu, 12 Oct 2017 14:55:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=qVv2oh2yx3ThRK4tcZmRBBNldVkPlznm4mP/DlJNGj0=;\n\tb=LJBn8xljRk7TE5i1eFFTqSQQpFMuoEmndr2IeLbb96ISyqby4B3yuA9b5QoZA+3oiV\n\tRWi7GS/iRzbojGoELb9sTX69P41OUlcZIeYErhwrBzEfUhjsmGqK6sEA2wMqtG8b/kb2\n\tXCw8cyg5OJ4MyNx+EnyGkYhVq5byhD39VZ2MACqVHPDSVj/Kr0jgP0V2ZttMoVtXlB3c\n\tksfEwb4DeCyLHHeDW0pLCxBUfxMTpo0Lsc/TPFeWXRw+rfcO+bZX+mQmB2qSg/LMvxD7\n\tHTsRXGaFpbb4rvnhJBtC24W6+ItDSl6pv4KqSWK7Y6K1lOiv61QLbLl/Jrs9Q8EYuKQm\n\tZCwg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=qVv2oh2yx3ThRK4tcZmRBBNldVkPlznm4mP/DlJNGj0=;\n\tb=tcqO8Sa0g3nuQZRUvip6aTlK8Bdx1PyhLngzWWWL24fXfiIpQrtsg4fg05YoX9z4NF\n\t1sSAUsbg80HeHWDRLgk/b4ra9AUqQtZoE0cOREYvckbo7r5usC5GTZ7z/yg4oCYp5JYu\n\tHIyqO/OCMifiruf4sO/yCSKnFw/2cMoTVkCPiR8+nxxCw5CwhTRU/FLBiJ2Lwkhfyr4X\n\tk4tVj+JBwcEAlzcPrnkraWtwq7W96y2/jqJFhjk7HMF7skaKregRqTAzoTyu6TeABa5D\n\t/HEl88r1CJGFfFEiyRotZkbrhLOfz9bqsM+2aYTok7aUGmLvZ8CEJ118AsbTaQWimfHW\n\t0QzQ==","X-Gm-Message-State":"AMCzsaUITXARkhn4SeTiHaXjjrzxasqWX8mc1h/ybaUoENXAPMFkd7kY\n\tFrth3SuixIp1qoepWg0BfPBaWqiSP2lHr34YEcbInw==","X-Google-Smtp-Source":"ABhQp+RMeUOGY6/nbnaAO2rQuT65ahmdew59qdBrQyScGuIZI+FnHm/4QKLvdACMzV9ulMBO7Xd5+kc5k23uoBFboug=","X-Received":"by 10.157.31.71 with SMTP id x7mr2448459otx.14.1507845335607;\n\tThu, 12 Oct 2017 14:55:35 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1507737390-27818-1-git-send-email-eric@nelint.com>","References":"\n\t<1507737390-27818-1-git-send-email-eric@nelint.com>","From":"Fabio Estevam ","Date":"Thu, 12 Oct 2017 18:55:35 -0300","Message-ID":"","Subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","To":"Eric Nelson ","Cc":"linux-rtc@vger.kernel.org, Alessandro Zummo ,\n\tAlexandre Belloni ,\n\t\"robh+dt@kernel.org\" ,\n\tMark Rutland ,\n\t\"devicetree@vger.kernel.org\" ,\n\tOtavio Salvador ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1788818,"web_url":"http://patchwork.ozlabs.org/comment/1788818/","msgid":"<20171017200622.7xs6hiw3y43mxi2k@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-17T20:06:22","subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Oct 11, 2017 at 08:56:30AM -0700, Eric Nelson wrote:\n> Note that alarms are not currently implemented.\n> \n> 64 bytes of nvmem is supported and exposed in\n> sysfs (# is the instance number, starting with 0):\n> \n> \t/sys/bus/nvmem/devices/pcf85363-#/nvmem\n> \n> Signed-off-by: Eric Nelson \n> ---\n> V2 addresses a couple of issues highlighted by Fabio Estevam\n> 1. Kconfig updated to select REGMAP_I2C\n> 2. Switch to of_device_id from i2c_device_id for driver matching\n> \n> Documentation/devicetree/bindings/rtc/pcf85363.txt | 16 ++\n> drivers/rtc/Kconfig | 13 ++\n> drivers/rtc/Makefile | 1 +\n> drivers/rtc/rtc-pcf85363.c | 221 +++++++++++++++++++++\n> 4 files changed, 251 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/rtc/pcf85363.txt\n> create mode 100644 drivers/rtc/rtc-pcf85363.c\n> \n> diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n> new file mode 100644\n> index 0000000..5fddb9f\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n> @@ -0,0 +1,16 @@\n> +NXP PCF85363 Real Time Clock\n> +============================\n> +\n> +Required properties:\n> +- compatible: Should contain \"nxp,pcf85363\".\n> +- reg: I2C address for chip.\n> +\n> +Example:\n> +\n> +pcf85363: pcf85363@51 {\n> +\tcompatible = \"nxp,pcf85363\";\n> +\treg = <0x51>;\n> +};\n> +\n> +Note that alarms are not yet supported, so a specifier for\n> +\"interrupts\" will be ignored.\n\nIrrelevant to the binding. That's a driver feature (or lack of). If the \ndevice has an interrupt line, you should document it. It can be optional \nthough.\n\nRob","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGmSn4tZtz9t38\n\tfor ;\n\tWed, 18 Oct 2017 07:07:37 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1764052AbdJQUHb (ORCPT );\n\tTue, 17 Oct 2017 16:07:31 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:51211 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1764048AbdJQUGY (ORCPT\n\t); Tue, 17 Oct 2017 16:06:24 -0400","by mail-oi0-f68.google.com with SMTP id j126so5165415oib.8;\n\tTue, 17 Oct 2017 13:06:24 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tp23sm5510954ota.56.2017.10.17.13.06.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 17 Oct 2017 13:06:22 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=OMRDtDLw/UumxdLiOYqhahieQwxp9SV3ALGkQCCCvCI=;\n\tb=qcIAywvchNFNtnEcuWEQEFEIkfLZhHWXljoR5jDSJyZJwqH9Eh8gWNZIwyHJ6aZAhF\n\txlYEImyqKQZsTzpKfdIqauD+J7HrbNIDyQ+21dv17uQvE0kwLK5Tl3mT61UwsA0Xh/kA\n\tqb8WgwfSkYC6T6zXt+yzPuPCsOMOt3UGnzp5/pUwsRxA4xzM617NfZTs2S1bQtfvzelo\n\td8lomNVeCs5fE03ZyVrtCw/5m0bpKa41H7eD3MlJBmZUlHrsComJgDkqA7GzTuMAktjN\n\tYp71PP3Eqfp8mgcsNZw5gMpGrxe5jNvb1PRS/Hd8evLtnvSiDpy7rNMafZPP+RN7lkY0\n\tL3xQ==","X-Gm-Message-State":"AMCzsaW+yzUeR66YbpESDQzXZXICi7jifQfvkOLlxIgjt29ncCNDOzmx\n\tdM1Kk28Xn4Kk4M/SV1e6Tg==","X-Google-Smtp-Source":"ABhQp+Tm58zs+eaOZkrSYEdlxs0NVh/exlMAp3F4k+BMUwjgplpOA0mCQNApr2OTuKjOqT7Dsa80gA==","X-Received":"by 10.202.95.137 with SMTP id t131mr7872187oib.18.1508270783793; \n\tTue, 17 Oct 2017 13:06:23 -0700 (PDT)","Date":"Tue, 17 Oct 2017 15:06:22 -0500","From":"Rob Herring ","To":"Eric Nelson ","Cc":"linux-rtc@vger.kernel.org, a.zummo@towertech.it,\n\talexandre.belloni@free-electrons.com, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, otavio.salvador@ossystems.com.br,\n\tfestevam@gmail.com","Subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","Message-ID":"<20171017200622.7xs6hiw3y43mxi2k@rob-hp-laptop>","References":"\n\t<1507737390-27818-1-git-send-email-eric@nelint.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1507737390-27818-1-git-send-email-eric@nelint.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1788978,"web_url":"http://patchwork.ozlabs.org/comment/1788978/","msgid":"<20602538-2164-e85c-33b6-31c99dfa8a5e@nelint.com>","list_archive_url":null,"date":"2017-10-17T22:24:35","subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","submitter":{"id":67231,"url":"http://patchwork.ozlabs.org/api/people/67231/","name":"Eric Nelson","email":"eric@nelint.com"},"content":"Hi Rob,\n\nOn 10/17/2017 01:06 PM, Rob Herring wrote:\n> On Wed, Oct 11, 2017 at 08:56:30AM -0700, Eric Nelson wrote:\n>> Note that alarms are not currently implemented.\n>>\n>> 64 bytes of nvmem is supported and exposed in\n>> sysfs (# is the instance number, starting with 0):\n>>\n>> \t/sys/bus/nvmem/devices/pcf85363-#/nvmem\n>>\n>> Signed-off-by: Eric Nelson \n>> ---\n>> V2 addresses a couple of issues highlighted by Fabio Estevam\n>> 1. Kconfig updated to select REGMAP_I2C\n>> 2. Switch to of_device_id from i2c_device_id for driver matching\n>>\n>> Documentation/devicetree/bindings/rtc/pcf85363.txt | 16 ++\n>> drivers/rtc/Kconfig | 13 ++\n>> drivers/rtc/Makefile | 1 +\n>> drivers/rtc/rtc-pcf85363.c | 221 +++++++++++++++++++++\n>> 4 files changed, 251 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/rtc/pcf85363.txt\n>> create mode 100644 drivers/rtc/rtc-pcf85363.c\n>>\n>> diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n>> new file mode 100644\n>> index 0000000..5fddb9f\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n>> @@ -0,0 +1,16 @@\n>> +NXP PCF85363 Real Time Clock\n>> +============================\n>> +\n>> +Required properties:\n>> +- compatible: Should contain \"nxp,pcf85363\".\n>> +- reg: I2C address for chip.\n>> +\n>> +Example:\n>> +\n>> +pcf85363: pcf85363@51 {\n>> +\tcompatible = \"nxp,pcf85363\";\n>> +\treg = <0x51>;\n>> +};\n>> +\n>> +Note that alarms are not yet supported, so a specifier for\n>> +\"interrupts\" will be ignored.\n> \n> Irrelevant to the binding. That's a driver feature (or lack of). If the\n> device has an interrupt line, you should document it. It can be optional\n> though.\n> \n\nThat's what I was attempting do do in an awkward way.\n\nSince the driver doesn't support interrupts or alarms at the moment,\nI'll remove this note.\n\nThe chip does have an interrupt pin, but the board I have doesn't\nhave it connected.\n\nRegards,\n\n\nEric","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tsecure) header.d=nelint.com header.i=@nelint.com header.b=\"ZikGXZR/\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGqVy032Sz9t3f\n\tfor ;\n\tWed, 18 Oct 2017 09:24:42 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1764580AbdJQWYk (ORCPT );\n\tTue, 17 Oct 2017 18:24:40 -0400","from mail-pg0-f51.google.com ([74.125.83.51]:47480 \"EHLO\n\tmail-pg0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1764573AbdJQWYi (ORCPT\n\t); Tue, 17 Oct 2017 18:24:38 -0400","by mail-pg0-f51.google.com with SMTP id r25so2564673pgn.4\n\tfor ; Tue, 17 Oct 2017 15:24:38 -0700 (PDT)","from ?IPv6:2600:8800:1300:1c00:551d:9e49:c138:b216?\n\t([2600:8800:1300:1c00:551d:9e49:c138:b216])\n\tby smtp.gmail.com with ESMTPSA id\n\ty197sm19706405pfg.103.2017.10.17.15.24.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 17 Oct 2017 15:24:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nelint.com; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=U3kTQmYSrrFKbBXV+W5Cetmj+jyx8PLLl6nqMNDAhYs=;\n\tb=ZikGXZR/gNrbH4LnlLM3tpJcxCzryciVVxJNwHOlXBzpu98i7exsw3kdmzww66GzH4\n\tJgpxg4W7Vtv3kvfaIiw6yM0t6SgnKxuWvt0Ktorg5mPS5rKhRAj+KJG0baXsgMPK5YDu\n\t6sBapqwuHgsjsVSxtSMgWgsU6oSGvlE3OxRcs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=U3kTQmYSrrFKbBXV+W5Cetmj+jyx8PLLl6nqMNDAhYs=;\n\tb=I5x9CMFkaTmfixK+SS06uLaZFv4WLfBKHZnVi/6LjWHM9y9TuRuGgoSgIkn98S8FMP\n\tNeemMmEeBlIdyDbX6AybQ0SKsxekNZqGLI8d0NDhe6wKwT1PnbwSt98wRLAlFfZdrKcu\n\tO5ULtzRbZaUIUw6RKA6uz5k8J7Xb9grlhGEZ+WOubwJbbE1DYI3bOKKVvLDkHC1RVHsm\n\tTzYLFuE3dNU2yNrudGOolLyS/nSi2+cekrxt8LRbN2bZvWpbJQoO8r0UbeHmIFEl44bO\n\tHKaotcWk3gkxKctXuAy0M7N/jcXlgYf5bTfc3O4o2tzwVr+yz6h2Pwfz31DzepoOPP9e\n\td9lA==","X-Gm-Message-State":"AMCzsaVTTCh5r8PdZYNguPtbGR/V6J8iGObMzMmLynOQEEDu1GWnC8Qs\n\t6RsFFh1a3xBDvIV5s4QaRJnORQ==","X-Google-Smtp-Source":"AOwi7QBgHcFVMe6+iREvWkq97+4flvkF8H1Q5HWqJNw/Yw4iyhOFI2B4YaCriTDafTRcGbXWDoG0EA==","X-Received":"by 10.84.247.133 with SMTP id o5mr12825609pll.6.1508279077705;\n\tTue, 17 Oct 2017 15:24:37 -0700 (PDT)","Subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","To":"Rob Herring ","Cc":"linux-rtc@vger.kernel.org, a.zummo@towertech.it,\n\talexandre.belloni@free-electrons.com, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, otavio.salvador@ossystems.com.br,\n\tfestevam@gmail.com","References":"\n\t<1507737390-27818-1-git-send-email-eric@nelint.com>\n\t<20171017200622.7xs6hiw3y43mxi2k@rob-hp-laptop>","From":"Eric Nelson ","Message-ID":"<20602538-2164-e85c-33b6-31c99dfa8a5e@nelint.com>","Date":"Tue, 17 Oct 2017 15:24:35 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171017200622.7xs6hiw3y43mxi2k@rob-hp-laptop>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1790938,"web_url":"http://patchwork.ozlabs.org/comment/1790938/","msgid":"","list_archive_url":null,"date":"2017-10-19T21:24:33","subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Oct 17, 2017 at 5:24 PM, Eric Nelson wrote:\n> Hi Rob,\n>\n>\n> On 10/17/2017 01:06 PM, Rob Herring wrote:\n>>\n>> On Wed, Oct 11, 2017 at 08:56:30AM -0700, Eric Nelson wrote:\n>>>\n>>> Note that alarms are not currently implemented.\n>>>\n>>> 64 bytes of nvmem is supported and exposed in\n>>> sysfs (# is the instance number, starting with 0):\n>>>\n>>> /sys/bus/nvmem/devices/pcf85363-#/nvmem\n>>>\n>>> Signed-off-by: Eric Nelson \n>>> ---\n>>> V2 addresses a couple of issues highlighted by Fabio Estevam\n>>> 1. Kconfig updated to select REGMAP_I2C\n>>> 2. Switch to of_device_id from i2c_device_id for driver matching\n>>>\n>>> Documentation/devicetree/bindings/rtc/pcf85363.txt | 16 ++\n>>> drivers/rtc/Kconfig | 13 ++\n>>> drivers/rtc/Makefile | 1 +\n>>> drivers/rtc/rtc-pcf85363.c | 221\n>>> +++++++++++++++++++++\n>>> 4 files changed, 251 insertions(+)\n>>> create mode 100644 Documentation/devicetree/bindings/rtc/pcf85363.txt\n>>> create mode 100644 drivers/rtc/rtc-pcf85363.c\n>>>\n>>> diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt\n>>> b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n>>> new file mode 100644\n>>> index 0000000..5fddb9f\n>>> --- /dev/null\n>>> +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt\n>>> @@ -0,0 +1,16 @@\n>>> +NXP PCF85363 Real Time Clock\n>>> +============================\n>>> +\n>>> +Required properties:\n>>> +- compatible: Should contain \"nxp,pcf85363\".\n>>> +- reg: I2C address for chip.\n>>> +\n>>> +Example:\n>>> +\n>>> +pcf85363: pcf85363@51 {\n>>> + compatible = \"nxp,pcf85363\";\n>>> + reg = <0x51>;\n>>> +};\n>>> +\n>>> +Note that alarms are not yet supported, so a specifier for\n>>> +\"interrupts\" will be ignored.\n>>\n>>\n>> Irrelevant to the binding. That's a driver feature (or lack of). If the\n>> device has an interrupt line, you should document it. It can be optional\n>> though.\n>>\n>\n> That's what I was attempting do do in an awkward way.\n>\n> Since the driver doesn't support interrupts or alarms at the moment,\n> I'll remove this note.\n>\n> The chip does have an interrupt pin, but the board I have doesn't\n> have it connected.\n\nThen just document \"interrupts\" as optional.\n\nRob","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yJ2550RSHz9t5x\n\tfor ;\n\tFri, 20 Oct 2017 08:24:57 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751997AbdJSVY4 (ORCPT );\n\tThu, 19 Oct 2017 17:24:56 -0400","from mail.kernel.org ([198.145.29.99]:33354 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751831AbdJSVYz (ORCPT );\n\tThu, 19 Oct 2017 17:24:55 -0400","from mail-qk0-f173.google.com (mail-qk0-f173.google.com\n\t[209.85.220.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id C4AAA21924;\n\tThu, 19 Oct 2017 21:24:54 +0000 (UTC)","by mail-qk0-f173.google.com with SMTP id k123so12127436qke.3;\n\tThu, 19 Oct 2017 14:24:54 -0700 (PDT)","by 10.12.130.134 with HTTP; Thu, 19 Oct 2017 14:24:33 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org C4AAA21924","X-Gm-Message-State":"AMCzsaW+WwK28RSWT5DAEyhrOaZY4x0kQkirnOC7wFV0LMH8buLBN0Rn\n\tb7MB+Yz4dLBtNIAyBhxY5/uISJdgZq9j1Yw8KA==","X-Google-Smtp-Source":"ABhQp+ThfPtsr6G/3r2VN0GHAQ7Pj762j7BMDc/1e6GtSvy3vTtiPaMzHV9DvCIj9ZgJLA7VqUilPpyAOcRyckMw8ng=","X-Received":"by 10.233.221.133 with SMTP id\n\tr127mr3702838qkf.205.1508448293600; \n\tThu, 19 Oct 2017 14:24:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20602538-2164-e85c-33b6-31c99dfa8a5e@nelint.com>","References":"\n\t<1507737390-27818-1-git-send-email-eric@nelint.com>\n\t<20171017200622.7xs6hiw3y43mxi2k@rob-hp-laptop>\n\t<20602538-2164-e85c-33b6-31c99dfa8a5e@nelint.com>","From":"Rob Herring ","Date":"Thu, 19 Oct 2017 16:24:33 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH V2] rtc: add support for NXP PCF85363 real-time clock","To":"Eric Nelson ","Cc":"linux-rtc@vger.kernel.org, Alessandro Zummo ,\n\tAlexandre Belloni ,\n\tMark Rutland ,\n\t\"devicetree@vger.kernel.org\" ,\n\tOtavio Salvador ,\n\tFabio Estevam ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]