[{"id":1783423,"web_url":"http://patchwork.ozlabs.org/comment/1783423/","msgid":"<1507609105.3552.18.camel@perches.com>","list_archive_url":null,"date":"2017-10-10T04:18:25","subject":"Re: [PATCH 1/3] net/atm: Delete an error message for a failed\n\tmemory allocation in five functions","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Mon, 2017-10-09 at 22:49 +0200, SF Markus Elfring wrote:\n> Omit extra messages for a memory allocation failure in these functions.\n[]\n> diff --git a/net/atm/mpc.c b/net/atm/mpc.c\n> @@ -184,10 +184,8 @@ struct atm_mpoa_qos *atm_mpoa_add_qos(__be32 dst_ip, struct atm_qos *qos)\n>  \t}\n>  \n>  \tentry = kmalloc(sizeof(struct atm_mpoa_qos), GFP_KERNEL);\n> -\tif (entry == NULL) {\n> -\t\tpr_info(\"mpoa: out of memory\\n\");\n> +\tif (!entry)\n\nUnspecified change.  Make sure your changelog is comprehensive.\n\n>  \t\treturn entry;\n> -\t}\n\n \n>  \tentry->ipaddr = dst_ip;\n>  \tentry->qos = *qos;\n> @@ -473,10 +471,8 @@ static const uint8_t *copy_macs(struct mpoa_client *mpc,\n>  \t\t\tkfree(mpc->mps_macs);\n>  \t\tmpc->number_of_mps_macs = 0;\n>  \t\tmpc->mps_macs = kmalloc(num_macs * ETH_ALEN, GFP_KERNEL);\n> -\t\tif (mpc->mps_macs == NULL) {\n> -\t\t\tpr_info(\"(%s) out of mem\\n\", mpc->dev->name);\n> +\t\tif (!mpc->mps_macs)\n>  \t\t\treturn NULL;\n\netc...","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yB3lC19C0z9tYJ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 10 Oct 2017 15:18:47 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751871AbdJJESf (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 10 Oct 2017 00:18:35 -0400","from smtprelay0237.hostedemail.com ([216.40.44.237]:47922 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1750734AbdJJESd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 10 Oct 2017 00:18:33 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay03.hostedemail.com (Postfix) with ESMTP id 9A5D0837F242; \n\tTue, 10 Oct 2017 04:18:32 +0000 (UTC)","from XPS-9350 (unknown [172.56.40.60])\n\t(Authenticated sender: joe@perches.com)\n\tby omf10.hostedemail.com (Postfix) with ESMTPA;\n\tTue, 10 Oct 2017 04:18:28 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com,\n\t:::::::::::::::::::::::::::::::::,\n\tRULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3352:3622:3866:3870:3871:4321:4385:5007:6737:10004:10400:10848:11026:11232:11658:11914:12048:12296:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:21212:21433:21627:30029:30054:30070:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none","X-HE-Tag":"cord54_fc82d44eee5b","X-Filterd-Recvd-Size":"2415","Message-ID":"<1507609105.3552.18.camel@perches.com>","Subject":"Re: [PATCH 1/3] net/atm: Delete an error message for a failed\n\tmemory allocation in five functions","From":"Joe Perches <joe@perches.com>","To":"SF Markus Elfring <elfring@users.sourceforge.net>,\n\tnetdev@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tAugusto Mecking Caringi <augustocaringi@gmail.com>,\n\tBhumika Goyal <bhumirks@gmail.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tDavid Windsor <dwindsor@gmail.com>,\n\tElena Reshetova <elena.reshetova@intel.com>,\n\tHans Liljestrand <ishkamiel@gmail.com>, Jarod Wilson <jarod@redhat.com>,\n\tJohannes Berg <johannes.berg@intel.com>,\n\tKees Cook <keescook@chromium.org>, Mitchell Blank Jr <mitch@sfgoth.com>,\n\tRoopa Prabhu <roopa@cumulusnetworks.com>","Cc":"LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org","Date":"Mon, 09 Oct 2017 21:18:25 -0700","In-Reply-To":"<5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net>","References":"<10a92558-1105-b947-86a2-6ac763cca36d@users.sourceforge.net>\n\t<5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]