[{"id":1778005,"web_url":"http://patchwork.ozlabs.org/comment/1778005/","msgid":"<20171001113145.2e839bc1@archlinux>","list_archive_url":null,"date":"2017-10-01T10:31:45","subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Thu, 28 Sep 2017 14:50:14 +0200\nMaciej Purski <m.purski@samsung.com> wrote:\n\n> Add optional max expected current property which allows calibrating\n> the ina sensor in order to achieve requested precision. Document\n> the changes in Documentation/hwmon/ina2xx.\n> \n\nThis is introducing new generic devicetree bindings..  \nI'm not totally sure we want to do this rather than having a\nmanufacturer specific binding...  I don't have a good feeling for\nhow common this will be in other devices.\n\nIf it's generic, then this isn't necessarily the place to define it.\n\nJonathan\n\n> Signed-off-by: Maciej Purski <m.purski@samsung.com>\n> ---\n>  Documentation/devicetree/bindings/hwmon/ina2xx.txt | 4 +++-\n>  Documentation/hwmon/ina2xx                         | 9 +++++----\n>  2 files changed, 8 insertions(+), 5 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/hwmon/ina2xx.txt b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> index 02af0d9..25ba372 100644\n> --- a/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> +++ b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> @@ -14,11 +14,13 @@ Optional properties:\n>  \n>  - shunt-resistor\n>  \tShunt resistor value in micro-Ohm\n> -\n> +- max-expected-current\n> +\tMax expected current value in mA\n>  Example:\n>  \n>  ina220@44 {\n>  \tcompatible = \"ti,ina220\";\n>  \treg = <0x44>;\n>  \tshunt-resistor = <1000>;\n> +\tmax-expected-current = <3000>;\n>  };\n> diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx\n> index cfd31d9..e9ca838 100644\n> --- a/Documentation/hwmon/ina2xx\n> +++ b/Documentation/hwmon/ina2xx\n> @@ -51,10 +51,11 @@ INA230 and INA231 are high or low side current shunt and power monitors\n>  with an I2C interface. The chips monitor both a shunt voltage drop and\n>  bus supply voltage.\n>  \n> -The shunt value in micro-ohms can be set via platform data or device tree at\n> -compile-time or via the shunt_resistor attribute in sysfs at run-time. Please\n> -refer to the Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings\n> -if the device tree is used.\n> +The shunt value in micro-ohms and max expected current in mA can be set\n> +via platform data or device tree at compile-time or via the shunt_resistor\n> +and max_expected_current attributes in sysfs at run-time. Please refer to the\n> +Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings if the\n> +device tree is used.\n>  \n>  Additionally ina226 supports update_interval attribute as described in\n>  Documentation/hwmon/sysfs-interface. Internally the interval is the sum of\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4hRt0FC2z9t2Q\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSun,  1 Oct 2017 21:31:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751032AbdJAKbw (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSun, 1 Oct 2017 06:31:52 -0400","from mail.kernel.org ([198.145.29.99]:45170 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751013AbdJAKbv (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tSun, 1 Oct 2017 06:31:51 -0400","from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net\n\t[81.96.234.148])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 9A820218CC;\n\tSun,  1 Oct 2017 10:31:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 9A820218CC","Date":"Sun, 1 Oct 2017 11:31:45 +0100","From":"Jonathan Cameron <jic23@kernel.org>","To":"Maciej Purski <m.purski@samsung.com>","Cc":"devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-samsung-soc@vger.kernel.org, linux-iio@vger.kernel.org,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tGuenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>, \n\tJonathan Corbet <corbet@lwn.net>, Russell King <linux@armlinux.org.uk>,\n\tKukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, \n\tHartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,\n\tPeter Meerwald-Stadler <pmeerw@pmeerw.net>,\n\tBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,\n\tMarek Szyprowski <m.szyprowski@samsung.com>","Subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","Message-ID":"<20171001113145.2e839bc1@archlinux>","In-Reply-To":"<1506603015-27202-4-git-send-email-m.purski@samsung.com>","References":"<1506603015-27202-1-git-send-email-m.purski@samsung.com>\n\t<CGME20170928125104eucas1p20a3ead82624005331e36b8ebeca46815@eucas1p2.samsung.com>\n\t<1506603015-27202-4-git-send-email-m.purski@samsung.com>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1780710,"web_url":"http://patchwork.ozlabs.org/comment/1780710/","msgid":"<b990ff1b-80d6-4686-eb8f-51f045a92858@samsung.com>","list_archive_url":null,"date":"2017-10-05T15:15:07","subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","submitter":{"id":72100,"url":"http://patchwork.ozlabs.org/api/people/72100/","name":"Maciej Purski","email":"m.purski@samsung.com"},"content":"On 10/01/2017 12:31 PM, Jonathan Cameron wrote:\n> On Thu, 28 Sep 2017 14:50:14 +0200\n> Maciej Purski <m.purski@samsung.com> wrote:\n> \n>> Add optional max expected current property which allows calibrating\n>> the ina sensor in order to achieve requested precision. Document\n>> the changes in Documentation/hwmon/ina2xx.\n>>\n> \n> This is introducing new generic devicetree bindings..\n> I'm not totally sure we want to do this rather than having a\n> manufacturer specific binding...  I don't have a good feeling for\n> how common this will be in other devices.\n> \n> If it's generic, then this isn't necessarily the place to define it.\n> \n> Jonathan\n>\n\nI agree, this should be manufacturer-specific property. Thanks.\n\n>> Signed-off-by: Maciej Purski <m.purski@samsung.com>\n>> ---\n>>   Documentation/devicetree/bindings/hwmon/ina2xx.txt | 4 +++-\n>>   Documentation/hwmon/ina2xx                         | 9 +++++----\n>>   2 files changed, 8 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/Documentation/devicetree/bindings/hwmon/ina2xx.txt b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n>> index 02af0d9..25ba372 100644\n>> --- a/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n>> +++ b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n>> @@ -14,11 +14,13 @@ Optional properties:\n>>   \n>>   - shunt-resistor\n>>   \tShunt resistor value in micro-Ohm\n>> -\n>> +- max-expected-current\n>> +\tMax expected current value in mA\n>>   Example:\n>>   \n>>   ina220@44 {\n>>   \tcompatible = \"ti,ina220\";\n>>   \treg = <0x44>;\n>>   \tshunt-resistor = <1000>;\n>> +\tmax-expected-current = <3000>;\n>>   };\n>> diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx\n>> index cfd31d9..e9ca838 100644\n>> --- a/Documentation/hwmon/ina2xx\n>> +++ b/Documentation/hwmon/ina2xx\n>> @@ -51,10 +51,11 @@ INA230 and INA231 are high or low side current shunt and power monitors\n>>   with an I2C interface. The chips monitor both a shunt voltage drop and\n>>   bus supply voltage.\n>>   \n>> -The shunt value in micro-ohms can be set via platform data or device tree at\n>> -compile-time or via the shunt_resistor attribute in sysfs at run-time. Please\n>> -refer to the Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings\n>> -if the device tree is used.\n>> +The shunt value in micro-ohms and max expected current in mA can be set\n>> +via platform data or device tree at compile-time or via the shunt_resistor\n>> +and max_expected_current attributes in sysfs at run-time. Please refer to the\n>> +Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings if the\n>> +device tree is used.\n>>   \n>>   Additionally ina226 supports update_interval attribute as described in\n>>   Documentation/hwmon/sysfs-interface. Internally the interval is the sum of\n> \n> \n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7GYB5RgZz9sNw\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri,  6 Oct 2017 02:15:26 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751418AbdJEPPY (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 5 Oct 2017 11:15:24 -0400","from mailout1.w1.samsung.com ([210.118.77.11]:51262 \"EHLO\n\tmailout1.w1.samsung.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750965AbdJEPPV (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 5 Oct 2017 11:15:21 -0400","from eucas1p2.samsung.com (unknown [182.198.249.207])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20171005151516euoutp0111efa93150d9c7768dee4e38c8a864d8~qtW_x5yqs1921419214euoutp01i;\n\tThu,  5 Oct 2017 15:15:16 +0000 (GMT)","from eusmges5.samsung.com (unknown [203.254.199.245]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20171005151515eucas1p1e4b3154cc195ff07e83b36cef74e60db~qtW97eKQR3190731907eucas1p19;\n\tThu,  5 Oct 2017 15:15:15 +0000 (GMT)","from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges5.samsung.com (EUCPMTA) with SMTP id 69.C7.12743.38C46D95;\n\tThu,  5 Oct 2017 16:15:15 +0100 (BST)","from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20171005151514eucas1p259c97b3323275e46cc513aad9644d611~qtW9QIEJT1138411384eucas1p2O;\n\tThu,  5 Oct 2017 15:15:14 +0000 (GMT)","from eusync1.samsung.com ( [203.254.199.211]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 3B.55.20118.28C46D95;\n\tThu,  5 Oct 2017 16:15:14 +0100 (BST)","from [106.120.51.25] by eusync1.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA\n\tid <0OXC00AB2VP7YV70@eusync1.samsung.com>;\n\tThu, 05 Oct 2017 16:15:14 +0100 (BST)"],"X-AuditID":"cbfec7f5-f79d06d0000031c7-59-59d64c83448a","Subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","To":"Jonathan Cameron <jic23@kernel.org>","Cc":"devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-samsung-soc@vger.kernel.org, linux-iio@vger.kernel.org,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tGuenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>, \n\tJonathan Corbet <corbet@lwn.net>, Russell King <linux@armlinux.org.uk>,\n\tKukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, \n\tHartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,\n\tPeter Meerwald-Stadler <pmeerw@pmeerw.net>,\n\tBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,\n\tMarek Szyprowski <m.szyprowski@samsung.com>","From":"Maciej Purski <m.purski@samsung.com>","Message-id":"<b990ff1b-80d6-4686-eb8f-51f045a92858@samsung.com>","Date":"Thu, 05 Oct 2017 17:15:07 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-version":"1.0","In-reply-to":"<20171001113145.2e839bc1@archlinux>","Content-type":"text/plain; charset=\"utf-8\"; format=\"flowed\"","Content-language":"en-US","Content-transfer-encoding":"7bit","X-Brightmail-Tracker":["H4sIAAAAAAAAA02Sa0hTYRjHe89l5yhOXqfZY3aBURRCN6h4s7xEFw4VZNSHZqEtPamkJjtq\n\tZVFe0pWBWWLJKsuaUnPqnDPS0mKs7UPWGtq6kURKH/KCJWJDujiPgd9+7/v8n//D/+HhadVv\n\tdiGfkZ0r6rK1mWpFIPPI6Xu9qmSPV7O29Vkkaa1pYcngcz0idxyvWfKqch/5UmyiyJWBIZp0\n\t/h2midtt4Yix6g5LrANeltSVGRmiH2pHpNYxypAadzdF7NVdiAzW9VCkyfGZI/XvPBSZ6nRy\n\tpLTLwcWHCeZaMxJ6vR5aGPuRJFhNlxRCm/G8cL+iihWMw3ZWcJc4kNAxWcgJFTYTElpsbxlh\n\t3LokISgxcEuqmJmRL+rWxB4JTO9x/UQ5ReGnfG1jXCEaCSlHATzg9VA0OoVkDoc3/S2KchTI\n\tq3A9gnsvnlDyYxxB2+2O6Qo/03HTCf4GFW5A8P5tgqz5hmC82TDjFIoTodo6wfg5DK+A6zV9\n\tM0Y07mahv9FM+Y0UOArM+mS/RoljobnhIeVnBi+HgZEOzs/z8UF4Y/VRsiYEflX1z3gG4LVQ\n\tXP2D9jONo+Hbn1JW5gVQUvqBkXkptJlHaP9cwCMcvDDdmo25HRrLnYzMofDdZeNkXgS9VZdn\n\t/8+AZ6JTIfNZKPpkmdVshvFrttnBwXDt0Q1aXooSLpapZIkAPTdfUjJvhcp+PSsvyIfAcOkC\n\tVYmWGubkMczJYJiTwTAnw13EmFCYmCdlpYnShtWSNkvKy05bnXIiy4qmj/LlH9fEY1TvjLYj\n\tzCN1kHLelz6NitXmS6ez7Ah4Wh2m3L3Lq1EpU7WnC0TdiWRdXqYo2VEkz6gXKGMSyzQqnKbN\n\tFY+LYo6o+1+l+ICFhSiuLrdg78qv3zf5fNtCiy4fdwW/Dzr64bF7EFc8OJSRcNezcywyJcZ7\n\tpeHIPW7MUxm+r6lpT87J+REfQza1WizrbZ52246k3MOLXfGZbm2wsIzZO6zf6MlTTKa2b+/d\n\tb9wfH2M4dsCCnpYadiWlSLhGExe/oiCn2Hou4mo6epfvUTNSunZdFK2TtP8Ax72WdZADAAA=","H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsVy+t/xy7pNPtciDTY9sLLYOGM9q8WTA+2M\n\tFvOPnGO1ODsh0OJB0yomi/7Hr5ktdv1/w2xx/vwGdoslk+ezWmx6fI3VYmHbEhaL9tdbGS3m\n\tHXnHYjHj/D4mi0NT9zJaPFl4hsli7ZG77BZLr19ksvi96xi7ReveI+wOIh5r5q1h9Lh87SKz\n\tx4ePcR6bVnWyeWxeUu+xuG8yq8eSN4dYPc43H2H02Pm9gd2jb8sqRo/1W66yeHzeJBfAE8Vl\n\tk5Kak1mWWqRvl8CVceb4J8aCRrGKn5s/sDcwvhXsYuTgkBAwkZh9TKKLkRPIFJO4cG89Wxcj\n\tF4eQwBJGiVvzFzNDOM8YJY6dXMkGUiUsECXx59QmZhBbREBdYtqMK0wgRcwCB1gl5h29yA7R\n\t8ZNR4sGUaewgK9gEtCTWtMeDNPAK2EmsW7aSCcRmEVCVePx2J1iJqECExIaN/BAlghI/Jt9j\n\tAbE5BQwkmqZ+BNvFLGAm8eXlYVYIW1yiufUmC4QtL7F5zVvmCYyCs5C0z0LSMgtJyywkLQsY\n\tWVYxiqSWFuem5xYb6RUn5haX5qXrJefnbmIERvW2Yz+37GDsehd8iFGAg1GJh5fhwZVIIdbE\n\tsuLK3EOMEhzMSiK83l7XIoV4UxIrq1KL8uOLSnNSiw8xSnOwKInz9u5ZHSkkkJ5YkpqdmlqQ\n\tWgSTZeLglGpgPH/6cO/qgKCyv5zanzpFT0rpvZ/x/aqr/5r1JhMUFZY6mjVfXjjhQtDD1MDQ\n\tLWxa03U32T9OtN99bdPemw6rFzgUFW8+EqWk5qMy147JfVbmc5Elj+fxrVb6sny/+Z3ne73P\n\tOgQe2X4g/FP/jWd27KJ/ShxibGUf/9zE/X6KTvWxXYe+XchyK1ZiKc5INNRiLipOBABKJSPL\n\t5gIAAA=="],"X-CMS-MailID":"20171005151514eucas1p259c97b3323275e46cc513aad9644d611","X-Msg-Generator":"CA","X-Sender-IP":"182.198.249.180","X-Local-Sender":"=?utf-8?q?Maciej_Purski=1BSecurity_=28TP=29=1BSamsung_Ele?=\n\t=?utf-8?q?ctronics=1BTrainee_=28=29?=","X-Global-Sender":"=?utf-8?q?Maciej_Purski=1BSecurity_=28TP=29=1BSamsung_El?=\n\t=?utf-8?q?ectronics=1BTrainee_=28=29?=","X-Sender-Code":"=?utf-8?q?C10=1BEHQ=1BC10CD02CD027395?=","CMS-TYPE":"201P","X-CMS-RootMailID":"20170928125104eucas1p20a3ead82624005331e36b8ebeca46815","X-RootMTR":"20170928125104eucas1p20a3ead82624005331e36b8ebeca46815","References":"<1506603015-27202-1-git-send-email-m.purski@samsung.com>\n\t<CGME20170928125104eucas1p20a3ead82624005331e36b8ebeca46815@eucas1p2.samsung.com>\n\t<1506603015-27202-4-git-send-email-m.purski@samsung.com>\n\t<20171001113145.2e839bc1@archlinux>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1781108,"web_url":"http://patchwork.ozlabs.org/comment/1781108/","msgid":"<20171005223533.iuzvfqxv57aktwtk@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-05T22:35:33","subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Oct 05, 2017 at 05:15:07PM +0200, Maciej Purski wrote:\n> On 10/01/2017 12:31 PM, Jonathan Cameron wrote:\n> > On Thu, 28 Sep 2017 14:50:14 +0200\n> > Maciej Purski <m.purski@samsung.com> wrote:\n> > \n> > > Add optional max expected current property which allows calibrating\n> > > the ina sensor in order to achieve requested precision. Document\n> > > the changes in Documentation/hwmon/ina2xx.\n> > > \n> > \n> > This is introducing new generic devicetree bindings..\n> > I'm not totally sure we want to do this rather than having a\n> > manufacturer specific binding...  I don't have a good feeling for\n> > how common this will be in other devices.\n> > \n> > If it's generic, then this isn't necessarily the place to define it.\n> > \n> > Jonathan\n> > \n> \n> I agree, this should be manufacturer-specific property. Thanks.\n> \n> > > Signed-off-by: Maciej Purski <m.purski@samsung.com>\n> > > ---\n> > >   Documentation/devicetree/bindings/hwmon/ina2xx.txt | 4 +++-\n> > >   Documentation/hwmon/ina2xx                         | 9 +++++----\n> > >   2 files changed, 8 insertions(+), 5 deletions(-)\n> > > \n> > > diff --git a/Documentation/devicetree/bindings/hwmon/ina2xx.txt b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> > > index 02af0d9..25ba372 100644\n> > > --- a/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> > > +++ b/Documentation/devicetree/bindings/hwmon/ina2xx.txt\n> > > @@ -14,11 +14,13 @@ Optional properties:\n> > >   - shunt-resistor\n> > >   \tShunt resistor value in micro-Ohm\n> > > -\n> > > +- max-expected-current\n> > > +\tMax expected current value in mA\n\nAlso needs a unit suffix as defined in property-units.txt.\n\n> > >   Example:\n> > >   ina220@44 {\n> > >   \tcompatible = \"ti,ina220\";\n> > >   \treg = <0x44>;\n> > >   \tshunt-resistor = <1000>;\n> > > +\tmax-expected-current = <3000>;\n> > >   };\n> > > diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx\n> > > index cfd31d9..e9ca838 100644\n> > > --- a/Documentation/hwmon/ina2xx\n> > > +++ b/Documentation/hwmon/ina2xx\n> > > @@ -51,10 +51,11 @@ INA230 and INA231 are high or low side current shunt and power monitors\n> > >   with an I2C interface. The chips monitor both a shunt voltage drop and\n> > >   bus supply voltage.\n> > > -The shunt value in micro-ohms can be set via platform data or device tree at\n> > > -compile-time or via the shunt_resistor attribute in sysfs at run-time. Please\n> > > -refer to the Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings\n> > > -if the device tree is used.\n> > > +The shunt value in micro-ohms and max expected current in mA can be set\n> > > +via platform data or device tree at compile-time or via the shunt_resistor\n> > > +and max_expected_current attributes in sysfs at run-time. Please refer to the\n> > > +Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings if the\n> > > +device tree is used.\n> > >   Additionally ina226 supports update_interval attribute as described in\n> > >   Documentation/hwmon/sysfs-interface. Internally the interval is the sum of\n> > \n> > \n> > \n> > \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7SK80nWFz9t63\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri,  6 Oct 2017 09:35:40 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751454AbdJEWfi (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 5 Oct 2017 18:35:38 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:37427 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751393AbdJEWff (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 5 Oct 2017 18:35:35 -0400","by mail-oi0-f65.google.com with SMTP id h9so9267159oia.4;\n\tThu, 05 Oct 2017 15:35:35 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\t199sm45228oie.58.2017.10.05.15.35.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 05 Oct 2017 15:35:34 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=iHXOPKgY2Y1UTkaXT+Gz1xNmaDognsmB5u+yx4eW/14=;\n\tb=dM3Q1htoxr/PqjGnUd9nvGVFKxkAUzo4wh3dgTeAFahHkW2aay3vQbh6DSd9CWJkDS\n\tF2JnSEJC+VMfV8VZF4BxDVqzs584fpJeVjP7jRaUNXtpDnY2zDDTxQOlYPyFHhEPx8Km\n\tRQHZBNykk0JDzGcPmpFMEFxF3SFuiWSztFAdWuzr46K3wjenkaDpkb3z9D9J1jFzV2Jp\n\tRsUBtC2wqeiu63tVMdRhCAbi4GPLMX5qE1OX0eyW9Bods7Gslpwht5h+zg1ngXm8J40S\n\teKecljeHYt5p6pNcJ+JpaL+dVELODVMzUlNsGQEHQvRV2LVyHl0JbqL5wMgBsKVNdEDr\n\tGF3A==","X-Gm-Message-State":"AMCzsaUagivDBPQlXOr1DXb1UT8iLJ6a11/WK0E7MpjpcoGU4xOfyhZl\n\teHjOhL9M4Zhm2ESnAHbUYg==","X-Google-Smtp-Source":"AOwi7QAIs37f6YRlh7bBMv0EsVpB5RGYtIq4cLle5XN0BBVPvBdOK6AHLCg37HPRlN4IEXdJu5rfew==","X-Received":"by 10.157.63.116 with SMTP id m107mr126331otc.108.1507242935149; \n\tThu, 05 Oct 2017 15:35:35 -0700 (PDT)","Date":"Thu, 5 Oct 2017 17:35:33 -0500","From":"Rob Herring <robh@kernel.org>","To":"Maciej Purski <m.purski@samsung.com>","Cc":"Jonathan Cameron <jic23@kernel.org>, devicetree@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-samsung-soc@vger.kernel.org, linux-iio@vger.kernel.org,\n\tMark Rutland <mark.rutland@arm.com>, Guenter Roeck <linux@roeck-us.net>, \n\tJean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>,\n\tRussell King <linux@armlinux.org.uk>, Kukjin Kim <kgene@kernel.org>, \n\tKrzysztof Kozlowski <krzk@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, \n\tLars-Peter Clausen <lars@metafoo.de>,\n\tPeter Meerwald-Stadler <pmeerw@pmeerw.net>,\n\tBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,\n\tMarek Szyprowski <m.szyprowski@samsung.com>","Subject":"Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current\n\tproperty to ina2xx","Message-ID":"<20171005223533.iuzvfqxv57aktwtk@rob-hp-laptop>","References":"<1506603015-27202-1-git-send-email-m.purski@samsung.com>\n\t<CGME20170928125104eucas1p20a3ead82624005331e36b8ebeca46815@eucas1p2.samsung.com>\n\t<1506603015-27202-4-git-send-email-m.purski@samsung.com>\n\t<20171001113145.2e839bc1@archlinux>\n\t<b990ff1b-80d6-4686-eb8f-51f045a92858@samsung.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<b990ff1b-80d6-4686-eb8f-51f045a92858@samsung.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]