[{"id":1777048,"web_url":"http://patchwork.ozlabs.org/comment/1777048/","msgid":"<553f7dad-3bb7-ed42-c78d-e54592f87c81@6wind.com>","list_archive_url":null,"date":"2017-09-28T14:11:54","subject":"Re: [PATCH v4 1/2] expose stack entry function","submitter":{"id":2036,"url":"http://patchwork.ozlabs.org/api/people/2036/","name":"Nicolas Dichtel","email":"nicolas.dichtel@6wind.com"},"content":"Le 28/09/2017 à 11:34, Amine Kherbouche a écrit :\n> Exporting mpls_forward() function to be able to be called from elsewhere\n> such as MPLSoverGRE in the next commit.\n\nI'm nitpicking, but the commit title is too generic. What about something like\n'mpls: export mpls_forward()'?\n\nWhen parsing history, the user knows precisely what is done in the commit\nwithout openning it.\n\n\nRegards,\nNicolas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=6wind-com.20150623.gappssmtp.com\n\theader.i=@6wind-com.20150623.gappssmtp.com\n\theader.b=\"XeAwfQpQ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2xTH4G30z9t5x\n\tfor ;\n\tFri, 29 Sep 2017 00:12:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753193AbdI1OMB (ORCPT );\n\tThu, 28 Sep 2017 10:12:01 -0400","from mail-wm0-f45.google.com ([74.125.82.45]:45348 \"EHLO\n\tmail-wm0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752608AbdI1OL7 (ORCPT\n\t); Thu, 28 Sep 2017 10:11:59 -0400","by mail-wm0-f45.google.com with SMTP id q124so2612027wmb.0\n\tfor ; Thu, 28 Sep 2017 07:11:59 -0700 (PDT)","from ?IPv6:2a01:e35:8b63:dc30:74ba:af39:b25b:5882?\n\t([2a01:e35:8b63:dc30:74ba:af39:b25b:5882])\n\tby smtp.gmail.com with ESMTPSA id\n\te50sm1653317ede.18.2017.09.28.07.11.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Sep 2017 07:11:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=reply-to:subject:references:to:cc:from:organization:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ygGRhV5YoL5acPQnrI0WysD/H0rA8et3kguTEKyNwgA=;\n\tb=XeAwfQpQVhFizLq777lK0miBrEfK1120F/A8uovYYpWGfvbh3aClB2jYz+6kCY0Net\n\txGhEjgQhXFhq5YQPvNABj++h6lPanvGUzx0pV1MYSxsL4yIhiUQjvNgoUsoC2NXlt+n8\n\t5KEnWRAU3sqrxXMRwylyMc8j50DUjWNiGkQPYiA5MqeRXJBY8tM82SL2Fq86xdgxcQCJ\n\tLpdFjKPk2bI4/UJg60XAy+242a9t7ForawxybU4gC70K3SzOP9uIAWngN+Ltgwql/fZb\n\tvJGtdfLrgR15gU/WbuXkg+pH1vj5YwYKdQVv8Ht0XVKhhSKGSEeNZgR+8MSFoAcJxUa8\n\tjNog==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:reply-to:subject:references:to:cc:from\n\t:organization:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=ygGRhV5YoL5acPQnrI0WysD/H0rA8et3kguTEKyNwgA=;\n\tb=FjMb/I/YMZS5wnlevGywzwGzZWDZSEYZyLBPc7rEKo2snY+3aZs2a8zYsl8IUpDJ6v\n\tK/g3HbcMuyrcB1VCEAArU4s49VEpo06luryV7uEuFQ7/bz+pzEWFdMzV8mEbuvNqnB0/\n\tLSRWnI3yCdj7/cvheeLBqIJUS3kdSN/YBGwkIAvSORLUMpCItJTkN60EfaIA+HtJSbke\n\t+KpBF/nBtn7yBAf4JB6TS3+Dw7lfHM5Sh+l2kdS7ghDAbs3KMOiOsNO9ViSTqjxOCb1V\n\txbNehk1MMSSvhzJoXEJGO+gQAZ5nEX+CLB2uAhbR2jwWwT4o4t7t+VacM/ZH/SL76STw\n\tsaow==","X-Gm-Message-State":"AHPjjUhgD7rKHWDI07O1LvdXaa+jrH3gp5JeONoRUV3NQcPWsPoYJ68d\n\taE0gCTXI41sUmsTVcoQfHi6y5g==","X-Google-Smtp-Source":"AOwi7QChMz6D2sPR8A1RJsWklqLe9RnlOIvFRHdeX1qCwB8giZj39m/uXxnX6oMjQv6RYzOtRdqgig==","X-Received":"by 10.80.222.8 with SMTP id z8mr6050047edk.214.1506607918361;\n\tThu, 28 Sep 2017 07:11:58 -0700 (PDT)","Reply-To":"nicolas.dichtel@6wind.com","Subject":"Re: [PATCH v4 1/2] expose stack entry function","References":"\n\t","To":"Amine Kherbouche ,\n\tnetdev@vger.kernel.org, xeb@mail.ru, roopa@cumulusnetworks.com","Cc":"equinox@diac24.net","From":"Nicolas Dichtel ","Organization":"6WIND","Message-ID":"<553f7dad-3bb7-ed42-c78d-e54592f87c81@6wind.com>","Date":"Thu, 28 Sep 2017 16:11:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"fr","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1777111,"web_url":"http://patchwork.ozlabs.org/comment/1777111/","msgid":"<20170928.084331.924575925867572935.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-28T15:43:31","subject":"Re: [PATCH v4 1/2] expose stack entry function","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Amine Kherbouche \nDate: Thu, 28 Sep 2017 11:34:19 +0200\n\n> Exporting mpls_forward() function to be able to be called from elsewhere\n> such as MPLSoverGRE in the next commit.\n> \n> Signed-off-by: Amine Kherbouche \n> Acked-by: Roopa Prabhu \n\nYou need to resubmit this series with this patch having a proper\nsubsystem prefix in the Subject line, as pointed out by another\nreviewer.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2zVv1cTZz9t16\n\tfor ;\n\tFri, 29 Sep 2017 01:43:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932112AbdI1Pnd (ORCPT );\n\tThu, 28 Sep 2017 11:43:33 -0400","from shards.monkeyblade.net ([184.105.139.130]:47024 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753149AbdI1Pnc (ORCPT\n\t); Thu, 28 Sep 2017 11:43:32 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 0C04A1340B8D1;\n\tThu, 28 Sep 2017 08:43:32 -0700 (PDT)"],"Date":"Thu, 28 Sep 2017 08:43:31 -0700 (PDT)","Message-Id":"<20170928.084331.924575925867572935.davem@davemloft.net>","To":"amine.kherbouche@6wind.com","Cc":"netdev@vger.kernel.org, xeb@mail.ru, roopa@cumulusnetworks.com,\n\tequinox@diac24.net","Subject":"Re: [PATCH v4 1/2] expose stack entry function","From":"David Miller ","In-Reply-To":"","References":"\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 28 Sep 2017 08:43:32 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]