[{"id":1779389,"web_url":"http://patchwork.ozlabs.org/comment/1779389/","msgid":"<1507088159.5452.3.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-04T03:35:59","subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:\n> We try to keep the nodes in address order. The ADC node was out of\n> place.\n> \n> Signed-off-by: Joel Stanley <joel@jms.id.au>\n> ---\n>  arch/arm/boot/dts/aspeed-g4.dtsi | 16 ++++++++--------\n>  arch/arm/boot/dts/aspeed-g5.dtsi | 16 ++++++++--------\n>  2 files changed, 16 insertions(+), 16 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi\n> index 1edd0cee6221..a4579498fc25 100644\n> --- a/arch/arm/boot/dts/aspeed-g4.dtsi\n> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi\n> @@ -129,6 +129,14 @@\n>  \t\t\t\t};\n>  \t\t\t};\n>  \n> +\t\t\tadc: adc@1e6e9000 {\n> +\t\t\t\tcompatible = \"aspeed,ast2400-adc\";\n> +\t\t\t\treg = <0x1e6e9000 0xb0>;\n> +\t\t\t\tclocks = <&syscon ASPEED_CLK_APB>;\n\nWe can't do this yet as the clk driver isn't yet merged, and it breaks from the\n\"just move the node\" description in the commit message.\n\n> +\t\t\t\t#io-channel-cells = <1>;\n> +\t\t\t\tstatus = \"disabled\";\n> +\t\t\t};\n> +\n>  \t\t\tsram@1e720000 {\n>  \t\t\t\tcompatible = \"mmio-sram\";\n>  \t\t\t\treg = <0x1e720000 0x8000>;\t// 32K\n> @@ -227,14 +235,6 @@\n>  \t\t\t\tno-loopback-test;\n>  \t\t\t\tstatus = \"disabled\";\n>  \t\t\t};\n> -\n> -\t\t\tadc: adc@1e6e9000 {\n> -\t\t\t\tcompatible = \"aspeed,ast2400-adc\";\n> -\t\t\t\treg = <0x1e6e9000 0xb0>;\n> -\t\t\t\tclocks = <&clk_apb>;\n> -\t\t\t\t#io-channel-cells = <1>;\n> -\t\t\t\tstatus = \"disabled\";\n> -\t\t\t};\n>  \t\t};\n>  \t};\n>  };\n> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi\n> index f56dd67efa50..f6430b313f90 100644\n> --- a/arch/arm/boot/dts/aspeed-g5.dtsi\n> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi\n> @@ -173,6 +173,14 @@\n>  \t\t\t\treg-io-width = <4>;\n>  \t\t\t};\n>  \n> +\t\t\tadc: adc@1e6e9000 {\n> +\t\t\t\tcompatible = \"aspeed,ast2500-adc\";\n> +\t\t\t\treg = <0x1e6e9000 0xb0>;\n\nDid you intend to change the size cell value here? It now matches the g4, but\nthere was an explicit comment about the size for some reason in the -hunk\nbelow. It's probably worth an explicit call-out if we're going to change it. \n\n> +\t\t\t\tclocks = <&syscon ASPEED_CLK_APB>;\n\nSee the clk comment on the g4 diff.\n\nCheers,\n\nAndrew\n\n> +\t\t\t\t#io-channel-cells = <1>;\n> +\t\t\t\tstatus = \"disabled\";\n> +\t\t\t};\n> +\n>  \t\t\tsram@1e720000 {\n>  \t\t\t\tcompatible = \"mmio-sram\";\n>  \t\t\t\treg = <0x1e720000 0x9000>;\t// 36K\n> @@ -307,14 +315,6 @@\n>  \t\t\t\tno-loopback-test;\n>  \t\t\t\tstatus = \"disabled\";\n>  \t\t\t};\n> -\n> -\t\t\tadc: adc@1e6e9000 {\n> -\t\t\t\tcompatible = \"aspeed,ast2500-adc\";\n> -\t\t\t\treg = <0x1e6e9000 0xb0>;\n> -\t\t\t\tclocks = <&clk_apb>;\n> -\t\t\t\t#io-channel-cells = <1>;\n> -\t\t\t\tstatus = \"disabled\";\n> -\t\t\t};\n>  \t\t};\n>  \t};\n>  };","headers":{"Return-Path":"<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6M4s58pZz9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 14:36:13 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y6M4s3v2gzDqlr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 14:36:13 +1100 (AEDT)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y6M4p2dvSzDqlr\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tWed,  4 Oct 2017 14:36:10 +1100 (AEDT)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 2E4A820FAD;\n\tTue,  3 Oct 2017 23:36:08 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Tue, 03 Oct 2017 23:36:08 -0400","from keelia (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id D9FBB240C8;\n\tTue,  3 Oct 2017 23:36:03 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Brwhbv/G\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"BYFwESh+\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Brwhbv/G\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"BYFwESh+\"; \n\tdkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Brwhbv/G\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"BYFwESh+\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=XRbSSxXZD61HSxubB2lh82IEICOP2hB398vvjJcQu\n\tB4=; b=Brwhbv/GXv/TBLVMGBoWhh6yUbP7h0MhatxohFw1H0TQWpamd3vyjSxWX\n\tEoWs7dAilUUWTEJMrNlT5L0vV8HM3b0qr9oyUU9r6nb3+87RoL+LQemJsaETf9fh\n\tpqK4beySBBiV7TzJBzkdY2h9P5CEF15tYbAxArdJ9YikNYNQ1ieNLJe6em1OvTmu\n\tFVRrfrGWYrDzms+bUadOtyMOZlBBr3EIOkQOX+ebBGp8N9EU/ZjL2cS9ewUMtFpi\n\tYy6J+ZAFTZMV0zvSxwnO9z5ZjYkJgaG68J1Z7USa/cnfYlDt7KsE0AJMFlX1LXYg\n\tye7zdAyT5fST21rUYTT016H/qjwVA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=XRbSSxXZD61HSxubB2\n\tlh82IEICOP2hB398vvjJcQuB4=; b=BYFwESh+GvDkUqSVj0Nq+wpnpENSD/sfGm\n\tRYkR9KvBNH9u5+7NL2jJobtsDo9Btuq/7NsA3R+7WwwelUw/nO4OaZRnIPtP0g32\n\t4Rt+iPr3VFdIo6XyHBtVU3nnhQHdns42C0NzqqBsTmFFnv+7+qAItdiC5X0og1d0\n\tpGdohMPvWqcQKELtnkUyWBLYSb/5vIN99a/XdwzfM+htsYyG11kkSTCN8FtIzbqm\n\tq93OSRZRuriyF4PjDFh5JL0S8ZuQh0BnJEsMNINP+A/HrOZ+Nm7VdJ/BhHOhbIm0\n\tUmU35H0BBA/5ogccXxsNQWWNRB6n+68FaTPj7Bbmm5Lx0fD/5u9Q=="],"X-ME-Sender":"<xms:KFfUWed0muzHbrGPJaFIgul-YywPKTuViZ9J5exbXuH1dg8y3Gl0Ag>","X-Sasl-enc":"MrdsDR8txie3WViggYLhB16N+ZwQCFhSLvXOi6iDWYtE 1507088167","Message-ID":"<1507088159.5452.3.camel@aj.id.au>","Subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","From":"Andrew Jeffery <andrew@aj.id.au>","To":"Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>, Mark\n\tRutland <mark.rutland@arm.com>","Date":"Wed, 04 Oct 2017 14:05:59 +1030","In-Reply-To":"<20170928075149.8154-3-joel@jms.id.au>","References":"<20170928075149.8154-1-joel@jms.id.au>\n\t<20170928075149.8154-3-joel@jms.id.au>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-75AtwNxlYxnC1tzum8ve\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"linux-aspeed@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linux-aspeed/>","List-Post":"<mailto:linux-aspeed@lists.ozlabs.org>","List-Help":"<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>","Cc":"devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,\n\tBrendan Higgins <brendanhiggins@google.com>,\n\tRussell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org,\n\tRick Altherr <raltherr@google.com>, linux-arm-kernel@lists.infradead.org","Errors-To":"linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Linux-aspeed\"\n\t<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1779432,"web_url":"http://patchwork.ozlabs.org/comment/1779432/","msgid":"<CACPK8XfENyKdcV1ZgPrf-Kv+H5BsyQcaCX9ha_gNgD3gcuBUwg@mail.gmail.com>","list_archive_url":null,"date":"2017-10-04T05:13:15","subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Wed, Oct 4, 2017 at 1:05 PM, Andrew Jeffery <andrew@aj.id.au> wrote:\n> On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:\n>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi\n>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi\n>> @@ -129,6 +129,14 @@\n>>                               };\n>>                       };\n>>\n>> +                     adc: adc@1e6e9000 {\n>> +                             compatible = \"aspeed,ast2400-adc\";\n>> +                             reg = <0x1e6e9000 0xb0>;\n>> +                             clocks = <&syscon ASPEED_CLK_APB>;\n>\n> We can't do this yet as the clk driver isn't yet merged, and it breaks from the\n> \"just move the node\" description in the commit message.\n\nYep. This was a bad commit that comes from post-clk driver. I will fix in v2.\n\n>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi\n>> index f56dd67efa50..f6430b313f90 100644\n>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi\n>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi\n>> @@ -173,6 +173,14 @@\n>>                               reg-io-width = <4>;\n>>                       };\n>>\n>> +                     adc: adc@1e6e9000 {\n>> +                             compatible = \"aspeed,ast2500-adc\";\n>> +                             reg = <0x1e6e9000 0xb0>;\n>\n> Did you intend to change the size cell value here? It now matches the g4, but\n> there was an explicit comment about the size for some reason in the -hunk\n> below. It's probably worth an explicit call-out if we're going to change it.\n\nLooks ok to me.\n\nThanks for the review.\n\nCheers,\n\nJoel","headers":{"Return-Path":"<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6PFL6fsRz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 16:13:42 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y6PFL5HB0zDqlM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 16:13:42 +1100 (AEDT)","from mail-lf0-x242.google.com (mail-lf0-x242.google.com\n\t[IPv6:2a00:1450:4010:c07::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y6PFH56MkzDqlM\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tWed,  4 Oct 2017 16:13:39 +1100 (AEDT)","by mail-lf0-x242.google.com with SMTP id d17so12046408lfe.2\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tTue, 03 Oct 2017 22:13:39 -0700 (PDT)","by 10.25.195.6 with HTTP; Tue, 3 Oct 2017 22:13:15 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q1w8GNVV\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q1w8GNVV\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2a00:1450:4010:c07::242; helo=mail-lf0-x242.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q1w8GNVV\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=28TDgbTt3wQol9qUhCNu/hTXhlUI9imWwc5+I1hVOjo=;\n\tb=Q1w8GNVV3K+ASRt7qKzmV/MgKbS0hRV0WKww8EnCX5ip3KuqdV6pmO2nW/v5pqaEnJ\n\tc0s/Kd3rC2Wb/1hhcLV8mCqXw8oNdE/jhHpWDjAXSAywuRSxUEruIQksXX8WgxLFZWyQ\n\thZxBUCkIeBk88QQuri/N+6cU2+4DOII9Oxybv7W5V4HbgOnJR9YmwYV5aJFg1+zQthdg\n\t1MYJnWshVLt6zEkzuj6lVaYuyDOfcHQLxh+b2OyJOuD9iHZqZgFoHey6PtysLmQ8LJoo\n\tMa1N3oZT+LzTcjK2LKPYcqoJMZbBnupTLWKIAH6GYxXrP2yxxS4sFCuSBrwG6hO9KkLY\n\tA+Bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=28TDgbTt3wQol9qUhCNu/hTXhlUI9imWwc5+I1hVOjo=;\n\tb=exJxL/6iVi/cx2fPt0eySMl8kIkHi8D3fLyv+aqmXdkzY74p5Dj8MNN9oyCAfthim8\n\tCuklOjiRsYpijvx3ygsndC4cQZ2LQO6BNMttkw8v2ILg2l/IzhgYO15K2WjLdliq726L\n\tBWiyEtBbzgV3sNmYOrC+HMYLj8Bf9sLZHPVqq0dfOxDymC9ysoM45xMF6FTct2eMYlbB\n\t4PsiUDhqqMjIzqykIoNB/yT4b4QrEU5hs8Hisbmh5nJZCobjm+1HtiMUXzpdgLGMo21P\n\txAItSqPLne9ePp7iFKvJBJu0PInZDXVZGDxVhjP982lbfK/5KyaWZtuPekuwTyZl6BjS\n\t0BjA==","X-Gm-Message-State":"AMCzsaXI4WHaWJ3t7GcjicKUd34uxFbfSiLDikzyKkcz7wp8v+Pw8T5T\n\tetzrUrpobSdtIEVCvBp/rL4c26uMdNf0/QRYN2Y=","X-Google-Smtp-Source":"AOwi7QA6g8rUnaglK/Kac2Vm2nkCyIFZqBPjyiKX+8P1aqNdhBFvPS9sPxMxtCpkYPpTFGr4yNAoBMI9Rr8cfScmw2g=","X-Received":"by 10.25.78.206 with SMTP id u75mr4091905lfk.111.1507094016028; \n\tTue, 03 Oct 2017 22:13:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1507088159.5452.3.camel@aj.id.au>","References":"<20170928075149.8154-1-joel@jms.id.au>\n\t<20170928075149.8154-3-joel@jms.id.au>\n\t<1507088159.5452.3.camel@aj.id.au>","From":"Joel Stanley <joel@jms.id.au>","Date":"Wed, 4 Oct 2017 14:43:15 +0930","X-Google-Sender-Auth":"_RVovoQk2kZTMWc0Y4QUhw2_hGA","Message-ID":"<CACPK8XfENyKdcV1ZgPrf-Kv+H5BsyQcaCX9ha_gNgD3gcuBUwg@mail.gmail.com>","Subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","To":"Andrew Jeffery <andrew@aj.id.au>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linux-aspeed@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linux-aspeed/>","List-Post":"<mailto:linux-aspeed@lists.ozlabs.org>","List-Help":"<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tdevicetree <devicetree@vger.kernel.org>, linux-aspeed@lists.ozlabs.org,\n\tBrendan Higgins <brendanhiggins@google.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Rick Altherr <raltherr@google.com>, \n\tLinux ARM <linux-arm-kernel@lists.infradead.org>","Errors-To":"linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Linux-aspeed\"\n\t<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1779438,"web_url":"http://patchwork.ozlabs.org/comment/1779438/","msgid":"<1507094490.5452.18.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-04T05:21:30","subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-10-04 at 14:43 +0930, Joel Stanley wrote:\n> > > > > > +                     adc: adc@1e6e9000 {\n> > > +                             compatible = \"aspeed,ast2500-adc\";\n> > > +                             reg = <0x1e6e9000 0xb0>;\n> > \n> > Did you intend to change the size cell value here? It now matches the g4, but\n> > there was an explicit comment about the size for some reason in the -hunk\n> > below. It's probably worth an explicit call-out if we're going to change it.\n> \n> Looks ok to me.\n\nYeah, sorry, was looking in the wrong spot :/\n\nAndrew","headers":{"Return-Path":"<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6PQb5Dbwz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 16:21:43 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y6PQb3frzzDqlM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 16:21:43 +1100 (AEDT)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y6PQX448xzDqlM\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tWed,  4 Oct 2017 16:21:40 +1100 (AEDT)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 18A5520FAB;\n\tWed,  4 Oct 2017 01:21:38 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Wed, 04 Oct 2017 01:21:38 -0400","from keelia (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 913E124009;\n\tWed,  4 Oct 2017 01:21:33 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"VpA3uHv/\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"LveeUyEG\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"VpA3uHv/\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"LveeUyEG\"; \n\tdkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"VpA3uHv/\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"LveeUyEG\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=bDMzsxc0w2NyyefUCVhE9eY3VaYffEVZb2dyN8Ccm\n\tzM=; b=VpA3uHv/L5KALeBtHYiyrxa8nDuxuo4C0oANxCOq4uA6msf6CZLbUPwB8\n\tJIkwJzHrJdTY6XCGOv3RJgueQOA8waX4lNzXYVAfih4kGpk1obhaBNrfMQPP3LTN\n\tOch4cbDObL4NNp/nE7RNL+AYBBnn0RF7rLjeJc1ErIt9tk2c+5q1h5Ox/727WX32\n\tzTk4o4jB/cpxit/2J2nsYzTX+5eLzfFi4SMv9nQDu46/Ad732ceiNcgeAoP94IWy\n\tZeXGV9El7cBhiWPECP2gh/vz3aVW2hILtWUT/3mIecVC1W8o7Ecr7hqIqW5ZEc+k\n\t8/GNYOyLuXcWk30LQXzYoHrsGPoFw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=bDMzsxc0w2NyyefUCV\n\thE9eY3VaYffEVZb2dyN8CcmzM=; b=LveeUyEGJdgDE2oQF2X4CLN7L7TDqZsdyr\n\tu+rr0KYDBptJVUKMt9mkdK4MzpUledswl7DFXFkllRFk+nYbE2AcQk/X0AHRt5AY\n\tCcdIiqBFT25G0yGY3VAinamcORs5xJjZiyPBhX3CNhB+ZqplWsSrPmjaV3XQ8mvo\n\tIRgKU4H8x4gaMQT0uSndCIwPg2Jr0eMn71Fq016eT3vCSn73gpFep/AJH20O0OCm\n\tFxWXnB1KoCYGswlMMuohcVo6TcKV/KmBq3KbBJ1LYGn2J0oEqSRUUd7phR6Fr9i6\n\tGqx64DStesvejsf5qKgjk4ow1Pp8zsuK2tmMi8J6SWLKXvBDFw9Q=="],"X-ME-Sender":"<xms:4m_UWU2moupdd6gDAYBPnHP2n7UW8yJtt4aLb9VLNIVRgSuoZIb6CQ>","X-Sasl-enc":"xz3AKS1zn7L9gWlLuWSt52zRpSAcyLNtR0iZyDG6bF+P 1507094496","Message-ID":"<1507094490.5452.18.camel@aj.id.au>","Subject":"Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node","From":"Andrew Jeffery <andrew@aj.id.au>","To":"Joel Stanley <joel@jms.id.au>","Date":"Wed, 04 Oct 2017 15:51:30 +1030","In-Reply-To":"<CACPK8XfENyKdcV1ZgPrf-Kv+H5BsyQcaCX9ha_gNgD3gcuBUwg@mail.gmail.com>","References":"<20170928075149.8154-1-joel@jms.id.au>\n\t<20170928075149.8154-3-joel@jms.id.au>\n\t<1507088159.5452.3.camel@aj.id.au>\n\t<CACPK8XfENyKdcV1ZgPrf-Kv+H5BsyQcaCX9ha_gNgD3gcuBUwg@mail.gmail.com>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-i4FU3F+fnGD/svucSC2x\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"linux-aspeed@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linux-aspeed/>","List-Post":"<mailto:linux-aspeed@lists.ozlabs.org>","List-Help":"<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tdevicetree <devicetree@vger.kernel.org>, linux-aspeed@lists.ozlabs.org,\n\tBrendan Higgins <brendanhiggins@google.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Rick Altherr <raltherr@google.com>, \n\tLinux ARM <linux-arm-kernel@lists.infradead.org>","Errors-To":"linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Linux-aspeed\"\n\t<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]