[{"id":1776840,"web_url":"http://patchwork.ozlabs.org/comment/1776840/","msgid":"<87wp4jgssp.fsf@free-electrons.com>","list_archive_url":null,"date":"2017-09-28T07:56:38","subject":"Re: [PATCH 2/2] dt-bindings: i2c: Update documentation for\n\t\"mv78230-a0-i2c\"","submitter":{"id":15771,"url":"http://patchwork.ozlabs.org/api/people/15771/","name":"Gregory CLEMENT","email":"gregory.clement@free-electrons.com"},"content":"Hi Kalyan,\n \n On jeu., sept. 28 2017, Kalyan Kinthada wrote:\n\n> This commit modifies the documentation for\n> \"marvell,mv78230-a0-i2c\" compatible string.\n>\n> The \"marvell,mv78230-a0-i2c\" compatible string enables the workaround\n> for an i2c repeated start timing violation, but unlike\n> \"marvell,mv78230-i2c\" it disables the i2c offload support. This is\n> applicable to a number of SoCs such as early revisions of the Armada XP\n> and the Armada 38x.\n>\n> Deleted the special note for \"marvell,mv78230-a0-i2c\" as it can\n> be used by other SoCs as well.\n>\n> Signed-off-by: Kalyan Kinthada \n> ---\n> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 4 ----\n> 1 file changed, 4 deletions(-)\n>\n> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt\n> index 5c30026921ae..37c00ad1c0bb 100644\n> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt\n> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt\n> @@ -10,10 +10,6 @@ Required properties :\n> - \"marvell,mv64xxx-i2c\"\n> - \"marvell,mv78230-i2c\"\n> - \"marvell,mv78230-a0-i2c\"\n> - * Note: Only use \"marvell,mv78230-a0-i2c\" for a\n> - very rare, initial version of the SoC which\n> - had broken offload support. Linux\n> - auto-detects this and sets it appropriately.\n\nI think here we should pour more details like what you wrote in the\ncommit log. Maybe something like:\n\n - \"marvell,mv78230-a0-i2c\": for controller which\n do not support offload but still have the i2c\n repeated start timing violation issue, such as\n the ones found in the Armada XP A0 and the\n Armada 38x SoCs.\n\n\nAnd I still have to check it for Armada 375 and Armada 39x, but of\ncourse it is not preventing merging your patches.\n\nGregory\n\n\n\n\n> - interrupts : The interrupt number\n> \n> Optional properties :\n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2n8C0dRzz9t5l\n\tfor ;\n\tThu, 28 Sep 2017 17:56:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752022AbdI1H4l (ORCPT\n\t);\n\tThu, 28 Sep 2017 03:56:41 -0400","from mail.free-electrons.com ([62.4.15.54]:34960 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752017AbdI1H4k (ORCPT\n\t); Thu, 28 Sep 2017 03:56:40 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid A966620928; Thu, 28 Sep 2017 09:56:37 +0200 (CEST)","from localhost (242.171.71.37.rev.sfr.net [37.71.171.242])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 7DA9D20926;\n\tThu, 28 Sep 2017 09:56:37 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Gregory CLEMENT ","To":"Kalyan Kinthada ","Cc":"jason@lakedaemon.net, andrew@lunn.ch,\n\tsebastian.hesselbarth@gmail.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, linux@armlinux.org.uk, wsa@the-dreams.de,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n\tChris Packham ","Subject":"Re: [PATCH 2/2] dt-bindings: i2c: Update documentation for\n\t\"mv78230-a0-i2c\"","References":"<20170928040407.8933-1-kalyan.kinthada@alliedtelesis.co.nz>\n\t<20170928040407.8933-3-kalyan.kinthada@alliedtelesis.co.nz>","Date":"Thu, 28 Sep 2017 09:56:38 +0200","In-Reply-To":"<20170928040407.8933-3-kalyan.kinthada@alliedtelesis.co.nz>\n\t(Kalyan Kinthada's message of \"Thu, 28 Sep 2017 17:04:07 +1300\")","Message-ID":"<87wp4jgssp.fsf@free-electrons.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]