[{"id":1776704,"web_url":"http://patchwork.ozlabs.org/comment/1776704/","msgid":"","list_archive_url":null,"date":"2017-09-28T00:21:40","subject":"Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs'\n\tsymbol exposition","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/27/17, Samuel Thibault wrote:\n> from `freeaddrinfo'.\n>\n> `getifaddrs' and `freeifaddrs' are not in POSIX, they should not be\n> exposed along `freeaddrinfo' (through `__check_pf') which is POSIX.\n>\n> \t* include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations,\n> \tand use libc_hidden_def on them.\n> \t* inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on\n> \tthem.\n> \t* sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise.\n> \t* inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs\n> \tinstead of getifaddrs and freeifaddrs.\n>\n\nI checked in this patch to fix Linux build.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85053-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"TIb0/ErI\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2b3L5D6Gz9t1G\n\tfor ;\n\tThu, 28 Sep 2017 10:21:50 +1000 (AEST)","(qmail 74131 invoked by alias); 28 Sep 2017 00:21:45 -0000","(qmail 74119 invoked by uid 89); 28 Sep 2017 00:21:44 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=iy2o\n\t547Tam0UKeddykPepKHv/tatUs6NfTDaHDU8c55OsjvIMV3S4qyHOibWDFNYllYc\n\tqGz816fjBUBV125P9f9Fvu6eCW2lPpj1e/ADsn4r8Cjps6+LRlVewEXRk+LkceZy\n\tI6ylv72p6gs/8w/s/jp99NucKTZL4mNqqywVUso=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=8SmhMtEM3b\n\tbAON3ysonXuJfsZ5k=; b=TIb0/ErIcTtJBkCRG+3XXGf6RnnBt+o4PXWrMJCCUc\n\tJiWI4IBbm+YlO6tryDaFZwCFhBuqz1+UinS2dctSAkK1pnNZ/e99XLzQXT15xY8U\n\tRNkscrFkbg6UWaOWntH3QgKvc4uj7gCCnuWOuud5HStDl6w6JqbrctwltrSnI9C/\n\ts=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-oi0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ylywmR4cXsHbE8hNtQS3RH6C86VMsdl55UI73vCkleY=;\n\tb=UgkEmuPQzYuStEdr3elAzU4UhC+J4PGHf6ttiBAbING7HtnsLhkxR0PAY8YDZf6Ahx\n\tHulQ42X5TGNxY4NiiOl2bCoE1JuiooetvC4s+DjdrMAW9GxGrbzV/OOlMFqfWTZF5bli\n\t9Wlt8qvhNxVARUv9dx3YkLDJF9Ym3skjeVzdKPbOVZdyJJROiPtTDqC/yfl2mdQei5oK\n\t8QORol2Ixsd6hQA4zdAlTOQSit1SaRh4kAomqGi6exV5Xbg1/wRAm4DpxYfVDbVdQGLP\n\te7Kwr4vJQzZL2UQxnNiaIhUN0yi45WIn0nip/0uh3YZ/AOdgYjzUoAeo/J/ciquYvzjj\n\tXxIA==","X-Gm-Message-State":"AHPjjUjb2aONFBKj/YCi8Ci+RIXQQbn9wwIZdJCtuhK10nfhraF0B9Fv\n\tJbp6r8ZnmYgixuWKWoaGcvNkC9n6PMq9zVKBRUg=","X-Google-Smtp-Source":"AOwi7QDvS4fvuiI7hqpS1S3cPpLmyd0e9HeWiuHjmZyyatJV4+kjXQz+m+QSjMfhXnT5uDozDte2Iq3YC8Q56jB7SSg=","X-Received":"by 10.202.75.137 with SMTP id y131mr632440oia.430.1506558101103; \n\tWed, 27 Sep 2017 17:21:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170927231742.9050-5-samuel.thibault@ens-lyon.org>","References":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>\n\t<20170927231742.9050-5-samuel.thibault@ens-lyon.org>","From":"\"H.J. Lu\" ","Date":"Wed, 27 Sep 2017 17:21:40 -0700","Message-ID":"","Subject":"Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs'\n\tsymbol exposition","To":"Samuel Thibault ","Cc":"libc-alpha@sourceware.org","Content-Type":"multipart/mixed; boundary=\"001a11352e1e73c34f055a34e4ae\""}},{"id":1776776,"web_url":"http://patchwork.ozlabs.org/comment/1776776/","msgid":"<20170928051536.v7z7eh4f57zp4iyu@var.youpi.perso.aquilenet.fr>","list_archive_url":null,"date":"2017-09-28T05:15:36","subject":"Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs'\n\tsymbol exposition","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/people/418/","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"content":"Hello,\n\nH.J. Lu, on mer. 27 sept. 2017 17:21:40 -0700, wrote:\n> On 9/27/17, Samuel Thibault wrote:\n> > from `freeaddrinfo'.\n> >\n> > `getifaddrs' and `freeifaddrs' are not in POSIX, they should not be\n> > exposed along `freeaddrinfo' (through `__check_pf') which is POSIX.\n> >\n> > \t* include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations,\n> > \tand use libc_hidden_def on them.\n> > \t* inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on\n> > \tthem.\n> > \t* sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise.\n> > \t* inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs\n> > \tinstead of getifaddrs and freeifaddrs.\n> >\n> \n> I checked in this patch to fix Linux build.\n> \n> ../sysdeps/unix/sysv/linux/ifaddrs.c:835:27: error: ‘getifaddrs’ aliased to undefined symbol ‘__getifaddrs’\n> weak_alias (__getifaddrs, getifaddrs)\n> ^\n> ../sysdeps/unix/sysv/linux/ifaddrs.c:844:28: error: ‘freeifaddrs’ aliased to undefined symbol ‘__freeifaddrs’\n> weak_alias (__freeifaddrs, freeifaddrs)\n> \n> caused by\n> \n> commit 4009ddc69225d571772aaea597615a0c032e14ab\n\nOh, sorry, I missed that the mere addition of libc_hidden_proto would\nchange the needs of other archs.\n\nThanks,\nSamuel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85058-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"gbQ4DEQH\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2jdX2Mjjz9t43\n\tfor ;\n\tThu, 28 Sep 2017 15:18:23 +1000 (AEST)","(qmail 109307 invoked by alias); 28 Sep 2017 05:17:30 -0000","(qmail 14822 invoked by uid 89); 28 Sep 2017 05:15:40 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:content-transfer-encoding\n\t:in-reply-to; q=dns; s=default; b=yTP9gslSjCs5SSmZzecRiiwW0FUfom\n\thJS+tSlhwca5NuUEDJvg2YJ8gm2EtUIVuISevdIXpLo4YmMWwRzm00n9RkSycz6+\n\tSh6KYkS246q7RbdA/5PVUT8GPWwxyHneDhjUK5v/JpoodLTrXX5jIzvD7LiG3H1r\n\ts0NX0ex+ue5y0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:content-transfer-encoding\n\t:in-reply-to; s=default; bh=3crPJ6GBpaf8FElxJ2Eri7RDjLg=; b=gbQ4\n\tDEQHK2cNxL5KhDwGRbvHE0a1rPZo5JxEz890q3wOYypue1QYxM23M5MRsUTMZGPH\n\t7rYyKcjpKzF1+AUNpxByzQXyN0xsXwNchOB6msnxQNHVDgkcpdOzd9W0DTmMUPaP\n\tLWvlDhhihSMHBzY7j7Fh1ZOMqHCy5jwCLaF53YM=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,\n\tSPF_HELO_PASS, SPF_NEUTRAL autolearn=no version=3.3.2\n\tspammy=HContent-Transfer-Encoding:8bit","X-HELO":"hera.aquilenet.fr","Date":"Thu, 28 Sep 2017 07:15:36 +0200","From":"Samuel Thibault ","To":"\"H.J. Lu\" ","Cc":"libc-alpha@sourceware.org","Subject":"Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs'\n\tsymbol exposition","Message-ID":"<20170928051536.v7z7eh4f57zp4iyu@var.youpi.perso.aquilenet.fr>","References":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>\n\t<20170927231742.9050-5-samuel.thibault@ens-lyon.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)"}}]