[{"id":1777141,"web_url":"http://patchwork.ozlabs.org/comment/1777141/","msgid":"<5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>","list_archive_url":null,"date":"2017-09-28T16:12:19","subject":"Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with\n\tpci_bus_sem held","submitter":{"id":67496,"url":"http://patchwork.ozlabs.org/api/people/67496/","name":"Sinan Kaya","email":"okaya@codeaurora.org"},"content":"On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote:\n> +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n> +\t\t void *userdata);\n\npci_walk_bus_locked would be a better name as you are assuming that caller is\nholding the lock.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"pKmCegsZ\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"pKmCegsZ\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y308943rrz9t48\n\tfor ;\n\tFri, 29 Sep 2017 02:12:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751403AbdI1QMX (ORCPT );\n\tThu, 28 Sep 2017 12:12:23 -0400","from smtp.codeaurora.org ([198.145.29.96]:38162 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751355AbdI1QMW (ORCPT\n\t); Thu, 28 Sep 2017 12:12:22 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid E5FF160960; Thu, 28 Sep 2017 16:12:21 +0000 (UTC)","from [192.168.1.79] (104-182-54-152.lightspeed.rlghnc.sbcglobal.net\n\t[104.182.54.152])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 682086044E;\n\tThu, 28 Sep 2017 16:12:20 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506615141;\n\tbh=76hNt4n+sshU4zUv6YyILNxiCwtATk1JMkW8fMTOcLI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=pKmCegsZ4iwetqjTa6qFr/zADS7Hgn9qnZYjcRAXmYI4luj0F5dFlMwfGbaBWw6VC\n\tjCaKxt18NkIQHwSCCVLL+U8MQ+0ngvUPb8R9KzGkqDIwDeAlgtIxhwLA7ozVRcCxeG\n\tQ2+murACkDM63af4xY4gnEeBQv2JvmWB+XywO3I8=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1506615141;\n\tbh=76hNt4n+sshU4zUv6YyILNxiCwtATk1JMkW8fMTOcLI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=pKmCegsZ4iwetqjTa6qFr/zADS7Hgn9qnZYjcRAXmYI4luj0F5dFlMwfGbaBWw6VC\n\tjCaKxt18NkIQHwSCCVLL+U8MQ+0ngvUPb8R9KzGkqDIwDeAlgtIxhwLA7ozVRcCxeG\n\tQ2+murACkDM63af4xY4gnEeBQv2JvmWB+XywO3I8="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 682086044E","Subject":"Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with\n\tpci_bus_sem held","To":"Govindarajulu Varadarajan , benve@cisco.com,\n\tbhelgaas@google.com, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, jlbec@evilplan.org, hch@lst.de,\n\tmingo@redhat.com, peterz@infradead.org","References":"<20170927214220.41216-1-gvaradar@cisco.com>\n\t<20170927214220.41216-2-gvaradar@cisco.com>","From":"Sinan Kaya ","Message-ID":"<5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>","Date":"Thu, 28 Sep 2017 12:12:19 -0400","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927214220.41216-2-gvaradar@cisco.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1777327,"web_url":"http://patchwork.ozlabs.org/comment/1777327/","msgid":"","list_archive_url":null,"date":"2017-09-28T23:52:55","subject":"Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with\n\tpci_bus_sem held","submitter":{"id":46073,"url":"http://patchwork.ozlabs.org/api/people/46073/","name":"Govindarajulu Varadarajan","email":"gvaradar@cisco.com"},"content":"On Thu, 28 Sep 2017, Sinan Kaya wrote:\n\n> On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote:\n>> +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n>> +\t\t void *userdata);\n>\n> pci_walk_bus_locked would be a better name as you are assuming that caller is\n> holding the lock.\n>\n\nWill change and resubmit for v2.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cisco.com header.i=@cisco.com\n\theader.b=\"JnbUx5dl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3BNL5145z9sP1\n\tfor ;\n\tFri, 29 Sep 2017 09:53:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751524AbdI1XxR (ORCPT );\n\tThu, 28 Sep 2017 19:53:17 -0400","from alln-iport-2.cisco.com ([173.37.142.89]:35118 \"EHLO\n\talln-iport-2.cisco.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751967AbdI1XxO (ORCPT\n\t); Thu, 28 Sep 2017 19:53:14 -0400","from alln-core-2.cisco.com ([173.36.13.135])\n\tby alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t28 Sep 2017 23:53:14 +0000","from XCH-RCD-012.cisco.com (xch-rcd-012.cisco.com [173.37.102.22])\n\tby alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id\n\tv8SNrERj011812\n\t(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL);\n\tThu, 28 Sep 2017 23:53:14 GMT","from cisco (10.157.132.141) by XCH-RCD-012.cisco.com\n\t(173.37.102.22) with Microsoft SMTP Server (TLS) id 15.0.1320.4;\n\tThu, 28 Sep 2017 18:53:12 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=355; q=dns/txt; s=iport;\n\tt=1506642794; x=1507852394;\n\th=date:from:to:cc:subject:in-reply-to:message-id:\n\treferences:mime-version;\n\tbh=QGCoYElQMWxeXEbvmJGhiWe3Uak/7T4uH61w7vMrNZs=;\n\tb=JnbUx5dl51LB1vJG1O0ElNB8cgs60110mq3NSINNna/uWUfv3VeMvqwb\n\t5AIKMVnJ/kX1wD7gaiFIZA2zUJBM/CVbdF2/aQ0auT2pPuGJS9mDt6mZS\n\thgqFCkNjd9z2svtXT6E0ZRRINSx/IDm+zBsnAAEibhQTkg5FC2yYp/L0m c=;","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"A0CoAQDCis1Z/4cNJK1dGQEBAQEBAQEBAQEBBwEBAQEBg1yBUi6dcIFUIpg9CoU7AoQlVwECAQEBAQECayiFGAEBAQECATgCPwULCw4KLjwbBg6KKQUIqUCLQwEBAQEBAQEBAQEBAQEBAQEBASCDK4ICgVGCIIJyincFkT2BD45cllsBkQpIlFgCERkBgTlXgQ54FYVjHIIHh3sBgQ8BAQE","X-IronPort-AV":"E=Sophos;i=\"5.42,451,1500940800\"; d=\"scan'208\";a=\"10196403\"","Date":"Thu, 28 Sep 2017 16:52:55 -0700","From":"Govindarajulu Varadarajan ","To":"Sinan Kaya ","CC":", ,\n\t, ,\n\t, , ,\n\t","Subject":"Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with\n\tpci_bus_sem held","In-Reply-To":"<5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>","Message-ID":"","References":"<20170927214220.41216-1-gvaradar@cisco.com>\n\t<20170927214220.41216-2-gvaradar@cisco.com>\n\t<5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>","User-Agent":"Alpine 2.20 (LNX 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"; format=flowed","X-Originating-IP":"[10.157.132.141]","X-ClientProxiedBy":"xch-aln-006.cisco.com (173.36.7.16) To\n\tXCH-RCD-012.cisco.com (173.37.102.22)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]