[{"id":1777846,"web_url":"http://patchwork.ozlabs.org/comment/1777846/","msgid":"<20170929190746.322df52d@cakuba>","list_archive_url":null,"date":"2017-09-30T02:07:46","subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","submitter":{"id":17220,"url":"http://patchwork.ozlabs.org/api/people/17220/","name":"Jakub Kicinski","email":"kubakici@wp.pl"},"content":"Hi Martin!\n\nOn Wed, 27 Sep 2017 14:37:53 -0700, Martin KaFai Lau wrote:\n> diff --git a/include/linux/bpf.h b/include/linux/bpf.h\n> index 33ccc474fb04..252f4bc9eb25 100644\n> --- a/include/linux/bpf.h\n> +++ b/include/linux/bpf.h\n> @@ -56,6 +56,7 @@ struct bpf_map {\n> \tstruct work_struct work;\n> \tatomic_t usercnt;\n> \tstruct bpf_map *inner_map_meta;\n> +\tu8 name[BPF_OBJ_NAME_LEN];\n\nAny reason not to use plain char? I was looking at adding names to\nbpftool and:\n\nmap.c: In function ‘show_map_close’:\nmap.c:386:13: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]\n if (strlen(info->name))\n ^~~~\nIn file included from map.c:43:0:\n/usr/include/string.h:399:15: note: expected ‘const char *’ but argument is of type ‘__u8 * {aka unsigned char *}’\n extern size_t strlen (const char *__s)\n ^~~~~~\n> };\n> \n> /* function argument constraints */","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=wp.pl header.i=@wp.pl header.b=\"HDqzvXGp\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3sJy1kQpz9t4F\n\tfor ;\n\tSat, 30 Sep 2017 12:08:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752670AbdI3CH4 (ORCPT );\n\tFri, 29 Sep 2017 22:07:56 -0400","from mx4.wp.pl ([212.77.101.12]:46407 \"EHLO mx4.wp.pl\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752639AbdI3CHz (ORCPT );\n\tFri, 29 Sep 2017 22:07:55 -0400","(wp-smtpd smtp.wp.pl 17313 invoked from network);\n\t30 Sep 2017 04:07:53 +0200","from unknown (HELO cakuba) (kubakici@wp.pl@[75.53.12.129])\n\t(envelope-sender )\n\tby smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted\n\tSMTP for ; 30 Sep 2017 04:07:53 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a;\n\tt=1506737273; bh=z0yTI/CQYfmogXQnrQXePxEaFBPsKF3CS8xD4KwjKqg=;\n\th=From:To:Cc:Subject;\n\tb=HDqzvXGpujVvnxCQ4Pj1MlfViDGV3PRk9hHl43shsTE9qiDdtpIhf3XOontVHSBW9\n\tgQUvzjhXbGsFVf3O1ZW0ieZkpO0erwW42ODxbmVmtZbAbSMrxxcxaIhVmfpD3wqTIt\n\tgft1ufp0ng6P+/7M9ZrMl2b+7auibR9xMITe/kJE=","Date":"Fri, 29 Sep 2017 19:07:46 -0700","From":"Jakub Kicinski ","To":"Martin KaFai Lau ","Cc":", Alexei Starovoitov ,\n\tDaniel Borkmann , ","Subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","Message-ID":"<20170929190746.322df52d@cakuba>","In-Reply-To":"<20170927213756.1254938-3-kafai@fb.com>","References":"<20170927213756.1254938-1-kafai@fb.com>\n\t<20170927213756.1254938-3-kafai@fb.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-WP-MailID":"f0f30afb70f94c720f5e8cc1337ac017","X-WP-AV":"skaner antywirusowy Poczty Wirtualnej Polski","X-WP-SPAM":"NO 000000A [8WOU] ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1777848,"web_url":"http://patchwork.ozlabs.org/comment/1777848/","msgid":"<20170930023518.bmc6dbpnz27wunod@kafai-mbp>","list_archive_url":null,"date":"2017-09-30T02:35:18","subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","submitter":{"id":64907,"url":"http://patchwork.ozlabs.org/api/people/64907/","name":"Martin KaFai Lau","email":"kafai@fb.com"},"content":"On Sat, Sep 30, 2017 at 02:07:46AM +0000, Jakub Kicinski wrote:\n> Hi Martin!\n> \n> On Wed, 27 Sep 2017 14:37:53 -0700, Martin KaFai Lau wrote:\n> > diff --git a/include/linux/bpf.h b/include/linux/bpf.h\n> > index 33ccc474fb04..252f4bc9eb25 100644\n> > --- a/include/linux/bpf.h\n> > +++ b/include/linux/bpf.h\n> > @@ -56,6 +56,7 @@ struct bpf_map {\n> > \tstruct work_struct work;\n> > \tatomic_t usercnt;\n> > \tstruct bpf_map *inner_map_meta;\n> > +\tu8 name[BPF_OBJ_NAME_LEN];\n> \n> Any reason not to use plain char? I was looking at adding names to\n> bpftool and:\nHappy to have early user :)\n\nIt was mostly due to my early idea on treating the name as\na blob without much char checking, which was then trashed\nbut did not reflect that here.\n\nI will make a followup patch later.\n> \n> map.c: In function ‘show_map_close’:\n> map.c:386:13: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]\n> if (strlen(info->name))\n> ^~~~\n> In file included from map.c:43:0:\n> /usr/include/string.h:399:15: note: expected ‘const char *’ but argument is of type ‘__u8 * {aka unsigned char *}’\n> extern size_t strlen (const char *__s)\n> ^~~~~~\n> > };\n> > \n> > /* function argument constraints */\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=fb.com header.i=@fb.com header.b=\"GAPOI3l2\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3swz4ps1z9t6D\n\tfor ;\n\tSat, 30 Sep 2017 12:35:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752701AbdI3Cfj (ORCPT );\n\tFri, 29 Sep 2017 22:35:39 -0400","from mx0b-00082601.pphosted.com ([67.231.153.30]:41780 \"EHLO\n\tmx0a-00082601.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1752677AbdI3Cfi (ORCPT\n\t); Fri, 29 Sep 2017 22:35:38 -0400","from pps.filterd (m0089730.ppops.net [127.0.0.1])\n\tby m0089730.ppops.net (8.16.0.21/8.16.0.21) with SMTP id\n\tv8U2XsWQ027119; Fri, 29 Sep 2017 19:35:26 -0700","from mail.thefacebook.com ([199.201.64.23])\n\tby m0089730.ppops.net with ESMTP id 2d9w0k11dq-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tFri, 29 Sep 2017 19:35:26 -0700","from kafai-mbp (192.168.52.123) by mail.thefacebook.com\n\t(192.168.16.11) with Microsoft SMTP Server (TLS) id 14.3.319.2;\n\tFri, 29 Sep 2017 19:35:23 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com;\n\th=date : from : to : cc :\n\tsubject : message-id : references : mime-version : content-type :\n\tcontent-transfer-encoding : in-reply-to; s=facebook;\n\tbh=bbK4AxUhXMkNiXSDTJWJTKQn6wsI2AL7ePcLhJ7vZ6s=;\n\tb=GAPOI3l2ukF0Ftq2Ogp4ZEFsX4RCU9I4TZuCm++R05faQe88btmF1dA+TzBiJmsO6bd/\n\tWoqmQlV5GudEFlbgo2BAkVV/nBn1QmbuAN7CmogxJq2Z4opYiwvkcoawiVFDo13KWt5k\n\tF6uxTSWMuR8Qyhsk3fzTagE5zTrQ2L5xWj0= ","Date":"Fri, 29 Sep 2017 19:35:18 -0700","From":"Martin KaFai Lau ","To":"Jakub Kicinski ","CC":", Alexei Starovoitov ,\n\tDaniel Borkmann , ","Subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","Message-ID":"<20170930023518.bmc6dbpnz27wunod@kafai-mbp>","References":"<20170927213756.1254938-1-kafai@fb.com>\n\t<20170927213756.1254938-3-kafai@fb.com>\n\t<20170929190746.322df52d@cakuba>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170929190746.322df52d@cakuba>","User-Agent":"NeoMutt/20170912 (1.9.0)","X-Originating-IP":"[192.168.52.123]","X-Proofpoint-Spam-Reason":"safe","X-FB-Internal":"Safe","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-29_07:, , signatures=0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1777853,"web_url":"http://patchwork.ozlabs.org/comment/1777853/","msgid":"<20170929195221.732aab55@cakuba>","list_archive_url":null,"date":"2017-09-30T02:52:21","subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","submitter":{"id":17220,"url":"http://patchwork.ozlabs.org/api/people/17220/","name":"Jakub Kicinski","email":"kubakici@wp.pl"},"content":"On Fri, 29 Sep 2017 19:35:18 -0700, Martin KaFai Lau wrote:\n> On Sat, Sep 30, 2017 at 02:07:46AM +0000, Jakub Kicinski wrote:\n> > Hi Martin!\n> > \n> > On Wed, 27 Sep 2017 14:37:53 -0700, Martin KaFai Lau wrote: \n> > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h\n> > > index 33ccc474fb04..252f4bc9eb25 100644\n> > > --- a/include/linux/bpf.h\n> > > +++ b/include/linux/bpf.h\n> > > @@ -56,6 +56,7 @@ struct bpf_map {\n> > > \tstruct work_struct work;\n> > > \tatomic_t usercnt;\n> > > \tstruct bpf_map *inner_map_meta;\n> > > +\tu8 name[BPF_OBJ_NAME_LEN]; \n> > \n> > Any reason not to use plain char? I was looking at adding names to\n> > bpftool and: \n> Happy to have early user :)\n\nThe newly exposed info is so useful I couldn't resist :)\n\n> It was mostly due to my early idea on treating the name as\n> a blob without much char checking, which was then trashed\n> but did not reflect that here.\n> \n> I will make a followup patch later.\n\nAwesome, thanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=wp.pl header.i=@wp.pl header.b=\"sL9HAKiz\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3tJL46JJz9t60\n\tfor ;\n\tSat, 30 Sep 2017 12:52:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752668AbdI3Cwa (ORCPT );\n\tFri, 29 Sep 2017 22:52:30 -0400","from mx3.wp.pl ([212.77.101.9]:14412 \"EHLO mx3.wp.pl\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752649AbdI3Cwa (ORCPT );\n\tFri, 29 Sep 2017 22:52:30 -0400","(wp-smtpd smtp.wp.pl 24612 invoked from network);\n\t30 Sep 2017 04:52:27 +0200","from unknown (HELO cakuba) (kubakici@wp.pl@[75.53.12.129])\n\t(envelope-sender )\n\tby smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted\n\tSMTP for ; 30 Sep 2017 04:52:27 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a;\n\tt=1506739947; bh=OqWA3kM4DZkil+P+SM3B4ax8MXp7b8bYwmQPVCBk0lY=;\n\th=From:To:Cc:Subject;\n\tb=sL9HAKizFqLvyFfbuyTS4Nwy9AID2EEC0gqYH5B1+2f4fnthXyFvv71JQ0k5Nq1u0\n\tBJ0FE4FSbU84JkjJlSu73pcffFvs5e/oHDgERsOmkA93scaKI/LV4LZtubhZuhbUAY\n\t7Te2E4029lifaeFIAXCEVrwDpqGjDGuS0IRSBV3A=","Date":"Fri, 29 Sep 2017 19:52:21 -0700","From":"Jakub Kicinski ","To":"Martin KaFai Lau ","Cc":", Alexei Starovoitov ,\n\tDaniel Borkmann , ","Subject":"Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info","Message-ID":"<20170929195221.732aab55@cakuba>","In-Reply-To":"<20170930023518.bmc6dbpnz27wunod@kafai-mbp>","References":"<20170927213756.1254938-1-kafai@fb.com>\n\t<20170927213756.1254938-3-kafai@fb.com>\n\t<20170929190746.322df52d@cakuba>\n\t<20170930023518.bmc6dbpnz27wunod@kafai-mbp>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-WP-MailID":"d34c58619a8918c430c614430ae06020","X-WP-AV":"skaner antywirusowy Poczty Wirtualnej Polski","X-WP-SPAM":"NO 000000A [8VME] ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]