[{"id":1776610,"web_url":"http://patchwork.ozlabs.org/comment/1776610/","msgid":"<3e0e7e4a-0e66-ef49-8ee7-02e6ffd424b4@redhat.com>","list_archive_url":null,"date":"2017-09-27T20:49:55","subject":"Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return\n\tnumber of config groups","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/27/2017 03:41 PM, Eduardo Habkost wrote:\n> Change qemu_config_parse() to return the number of config groups\n> in success and -EINVAL on error. This will allow callers of\n> qemu_config_parse() to check if something was really loaded from\n> the config file.\n> \n> All existing callers of qemu_config_parse() and\n> qemu_read_config_file() only check if the return value was\n> negative, so the change shouldn't affect them.\n> \n> Signed-off-by: Eduardo Habkost \n> ---\n\nReviewed-by: Eric Blake \n\n> Changes v2 -> v3:\n> * None (rebase only)\n> \n> Changes v1 -> v2:\n> * Remove unnecessary translation of qemu_config_parse()\n> erros to -EINVAL at block/blkdebug.c:read_config()\n> * Suggsted-by: Markus Armbruster \n\nDo you want the Suggested-by (spelled correctly) in the commit body proper?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VND0blQz9t6C\n\tfor ;\n\tThu, 28 Sep 2017 06:51:08 +1000 (AEST)","from localhost ([::1]:56302 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJIQ-00055P-7d\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:51:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33772)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJHO-0004fd-4Q\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:50:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJHK-00015k-W8\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:50:02 -0400","from mx1.redhat.com ([209.132.183.28]:43424)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxJHK-00013d-Nl\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:49:58 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BED29C0BD3BB\n\tfor ; Wed, 27 Sep 2017 20:49:57 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C77B5675F0;\n\tWed, 27 Sep 2017 20:49:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BED29C0BD3BB","To":"Eduardo Habkost , qemu-devel@nongnu.org","References":"<20170927204148.2311-1-ehabkost@redhat.com>\n\t<20170927204148.2311-2-ehabkost@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<3e0e7e4a-0e66-ef49-8ee7-02e6ffd424b4@redhat.com>","Date":"Wed, 27 Sep 2017 15:49:55 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927204148.2311-2-ehabkost@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"JJ6QkA5I5EMH26UuUaSJw8F10Lirg0nxV\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 20:49:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return\n\tnumber of config groups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]