[{"id":1776787,"web_url":"http://patchwork.ozlabs.org/comment/1776787/","msgid":"","list_archive_url":null,"date":"2017-09-28T06:03:39","subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","submitter":{"id":347,"url":"http://patchwork.ozlabs.org/api/people/347/","name":"Dan Williams","email":"dan.j.williams@intel.com"},"content":"On Wed, Sep 27, 2017 at 1:40 PM, Jon Derrick wrote:\n> The PCI driver delete_id parameter is handled in each individual driver\n> registration callback.\n>\n> Signed-off-by: Jon Derrick \n> ---\n> kernel/module.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/kernel/module.c b/kernel/module.c\n> index de66ec8..2b2dccf 100644\n> --- a/kernel/module.c\n> +++ b/kernel/module.c\n> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,\n> return 0;\n> }\n>\n> + /*\n> + * Ignore driver delete list arguments. They are handled by driver\n> + * registration callbacks\n> + */\n> + if (strcmp(param, \"delete_id\") == 0)\n> + return 0;\n> +\n\nDoes this preclude something like:\n\n modprobe ahci delete_id=1234:5678?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel-com.20150623.gappssmtp.com\n\theader.i=@intel-com.20150623.gappssmtp.com\n\theader.b=\"BwbJ7VUa\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2kf470g4z9t5C\n\tfor ;\n\tThu, 28 Sep 2017 16:03:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751692AbdI1GDy (ORCPT );\n\tThu, 28 Sep 2017 02:03:54 -0400","from mail-oi0-f52.google.com ([209.85.218.52]:46419 \"EHLO\n\tmail-oi0-f52.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751058AbdI1GDk (ORCPT\n\t); Thu, 28 Sep 2017 02:03:40 -0400","by mail-oi0-f52.google.com with SMTP id a74so681872oib.3\n\tfor ; Wed, 27 Sep 2017 23:03:40 -0700 (PDT)","by 10.157.12.212 with HTTP; Wed, 27 Sep 2017 23:03:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=intel-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=kIYrN+xbj5rEn8n6l6b2ac3pXwtBYeUcCqENbW7vAyk=;\n\tb=BwbJ7VUaLXWpGX5Q9xBToRwivcVkV5FlYmEMROA8U5I6HBiSGtglVD5X/8atYGbdvf\n\tEYGuhdEYN1NVj0SV6dnaD/GQTGzhdMsESIUirU1E1EfPmzEAQZotJezE1GN4AZXw32HW\n\tmonx3ncCtk3YmSjIRlCox3miwoPtxB4kRh7Xh/vWulIcT5u3CPm1EtSZADtGBpIS9sHE\n\tNWjAbEW4Zt96WXVv90dLPG3nd7o+2kJllaIPfyIQScWK+3Y+CuzTbsHqvbvGmHl/JTpN\n\tkRmv98+6ohVSIRaRTtM+/E1yOcwvIx/viwjCFC5z0m2+a7vZqgjVyNhE9PXpk2qRPlyo\n\tuJYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=kIYrN+xbj5rEn8n6l6b2ac3pXwtBYeUcCqENbW7vAyk=;\n\tb=ikVpaxbpsvGlLahHk2X9a8O5Yus06Y4+dl4bPwKNw5k5CyFPoHlTo4hMuKKpG7RNrr\n\tKs8hS/hK2WIXmd2oHpXDPeUlIVYi0zyu7L9UshLyW65zJHNoRB0l94AK6CFbRrmB3mUp\n\t3TSnYRulZtBPlDzRe1Ev0Glp7gPUnY9funMIf3V/6OrLI0Wgu86umu0O4rDqgOekBpoS\n\t2P+ByxO/vvskaun4YwQI4jBji84/FK3eK6CoZM8XM7c16pmId+2n3G+9BgQHYyoXmcR3\n\tQeQqaYiuDZcYr+Q6gtCMfeKH0AZM02YsCvyoGBGR/KNMlAXGtF2xtY4VFql+fIf7O6dn\n\taPdg==","X-Gm-Message-State":"AMCzsaWHWal75vgyv92hvt4S9QmbZe314fyDj1B4JsehWc24XyD0jzym\n\ta/vV4FUpv1UrotrZIiowHBFBAx8QXzDPOAd9Q1E8eA==","X-Google-Smtp-Source":"AOwi7QDJK2KC2n/ByB6lMzwNY0a7i8mLnKDgHVivVH0ZWjqBHuUYgRO9R4tuNmswAdY9HxmsSUwNhDSPQq/iHwB11lQ=","X-Received":"by 10.157.14.52 with SMTP id c49mr303457otc.444.1506578620106;\n\tWed, 27 Sep 2017 23:03:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>","References":"<1506544822-2632-1-git-send-email-jonathan.derrick@intel.com>\n\t<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>","From":"Dan Williams ","Date":"Wed, 27 Sep 2017 23:03:39 -0700","Message-ID":"","Subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","To":"Jon Derrick ","Cc":"Greg Kroah-Hartman ,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tArjan van de Ven , Alan Cox ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1776891,"web_url":"http://patchwork.ozlabs.org/comment/1776891/","msgid":"<20170928090234.GB12599@kroah.com>","list_archive_url":null,"date":"2017-09-28T09:02:34","subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Wed, Sep 27, 2017 at 04:40:21PM -0400, Jon Derrick wrote:\n> The PCI driver delete_id parameter is handled in each individual driver\n> registration callback.\n> \n> Signed-off-by: Jon Derrick \n> ---\n> kernel/module.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/kernel/module.c b/kernel/module.c\n> index de66ec8..2b2dccf 100644\n> --- a/kernel/module.c\n> +++ b/kernel/module.c\n> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,\n> \t\treturn 0;\n> \t}\n> \n> +\t/*\n> +\t * Ignore driver delete list arguments. They are handled by driver\n> +\t * registration callbacks\n> +\t */\n> +\tif (strcmp(param, \"delete_id\") == 0)\n> +\t\treturn 0;\n\nWhy? This is only for the PCI core as you have defined it in this\npatchset, but you just broke this module id for all other kernel modules\nin the system :(\n\nIf you want to do this, you need to provide this feature for _all_\nkernel drivers...\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2pcJ0zpGz9t2l\n\tfor ;\n\tThu, 28 Sep 2017 19:02:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752559AbdI1JCi (ORCPT );\n\tThu, 28 Sep 2017 05:02:38 -0400","from mail.linuxfoundation.org ([140.211.169.12]:56892 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752554AbdI1JCi (ORCPT\n\t); Thu, 28 Sep 2017 05:02:38 -0400","from localhost (unknown [195.81.232.10])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 366798FF;\n\tThu, 28 Sep 2017 09:02:37 +0000 (UTC)"],"Date":"Thu, 28 Sep 2017 11:02:34 +0200","From":"Greg Kroah-Hartman ","To":"Jon Derrick ","Cc":"Bjorn Helgaas , linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Arjan van de Ven ,\n\tAlan Cox ,\n\tDan J Williams ","Subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","Message-ID":"<20170928090234.GB12599@kroah.com>","References":"<1506544822-2632-1-git-send-email-jonathan.derrick@intel.com>\n\t<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1777126,"web_url":"http://patchwork.ozlabs.org/comment/1777126/","msgid":"","list_archive_url":null,"date":"2017-09-28T15:57:02","subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","submitter":{"id":68102,"url":"http://patchwork.ozlabs.org/api/people/68102/","name":"Jon Derrick","email":"jonathan.derrick@intel.com"},"content":"On 09/28/2017 03:02 AM, Greg Kroah-Hartman wrote:\n> On Wed, Sep 27, 2017 at 04:40:21PM -0400, Jon Derrick wrote:\n>> The PCI driver delete_id parameter is handled in each individual driver\n>> registration callback.\n>>\n>> Signed-off-by: Jon Derrick \n>> ---\n>> kernel/module.c | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/kernel/module.c b/kernel/module.c\n>> index de66ec8..2b2dccf 100644\n>> --- a/kernel/module.c\n>> +++ b/kernel/module.c\n>> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,\n>> \t\treturn 0;\n>> \t}\n>> \n>> +\t/*\n>> +\t * Ignore driver delete list arguments. They are handled by driver\n>> +\t * registration callbacks\n>> +\t */\n>> +\tif (strcmp(param, \"delete_id\") == 0)\n>> +\t\treturn 0;\n> \n> Why? This is only for the PCI core as you have defined it in this\n> patchset, but you just broke this module id for all other kernel modules\n> in the system :(\n> \n> If you want to do this, you need to provide this feature for _all_\n> kernel drivers...\n> \n> thanks,\n> \n> greg k-h\n> \nYes I'm not particularly happy about this one either. I will make this\nmore robust if the blacklisting idea is sound.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2zpX33H7z9t3h\n\tfor ;\n\tFri, 29 Sep 2017 01:57:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750942AbdI1P5G (ORCPT );\n\tThu, 28 Sep 2017 11:57:06 -0400","from mga07.intel.com ([134.134.136.100]:17851 \"EHLO\n\tmga07.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751136AbdI1P5G (ORCPT );\n\tThu, 28 Sep 2017 11:57:06 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 08:57:04 -0700","from jderrick-mobl1.amr.corp.intel.com (HELO\n\tlocalhost.localdomain) ([10.232.112.166])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 Sep 2017 08:57:03 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,450,1500966000\"; d=\"scan'208\";a=\"1200081240\"","From":"Jon Derrick ","Subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","To":"Greg Kroah-Hartman ","Cc":"Bjorn Helgaas , linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Arjan van de Ven ,\n\tAlan Cox ,\n\tDan J Williams ","References":"<1506544822-2632-1-git-send-email-jonathan.derrick@intel.com>\n\t<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>\n\t<20170928090234.GB12599@kroah.com>","Message-ID":"","Date":"Thu, 28 Sep 2017 09:57:02 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170928090234.GB12599@kroah.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1777129,"web_url":"http://patchwork.ozlabs.org/comment/1777129/","msgid":"<77cbeca1-c5a6-1fe0-d342-e248462eb3e9@intel.com>","list_archive_url":null,"date":"2017-09-28T15:57:56","subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","submitter":{"id":68102,"url":"http://patchwork.ozlabs.org/api/people/68102/","name":"Jon Derrick","email":"jonathan.derrick@intel.com"},"content":"On 09/28/2017 12:03 AM, Dan Williams wrote:\n> On Wed, Sep 27, 2017 at 1:40 PM, Jon Derrick wrote:\n>> The PCI driver delete_id parameter is handled in each individual driver\n>> registration callback.\n>>\n>> Signed-off-by: Jon Derrick \n>> ---\n>> kernel/module.c | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/kernel/module.c b/kernel/module.c\n>> index de66ec8..2b2dccf 100644\n>> --- a/kernel/module.c\n>> +++ b/kernel/module.c\n>> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,\n>> return 0;\n>> }\n>>\n>> + /*\n>> + * Ignore driver delete list arguments. They are handled by driver\n>> + * registration callbacks\n>> + */\n>> + if (strcmp(param, \"delete_id\") == 0)\n>> + return 0;\n>> +\n> \n> Does this preclude something like:\n> \n> modprobe ahci delete_id=1234:5678?\n> \n\nIt does seem like it would. I can look into calling into the pci\ncallback for this, but val is a struct module here and I haven't figured\nout the plumbing to get the [correct] driver from that.\n\nMaybe if I enforce the format of 'modprobe ahci ahci.delete_id=xxxx' to\nensure the driver is specified (and would be required in cases with\nmulti-driver modules).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2zqW6cznz9t3h\n\tfor ;\n\tFri, 29 Sep 2017 01:57:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751672AbdI1P56 (ORCPT );\n\tThu, 28 Sep 2017 11:57:58 -0400","from mga05.intel.com ([192.55.52.43]:65315 \"EHLO mga05.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751664AbdI1P55 (ORCPT );\n\tThu, 28 Sep 2017 11:57:57 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP; 28 Sep 2017 08:57:57 -0700","from jderrick-mobl1.amr.corp.intel.com (HELO\n\tlocalhost.localdomain) ([10.232.112.166])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 Sep 2017 08:57:56 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,450,1500966000\"; d=\"scan'208\";a=\"1200081580\"","From":"Jon Derrick ","Subject":"Re: [RFC 2/3] module: Ignore delete_id parameter","To":"Dan Williams ","Cc":"Greg Kroah-Hartman ,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tArjan van de Ven , Alan Cox ","References":"<1506544822-2632-1-git-send-email-jonathan.derrick@intel.com>\n\t<1506544822-2632-3-git-send-email-jonathan.derrick@intel.com>\n\t","Message-ID":"<77cbeca1-c5a6-1fe0-d342-e248462eb3e9@intel.com>","Date":"Thu, 28 Sep 2017 09:57:56 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]