[{"id":1776607,"web_url":"http://patchwork.ozlabs.org/comment/1776607/","msgid":"","list_archive_url":null,"date":"2017-09-27T20:47:18","subject":"Re: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default\n\tconfig file is loaded","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/27/2017 03:41 PM, Eduardo Habkost wrote:\n> In case there were options set in the default config file, print\n> a warning so users can update their scripts.\n> \n> If somebody wants to keep the config file as-is, avoid the\n> warning and use a command-line that will work in future QEMU\n> versions, they can use:\n> \n> $QEMU -no-user-config -readconfig /etc/qemu/qemu.conf\n> \n> I was going to add an additional message suggesting it as a\n> solution, but I thought it could make it more confusing. The\n> solution can be documented in the QEMU 2.11 ChangeLog.\n> \n> Reviewed-by: Markus Armbruster \n> Signed-off-by: Eduardo Habkost \n> ---\n> Changes v2 -> v3:\n> * Rebase (no code changes)\n> * Commit message update: suggest -no-user-config\n\n> + if (ret > 0) {\n> + loc_set_none();\n> + error_report(\"Warning: Future QEMU versions won't load %s automatically\",\n> + CONFIG_QEMU_CONFDIR \"/qemu.conf\");\n\nShouldn't we now use warn_report() with no 'Warning:' prefix?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VJL6fTlz9t6B\n\tfor ;\n\tThu, 28 Sep 2017 06:47:46 +1000 (AEST)","from localhost ([::1]:56290 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJFB-0003P0-2y\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:47:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33010)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJEr-0003Nh-It\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:47:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJEn-0007xy-MI\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:47:25 -0400","from mx1.redhat.com ([209.132.183.28]:46324)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxJEn-0007xr-D3\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:47:21 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4601CA1969\n\tfor ; Wed, 27 Sep 2017 20:47:20 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7C3BF7F921;\n\tWed, 27 Sep 2017 20:47:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4601CA1969","To":"Eduardo Habkost , qemu-devel@nongnu.org","References":"<20170927204148.2311-1-ehabkost@redhat.com>\n\t<20170927204148.2311-3-ehabkost@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 27 Sep 2017 15:47:18 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927204148.2311-3-ehabkost@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"Kk6PXWhjI9ptTE6vwnIUO0CAIWqkFTrch\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 27 Sep 2017 20:47:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default\n\tconfig file is loaded","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]