[{"id":1776879,"web_url":"http://patchwork.ozlabs.org/comment/1776879/","msgid":"<20170928085021.GM4630@lahna.fi.intel.com>","list_archive_url":null,"date":"2017-09-28T08:50:21","subject":"Re: [PATCH 3/3] i2c: xlp9xx: Handle I2C_M_RECV_LEN in msg->flags","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"content":"On Wed, Sep 27, 2017 at 08:22:23PM +0530, Kamlakant Patel wrote:\n> +\tpriv->len_recv = (msg->flags & I2C_M_RECV_LEN);\n\nYou don't need parens here.\n\n> +\tlen = priv->len_recv ? XLP9XX_I2C_FIFO_SIZE : msg->len;\n> +\tpriv->client_pec = (msg->flags & I2C_CLIENT_PEC);\n\nDitto.\n\nOtherwise looks good to me,\n\nReviewed-by: Mika Westerberg ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2pLC5W8Dz9t2Q\n\tfor ;\n\tThu, 28 Sep 2017 18:50:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752613AbdI1Iu0 (ORCPT );\n\tThu, 28 Sep 2017 04:50:26 -0400","from mga11.intel.com ([192.55.52.93]:38773 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752156AbdI1IuZ (ORCPT );\n\tThu, 28 Sep 2017 04:50:25 -0400","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 01:50:24 -0700","from lahna.fi.intel.com (HELO lahna) ([10.237.72.157])\n\tby fmsmga004.fm.intel.com with SMTP; 28 Sep 2017 01:50:22 -0700","by lahna (sSMTP sendmail emulation);\n\tThu, 28 Sep 2017 11:50:21 +0300"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"317164580\"","Date":"Thu, 28 Sep 2017 11:50:21 +0300","From":"Mika Westerberg ","To":"Kamlakant Patel ","Cc":"linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,\n\tWolfram Sang ,\n\tJayachandran C ","Subject":"Re: [PATCH 3/3] i2c: xlp9xx: Handle I2C_M_RECV_LEN in msg->flags","Message-ID":"<20170928085021.GM4630@lahna.fi.intel.com>","References":"<1506523943-8632-1-git-send-email-kamlakant.patel@cavium.com>\n\t<1506523943-8632-4-git-send-email-kamlakant.patel@cavium.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506523943-8632-4-git-send-email-kamlakant.patel@cavium.com>","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]