[{"id":1776332,"web_url":"http://patchwork.ozlabs.org/comment/1776332/","msgid":"<20170927131726.GG12223@redhat.com>","list_archive_url":null,"date":"2017-09-27T13:17:26","subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Sep 27, 2017 at 10:03:35AM -0300, Eduardo Habkost wrote:\n> The logging module will eventually replace the 'debug' parameter\n> in QEMUMachine and QEMUMonitorProtocol.\n> \n> Cc: Daniel P. Berrange \n> Signed-off-by: Eduardo Habkost \n> ---\n> tests/migration/guestperf/shell.py | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n\nReviewed-by: Daniel P. Berrange \n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2JKb2Ysdz9tXn\n\tfor ;\n\tWed, 27 Sep 2017 23:18:11 +1000 (AEST)","from localhost ([::1]:54808 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxCDz-0006Wy-6p\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 09:18:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56296)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxCDc-0006WL-TJ\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:17:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxCDT-0005pg-DD\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:17:40 -0400","from mx1.redhat.com ([209.132.183.28]:39376)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxCDT-0005pQ-6l\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:17:31 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3327DC0641EA\n\tfor ; Wed, 27 Sep 2017 13:17:30 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 12CA578A8C;\n\tWed, 27 Sep 2017 13:17:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3327DC0641EA","Date":"Wed, 27 Sep 2017 14:17:26 +0100","From":"\"Daniel P. Berrange\" ","To":"Eduardo Habkost ","Message-ID":"<20170927131726.GG12223@redhat.com>","References":"<20170927130339.21444-1-ehabkost@redhat.com>\n\t<20170927130339.21444-2-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170927130339.21444-2-ehabkost@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 13:17:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"=?utf-8?b?THVrw6HFoQ==?= Doktor ,\n\tqemu-devel@nongnu.org, \tCleber Rosa ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776901,"web_url":"http://patchwork.ozlabs.org/comment/1776901/","msgid":"<655d9ac0-f36e-a764-0e3c-d1d28818bd9a@redhat.com>","list_archive_url":null,"date":"2017-09-28T09:15:47","subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","submitter":{"id":72013,"url":"http://patchwork.ozlabs.org/api/people/72013/","name":"Lukáš Doktor","email":"ldoktor@redhat.com"},"content":"Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a):\n> The logging module will eventually replace the 'debug' parameter\n> in QEMUMachine and QEMUMonitorProtocol.\n> \n> Cc: Daniel P. Berrange \n> Signed-off-by: Eduardo Habkost \n> ---\n> tests/migration/guestperf/shell.py | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/tests/migration/guestperf/shell.py b/tests/migration/guestperf/shell.py\n> index 7992459a97..e378cf0cfa 100644\n> --- a/tests/migration/guestperf/shell.py\n> +++ b/tests/migration/guestperf/shell.py\n> @@ -26,6 +26,7 @@ sys.path.append(os.path.join(os.path.dirname(__file__),\n> import argparse\n> import fnmatch\n> import platform\n> +import logging\n> \n> from guestperf.hardware import Hardware\n> from guestperf.engine import Engine\n> @@ -64,6 +65,11 @@ class BaseShell(object):\n> \n> self._parser = parser\n> \n> + def init_logging(self, args):\n> + logging.basicConfig(level=(logging.DEBUG if args.debug else\n> + logging.INFO if args.verbose else\n> + logging.WARN))\n> +\n> def get_engine(self, args):\n> return Engine(binary=args.binary,\n> dst_host=args.dst_host,\n> @@ -147,6 +153,7 @@ class Shell(BaseShell):\n> \n> def run(self, argv):\n> args = self._parser.parse_args(argv)\n> + self.init_logging(args)\n> \n> engine = self.get_engine(args)\n> hardware = self.get_hardware(args)\n> @@ -179,6 +186,7 @@ class BatchShell(BaseShell):\n> \n> def run(self, argv):\n> args = self._parser.parse_args(argv)\n> + self.init_logging(args)\n> \n> engine = self.get_engine(args)\n> hardware = self.get_hardware(args)\n> @@ -231,6 +239,7 @@ class PlotShell(object):\n> \n> def run(self, argv):\n> args = self._parser.parse_args(argv)\n\nThis class is not inherited from the `BaseShell`, therefor it does not contain `init_logging` method. Apart from this it looks good.\n\n> + self.init_logging(args)\n> \n> if len(args.reports) == 0:\n> print >>sys.stderr, \"At least one report required\"\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ldoktor@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2pw25pWJz9t2c\n\tfor ;\n\tThu, 28 Sep 2017 19:16:18 +1000 (AEST)","from localhost ([::1]:58089 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxUvY-0008TG-VR\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 05:16:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58565)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxUvE-0008TA-QU\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:15:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxUv8-0007bD-P1\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:15:56 -0400","from mx1.redhat.com ([209.132.183.28]:33846)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxUv8-0007aq-Ex\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:15:50 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 91F75D097B\n\tfor ; Thu, 28 Sep 2017 09:15:49 +0000 (UTC)","from localhost.localdomain (ovpn-204-104.brq.redhat.com\n\t[10.40.204.104])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 69A9717253;\n\tThu, 28 Sep 2017 09:15:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 91F75D097B","To":"Eduardo Habkost , qemu-devel@nongnu.org","References":"<20170927130339.21444-1-ehabkost@redhat.com>\n\t<20170927130339.21444-2-ehabkost@redhat.com>","From":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ","Message-ID":"<655d9ac0-f36e-a764-0e3c-d1d28818bd9a@redhat.com>","Date":"Thu, 28 Sep 2017 11:15:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927130339.21444-2-ehabkost@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"s6SkifAdtJsv0jv5Eo39Rj9KsckTBFlpi\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 28 Sep 2017 09:15:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Cleber Rosa ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1777025,"web_url":"http://patchwork.ozlabs.org/comment/1777025/","msgid":"<20170928131940.GR4115@localhost.localdomain>","list_archive_url":null,"date":"2017-09-28T13:19:40","subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Thu, Sep 28, 2017 at 11:15:47AM +0200, Lukáš Doktor wrote:\n[...]\n> > @@ -231,6 +239,7 @@ class PlotShell(object):\n> > \n> > def run(self, argv):\n> > args = self._parser.parse_args(argv)\n> \n> This class is not inherited from the `BaseShell`, therefor it\n> does not contain `init_logging` method. Apart from this it\n> looks good.\n\nOops. I will fix this in v2. Thanks!\n\n> \n> > + self.init_logging(args)\n> > \n> > if len(args.reports) == 0:\n> > print >>sys.stderr, \"At least one report required\"\n> >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2wKd5nkHz9ryr\n\tfor ;\n\tThu, 28 Sep 2017 23:20:21 +1000 (AEST)","from localhost ([::1]:59232 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxYjj-0000mE-UF\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 09:20:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35225)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxYjF-0000ky-Tr\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:19:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxYjA-0006zs-2A\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:19:49 -0400","from mx1.redhat.com ([209.132.183.28]:37764)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxYj9-0006zS-Se\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:19:44 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B7C3680A45\n\tfor ; Thu, 28 Sep 2017 13:19:42 +0000 (UTC)","from localhost (ovpn-116-3.gru2.redhat.com [10.97.116.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4F8C518C61;\n\tThu, 28 Sep 2017 13:19:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B7C3680A45","Date":"Thu, 28 Sep 2017 10:19:40 -0300","From":"Eduardo Habkost ","To":"=?utf-8?b?THVrw6HFoQ==?= Doktor ","Message-ID":"<20170928131940.GR4115@localhost.localdomain>","References":"<20170927130339.21444-1-ehabkost@redhat.com>\n\t<20170927130339.21444-2-ehabkost@redhat.com>\n\t<655d9ac0-f36e-a764-0e3c-d1d28818bd9a@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<655d9ac0-f36e-a764-0e3c-d1d28818bd9a@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 28 Sep 2017 13:19:42 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all\n\tshell frontends","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Cleber Rosa ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]